Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
Thanks everybody!
---
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2588
full clean build w/contrib check passes.
review of code all seems ok and no new dep issues
license and notice updates correct/header changes.
My review was more legal/structural than fu
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
@joewitt requested changes are in
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
Thanks @joewitt for clearing that up. I'll get right to it.
---
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2588
@ottobackwards this describes how to handle code contributed to the ASF
https://www.apache.org/legal/src-headers.html#headers
In short that is when you add the header.
This describes
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
Do I need to add ratcheck exceptions if I remove the headers?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
@joewitt
I added the headers because the code was already apache lic. in the
project, I thought that would be the proper thing to do. I ( possibly or
probably wrongly ) thought that if yo
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2588
@ottobackwards I would be fine merging this in without running additional
testing like you've already done. What we cannot have though are the ASF
headers on source code we copied from elsewhere. Yo
Github user jzonthemtn commented on the issue:
https://github.com/apache/nifi/pull/2588
@ottobackwards Haven't tested it but code-wise it makes sense.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
I can provide the reviewers with access to my PETSTORE endpoint for testing
and we can work out how not to overload it, if that helps get this going
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
bump, any takers?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
@mattyb149 no word on that pr. @jvwing any chance you may be able to
review?
---
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2588
Sounds good to me, especially if that project is active, I'd like to keep
our dependencies as modules rather than code if possible.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
https://github.com/rpgreen/apigateway-generic-java-sdk/pull/8
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
It would be better if we would just use RPGreen's maven dep instead off
bringing in the classes. I have a pr against his repo to upgrade to the same
aws package we use. When that is taken and
Github user zenfenan commented on the issue:
https://github.com/apache/nifi/pull/2588
@ottobackwards I would really love to do it but I'm occupied until next
week. If no one takes a look by that time, I'll definitely do that.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
@zenfenan any chance for a review?
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2588
Hey @ottobackwards - I'd love to have a look but I won't have cycles to do
a proper review and testing before end of next week at best.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-create-api-from-example.html
If you can do this you can test with the pet store sample
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
@MikeThomsen @pvillard31 @mattyb149 @mans2singh Anyone up for a code review?
---
20 matches
Mail list logo
