[GitHub] nifi issue #2633: NIFI-5066: Allow global enable/disable component requests
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2633 @mcgilman many thanks for adding this improvement. Code looks good. Was able to verify functionality and everything worked exactly as I expected. +1 merged to master. ---
[GitHub] nifi issue #2633: NIFI-5066: Allow global enable/disable component requests
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2633 @andrewmlim When no components are selected both enable/disable and start/stop should be allowed as the request will be applied to all eligible components in the current process group. ---
[GitHub] nifi issue #2633: NIFI-5066: Allow global enable/disable component requests
Github user scottyaslan commented on the issue: https://github.com/apache/nifi/pull/2633 +1 for the UI code. ---
[GitHub] nifi issue #2633: NIFI-5066: Allow global enable/disable component requests
Github user andrewmlim commented on the issue: https://github.com/apache/nifi/pull/2633 Changes look good. Enable/disable and start/stop buttons behave consistently. This is minor, but it would be nice if all of these buttons were greyed out (or unavailable in the context menu) when there were no components available i.e. when the process group is empty. ---