[GitHub] nifi issue #2634: NIFI-5075: Do not execute Funnels with no outgoing connect...

2018-04-23 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2634 @ijokarumawak thanks for the update! I feel the code is far more understandable now and appears to work great! +1 merged to master ---

[GitHub] nifi issue #2634: NIFI-5075: Do not execute Funnels with no outgoing connect...

2018-04-20 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/2634 Thank you, @markap14, you are right, I thought I pushed it but didn't. Just pushed updated commit. ---

[GitHub] nifi issue #2634: NIFI-5075: Do not execute Funnels with no outgoing connect...

2018-04-20 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2634 @ijokarumawak that's great. Did you intend to push a new commit? The only commit that I see is from April 12th. ---

[GitHub] nifi issue #2634: NIFI-5075: Do not execute Funnels with no outgoing connect...

2018-04-16 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/2634 @ottobackwards Thanks for mentioning about tests. I've added tests for Funnels. @markap14 I've removed caching `hasNonLoopConnection` because it can be left unchanged when connections are

[GitHub] nifi issue #2634: NIFI-5075: Do not execute Funnels with no outgoing connect...

2018-04-13 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2634 Is there a test to go along with this? ---