Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2747
To reply to my own question: I think we should also test the dockerhub
image almost the same way we test the maven one. We just have to use the latest
public nifi archive to do that.
---
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2747
Are there any issues left I did not address?
---
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2747
Rebased and squashed commits
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2747
+1 fwiw|lgtm.
Ran the above steps to build and test the image from the maven snapshots (
not built locally ).
Everything ran fine.
Your integration test is awesome. I'm totally
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2747
No, sorry! I meant integration-test not package. I beleive this would do
it, at least works for me, just tested:
```
mvn package -pl nifi-assembly
cd nifi-docker
mvn integration-test -P
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2747
So to test this?
- mvn package
- mvn package -P docker from nifi-docker
- ???
- docker run --rm -ti --entrypoint /bin/bash apache/nifi -c "env | grep
NIFI" ? from nifi-docker
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2747
Now all the above described test steps can be executed with `mvn package -P
docker` from the `nifi-docker` folder
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2747
Thanks, I'd like to try this and help with the review
---
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2747
yes, working on it
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2747
Can you add explicit steps to test and verify, for those of use who don't
work with docker as much?
---
10 matches
Mail list logo
