[GitHub] nifi issue #2750: NIFI-5054: Couchbase Authentication, NIFI-5257: Expand Cou...

2018-06-15 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2750 Thanks @ijokarumawak! This has been merged to master. ---

[GitHub] nifi issue #2750: NIFI-5054: Couchbase Authentication, NIFI-5257: Expand Cou...

2018-06-14 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/2750 @mcgilman Thanks for reviewing. I've changed how Relationships are created. ---

[GitHub] nifi issue #2750: NIFI-5054: Couchbase Authentication, NIFI-5257: Expand Cou...

2018-06-14 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2750 Thanks for the PR @ijokarumawak and thanks for assisting with the review @mgroves! I'll be happy to have a look and help get this merged. ---

[GitHub] nifi issue #2750: NIFI-5054: Couchbase Authentication, NIFI-5257: Expand Cou...

2018-06-13 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/2750 @mgroves In order to get this PR merged, we need a +1 from another NiFi committer. We need to wait for further review. Hope it will happen soon. If you have time, it would be helpful to

[GitHub] nifi issue #2750: NIFI-5054: Couchbase Authentication, NIFI-5257: Expand Cou...

2018-06-13 Thread mgroves
Github user mgroves commented on the issue: https://github.com/apache/nifi/pull/2750 Great @ijokarumawak, thanks for that clarification. What are the next steps to getting this PR accepted? Do we need to just wait for further review, or is there anything else you need from me? When

[GitHub] nifi issue #2750: NIFI-5054: Couchbase Authentication, NIFI-5257: Expand Cou...

2018-06-12 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/2750 Thanks @mgroves for confirming that you can use username/password authentication, that helps a lot to finish review cycle! As for the compatibility against older version of Couchbase

[GitHub] nifi issue #2750: NIFI-5054: Couchbase Authentication, NIFI-5257: Expand Cou...

2018-06-12 Thread mgroves
Github user mgroves commented on the issue: https://github.com/apache/nifi/pull/2750 Thank @ijokarumawak, I used -DskipTests and it built successfully for me on Windows. I tried out the PutCouchbaseKey operator with a CouchbaseClusterService using a username and password, and it

[GitHub] nifi issue #2750: NIFI-5054: Couchbase Authentication, NIFI-5257: Expand Cou...

2018-06-04 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/2750 Hi @mgroves, first of all, thanks for jumping on the review process! Some unit tests fail due to environmental difference or race conditions. Does the error happen consistently? If so, the test

[GitHub] nifi issue #2750: NIFI-5054: Couchbase Authentication, NIFI-5257: Expand Cou...

2018-06-04 Thread mgroves
Github user mgroves commented on the issue: https://github.com/apache/nifi/pull/2750 Hi @ijokarumawak I tried building this today (on Windows). I'm not much of a Java developer, so this could easily be a noob mistake. It looks like there was an error here: ``` > [ERROR]