Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2768
+1 LGTM, ran build with unit tests and tried a pyspark session with
`print('Hi')`, verified it fails before the fix and passes after. Thanks for
the fix! Merging to master
---
Github user peter-toth commented on the issue:
https://github.com/apache/nifi/pull/2768
@mattyb149 I've rebased this onto latest master.
---
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2768
@peter-toth can you rebase this against the latest master? Not sure if
you'd worked on this and other Livy stuff at the same time, but there are now
merge conflicts and I wasn't quite sure what to i
Github user mgaido91 commented on the issue:
https://github.com/apache/nifi/pull/2768
LGTM
---
Github user peter-toth commented on the issue:
https://github.com/apache/nifi/pull/2768
@joewitt , thanks for the feedback. I've added Apache Commons Text to
NOTICE of the nifi-livy-nar and nifi-assembly as you suggested. I checked that
it does not bring in any new transitive dependen
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2768
@peter-toth Since this is adding a new dependency (at least directly and
possibly transitively) we'll at least need to make a License and Notice update.
Can you please verify what the old dependencies
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2768
Is there a test that should be created or updated for this change?
---
