[GitHub] nifi issue #2899: NIFI-4535 Only update Page Title to root flow name when us...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2899 Thanks @patricker! This has been merged to master. ---
[GitHub] nifi issue #2899: NIFI-4535 Only update Page Title to root flow name when us...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2899 @patricker Just had another look. I think there is one case that still hasn't been addressed. When a user has been granted permissions to the root group, the document title does update to the root group name. A check has been introduced that will only change the document title if the user has access to the root group. However, if the user does have access to the root group and those permissions are removed the document title does not change back to the previous value. It retains the name of the root group when they last loaded the page. We should be restoring the default value. The default value is loaded through the about endpoint [1]. It would probably make sense to store that value when the page loads so we can restore it in an else clause in your PR. Let me know if you any assistance here. I'm happy to help. [1] https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-global-menu-controller.js#L318 ---
[GitHub] nifi issue #2899: NIFI-4535 Only update Page Title to root flow name when us...
Github user patricker commented on the issue: https://github.com/apache/nifi/pull/2899 @mcgilman I played around with permissions, and I think this one covers all the cases you mentioned. It will loop up the breadcrumb tree, which you can do even if you have no read access, and then checks at the root level if read access exists. ---