[GitHub] nifi issue #3028: Nifi 4806

2018-10-04 Thread mcgilman 
Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/3028
  
Thanks @joewitt! This has been merged to master.


---

[GitHub] nifi issue #3028: Nifi 4806

2018-10-03 Thread joewitt 
Github user joewitt commented on the issue:

https://github.com/apache/nifi/pull/3028
  
@mcgilman let me know off-list that the guava changes I made were too 
dangerous without more thorough evaluation.  I've removed all guava changes 
from this PR as those can be taken up separately.


---

[GitHub] nifi issue #3028: Nifi 4806

2018-10-02 Thread mcgilman 
Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/3028
  
Will review...


---

[GitHub] nifi issue #3028: Nifi 4806

2018-09-25 Thread joewitt 
Github user joewitt commented on the issue:

https://github.com/apache/nifi/pull/3028
  
and i'll address the checkstyle finding

[WARNING] 
src/test/java/org/apache/nifi/atlas/emulator/AtlasAPIV2ServerEmulator.java:[175,21]
 (blocks) LeftCurly: '{' at column 21 should be on the previous line.



---

[GitHub] nifi issue #3028: Nifi 4806

2018-09-25 Thread joewitt 
Github user joewitt commented on the issue:

https://github.com/apache/nifi/pull/3028
  
new commons lang came out.  grabbing that.  will squash too to make 
reviewing easier from here


---