Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/502
@pvillard31 -
I've corrected checkstyle issues. Please let me know if you see any other
issue.
Thanks again.
Mans
---
If your project is set up for it, you can reply
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/502
@mans2singh I was about to merge but there are checkstyle issues:
[WARNING]
src/test/java/org/apache/nifi/processors/ignite/cache/ITPutIgniteCache.java[41:1]
(whitespace)
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/502
@pvillard31 - I've squashed the commits into a single one. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/502
Sorry I meant to rebase and squash them into one single commit ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/502
@pvillard31 - I've rebased the commits. Let me know if you have any other
comments/recommendations.
Thanks
---
If your project is set up for it, you can reply to this email and have your
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/502
@mans2singh Thanks for your work, it LGTM! Would you mind rebasing your
commits?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/502
Hi @pvillard31 -
I've removed the ignite key constant from the abstract cache processor. I
missed your comment about it earlier. I've also updated the documentation for
performance log
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/502
Thanks @JPercivall !
@mans2singh. It LGTM, one last comment about wording and also could you
confirm my old comment in ``AbstractIgniteCacheProcessor`` about
``IGNITE_CACHE_ENTRY_KEY``?
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/502
Hey @mans2singh, no other comments. Just those couple comments regarding
the notice/license and the logging, and it looks like they were addressed. I'll
defer to @pvillard31 to finish the review.
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/502
Hi @JPercivall - I've updated the code based on your comments. Please let
me know if you have any other comments. Thanks.
---
If your project is set up for it, you can reply to this email and
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/502
@pvillard31 - The build is passing locally for me, so I am not sure what
could the issue with the travis build.
---
If your project is set up for it, you can reply to this email and have your
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/502
@pvillard31 - I am checking into the build failures.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/502
Hi @pvillard31 -
Thanks for your thorough feedback. I've updated the code based on your
comments (removed commented dependency in pom file, added license and notice
files under nar
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/502
@mans2singh I added some minor comments. You also need to add a NOTICE file
for licensing aspects in the nar project (you may want to have a look to other
processors).
I just tried to run
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/502
Hello @pvillard31 @apiri - I've resolved the conflicts for the pull
request. Please let me know if you have any additional
feedback/recommendations for me. Thanks
---
If your project is set up
15 matches
Mail list logo
