[GitHub] nifi pull request #2017: NIFI-4197 - Expose some proxy settings to GCS Proce...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2017


---

[GitHub] nifi pull request #2017: NIFI-4197 - Expose some proxy settings to GCS Proce...

[jvwing]

Github user jvwing commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2017#discussion_r137959726
  
--- Diff: 
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/AbstractGCPProcessor.java
 ---
@@ -55,6 +55,25 @@
 .addValidator(StandardValidators.INTEGER_VALIDATOR)
 .build();
 
+public static final PropertyDescriptor PROXY_HOST = new 
PropertyDescriptor
+.Builder().name("proxy-host")
+.displayName("Proxy host")
+.description("IP or hostname of the proxy to be used")
+.required(false)
+.expressionLanguageSupported(false)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+.build();
+
+public static final PropertyDescriptor PROXY_PORT = new 
PropertyDescriptor
+.Builder().name("proxy-port")
+.displayName("Proxy port")
+.description("Porxy port number")
--- End diff --

"**Porxy** port number" -  looks like a typo


---

[GitHub] nifi pull request #2017: NIFI-4197 - Expose some proxy settings to GCS Proce...

[jvwing]

Github user jvwing commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2017#discussion_r137959785
  
--- Diff: 
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/AbstractGCPProcessor.java
 ---
@@ -55,6 +55,25 @@
 .addValidator(StandardValidators.INTEGER_VALIDATOR)
 .build();
 
+public static final PropertyDescriptor PROXY_HOST = new 
PropertyDescriptor
+.Builder().name("proxy-host")
+.displayName("Proxy host")
+.description("IP or hostname of the proxy to be used")
+.required(false)
+.expressionLanguageSupported(false)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+.build();
+
+public static final PropertyDescriptor PROXY_PORT = new 
PropertyDescriptor
+.Builder().name("proxy-port")
--- End diff --

Same thing with the `gcp-` prefix.


---

[GitHub] nifi pull request #2017: NIFI-4197 - Expose some proxy settings to GCS Proce...

[jvwing]

Github user jvwing commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2017#discussion_r137959775
  
--- Diff: 
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/AbstractGCPProcessor.java
 ---
@@ -55,6 +55,25 @@
 .addValidator(StandardValidators.INTEGER_VALIDATOR)
 .build();
 
+public static final PropertyDescriptor PROXY_HOST = new 
PropertyDescriptor
+.Builder().name("proxy-host")
--- End diff --

The other property descriptors in this file prefix their names with `gcp-`. 
 Any special reason not to fit in with the others?


---

[GitHub] nifi pull request #2017: NIFI-4197 - Expose some proxy settings to GCS Proce...

[trixpan]

GitHub user trixpan opened a pull request:

https://github.com/apache/nifi/pull/2017

NIFI-4197 - Expose some proxy settings to GCS Processors

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [] Have you written or updated unit tests to verify your changes?
- [X] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [X] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [X] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [X] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/trixpan/nifi NIFI-4197

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2017.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2017


commit 368e9feee54948ca6c9676b4bd87ea5c97cc3d36
Author: Andre F de Miranda 
Date:   2017-07-18T10:07:13Z

NIFI-4197 - Expose some proxy settings to GCS Processors




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---