[GitHub] nifi pull request #2449: NIFI-4840 Fix formatting for expression language gu...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2449


---

[GitHub] nifi pull request #2449: NIFI-4840 Fix formatting for expression language gu...

[Leah-Anderson]

Github user Leah-Anderson commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2449#discussion_r167752283
  
--- Diff: nifi-docs/src/main/asciidoc/expression-language-guide.adoc ---
@@ -1644,9 +1644,9 @@ Divide. This is to preserve backwards compatibility 
and to not force rounding er
 
 *Description*: [.description]#Converts the Subject from a Base 10 number 
to a different Radix (or number base). An optional
second argument can be used to indicate the minimum number of 
characters to be used. If the converted value
-   has fewer than this number of characters, the number will be padded 
with leading zeroes.
+   has fewer than this number of characters, the number will be padded 
with leading zeroes.#
--- End diff --

I was thinking the way it was made it seem like a call out to "hey this is 
important to note" but I can see it either way. I've pushed an update to remove 
the carriage return :)


---

[GitHub] nifi pull request #2449: NIFI-4840 Fix formatting for expression language gu...

[pvillard31]

Github user pvillard31 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2449#discussion_r167647277
  
--- Diff: nifi-docs/src/main/asciidoc/expression-language-guide.adoc ---
@@ -1644,9 +1644,9 @@ Divide. This is to preserve backwards compatibility 
and to not force rounding er
 
 *Description*: [.description]#Converts the Subject from a Base 10 number 
to a different Radix (or number base). An optional
second argument can be used to indicate the minimum number of 
characters to be used. If the converted value
-   has fewer than this number of characters, the number will be padded 
with leading zeroes.
+   has fewer than this number of characters, the number will be padded 
with leading zeroes.#
--- End diff --

I think that, instead of moving the # character, it'd be better to just 
remove the carriage return between this line and the next one, no? (same 
applies for fromRadix). Otherwise, the display is a bit weird in the doc:

https://github.com/Leah-Anderson/nifi/blob/a445ee4d141ea1218d3cf5c47abb5171c5890f43/nifi-docs/src/main/asciidoc/expression-language-guide.adoc#fromradix


---

[GitHub] nifi pull request #2449: NIFI-4840 Fix formatting for expression language gu...

[Leah-Anderson]

GitHub user Leah-Anderson opened a pull request:

https://github.com/apache/nifi/pull/2449

NIFI-4840 Fix formatting for expression language guide for toRadix an…

…d fromRadix

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Leah-Anderson/nifi NIFI-4840

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2449.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2449


commit a445ee4d141ea1218d3cf5c47abb5171c5890f43
Author: Leah Anderson 
Date:   2018-02-05T00:32:02Z

NIFI-4840 Fix formatting for expression language guide for toRadix and 
fromRadix




---