[GitHub] nifi pull request #2480: NIFI-4893 Cannot convert Avro schemas to Record sch...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2480


---

[GitHub] nifi pull request #2480: NIFI-4893 Cannot convert Avro schemas to Record sch...

[gardellajuanpablo]

Github user gardellajuanpablo commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2480#discussion_r169389143
  
--- Diff: 
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/RecordField.java
 ---
@@ -76,8 +77,12 @@ public RecordField(final String fieldName, final 
DataType dataType, final Object
 } else {
 this.aliases = Collections.unmodifiableSet(aliases);
 }
-
-this.defaultValue = defaultValue;
+if (RecordFieldType.ARRAY.equals(dataType.getFieldType()) && 
(defaultValue instanceof String
+|| defaultValue instanceof Number || defaultValue 
instanceof Boolean)) {
--- End diff --

Yes, it solves the reported issue, but it makes the test fails. It is 
required to think another solution approach. It is not as simple I initially 
thought


---

[GitHub] nifi pull request #2480: NIFI-4893 Cannot convert Avro schemas to Record sch...

[zenfenan]

Github user zenfenan commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2480#discussion_r169385890
  
--- Diff: 
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/RecordField.java
 ---
@@ -76,8 +77,12 @@ public RecordField(final String fieldName, final 
DataType dataType, final Object
 } else {
 this.aliases = Collections.unmodifiableSet(aliases);
 }
-
-this.defaultValue = defaultValue;
+if (RecordFieldType.ARRAY.equals(dataType.getFieldType()) && 
(defaultValue instanceof String
+|| defaultValue instanceof Number || defaultValue 
instanceof Boolean)) {
--- End diff --

This will cause 
[TestAvroReaderWithEmbeddedSchema](https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/avro/TestAvroReaderWithEmbeddedSchema.java)
 to fail.


---

[GitHub] nifi pull request #2480: NIFI-4893 Cannot convert Avro schemas to Record sch...

[gardellajuanpablo]

GitHub user gardellajuanpablo opened a pull request:

https://github.com/apache/nifi/pull/2480

NIFI-4893 Cannot convert Avro schemas to Record schemas with default …

…arrays

To test it run:
mvn test "-pl" org.apache.nifi:nifi-avro-record-utils -am  
-Dtest=TestAvroTypeUtil -DfailIfNoTests=false

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gardellajuanpablo/nifi master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2480.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2480


commit e7f0edbf948f1579150627ba03dc9b2ed7a9fca0
Author: gardellajuanpablo 
Date:   2018-02-19T19:07:14Z

NIFI-4893 Cannot convert Avro schemas to Record schemas with default arrays

To test it run:
mvn test "-pl" org.apache.nifi:nifi-avro-record-utils -am  
-Dtest=TestAvroTypeUtil -DfailIfNoTests=false




---