Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2698
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2698#discussion_r188355650
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
---
@@ -234
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2698#discussion_r188355616
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
---
@@ -102
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2698#discussion_r188354997
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
---
@@ -102
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2698#discussion_r188345339
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
---
@@ -234,6
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2698#discussion_r188345184
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
---
@@ -102,6
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2698#discussion_r188344570
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
---
@@ -102,6
GitHub user ottobackwards opened a pull request:
https://github.com/apache/nifi/pull/2698
NIFI-5077 ExtractGrok support for `keep empty captures`
Support for the new option to keep empty captures. I did not add to the
GrokReader because I am not sure of the effect on
the schema
