Re: [PR] MINIFICPP-2203 Add support for building Windows MSI without any redistributables included [nifi-minifi-cpp]

2024-03-14 Thread via GitHub
szaszm closed pull request #1734: MINIFICPP-2203 Add support for building Windows MSI without any redistributables included URL: https://github.com/apache/nifi-minifi-cpp/pull/1734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] MINIFICPP-2203 Add support for building Windows MSI without any redistributables included [nifi-minifi-cpp]

2024-03-13 Thread via GitHub
lordgamez commented on code in PR #1734: URL: https://github.com/apache/nifi-minifi-cpp/pull/1734#discussion_r1522884699 ## CMakeLists.txt: ## @@ -493,20 +504,21 @@ if(WIN32) list(GET VCRUNTIME_X64_MERGEMODULES 0 VCRUNTIME_X64_MERGEMODULE_PATH) endif()

Re: [PR] MINIFICPP-2203 Add support for building Windows MSI without any redistributables included [nifi-minifi-cpp]

2024-03-13 Thread via GitHub
fgerlits commented on code in PR #1734: URL: https://github.com/apache/nifi-minifi-cpp/pull/1734#discussion_r1522822212 ## CMakeLists.txt: ## @@ -493,20 +504,21 @@ if(WIN32) list(GET VCRUNTIME_X64_MERGEMODULES 0 VCRUNTIME_X64_MERGEMODULE_PATH) endif() -

Re: [PR] MINIFICPP-2203 Add support for building Windows MSI without any redistributables included [nifi-minifi-cpp]

2024-03-11 Thread via GitHub
lordgamez commented on code in PR #1734: URL: https://github.com/apache/nifi-minifi-cpp/pull/1734#discussion_r1519529421 ## cmake/MiNiFiOptions.cmake: ## @@ -82,6 +80,8 @@ list(APPEND STRICT_GSL_CHECKS_Values AUDIT ON DEBUG_ONLY OFF) set_property(CACHE STRICT_GSL_CHECKS

Re: [PR] MINIFICPP-2203 Add support for building Windows MSI without any redistributables included [nifi-minifi-cpp]

2024-03-08 Thread via GitHub
szaszm commented on code in PR #1734: URL: https://github.com/apache/nifi-minifi-cpp/pull/1734#discussion_r1517981895 ## cmake/MiNiFiOptions.cmake: ## @@ -82,6 +80,8 @@ list(APPEND STRICT_GSL_CHECKS_Values AUDIT ON DEBUG_ONLY OFF) set_property(CACHE STRICT_GSL_CHECKS PROPERTY

Re: [PR] MINIFICPP-2203 Add support for building Windows MSI without any redistributables included [nifi-minifi-cpp]

2024-03-05 Thread via GitHub
lordgamez commented on code in PR #1734: URL: https://github.com/apache/nifi-minifi-cpp/pull/1734#discussion_r1509271721 ## cmake/MiNiFiOptions.cmake: ## @@ -82,6 +80,8 @@ list(APPEND STRICT_GSL_CHECKS_Values AUDIT ON DEBUG_ONLY OFF) set_property(CACHE STRICT_GSL_CHECKS

Re: [PR] MINIFICPP-2203 Add support for building Windows MSI without any redistributables included [nifi-minifi-cpp]

2024-03-05 Thread via GitHub
martinzink commented on code in PR #1734: URL: https://github.com/apache/nifi-minifi-cpp/pull/1734#discussion_r1513120771 ## cmake/MiNiFiOptions.cmake: ## @@ -82,6 +80,8 @@ list(APPEND STRICT_GSL_CHECKS_Values AUDIT ON DEBUG_ONLY OFF) set_property(CACHE STRICT_GSL_CHECKS

Re: [PR] MINIFICPP-2203 Add support for building Windows MSI without any redistributables included [nifi-minifi-cpp]

2024-03-01 Thread via GitHub
lordgamez commented on code in PR #1734: URL: https://github.com/apache/nifi-minifi-cpp/pull/1734#discussion_r1509271721 ## cmake/MiNiFiOptions.cmake: ## @@ -82,6 +80,8 @@ list(APPEND STRICT_GSL_CHECKS_Values AUDIT ON DEBUG_ONLY OFF) set_property(CACHE STRICT_GSL_CHECKS

Re: [PR] MINIFICPP-2203 Add support for building Windows MSI without any redistributables included [nifi-minifi-cpp]

2024-03-01 Thread via GitHub
szaszm commented on code in PR #1734: URL: https://github.com/apache/nifi-minifi-cpp/pull/1734#discussion_r1509232446 ## cmake/MiNiFiOptions.cmake: ## @@ -82,6 +80,8 @@ list(APPEND STRICT_GSL_CHECKS_Values AUDIT ON DEBUG_ONLY OFF) set_property(CACHE STRICT_GSL_CHECKS PROPERTY

Re: [PR] MINIFICPP-2203 Add support for building Windows MSI without any redistributables included [nifi-minifi-cpp]

2024-02-28 Thread via GitHub
szaszm commented on code in PR #1734: URL: https://github.com/apache/nifi-minifi-cpp/pull/1734#discussion_r1505905580 ## cmake/MiNiFiOptions.cmake: ## Review Comment: What happens if all of these remain off? I'd switch to no redistributables by default, unless the

[PR] MINIFICPP-2203 Add support for building Windows MSI without any redistributables included [nifi-minifi-cpp]

2024-02-28 Thread via GitHub
lordgamez opened a new pull request, #1734: URL: https://github.com/apache/nifi-minifi-cpp/pull/1734 - Also remove unused FORCE_WINDOWS build option -- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of