Re: [PR] MINIFICPP-2267 - Add dynamic library to package on intel macos [nifi-minifi-cpp]
martinzink closed pull request #1700: MINIFICPP-2267 - Add dynamic library to package on intel macos URL: https://github.com/apache/nifi-minifi-cpp/pull/1700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2267 - Add dynamic library to package on intel macos [nifi-minifi-cpp]
lordgamez commented on PR #1700: URL: https://github.com/apache/nifi-minifi-cpp/pull/1700#issuecomment-1831839537 > > would it be possible to do static linking, like on other platforms? > > unclear what the root cause is (the comment mentions static linking issues), this was added during libressl -> openssl transition, @lordgamez do you remember this issue? It was something related to duplicating the openssl symbols when multiple libraries link openssl statically on intel mac, that's why the only solution we found was linking it dynamically here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2267 - Add dynamic library to package on intel macos [nifi-minifi-cpp]
adamdebreceni commented on PR #1700: URL: https://github.com/apache/nifi-minifi-cpp/pull/1700#issuecomment-1831801696 > would it be possible to do static linking, like on other platforms? unclear what the root cause is (the comment mentions static linking issues), this was added during libressl -> openssl transition, @lordgamez do you remember this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2267 - Add dynamic library to package on intel macos [nifi-minifi-cpp]
szaszm commented on PR #1700: URL: https://github.com/apache/nifi-minifi-cpp/pull/1700#issuecomment-1831778984 would it be possible to do static linking, like on other platforms? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] MINIFICPP-2267 - Add dynamic library to package on intel macos [nifi-minifi-cpp]
adamdebreceni opened a new pull request, #1700: URL: https://github.com/apache/nifi-minifi-cpp/pull/1700 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
