Re: [PR] NIFI-12255 refactor PutElasticsearchRecord and PutElasticsearchJson relationships to be more consistent with other processors [nifi]

2024-05-07 Thread via GitHub
exceptionfactory closed pull request #7940: NIFI-12255 refactor PutElasticsearchRecord and PutElasticsearchJson relationships to be more consistent with other processors URL: https://github.com/apache/nifi/pull/7940 -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] NIFI-12255 refactor PutElasticsearchRecord and PutElasticsearchJson relationships to be more consistent with other processors [nifi]

2024-05-04 Thread via GitHub
joewitt commented on PR #7940: URL: https://github.com/apache/nifi/pull/7940#issuecomment-2094285531 @ChrisSamo632 Thanks for rebasing and also leveraging migrate properties! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] NIFI-12255 refactor PutElasticsearchRecord and PutElasticsearchJson relationships to be more consistent with other processors [nifi]

2024-05-04 Thread via GitHub
ChrisSamo632 commented on PR #7940: URL: https://github.com/apache/nifi/pull/7940#issuecomment-2094061873 Rebased against latest `main` to refactor changed into new `nifi-extension-bundles` module -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] NIFI-12255 refactor PutElasticsearchRecord and PutElasticsearchJson relationships to be more consistent with other processors [nifi]

2024-03-26 Thread via GitHub
exceptionfactory commented on code in PR #7940: URL: https://github.com/apache/nifi/pull/7940#discussion_r1540029633 ## nifi-mock/src/main/java/org/apache/nifi/util/StandardProcessorTestRunner.java: ## @@ -229,33 +226,32 @@ public void run(final int iterations, final boolean

Re: [PR] NIFI-12255 refactor PutElasticsearchRecord and PutElasticsearchJson relationships to be more consistent with other processors [nifi]

2024-03-26 Thread via GitHub
ChrisSamo632 commented on code in PR #7940: URL: https://github.com/apache/nifi/pull/7940#discussion_r1539989744 ## nifi-mock/src/main/java/org/apache/nifi/util/StandardProcessorTestRunner.java: ## @@ -229,33 +226,32 @@ public void run(final int iterations, final boolean

Re: [PR] NIFI-12255 refactor PutElasticsearchRecord and PutElasticsearchJson relationships to be more consistent with other processors [nifi]

2024-03-25 Thread via GitHub
exceptionfactory commented on code in PR #7940: URL: https://github.com/apache/nifi/pull/7940#discussion_r1538546543 ## nifi-mock/src/main/java/org/apache/nifi/util/RelationshipMigrationResult.java: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] NIFI-12255 refactor PutElasticsearchRecord and PutElasticsearchJson relationships to be more consistent with other processors [nifi]

2024-02-16 Thread via GitHub
ChrisSamo632 commented on PR #7940: URL: https://github.com/apache/nifi/pull/7940#issuecomment-1949279317 I've rebased from latest `main` to address merge conflicts. Let me know your thoughts on previous comments @exceptionfactory. -- This is an automated message from the Apache

Re: [PR] NIFI-12255 refactor PutElasticsearchRecord and PutElasticsearchJson relationships to be more consistent with other processors [nifi]

2024-01-18 Thread via GitHub
ChrisSamo632 commented on PR #7940: URL: https://github.com/apache/nifi/pull/7940#issuecomment-1897996225 RE the migration testing, I discussed this with @markap14 at the time. I find some issues with the property mock processing, so fixed that (I'll have to reverse engineer what the

Re: [PR] NIFI-12255 refactor PutElasticsearchRecord and PutElasticsearchJson relationships to be more consistent with other processors [nifi]

2024-01-18 Thread via GitHub
ChrisSamo632 commented on code in PR #7940: URL: https://github.com/apache/nifi/pull/7940#discussion_r1457069952 ## nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/AbstractPutElasticsearch.java:

Re: [PR] NIFI-12255 refactor PutElasticsearchRecord and PutElasticsearchJson relationships to be more consistent with other processors [nifi]

2024-01-18 Thread via GitHub
ChrisSamo632 commented on code in PR #7940: URL: https://github.com/apache/nifi/pull/7940#discussion_r1457066410 ## nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/AbstractPutElasticsearch.java:

Re: [PR] NIFI-12255 refactor PutElasticsearchRecord and PutElasticsearchJson relationships to be more consistent with other processors [nifi]

2024-01-17 Thread via GitHub
exceptionfactory commented on code in PR #7940: URL: https://github.com/apache/nifi/pull/7940#discussion_r1456861650 ## nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/AbstractPutElasticsearch.java:

[PR] NIFI-12255 refactor PutElasticsearchRecord and PutElasticsearchJson relationships to be more consistent with other processors [nifi]

2023-10-26 Thread via GitHub
ChrisSamo632 opened a new pull request, #7940: URL: https://github.com/apache/nifi/pull/7940 # Summary [NIFI-12255](https://issues.apache.org/jira/browse/NIFI-12255) refactor PutElasticsearchRecord and PutElasticsearchJson