Re: [PR] NIFI-12339 Fix Property Decryption for Migrated Components [nifi]

2023-11-10 Thread via GitHub


markap14 commented on PR #8002:
URL: https://github.com/apache/nifi/pull/8002#issuecomment-1806074442

   Thanks for fixing @exceptionfactory . The approach seems to be good. Code 
looks good to me. +1 will merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NIFI-12339 Fix Property Decryption for Migrated Components [nifi]

2023-11-10 Thread via GitHub


markap14 merged PR #8002:
URL: https://github.com/apache/nifi/pull/8002


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] NIFI-12339 Fix Property Decryption for Migrated Components [nifi]

2023-11-09 Thread via GitHub


exceptionfactory opened a new pull request, #8002:
URL: https://github.com/apache/nifi/pull/8002

   
   
   
   
   
   
   
   
   
   
   
   
   
   # Summary
   
   [NIFI-12339](https://issues.apache.org/jira/browse/NIFI-12339) Resolves 
recursive sensitive property encryption issues on the main branch, introduced 
with changes for handling migration of properties in 
[NIFI-12301](https://issues.apache.org/jira/browse/NIFI-12301). The problem was 
the result of passing encrypted property values to migration methods, which 
subsequently resulted in encrypting a value that was already encrypted.
   
   The resolution decrypts original property values prior to registering 
created extensions so that subsequent property migration methods have access to 
the decrypted property values.
   
   The resolution can be verified using the `InvokeHTTP` Processor and creating 
a sensitive dynamic property named `Authorization`. After creating the property 
with an arbitrary value, restarting NiFi maintains the same length for the 
encrypted string in `flow.json.gz`, as opposed to growing the encrypted string 
length after each restart operation. New test methods for the Versioned 
Component Synchronizer also verify that migration methods for Processors 
receive decrypted values. 
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
 - [X] JDK 21
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org