Re: [PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]

2024-01-17 Thread via GitHub
exceptionfactory closed pull request #8240: NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… URL: https://github.com/apache/nifi/pull/8240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]

2024-01-16 Thread via GitHub
exceptionfactory commented on code in PR #8240: URL: https://github.com/apache/nifi/pull/8240#discussion_r1454335733 ##

Re: [PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]

2024-01-16 Thread via GitHub
exceptionfactory commented on code in PR #8240: URL: https://github.com/apache/nifi/pull/8240#discussion_r1454334009 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-kubernetes-bundle/nifi-framework-kubernetes-state-provider/pom.xml: ## @@ -48,5 +48,10 @@

Re: [PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]

2024-01-16 Thread via GitHub
juldrixx commented on code in PR #8240: URL: https://github.com/apache/nifi/pull/8240#discussion_r1454215788 ##

Re: [PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]

2024-01-16 Thread via GitHub
juldrixx commented on code in PR #8240: URL: https://github.com/apache/nifi/pull/8240#discussion_r1454206171 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-kubernetes-bundle/nifi-framework-kubernetes-state-provider/pom.xml: ## @@ -48,5 +48,10 @@

Re: [PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]

2024-01-16 Thread via GitHub
exceptionfactory commented on code in PR #8240: URL: https://github.com/apache/nifi/pull/8240#discussion_r1454177876 ##

Re: [PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]

2024-01-16 Thread via GitHub
juldrixx commented on code in PR #8240: URL: https://github.com/apache/nifi/pull/8240#discussion_r1453543972 ## nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/NiFiProperties.java: ## @@ -398,6 +401,7 @@ public class NiFiProperties extends ApplicationProperties

Re: [PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]

2024-01-16 Thread via GitHub
exceptionfactory commented on code in PR #8240: URL: https://github.com/apache/nifi/pull/8240#discussion_r1453528762 ## nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/NiFiProperties.java: ## @@ -398,6 +401,7 @@ public class NiFiProperties extends

Re: [PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]

2024-01-16 Thread via GitHub
mh013370 commented on code in PR #8240: URL: https://github.com/apache/nifi/pull/8240#discussion_r1453248459 ##

Re: [PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]

2024-01-16 Thread via GitHub
juldrixx commented on code in PR #8240: URL: https://github.com/apache/nifi/pull/8240#discussion_r1453238105 ##

Re: [PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]

2024-01-16 Thread via GitHub
juldrixx commented on code in PR #8240: URL: https://github.com/apache/nifi/pull/8240#discussion_r1453234246 ##

Re: [PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]

2024-01-16 Thread via GitHub
mh013370 commented on code in PR #8240: URL: https://github.com/apache/nifi/pull/8240#discussion_r1453193596 ##

Re: [PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]

2024-01-16 Thread via GitHub
juldrixx commented on code in PR #8240: URL: https://github.com/apache/nifi/pull/8240#discussion_r1453180213 ##

Re: [PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]

2024-01-16 Thread via GitHub
juldrixx commented on code in PR #8240: URL: https://github.com/apache/nifi/pull/8240#discussion_r1453158432 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/conf/nifi.properties: ## @@ -335,6 +335,9 @@

Re: [PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]

2024-01-16 Thread via GitHub
mh013370 commented on code in PR #8240: URL: https://github.com/apache/nifi/pull/8240#discussion_r1453151525 ##

Re: [PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]

2024-01-16 Thread via GitHub
mh013370 commented on code in PR #8240: URL: https://github.com/apache/nifi/pull/8240#discussion_r1453151525 ##

Re: [PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]

2024-01-16 Thread via GitHub
juldrixx commented on code in PR #8240: URL: https://github.com/apache/nifi/pull/8240#discussion_r1453146575 ##

Re: [PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]

2024-01-16 Thread via GitHub
juldrixx commented on code in PR #8240: URL: https://github.com/apache/nifi/pull/8240#discussion_r1453136540 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/conf/nifi.properties: ## @@ -335,6 +335,9 @@

Re: [PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]

2024-01-16 Thread via GitHub
juldrixx commented on code in PR #8240: URL: https://github.com/apache/nifi/pull/8240#discussion_r1453127210 ##

Re: [PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]

2024-01-16 Thread via GitHub
mh013370 commented on code in PR #8240: URL: https://github.com/apache/nifi/pull/8240#discussion_r1453077168 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/conf/nifi.properties: ## @@ -335,6 +335,9 @@

Re: [PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]

2024-01-16 Thread via GitHub
mh013370 commented on code in PR #8240: URL: https://github.com/apache/nifi/pull/8240#discussion_r1453076148 ##

Re: [PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]

2024-01-12 Thread via GitHub
juldrixx commented on PR #8240: URL: https://github.com/apache/nifi/pull/8240#issuecomment-1889716522 > Thanks for proposing this addition @juldrixx. I provided some recommendations on naming and implementation details. Thanks for the review, I should have made the requested changes.

Re: [PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]

2024-01-12 Thread via GitHub
juldrixx commented on code in PR #8240: URL: https://github.com/apache/nifi/pull/8240#discussion_r1450752341 ##

Re: [PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]

2024-01-12 Thread via GitHub
exceptionfactory commented on code in PR #8240: URL: https://github.com/apache/nifi/pull/8240#discussion_r1450663163 ##

[PR] NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… [nifi]

2024-01-12 Thread via GitHub
juldrixx opened a new pull request, #8240: URL: https://github.com/apache/nifi/pull/8240 …uster Leader Election and State Management # Summary [NIFI-12590](https://issues.apache.org/jira/browse/NIFI-12590) # Tracking