Re: [PR] NIFI-12776: Add UPLOAD provenance event to PutAzureBlobStorage [nifi]
Lehel44 closed pull request #8394: NIFI-12776: Add UPLOAD provenance event to PutAzureBlobStorage URL: https://github.com/apache/nifi/pull/8394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12776: Add UPLOAD provenance event to PutAzureBlobStorage [nifi]
exceptionfactory commented on code in PR #8394:
URL: https://github.com/apache/nifi/pull/8394#discussion_r1538540168
##
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureBlobStorage_v12.java:
##
@@ -200,7 +199,13 @@ public void onTrigger(final ProcessContext context, final
ProcessSession session
long transferMillis =
TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - startNanos);
String transitUri = attributes.get(ATTR_NAME_PRIMARY_URI);
-session.getProvenanceReporter().send(flowFile, transitUri,
transferMillis);
+if (fileResourceFound.isPresent()) {
+final FileResource fileResource = fileResourceFound.get();
+session.getProvenanceReporter().fetch(flowFile, transitUri,
transferMillis);
Review Comment:
The `fetch()` method is intended to indicate that the content of the
FlowFile was replaced with an external source, but that is not the case in this
scenario. The output FlowFile remains unchanged, so `FETCH` does not seem to
apply. The `receive()` method seems more appropriate as indicates the
introduction of data, as the content of the FlowFile remains unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] NIFI-12776: Add UPLOAD provenance event to PutAZureBlobStorage [nifi]
Lehel44 opened a new pull request, #8394: URL: https://github.com/apache/nifi/pull/8394 # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
