mattyb149 closed pull request #8266: NIFI-9677 Fixed LookupRecord issue that an
empty JSON array caused mismatch
URL: https://github.com/apache/nifi/pull/8266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
mattyb149 commented on PR #8266:
URL: https://github.com/apache/nifi/pull/8266#issuecomment-1912930704
+1 LGTM, thanks for the fix! Merging to support/nifi-1.x and main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
mattyb149 commented on PR #8266:
URL: https://github.com/apache/nifi/pull/8266#issuecomment-1904858202
When running the unit tests with Java 8 (for a `support/nifi-1.x` backport),
I get an error because the `foo` entry shows up as `null` in the output of
`testLookupMissingJsonField()`:
jrsteinebrey commented on code in PR #8266:
URL: https://github.com/apache/nifi/pull/8266#discussion_r1461196749
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/LookupRecord.java:
##
@@ -487,7 +487,13 @@ public
mattyb149 commented on code in PR #8266:
URL: https://github.com/apache/nifi/pull/8266#discussion_r1458090443
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/LookupRecord.java:
##
@@ -487,7 +487,13 @@ public
mattyb149 commented on PR #8266:
URL: https://github.com/apache/nifi/pull/8266#issuecomment-1899126576
Reviewing...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
jrsteinebrey opened a new pull request, #8266:
URL: https://github.com/apache/nifi/pull/8266
### Issue Tracking
- [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-9677)
issue created
### Pull Request Tracking
- [X] Pull Request title starts with Apache
