[jira] [Commented] (NIFI-12481) UI error when listing registry clients and not authorized

2023-12-21 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-12481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799530#comment-17799530
 ] 

ASF subversion and git services commented on NIFI-12481:


Commit e8e547a00c2e000be345434ad90b855cf0e330d9 in nifi's branch 
refs/heads/support/nifi-1.x from Matt Gilman
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e8e547a00c ]

NIFI-12481: Filtering out unauthorized registry clients to avoid unhandled 
error (#8147)

* NIFI-12481:
- Filtering out unauthorized registry clients to avoid unhandled error.

* NIFI-12481:
- Using es5 syntax.

This closes #8147


> UI error when listing registry clients and not authorized
> -
>
> Key: NIFI-12481
> URL: https://issues.apache.org/jira/browse/NIFI-12481
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Bryan Bende
>Assignee: Matt Gilman
>Priority: Major
> Fix For: 2.0.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently the authorization for registry clients is based on READ to 
> /controller (this is a separate issue that should be addressed).
> Steps:
>  * Run a secure instance locally
>  * Use initial admin to create a registry client
>  * Remove initial admin from controller policies
>  * Create a new PG and choose Import from Registry
>  * Notice nothing happens
> UI Error in dev tools:
> {code:java}
> nf-canvas-all.js?2.0.0-SNAPSHOT:47 Uncaught TypeError: Cannot read properties 
> of undefined (reading 'name')
>     at Object. (nf-canvas-all.js?2.0.0-SNAPSHOT:47:3678)
>     at Function.each (jquery.min.js:2:3003)
>     at b.each (jquery.each.js:1:96)
>     at Object. (nf-canvas-all.js?2.0.0-SNAPSHOT:47:3610)
>     at c (jquery.min.js:2:28447)
>     at Object.fireWith [as resolveWith] (jquery.min.js:2:29192)
>     at l (jquery.min.js:2:80176)
>     at XMLHttpRequest. (jquery.min.js:2:82630) {code}
> The issue is that the listing of registry clients will optionally fill in the 
> DTO in the entity based on the user's permissions for the entity, but the 
> permissions are always based on /controller, so if they don't have 
> /controller the DTO will be null.
> The UI should still be able to load a screen with an empty list of registry 
> clients.
> cc [~mcgilman] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-12481) UI error when listing registry clients and not authorized

2023-12-21 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-12481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799494#comment-17799494
 ] 

ASF subversion and git services commented on NIFI-12481:


Commit 1f54d5d1fc6a2c8c956b3426f6d5d12d2c547966 in nifi's branch 
refs/heads/main from Matt Gilman
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=1f54d5d1fc ]

NIFI-12481: Filtering out unauthorized registry clients to avoid unhandled 
error (#8147)

* NIFI-12481:
- Filtering out unauthorized registry clients to avoid unhandled error.

* NIFI-12481:
- Using es5 syntax.

This closes #8147 

> UI error when listing registry clients and not authorized
> -
>
> Key: NIFI-12481
> URL: https://issues.apache.org/jira/browse/NIFI-12481
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Bryan Bende
>Assignee: Matt Gilman
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently the authorization for registry clients is based on READ to 
> /controller (this is a separate issue that should be addressed).
> Steps:
>  * Run a secure instance locally
>  * Use initial admin to create a registry client
>  * Remove initial admin from controller policies
>  * Create a new PG and choose Import from Registry
>  * Notice nothing happens
> UI Error in dev tools:
> {code:java}
> nf-canvas-all.js?2.0.0-SNAPSHOT:47 Uncaught TypeError: Cannot read properties 
> of undefined (reading 'name')
>     at Object. (nf-canvas-all.js?2.0.0-SNAPSHOT:47:3678)
>     at Function.each (jquery.min.js:2:3003)
>     at b.each (jquery.each.js:1:96)
>     at Object. (nf-canvas-all.js?2.0.0-SNAPSHOT:47:3610)
>     at c (jquery.min.js:2:28447)
>     at Object.fireWith [as resolveWith] (jquery.min.js:2:29192)
>     at l (jquery.min.js:2:80176)
>     at XMLHttpRequest. (jquery.min.js:2:82630) {code}
> The issue is that the listing of registry clients will optionally fill in the 
> DTO in the entity based on the user's permissions for the entity, but the 
> permissions are always based on /controller, so if they don't have 
> /controller the DTO will be null.
> The UI should still be able to load a screen with an empty list of registry 
> clients.
> cc [~mcgilman] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-12481) UI error when listing registry clients and not authorized

2023-12-07 Thread Matt Gilman (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-12481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1779#comment-1779
 ] 

Matt Gilman commented on NIFI-12481:


The stack trace with non-minified source
{code:java}
Uncaught TypeError: Cannot read properties of undefined (reading 'name')
    at nf-flow-version.js?2.0.0-SNAPSHOT:203:40
    at Array.sort ()
    at Object. (nf-flow-version.js?2.0.0-SNAPSHOT:202:47)
    at c (jquery.min.js:2:28447)
    at Object.fireWith [as resolveWith] (jquery.min.js:2:29192)
    at l (jquery.min.js:2:80176)
    at XMLHttpRequest. (jquery.min.js:2:82630) {code}

> UI error when listing registry clients and not authorized
> -
>
> Key: NIFI-12481
> URL: https://issues.apache.org/jira/browse/NIFI-12481
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Bryan Bende
>Priority: Major
>
> Currently the authorization for registry clients is based on READ to 
> /controller (this is a separate issue that should be addressed).
> Steps:
>  * Run a secure instance locally
>  * Use initial admin to create a registry client
>  * Remove initial admin from controller policies
>  * Create a new PG and choose Import from Registry
>  * Notice nothing happens
> UI Error in dev tools:
> {code:java}
> nf-canvas-all.js?2.0.0-SNAPSHOT:47 Uncaught TypeError: Cannot read properties 
> of undefined (reading 'name')
>     at Object. (nf-canvas-all.js?2.0.0-SNAPSHOT:47:3678)
>     at Function.each (jquery.min.js:2:3003)
>     at b.each (jquery.each.js:1:96)
>     at Object. (nf-canvas-all.js?2.0.0-SNAPSHOT:47:3610)
>     at c (jquery.min.js:2:28447)
>     at Object.fireWith [as resolveWith] (jquery.min.js:2:29192)
>     at l (jquery.min.js:2:80176)
>     at XMLHttpRequest. (jquery.min.js:2:82630) {code}
> The issue is that the listing of registry clients will optionally fill in the 
> DTO in the entity based on the user's permissions for the entity, but the 
> permissions are always based on /controller, so if they don't have 
> /controller the DTO will be null.
> The UI should still be able to load a screen with an empty list of registry 
> clients.
> cc [~mcgilman] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)