[jira] [Commented] (NIFI-12768) Intermittent Failures in TestListFile.testFilterAge
[ https://issues.apache.org/jira/browse/NIFI-12768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819051#comment-17819051 ] ASF subversion and git services commented on NIFI-12768: Commit 3f2f5a02e05dbb2bd706613e648b9c562a34785a in nifi's branch refs/heads/main from Joe Witt [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=3f2f5a02e0 ] NIFI-12768 Removed unstable assertions from TestListFile Additional assertion removals which assumed ordering that isn't guaranteed or enforced by the tests This closes #8438 Signed-off-by: David Handermann > Intermittent Failures in TestListFile.testFilterAge > --- > > Key: NIFI-12768 > URL: https://issues.apache.org/jira/browse/NIFI-12768 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 2.0.0-M2 >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0 > > Time Spent: 40m > Remaining Estimate: 0h > > The TestListFIle class has not changed substantively in quite some time, but > it has begun to fail more recently across multiple platforms on GitHub Action > runners. > The {{testFilterAge}} method often fails with the same stack trace: > {noformat} > Error: org.apache.nifi.processors.standard.TestListFile.testFilterAge -- > Time elapsed: 6.436 s <<< FAILURE! > org.opentest4j.AssertionFailedError: expected: but was: > at > org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151) > at > org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132) > at > org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197) > at > org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182) > at > org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177) > at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1141) > at > org.apache.nifi.processors.standard.TestListFile.testFilterAge(TestListFile.java:331) > at java.base/java.lang.reflect.Method.invoke(Method.java:580) > at java.base/java.util.ArrayList.forEach(ArrayList.java:1596) > at java.base/java.util.ArrayList.forEach(ArrayList.java:1596) > {noformat} > The test method use recalculated timestamps to set file modification time, so > the problem appears to be related to these timing calculations. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12768) Intermittent Failures in TestListFile.testFilterAge
[ https://issues.apache.org/jira/browse/NIFI-12768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819019#comment-17819019 ] Joe Witt commented on NIFI-12768: - New PR will remove the same pattern of checks in the same test but preceding the change already made in this JIRA. It presumes ordering that isn't guaranteed which makes these already timing dependent tests worse. > Intermittent Failures in TestListFile.testFilterAge > --- > > Key: NIFI-12768 > URL: https://issues.apache.org/jira/browse/NIFI-12768 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 2.0.0-M2 >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The TestListFIle class has not changed substantively in quite some time, but > it has begun to fail more recently across multiple platforms on GitHub Action > runners. > The {{testFilterAge}} method often fails with the same stack trace: > {noformat} > Error: org.apache.nifi.processors.standard.TestListFile.testFilterAge -- > Time elapsed: 6.436 s <<< FAILURE! > org.opentest4j.AssertionFailedError: expected: but was: > at > org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151) > at > org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132) > at > org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197) > at > org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182) > at > org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177) > at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1141) > at > org.apache.nifi.processors.standard.TestListFile.testFilterAge(TestListFile.java:331) > at java.base/java.lang.reflect.Method.invoke(Method.java:580) > at java.base/java.util.ArrayList.forEach(ArrayList.java:1596) > at java.base/java.util.ArrayList.forEach(ArrayList.java:1596) > {noformat} > The test method use recalculated timestamps to set file modification time, so > the problem appears to be related to these timing calculations. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12768) Intermittent Failures in TestListFile.testFilterAge
[ https://issues.apache.org/jira/browse/NIFI-12768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819016#comment-17819016 ] Joe Witt commented on NIFI-12768: - Reopened since this JIRA/fix is still on this unreleased line. But a very similar problem remains in a similar test. {code:java} Error: org.apache.nifi.processors.standard.TestListFile.testFilterAge -- Time elapsed: 6.302 s <<< FAILURE! org.opentest4j.AssertionFailedError: expected: <2> but was: <3> at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151) at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132) at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197) at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:150) at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:145) at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:527) at org.apache.nifi.processors.standard.TestListFile.testFilterAge(TestListFile.java:319) at java.base/java.lang.reflect.Method.invoke(Method.java:580) at java.base/java.util.ArrayList.forEach(ArrayList.java:1596) at java.base/java.util.ArrayList.forEach(ArrayList.java:1596) {code} > Intermittent Failures in TestListFile.testFilterAge > --- > > Key: NIFI-12768 > URL: https://issues.apache.org/jira/browse/NIFI-12768 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 2.0.0-M2 >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The TestListFIle class has not changed substantively in quite some time, but > it has begun to fail more recently across multiple platforms on GitHub Action > runners. > The {{testFilterAge}} method often fails with the same stack trace: > {noformat} > Error: org.apache.nifi.processors.standard.TestListFile.testFilterAge -- > Time elapsed: 6.436 s <<< FAILURE! > org.opentest4j.AssertionFailedError: expected: but was: > at > org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151) > at > org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132) > at > org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197) > at > org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182) > at > org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177) > at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1141) > at > org.apache.nifi.processors.standard.TestListFile.testFilterAge(TestListFile.java:331) > at java.base/java.lang.reflect.Method.invoke(Method.java:580) > at java.base/java.util.ArrayList.forEach(ArrayList.java:1596) > at java.base/java.util.ArrayList.forEach(ArrayList.java:1596) > {noformat} > The test method use recalculated timestamps to set file modification time, so > the problem appears to be related to these timing calculations. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12768) Intermittent Failures in TestListFile.testFilterAge
[ https://issues.apache.org/jira/browse/NIFI-12768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816220#comment-17816220 ] ASF subversion and git services commented on NIFI-12768: Commit e93fb17b66aea4940c076724b9ba8702172847fc in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e93fb17b66 ] NIFI-12768 Removed unstable filename assertion in TestListFile (#8383) > Intermittent Failures in TestListFile.testFilterAge > --- > > Key: NIFI-12768 > URL: https://issues.apache.org/jira/browse/NIFI-12768 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 2.0.0-M2 >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > The TestListFIle class has not changed substantively in quite some time, but > it has begun to fail more recently across multiple platforms on GitHub Action > runners. > The {{testFilterAge}} method often fails with the same stack trace: > {noformat} > Error: org.apache.nifi.processors.standard.TestListFile.testFilterAge -- > Time elapsed: 6.436 s <<< FAILURE! > org.opentest4j.AssertionFailedError: expected: but was: > at > org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151) > at > org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132) > at > org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197) > at > org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182) > at > org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177) > at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1141) > at > org.apache.nifi.processors.standard.TestListFile.testFilterAge(TestListFile.java:331) > at java.base/java.lang.reflect.Method.invoke(Method.java:580) > at java.base/java.util.ArrayList.forEach(ArrayList.java:1596) > at java.base/java.util.ArrayList.forEach(ArrayList.java:1596) > {noformat} > The test method use recalculated timestamps to set file modification time, so > the problem appears to be related to these timing calculations. -- This message was sent by Atlassian Jira (v8.20.10#820010)