[jira] [Commented] (NIFI-2790) Set JMS destination name on send/receive instead of using the default destination

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506704#comment-15506704
 ] 

ASF subversion and git services commented on NIFI-2790:
---

Commit c2e98f96ebe30a6a8c919ed8a747a5829f5dea0f in nifi's branch refs/heads/0.x 
from [~ozhurakousky]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=c2e98f9 ]

NIFI-2789, NIFI-2790 - polishing


> Set JMS destination name on send/receive instead of using the default 
> destination
> -
>
> Key: NIFI-2790
> URL: https://issues.apache.org/jira/browse/NIFI-2790
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Joey Frazee
>Assignee: Joey Frazee
>Priority: Minor
> Fix For: 1.1.0
>
>
> ConsumeJMS and PublishJMS currently pull their destination name from the 
> default JMS destination (setDefaultDestinationName() on the JmsTemplate). The 
> effect this has is that attribute expressions are evaluated with respect to 
> the context only and not the FlowFile, so expression language support really 
> only extends to EL functions and variables from the variable registry.
> This doesn't have a big impact on ConsumeJMS since it doesn't take input, but 
> it means that destinations can be set at runtime in PublishJMS.
> The JmsTemplate send() and receive() can take the destination name as an 
> argument though, so these method variants should be used so EL support is 
> fully enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2790) Set JMS destination name on send/receive instead of using the default destination

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506702#comment-15506702
 ] 

ASF subversion and git services commented on NIFI-2790:
---

Commit 58fdfdc76e2e59bffbbcdd4e96ad2a190b412b29 in nifi's branch refs/heads/0.x 
from [~jfrazee]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=58fdfdc ]

NIFI-2789, NIFI-2790 - Read JMS properties and add to FlowFile attributes in 
ConsumeJMS

Remove unused assertEquals import

Move destination from default to send/receive to support EL better


> Set JMS destination name on send/receive instead of using the default 
> destination
> -
>
> Key: NIFI-2790
> URL: https://issues.apache.org/jira/browse/NIFI-2790
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Joey Frazee
>Assignee: Joey Frazee
>Priority: Minor
> Fix For: 1.1.0
>
>
> ConsumeJMS and PublishJMS currently pull their destination name from the 
> default JMS destination (setDefaultDestinationName() on the JmsTemplate). The 
> effect this has is that attribute expressions are evaluated with respect to 
> the context only and not the FlowFile, so expression language support really 
> only extends to EL functions and variables from the variable registry.
> This doesn't have a big impact on ConsumeJMS since it doesn't take input, but 
> it means that destinations can be set at runtime in PublishJMS.
> The JmsTemplate send() and receive() can take the destination name as an 
> argument though, so these method variants should be used so EL support is 
> fully enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2790) Set JMS destination name on send/receive instead of using the default destination

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506541#comment-15506541
 ] 

ASF subversion and git services commented on NIFI-2790:
---

Commit c23867605857f8380140ba4d69437b58585e9cba in nifi's branch 
refs/heads/master from [~jfrazee]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=c238676 ]

NIFI-2789, NIFI-2790 - Read JMS properties and add to FlowFile attributes in 
ConsumeJMS

Remove unused assertEquals import

Move destination from default to send/receive to support EL better


> Set JMS destination name on send/receive instead of using the default 
> destination
> -
>
> Key: NIFI-2790
> URL: https://issues.apache.org/jira/browse/NIFI-2790
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Joey Frazee
>Assignee: Joey Frazee
>Priority: Minor
> Fix For: 1.1.0
>
>
> ConsumeJMS and PublishJMS currently pull their destination name from the 
> default JMS destination (setDefaultDestinationName() on the JmsTemplate). The 
> effect this has is that attribute expressions are evaluated with respect to 
> the context only and not the FlowFile, so expression language support really 
> only extends to EL functions and variables from the variable registry.
> This doesn't have a big impact on ConsumeJMS since it doesn't take input, but 
> it means that destinations can be set at runtime in PublishJMS.
> The JmsTemplate send() and receive() can take the destination name as an 
> argument though, so these method variants should be used so EL support is 
> fully enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2790) Set JMS destination name on send/receive instead of using the default destination

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506545#comment-15506545
 ] 

ASF GitHub Bot commented on NIFI-2790:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1027


> Set JMS destination name on send/receive instead of using the default 
> destination
> -
>
> Key: NIFI-2790
> URL: https://issues.apache.org/jira/browse/NIFI-2790
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Joey Frazee
>Assignee: Joey Frazee
>Priority: Minor
> Fix For: 1.1.0
>
>
> ConsumeJMS and PublishJMS currently pull their destination name from the 
> default JMS destination (setDefaultDestinationName() on the JmsTemplate). The 
> effect this has is that attribute expressions are evaluated with respect to 
> the context only and not the FlowFile, so expression language support really 
> only extends to EL functions and variables from the variable registry.
> This doesn't have a big impact on ConsumeJMS since it doesn't take input, but 
> it means that destinations can be set at runtime in PublishJMS.
> The JmsTemplate send() and receive() can take the destination name as an 
> argument though, so these method variants should be used so EL support is 
> fully enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2790) Set JMS destination name on send/receive instead of using the default destination

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504784#comment-15504784
 ] 

ASF GitHub Bot commented on NIFI-2790:
--

Github user olegz commented on the issue:

https://github.com/apache/nifi/pull/1027
  
Reviewing. . .


> Set JMS destination name on send/receive instead of using the default 
> destination
> -
>
> Key: NIFI-2790
> URL: https://issues.apache.org/jira/browse/NIFI-2790
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Joey Frazee
>Assignee: Oleg Zhurakousky
>Priority: Minor
> Fix For: 1.1.0
>
>
> ConsumeJMS and PublishJMS currently pull their destination name from the 
> default JMS destination (setDefaultDestinationName() on the JmsTemplate). The 
> effect this has is that attribute expressions are evaluated with respect to 
> the context only and not the FlowFile, so expression language support really 
> only extends to EL functions and variables from the variable registry.
> This doesn't have a big impact on ConsumeJMS since it doesn't take input, but 
> it means that destinations can be set at runtime in PublishJMS.
> The JmsTemplate send() and receive() can take the destination name as an 
> argument though, so these method variants should be used so EL support is 
> fully enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2790) Set JMS destination name on send/receive instead of using the default destination

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503839#comment-15503839
 ] 

ASF GitHub Bot commented on NIFI-2790:
--

GitHub user jfrazee opened a pull request:

https://github.com/apache/nifi/pull/1027

NIFI-2790 Set JMS destination name on send/receive instead of using the 
default destination

Note: This was branched off of NIFI-2789 / #1026.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jfrazee/nifi NIFI-2790

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1027.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1027


commit d59b4338a838dff88c66ff86ea377071cf981765
Author: Joey Frazee 
Date:   2016-09-19T13:18:30Z

Read JMS properties and add to FlowFile attributes in ConsumeJMS

commit 621fec64bd6ffbe7aefffcfd005421a6515c8ff2
Author: Joey Frazee 
Date:   2016-09-19T14:49:07Z

Remove unused assertEquals import

commit 1c76e22b06bd999496e19cd05d08db50660c1652
Author: Joey Frazee 
Date:   2016-09-19T15:50:59Z

Move destination from default to send/receive to support EL better




> Set JMS destination name on send/receive instead of using the default 
> destination
> -
>
> Key: NIFI-2790
> URL: https://issues.apache.org/jira/browse/NIFI-2790
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Joey Frazee
>Assignee: Oleg Zhurakousky
>Priority: Minor
> Fix For: 1.1.0
>
>
> ConsumeJMS and PublishJMS currently pull their destination name from the 
> default JMS destination (setDefaultDestinationName() on the JmsTemplate). The 
> effect this has is that attribute expressions are evaluated with respect to 
> the context only and not the FlowFile, so expression language support really 
> only extends to EL functions and variables from the variable registry.
> This doesn't have a big impact on ConsumeJMS since it doesn't take input, but 
> it means that destinations can be set at runtime in PublishJMS.
> The JmsTemplate send() and receive() can take the destination name as an 
> argument though, so these method variants should be used so EL support is 
> fully enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)