[jira] [Commented] (NIFI-2831) "Auto-terminate" should be used consistently in Settings tab

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533351#comment-15533351
 ] 

ASF GitHub Bot commented on NIFI-2831:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1077


> "Auto-terminate" should be used consistently in Settings tab
> 
>
> Key: NIFI-2831
> URL: https://issues.apache.org/jira/browse/NIFI-2831
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0, 0.7.0
>Reporter: Andrew Lim
>Assignee: Scott Aslan
>Priority: Trivial
> Attachments: 0.7.0_auto-Terminate.png, 1.0.0_autoTerminate.png
>
>
> As shown in the attached screenshots of the Settings tab (0.7.0 and 1.0.0) 
> when configuring a processor:
> *The text "Auto terminate relationships" is displayed. This should be changed 
> to "Auto-terminate relationships"
> *In the Configuration error, should change "Cannot Auto-Terminate" to 
> "Cannot Auto-terminate"
> These changes would make references to auto-terminate functionality 
> consistent in the application and with the documentation 
> (https://nifi.apache.org/docs/nifi-docs/html/user-guide.html#settings-tab).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2831) "Auto-terminate" should be used consistently in Settings tab

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15530806#comment-15530806
 ] 

ASF GitHub Bot commented on NIFI-2831:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1077
  
Reviewing...


> "Auto-terminate" should be used consistently in Settings tab
> 
>
> Key: NIFI-2831
> URL: https://issues.apache.org/jira/browse/NIFI-2831
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0, 0.7.0
>Reporter: Andrew Lim
>Assignee: Scott Aslan
>Priority: Trivial
> Attachments: 0.7.0_auto-Terminate.png, 1.0.0_autoTerminate.png
>
>
> As shown in the attached screenshots of the Settings tab (0.7.0 and 1.0.0) 
> when configuring a processor:
> *The text "Auto terminate relationships" is displayed. This should be changed 
> to "Auto-terminate relationships"
> *In the Configuration error, should change "Cannot Auto-Terminate" to 
> "Cannot Auto-terminate"
> These changes would make references to auto-terminate functionality 
> consistent in the application and with the documentation 
> (https://nifi.apache.org/docs/nifi-docs/html/user-guide.html#settings-tab).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2831) "Auto-terminate" should be used consistently in Settings tab

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15530135#comment-15530135
 ] 

ASF GitHub Bot commented on NIFI-2831:
--

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi/pull/1077

[NIFI-2831] update auto terminate messages



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi NIFI-2831

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1077.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1077


commit df33cd47e01cbc8dcbb513523f863a3d481926dc
Author: Scott Aslan 
Date:   2016-09-28T16:21:21Z

[NIFI-2831] update auto terminate messages




> "Auto-terminate" should be used consistently in Settings tab
> 
>
> Key: NIFI-2831
> URL: https://issues.apache.org/jira/browse/NIFI-2831
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0, 0.7.0
>Reporter: Andrew Lim
>Assignee: Scott Aslan
>Priority: Trivial
> Attachments: 0.7.0_auto-Terminate.png, 1.0.0_autoTerminate.png
>
>
> As shown in the attached screenshots of the Settings tab (0.7.0 and 1.0.0) 
> when configuring a processor:
> *The text "Auto terminate relationships" is displayed. This should be changed 
> to "Auto-terminate relationships"
> *In the Configuration error, should change "Cannot Auto-Terminate" to 
> "Cannot Auto-terminate"
> These changes would make references to auto-terminate functionality 
> consistent in the application and with the documentation 
> (https://nifi.apache.org/docs/nifi-docs/html/user-guide.html#settings-tab).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2831) "Auto-terminate" should be used consistently in Settings tab

[Andrew Lim (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529871#comment-15529871
 ] 

Andrew Lim commented on NIFI-2831:
--

[~rmoran] Sounds good to change all of these references to "automatically 
terminate".   So in the Settings tab, the text will read "Automatically 
Terminate Relationships".  In the error message it will read "Cannot 
automatically terminate 'success'..."   Once done, I will update the docs 
accordingly.

> "Auto-terminate" should be used consistently in Settings tab
> 
>
> Key: NIFI-2831
> URL: https://issues.apache.org/jira/browse/NIFI-2831
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0, 0.7.0
>Reporter: Andrew Lim
>Assignee: Scott Aslan
>Priority: Trivial
> Attachments: 0.7.0_auto-Terminate.png, 1.0.0_autoTerminate.png
>
>
> As shown in the attached screenshots of the Settings tab (0.7.0 and 1.0.0) 
> when configuring a processor:
> *The text "Auto terminate relationships" is displayed. This should be changed 
> to "Auto-terminate relationships"
> *In the Configuration error, should change "Cannot Auto-Terminate" to 
> "Cannot Auto-terminate"
> These changes would make references to auto-terminate functionality 
> consistent in the application and with the documentation 
> (https://nifi.apache.org/docs/nifi-docs/html/user-guide.html#settings-tab).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2831) "Auto-terminate" should be used consistently in Settings tab

[Rob Moran (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15527513#comment-15527513
 ] 

Rob Moran commented on NIFI-2831:
-

Yes I'd like to maintain use of title case for these labels (text-transform: 
capitalize).

What I would actually recommend is to change the phrase "auto-terminate" to 
"automatically terminate." I think impact in the UI will be fine. [~andrewmlim] 
what about in documentation, can a simple find/replace be done? I assume 
there'd be some screenshots to update as well...



> "Auto-terminate" should be used consistently in Settings tab
> 
>
> Key: NIFI-2831
> URL: https://issues.apache.org/jira/browse/NIFI-2831
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0, 0.7.0
>Reporter: Andrew Lim
>Assignee: Scott Aslan
>Priority: Trivial
> Attachments: 0.7.0_auto-Terminate.png, 1.0.0_autoTerminate.png
>
>
> As shown in the attached screenshots of the Settings tab (0.7.0 and 1.0.0) 
> when configuring a processor:
> *The text "Auto terminate relationships" is displayed. This should be changed 
> to "Auto-terminate relationships"
> *In the Configuration error, should change "Cannot Auto-Terminate" to 
> "Cannot Auto-terminate"
> These changes would make references to auto-terminate functionality 
> consistent in the application and with the documentation 
> (https://nifi.apache.org/docs/nifi-docs/html/user-guide.html#settings-tab).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2831) "Auto-terminate" should be used consistently in Settings tab

[Scott Aslan (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15527365#comment-15527365
 ] 

Scott Aslan commented on NIFI-2831:
---

I can update the Configuration error to "Cannot Auto-terminate" but for the 
text "Auto-terminate relationships" [~rmoran] specifically called out that we 
perform a text-transform: capitalization for the .setting-name in 
https://issues.apache.org/jira/browse/NIFI-2468. This will capitalize the first 
letter of each word and thus the text would actually be "Auto-Terminate 
Relationships" (notice the T is capital in Terminate)...If you notice the 
"Penalty Duration", "Bulletin Level", and all other .setting-name text also do 
not match the documentation...

I don't want to undo this until Rob weighs inwhat say you Rob?

> "Auto-terminate" should be used consistently in Settings tab
> 
>
> Key: NIFI-2831
> URL: https://issues.apache.org/jira/browse/NIFI-2831
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0, 0.7.0
>Reporter: Andrew Lim
>Assignee: Scott Aslan
>Priority: Trivial
> Attachments: 0.7.0_auto-Terminate.png, 1.0.0_autoTerminate.png
>
>
> As shown in the attached screenshots of the Settings tab (0.7.0 and 1.0.0) 
> when configuring a processor:
> *The text "Auto terminate relationships" is displayed. This should be changed 
> to "Auto-terminate relationships"
> *In the Configuration error, should change "Cannot Auto-Terminate" to 
> "Cannot Auto-terminate"
> These changes would make references to auto-terminate functionality 
> consistent in the application and with the documentation 
> (https://nifi.apache.org/docs/nifi-docs/html/user-guide.html#settings-tab).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)