[jira] [Commented] (NIFI-4819) Add support to delete blob from Azure Storage container
[ https://issues.apache.org/jira/browse/NIFI-4819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368226#comment-16368226 ] ASF GitHub Bot commented on NIFI-4819: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2436 > Add support to delete blob from Azure Storage container > --- > > Key: NIFI-4819 > URL: https://issues.apache.org/jira/browse/NIFI-4819 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: zenfenan >Priority: Major > Fix For: 1.6.0 > > > Implement a delete processor that handles deleting blob from Azure Storage > container. This should be an extension of nifi-azure-nar bundle. Currently, > the azure bundle's storage processors has support to list, fetch, put Azure > Storage blobs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4819) Add support to delete blob from Azure Storage container
[ https://issues.apache.org/jira/browse/NIFI-4819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368225#comment-16368225 ] ASF GitHub Bot commented on NIFI-4819: -- Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2436 +1, thanks for the changes @zenfenan, merging to master. > Add support to delete blob from Azure Storage container > --- > > Key: NIFI-4819 > URL: https://issues.apache.org/jira/browse/NIFI-4819 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: zenfenan >Priority: Major > > Implement a delete processor that handles deleting blob from Azure Storage > container. This should be an extension of nifi-azure-nar bundle. Currently, > the azure bundle's storage processors has support to list, fetch, put Azure > Storage blobs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4819) Add support to delete blob from Azure Storage container
[ https://issues.apache.org/jira/browse/NIFI-4819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362415#comment-16362415 ] ASF GitHub Bot commented on NIFI-4819: -- Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2436 @pvillard31 Actually I left `AtomicReference` on purpose. The reason was I wanted to implement some features later that would need that but yeah it doesn't concern or matter for the current commit/Jira so I took that off as well as fixed to `@InputRequirement(Requirement.INPUT_REQUIRED)` > Add support to delete blob from Azure Storage container > --- > > Key: NIFI-4819 > URL: https://issues.apache.org/jira/browse/NIFI-4819 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: zenfenan >Priority: Major > > Implement a delete processor that handles deleting blob from Azure Storage > container. This should be an extension of nifi-azure-nar bundle. Currently, > the azure bundle's storage processors has support to list, fetch, put Azure > Storage blobs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4819) Add support to delete blob from Azure Storage container
[
https://issues.apache.org/jira/browse/NIFI-4819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361299#comment-16361299
]
ASF GitHub Bot commented on NIFI-4819:
--
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2436#discussion_r167655116
--- Diff:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/DeleteAzureBlobStorage.java
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.azure.storage;
+
+import com.microsoft.azure.storage.StorageException;
+import com.microsoft.azure.storage.blob.CloudBlob;
+import com.microsoft.azure.storage.blob.CloudBlobClient;
+import com.microsoft.azure.storage.blob.CloudBlobContainer;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.SeeAlso;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processors.azure.AbstractAzureBlobProcessor;
+import org.apache.nifi.processors.azure.storage.utils.AzureStorageUtils;
+
+import java.net.URISyntaxException;
+import java.util.Optional;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicReference;
+
+
+@Tags({ "azure", "microsoft", "cloud", "storage", "blob" })
+@SeeAlso({ ListAzureBlobStorage.class, FetchAzureBlobStorage.class,
PutAzureBlobStorage.class})
+@CapabilityDescription("Deletes the provided blob from Azure Storage")
+@InputRequirement(InputRequirement.Requirement.INPUT_REQUIRED)
+public class DeleteAzureBlobStorage extends AbstractAzureBlobProcessor {
+
+@Override
+public void onTrigger(ProcessContext context, ProcessSession session)
throws ProcessException {
+FlowFile flowFile = session.get();
+
+if(flowFile == null) {
+return;
+}
+
+final long startNanos = System.nanoTime();
+String containerName =
context.getProperty(AzureStorageUtils.CONTAINER).evaluateAttributeExpressions(flowFile).getValue();
+String blobPath =
context.getProperty(BLOB).evaluateAttributeExpressions(flowFile).getValue();
+
+AtomicReference storedException = new
AtomicReference<>();
--- End diff --
Is it really needed?
> Add support to delete blob from Azure Storage container
> ---
>
> Key: NIFI-4819
> URL: https://issues.apache.org/jira/browse/NIFI-4819
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Reporter: zenfenan
>Priority: Major
>
> Implement a delete processor that handles deleting blob from Azure Storage
> container. This should be an extension of nifi-azure-nar bundle. Currently,
> the azure bundle's storage processors has support to list, fetch, put Azure
> Storage blobs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-4819) Add support to delete blob from Azure Storage container
[
https://issues.apache.org/jira/browse/NIFI-4819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361298#comment-16361298
]
ASF GitHub Bot commented on NIFI-4819:
--
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2436#discussion_r167655333
--- Diff:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/DeleteAzureBlobStorage.java
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.azure.storage;
+
+import com.microsoft.azure.storage.StorageException;
+import com.microsoft.azure.storage.blob.CloudBlob;
+import com.microsoft.azure.storage.blob.CloudBlobClient;
+import com.microsoft.azure.storage.blob.CloudBlobContainer;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.SeeAlso;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processors.azure.AbstractAzureBlobProcessor;
+import org.apache.nifi.processors.azure.storage.utils.AzureStorageUtils;
+
+import java.net.URISyntaxException;
+import java.util.Optional;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicReference;
+
+
+@Tags({ "azure", "microsoft", "cloud", "storage", "blob" })
+@SeeAlso({ ListAzureBlobStorage.class, FetchAzureBlobStorage.class,
PutAzureBlobStorage.class})
+@CapabilityDescription("Deletes the provided blob from Azure Storage")
+@InputRequirement(InputRequirement.Requirement.INPUT_REQUIRED)
--- End diff --
Just
java
@InputRequirement(Requirement.INPUT_REQUIRED)
to be consistent.
> Add support to delete blob from Azure Storage container
> ---
>
> Key: NIFI-4819
> URL: https://issues.apache.org/jira/browse/NIFI-4819
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Reporter: zenfenan
>Priority: Major
>
> Implement a delete processor that handles deleting blob from Azure Storage
> container. This should be an extension of nifi-azure-nar bundle. Currently,
> the azure bundle's storage processors has support to list, fetch, put Azure
> Storage blobs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-4819) Add support to delete blob from Azure Storage container
[ https://issues.apache.org/jira/browse/NIFI-4819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342423#comment-16342423 ] zenfenaan commented on NIFI-4819: - Can anyone assign it to me? I started working on it and created a PR. > Add support to delete blob from Azure Storage container > --- > > Key: NIFI-4819 > URL: https://issues.apache.org/jira/browse/NIFI-4819 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: zenfenaan >Priority: Major > > Implement a delete processor that handles deleting blob from Azure Storage > container. This should be an extension of nifi-azure-nar bundle. Currently, > the azure bundle's storage processors has support to list, fetch, put Azure > Storage blobs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4819) Add support to delete blob from Azure Storage container
[ https://issues.apache.org/jira/browse/NIFI-4819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340893#comment-16340893 ] zenfenaan commented on NIFI-4819: - Created a PR. #2436 > Add support to delete blob from Azure Storage container > --- > > Key: NIFI-4819 > URL: https://issues.apache.org/jira/browse/NIFI-4819 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: zenfenaan >Priority: Major > > Implement a delete processor that handles deleting blob from Azure Storage > container. This should be an extension of nifi-azure-nar bundle. Currently, > the azure bundle's storage processors has support to list, fetch, put Azure > Storage blobs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
