[jira] [Commented] (NIFI-5595) Add filter to template endpoint
[ https://issues.apache.org/jira/browse/NIFI-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148234#comment-17148234 ] Lucas Moten commented on NIFI-5595: --- I may have encountered a bug on this, or else I'm misconfigured and could benefit from the outcomes of NIFI-6080. But I have a feeling that the CORS check is not handling the port the call is made on when coming through a proxy. My current workaround is to force the Origin header in Nginx to be [https://127.0.0.1|https://127.0.0.1/] without specifying the port that NiFi itself is listening on. > Add filter to template endpoint > --- > > Key: NIFI-5595 > URL: https://issues.apache.org/jira/browse/NIFI-5595 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.7.1 >Reporter: Nathan Gough >Assignee: Nathan Gough >Priority: Major > Labels: cors, security > Fix For: 1.8.0 > > > The template endpoint needs a CORS filter applied. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-5595) Add filter to template endpoint
[ https://issues.apache.org/jira/browse/NIFI-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640909#comment-16640909 ] ASF GitHub Bot commented on NIFI-5595: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/3024 > Add filter to template endpoint > --- > > Key: NIFI-5595 > URL: https://issues.apache.org/jira/browse/NIFI-5595 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Nathan Gough >Assignee: Nathan Gough >Priority: Major > > The template endpoint needs a CORS filter applied. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5595) Add filter to template endpoint
[ https://issues.apache.org/jira/browse/NIFI-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640908#comment-16640908 ] ASF GitHub Bot commented on NIFI-5595: -- Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/3024 Verified by sending curl POST commands with a client certificate to upload a template. With the `Origin` header set to a remote domain, the request is blocked with the response "Invalid CORS request". Ran `contrib-check` and all tests pass. +1, merging. > Add filter to template endpoint > --- > > Key: NIFI-5595 > URL: https://issues.apache.org/jira/browse/NIFI-5595 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Nathan Gough >Assignee: Nathan Gough >Priority: Major > > The template endpoint needs a CORS filter applied. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5595) Add filter to template endpoint
[ https://issues.apache.org/jira/browse/NIFI-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626071#comment-16626071 ] ASF GitHub Bot commented on NIFI-5595: -- Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/3024 Reviewing... > Add filter to template endpoint > --- > > Key: NIFI-5595 > URL: https://issues.apache.org/jira/browse/NIFI-5595 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Nathan Gough >Assignee: Nathan Gough >Priority: Major > > The template endpoint needs a CORS filter applied. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5595) Add filter to template endpoint
[ https://issues.apache.org/jira/browse/NIFI-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625952#comment-16625952 ] ASF GitHub Bot commented on NIFI-5595: -- GitHub user thenatog opened a pull request: https://github.com/apache/nifi/pull/3024 NIFI-5595 - Added the CORS filter to the templates/upload endpoint us… …ing a URL matcher. NIFI-5595 - Explicitly allow methods GET, HEAD. These are the Spring defaults when the allowedMethods is empty but now it is explicit. This will require other methods like POST etc to be from the same origin (for the template/upload URL). Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/thenatog/nifi NIFI-5595-rebased Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/3024.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3024 commit dca24d4f2d25f583dd3177a8c376dca32651d04d Author: thenatog Date: 2018-09-14T01:45:00Z NIFI-5595 - Added the CORS filter to the templates/upload endpoint using a URL matcher. NIFI-5595 - Explicitly allow methods GET, HEAD. These are the Spring defaults when the allowedMethods is empty but now it is explicit. This will require other methods like POST etc to be from the same origin (for the template/upload URL). > Add filter to template endpoint > --- > > Key: NIFI-5595 > URL: https://issues.apache.org/jira/browse/NIFI-5595 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Nathan Gough >Assignee: Nathan Gough >Priority: Major > > The template endpoint needs a CORS filter applied. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
