[jira] [Commented] (NIFI-6916) Null messages cannot be acknowledge at JMSConsumer
[
https://issues.apache.org/jira/browse/NIFI-6916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995801#comment-16995801
]
ASF subversion and git services commented on NIFI-6916:
---
Commit 3c3eba190937aee849da52149953b7cc63304166 in nifi's branch
refs/heads/master from Pierre Villard
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=3c3eba1 ]
NIFI-6916 - handle null text message in JMSConsumer
This closes #3919.
Signed-off-by: Mark Payne
> Null messages cannot be acknowledge at JMSConsumer
> --
>
> Key: NIFI-6916
> URL: https://issues.apache.org/jira/browse/NIFI-6916
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.10.0
>Reporter: Gardella Juan Pablo
>Assignee: Pierre Villard
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{ConsumeJMS}} procesor does not handled null messages properly. Null
> messages are never acknowledge.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (NIFI-6916) Null messages cannot be acknowledge at JMSConsumer
[
https://issues.apache.org/jira/browse/NIFI-6916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987889#comment-16987889
]
Gardella Juan Pablo commented on NIFI-6916:
---
The problem happens at
[https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/JMSConsumer.java#L99]
and at
[https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/JMSConsumer.java#L101].
For a TextMessage, it is called
[https://github.com/apache/nifi/blob/ea9b0db2f620526c8dd0db595cf8b44c3ef835be/nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/MessageBodyToBytesConverter.java#L52]
and will throw a NPE.
This will cause acknowledge call
([https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/JMSConsumer.java#L124])
is not called for a null message. Let me know if I am clear now.
> Null messages cannot be acknowledge at JMSConsumer
> --
>
> Key: NIFI-6916
> URL: https://issues.apache.org/jira/browse/NIFI-6916
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.10.0
>Reporter: Gardella Juan Pablo
>Priority: Major
>
> {{ConsumeJMS}} procesor does not handled null messages properly. Null
> messages are never acknowledge.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (NIFI-6916) Null messages cannot be acknowledge at JMSConsumer
[
https://issues.apache.org/jira/browse/NIFI-6916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987632#comment-16987632
]
Pierre Villard commented on NIFI-6916:
--
Not sure to understand what you mean here. By "null message", do you mean a
message with no content (only headers)? Looking at the code, I don't see when a
message would not be acknowledged. When the consumer receives a message, the
method "returns the next message produced for this message consumer, or null if
the timeout expires or this message consumer is concurrently closed". I don't
see how/why we would do a ACK in this case, no?
> Null messages cannot be acknowledge at JMSConsumer
> --
>
> Key: NIFI-6916
> URL: https://issues.apache.org/jira/browse/NIFI-6916
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.10.0
>Reporter: Gardella Juan Pablo
>Priority: Major
>
> {{ConsumeJMS}} procesor does not handled null messages properly. Null
> messages are never acknowledge.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
