Martin Wiesner created OPENNLP-1411:
---------------------------------------

             Summary: Provide equals and hashCode for POSModel
                 Key: OPENNLP-1411
                 URL: https://issues.apache.org/jira/browse/OPENNLP-1411
             Project: OpenNLP
          Issue Type: Improvement
          Components: POS Tagger
    Affects Versions: 2.1.0
            Reporter: Martin Wiesner
             Fix For: 2.1.1


The test _opennlp.tools.postag.POSModelTest_ signals by two TODOs that no 
actual assertions are made to check whether (de-)serialized POSModel instances 
are correctly read in again.

In other words: _opennlp.tools.postag.POSModel_ lacks a valid equals/hashCode 
implementation by which one could verify a valid state (=equality) after 
(de-)serialization has occurred.

In addition, two possible base classes GISModel and PerceptronModel also 
require valid equals/hashCode implementations, so that _POSModel's_ 
equals/hashCode will work properly.

Aim:
 * Provide an improved implementation of the POS-related "Model" classes.
 * Remove both TODOs in _POSModelTest_
 * Improve both test cases (MaxEnt/GIS and Perceptron) with further test 
assertions.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to