[ https://issues.apache.org/jira/browse/OPENNLP-1412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Zowalla resolved OPENNLP-1412. -------------------------------------- Resolution: Fixed > Provide equals and hashCode for ParserModel and TokenizerModel > -------------------------------------------------------------- > > Key: OPENNLP-1412 > URL: https://issues.apache.org/jira/browse/OPENNLP-1412 > Project: OpenNLP > Issue Type: Improvement > Components: Parser, Tokenizer > Affects Versions: 2.1.0 > Reporter: Martin Wiesner > Assignee: Martin Wiesner > Priority: Minor > Fix For: 2.1.1 > > > The tests {_}opennlp.tools.tokenize.{*}TokenizerModelTest{*}{_}, > {_}opennlp.tools.parser.chunking.{_}{*}_ParserTest_{*}, and > {_}opennlp.tools.parser.treeinsert.{_}{*}_ParserTest_{*} signal by TODOs that > no actual assertions are made to check whether (de-)serialized Model > instances are correctly read in again. > In other words: Those (Tokenizer/Parser) models lacks a valid equals/hashCode > implementation by which one could verify a valid state (=equality) after > (de-)serialization has occurred. > Aim: > * Provide an improved implementation of the related "Model" classes. > * Remove existing TODOs in _TokenizerModelTest_ and _ParserTest_ > * Improve the three test classes with further test assertions. -- This message was sent by Atlassian Jira (v8.20.10#820010)