[jira] [Updated] (OPENNLP-6) Create a new OpenNLP project logo for the site

2017-02-15 Thread Suneel Marthi (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OPENNLP-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suneel Marthi updated OPENNLP-6:

Fix Version/s: 1.8.0

> Create a new OpenNLP project logo for the site
> --
>
> Key: OPENNLP-6
> URL: https://issues.apache.org/jira/browse/OPENNLP-6
> Project: OpenNLP
>  Issue Type: Improvement
>  Components: Website
>Reporter: Joern Kottmann
>Priority: Minor
>  Labels: help-wanted
> Fix For: 1.8.0
>
> Attachments: kinow-opennlp-1.png, kinow-opennlp-2.png, 
> kinow-opennlp-3.png, kinow-opennlp-3-variations.png, OpenNLP-koji-1.png, 
> OpenNLP-koji-1.png, OpenNLP-koji-2.png, OpenNLP.png, opennlp-variations.png
>
>
> The current logo was not changed for a long time (if ever). 
> Lets create a new fresh looking logo.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (OPENNLP-981) Training EventStream Hash was removed from event trainer

2017-02-15 Thread Suneel Marthi (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OPENNLP-981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suneel Marthi closed OPENNLP-981.
-

> Training EventStream Hash was removed from event trainer
> 
>
> Key: OPENNLP-981
> URL: https://issues.apache.org/jira/browse/OPENNLP-981
> Project: OpenNLP
>  Issue Type: Bug
>  Components: Machine Learning
>Affects Versions: 1.7.2
>Reporter: Daniel Russ
>Priority: Minor
> Fix For: 1.8.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OPENNLP-986) Use stupid backoff by default in NGramLanguageModel

2017-02-15 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/OPENNLP-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868992#comment-15868992
 ] 

ASF GitHub Bot commented on OPENNLP-986:


Github user asfgit closed the pull request at:

https://github.com/apache/opennlp/pull/124


> Use stupid backoff by default in NGramLanguageModel
> ---
>
> Key: OPENNLP-986
> URL: https://issues.apache.org/jira/browse/OPENNLP-986
> Project: OpenNLP
>  Issue Type: Improvement
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 1.8.0
>
>
> {{NGramLanguageModel}} is already using [Stupid 
> Backoff|http://www.aclweb.org/anthology/D07-1090.pdf] discounting when it 
> contains more than 1M ngrams.
> However since the not very good performance of Laplace smoothing for smaller 
> models, it'd be better to simply use Stupid Backoff in all cases.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OPENNLP-990) Add checkstyle for array style to be String[] array

2017-02-15 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/OPENNLP-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868704#comment-15868704
 ] 

ASF GitHub Bot commented on OPENNLP-990:


GitHub user thygesen opened a pull request:

https://github.com/apache/opennlp/pull/127

OPENNLP-990: Add checkstyle for array style to be String[] array

added check for java style arrays. E.g. String[]

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/thygesen/opennlp opennlp-990

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/opennlp/pull/127.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #127


commit 218100a909f6cfde4adeb71c6dd1cfc6ecf0c3dc
Author: Peter Thygesen 
Date:   2017-02-15T22:27:55Z

OPENNLP-990 added checkstyle check to enforce Java style arrays




> Add checkstyle for array style to be String[] array
> ---
>
> Key: OPENNLP-990
> URL: https://issues.apache.org/jira/browse/OPENNLP-990
> Project: OpenNLP
>  Issue Type: Improvement
>Reporter: Joern Kottmann
>Assignee: Peter Thygesen
>Priority: Trivial
> Fix For: 1.8.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OPENNLP-989) NameFinderSequenceValidator should not return true for CONT following a START of a different name type

2017-02-15 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/OPENNLP-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868582#comment-15868582
 ] 

ASF GitHub Bot commented on OPENNLP-989:


GitHub user thygesen opened a pull request:

https://github.com/apache/opennlp/pull/126

OPENNLP-989: NameFinderSequenceValidator should not return true for CONT 
following a START of a different name type

Added same check as found in BilouNameFinderSequenceValidator. 
If outcome is CONT and previous was CONT or START then compare name types 
as part of the validation.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/thygesen/opennlp opennlp-989

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/opennlp/pull/126.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #126


commit 40d96d297a028b41c2f1ceb4c5c91b7ac5ac9de1
Author: Peter Thygesen 
Date:   2017-02-15T21:11:08Z

Fixed OPENNLP-989 START followed by CONT will compare name types




> NameFinderSequenceValidator should not return true for CONT following a START 
> of a different name type
> --
>
> Key: OPENNLP-989
> URL: https://issues.apache.org/jira/browse/OPENNLP-989
> Project: OpenNLP
>  Issue Type: Bug
>  Components: Name Finder
>Affects Versions: 1.7.2
>Reporter: Peter Thygesen
>Assignee: Peter Thygesen
>Priority: Minor
> Attachments: 
> Fixed_OPENNLP_989_START_followed_by_CONT_will_compare_name_types_.patch
>
>
> Writing the unittest for NameFinderSequenceValidator it was discovered that 
> Start followed by a Continue of a different type was validated as correct 
> (valid).
> The simple test for continue in NameFinderSequenceValidator does not take the 
> name type into account.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OPENNLP-989) NameFinderSequenceValidator should not return true for CONT following a START of a different name type

2017-02-15 Thread Peter Thygesen (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OPENNLP-989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Thygesen updated OPENNLP-989:
---
Attachment: 
Fixed_OPENNLP_989_START_followed_by_CONT_will_compare_name_types_.patch

> NameFinderSequenceValidator should not return true for CONT following a START 
> of a different name type
> --
>
> Key: OPENNLP-989
> URL: https://issues.apache.org/jira/browse/OPENNLP-989
> Project: OpenNLP
>  Issue Type: Bug
>  Components: Name Finder
>Affects Versions: 1.7.2
>Reporter: Peter Thygesen
>Assignee: Peter Thygesen
>Priority: Minor
> Attachments: 
> Fixed_OPENNLP_989_START_followed_by_CONT_will_compare_name_types_.patch
>
>
> Writing the unittest for NameFinderSequenceValidator it was discovered that 
> Start followed by a Continue of a different type was validated as correct 
> (valid).
> The simple test for continue in NameFinderSequenceValidator does not take the 
> name type into account.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (OPENNLP-990) Add checkstyle for array style to be String[] array

2017-02-15 Thread Joern Kottmann (JIRA) 
Joern Kottmann created OPENNLP-990:
--

 Summary: Add checkstyle for array style to be String[] array
 Key: OPENNLP-990
 URL: https://issues.apache.org/jira/browse/OPENNLP-990
 Project: OpenNLP
  Issue Type: Improvement
Reporter: Joern Kottmann
Assignee: Peter Thygesen
Priority: Trivial
 Fix For: 1.8.0






--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OPENNLP-989) NameFinderSequenceValidator should not return true for CONT following a START of a different name type

2017-02-15 Thread Peter Thygesen (JIRA) 

[ 
https://issues.apache.org/jira/browse/OPENNLP-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868543#comment-15868543
 ] 

Peter Thygesen commented on OPENNLP-989:


'It can be fixed just by added a test for "start" like in 
BilouNameFinderSequenceValidator.


> NameFinderSequenceValidator should not return true for CONT following a START 
> of a different name type
> --
>
> Key: OPENNLP-989
> URL: https://issues.apache.org/jira/browse/OPENNLP-989
> Project: OpenNLP
>  Issue Type: Bug
>  Components: Name Finder
>Affects Versions: 1.7.2
>Reporter: Peter Thygesen
>Assignee: Peter Thygesen
>Priority: Minor
>
> Writing the unittest for NameFinderSequenceValidator it was discovered that 
> Start followed by a Continue of a different type was validated as correct 
> (valid).
> The simple test for continue in NameFinderSequenceValidator does not take the 
> name type into account.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (OPENNLP-989) NameFinderSequenceValidator should not return true for CONT following a START of a different name type

2017-02-15 Thread Peter Thygesen (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OPENNLP-989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Thygesen reassigned OPENNLP-989:
--

Assignee: Peter Thygesen

> NameFinderSequenceValidator should not return true for CONT following a START 
> of a different name type
> --
>
> Key: OPENNLP-989
> URL: https://issues.apache.org/jira/browse/OPENNLP-989
> Project: OpenNLP
>  Issue Type: Bug
>  Components: Name Finder
>Affects Versions: 1.7.2
>Reporter: Peter Thygesen
>Assignee: Peter Thygesen
>Priority: Minor
>
> Writing the unittest for NameFinderSequenceValidator it was discovered that 
> Start followed by a Continue of a different type was validated as correct 
> (valid).
> The simple test for continue in NameFinderSequenceValidator does not take the 
> name type into account.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (OPENNLP-989) NameFinderSequenceValidator should not return true for CONT following a START of a different name type

2017-02-15 Thread Peter Thygesen (JIRA) 
Peter Thygesen created OPENNLP-989:
--

 Summary: NameFinderSequenceValidator should not return true for 
CONT following a START of a different name type
 Key: OPENNLP-989
 URL: https://issues.apache.org/jira/browse/OPENNLP-989
 Project: OpenNLP
  Issue Type: Bug
  Components: Name Finder
Affects Versions: 1.7.2
Reporter: Peter Thygesen
Priority: Minor


Writing the unittest for NameFinderSequenceValidator it was discovered that 
Start followed by a Continue of a different type was validated as correct 
(valid).

The simple test for continue in NameFinderSequenceValidator does not take the 
name type into account.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OPENNLP-229) Write a test case for the NameFinderSequenceValidator class

2017-02-15 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/OPENNLP-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868499#comment-15868499
 ] 

ASF GitHub Bot commented on OPENNLP-229:


GitHub user thygesen opened a pull request:

https://github.com/apache/opennlp/pull/125

OPENNLP-229: Write a test case for the NameFinderSequenceValidator class

I have written the missing test for NameFinderSequenceValidator. Please 
note that the test:testContinueAfterStartAndNotSameType has temporary been 
disabled because it will fail due to a minor "bug" in the 
NameFinderSequenceValidator. At the moment the validator accepts Continue after 
Start even though they are different name types. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/thygesen/opennlp opennlp-229

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/opennlp/pull/125.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #125


commit 5c29df047778fb1ac3d9773c27c001291a52112c
Author: Peter Thygesen 
Date:   2017-02-15T20:12:48Z

Added test for NameFinderSequenceValidator




> Write a test case for the NameFinderSequenceValidator class
> ---
>
> Key: OPENNLP-229
> URL: https://issues.apache.org/jira/browse/OPENNLP-229
> Project: OpenNLP
>  Issue Type: Task
>  Components: Name Finder
>Reporter: Joern Kottmann
>Assignee: Peter Thygesen
>Priority: Minor
> Fix For: 1.8.0
>
> Attachments: OPENNLP-229.patch, OPENNLP-229.patch, 
> patch_OPENNLP-229_added.patch, patch_OPENNLP-229.java
>
>
> The NameFinderSequenceValidator is public now, and that makes it possible to 
> write a test for it. The test should check that the sequence validation works 
> as expected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (OPENNLP-988) TokenNameFinderEvaluator CLI should support nameTypes argument

2017-02-15 Thread William Colen (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OPENNLP-988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

William Colen closed OPENNLP-988.
-
Resolution: Works for Me

Actually it is already supported by the CLI.

> TokenNameFinderEvaluator CLI should support nameTypes argument
> --
>
> Key: OPENNLP-988
> URL: https://issues.apache.org/jira/browse/OPENNLP-988
> Project: OpenNLP
>  Issue Type: Improvement
>  Components: Name Finder
>Affects Versions: 1.8.0
>Reporter: William Colen
>Assignee: William Colen
> Fix For: 1.8.0
>
>
> One can specify the name types to use for training. The same way, one could 
> specify the name types to use for evaluating that model.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (OPENNLP-6) Create a new OpenNLP project logo for the site

2017-02-15 Thread Joern Kottmann (JIRA) 

[ 
https://issues.apache.org/jira/browse/OPENNLP-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867706#comment-15867706
 ] 

Joern Kottmann edited comment on OPENNLP-6 at 2/15/17 12:04 PM:


Thanks again for taking time to help us with the logo!

There was a bit of an off mailing list discussion about the logos and we came 
to the conclusion that we really like two things:
- the book (see OpenNLP-koji-1.png)
- the logo (1,1) (see kinow-opennlp-3-variations.png)

Would it be possible for you two to work together and make a logo that has this 
somehow combined? 


was (Author: joern):
Thanks again for taking time to help us with the logo!

There was a bit of an off mailing list discussion about the logos and we came 
to the conclusion that we really like two things:
- the book (see OpenNLP-koji-1.png)
- the logo (1,1) 

Would it be possible for you two to work together and make a logo that has this 
somehow combined? 

> Create a new OpenNLP project logo for the site
> --
>
> Key: OPENNLP-6
> URL: https://issues.apache.org/jira/browse/OPENNLP-6
> Project: OpenNLP
>  Issue Type: Improvement
>  Components: Website
>Reporter: Joern Kottmann
>Priority: Minor
>  Labels: help-wanted
> Attachments: kinow-opennlp-1.png, kinow-opennlp-2.png, 
> kinow-opennlp-3.png, kinow-opennlp-3-variations.png, OpenNLP-koji-1.png, 
> OpenNLP-koji-1.png, OpenNLP-koji-2.png, OpenNLP.png, opennlp-variations.png
>
>
> The current logo was not changed for a long time (if ever). 
> Lets create a new fresh looking logo.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OPENNLP-6) Create a new OpenNLP project logo for the site

2017-02-15 Thread Joern Kottmann (JIRA) 

[ 
https://issues.apache.org/jira/browse/OPENNLP-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867706#comment-15867706
 ] 

Joern Kottmann commented on OPENNLP-6:
--

Thanks again for taking time to help us with the logo!

There was a bit of an off mailing list discussion about the logos and we came 
to the conclusion that we really like two things:
- the book (see OpenNLP-koji-1.png)
- the logo (1,1) 

Would it be possible for you two to work together and make a logo that has this 
somehow combined? 

> Create a new OpenNLP project logo for the site
> --
>
> Key: OPENNLP-6
> URL: https://issues.apache.org/jira/browse/OPENNLP-6
> Project: OpenNLP
>  Issue Type: Improvement
>  Components: Website
>Reporter: Joern Kottmann
>Priority: Minor
>  Labels: help-wanted
> Attachments: kinow-opennlp-1.png, kinow-opennlp-2.png, 
> kinow-opennlp-3.png, kinow-opennlp-3-variations.png, OpenNLP-koji-1.png, 
> OpenNLP-koji-1.png, OpenNLP-koji-2.png, OpenNLP.png, opennlp-variations.png
>
>
> The current logo was not changed for a long time (if ever). 
> Lets create a new fresh looking logo.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)