[jira] [Resolved] (OPENNLP-1146) remove unnecessary serialVersionUID
[
https://issues.apache.org/jira/browse/OPENNLP-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Koji Sekiguchi resolved OPENNLP-1146.
-
Resolution: Fixed
Thanks all for reviewing this!
> remove unnecessary serialVersionUID
> ---
>
> Key: OPENNLP-1146
> URL: https://issues.apache.org/jira/browse/OPENNLP-1146
> Project: OpenNLP
> Issue Type: Improvement
> Components: Build, Packaging and Test
>Affects Versions: 1.8.2
>Reporter: Koji Sekiguchi
>Assignee: Koji Sekiguchi
>Priority: Trivial
> Fix For: 1.8.3
>
>
> We saw several classes that have unnecessary serialVersionUID constant
> declaration. Most of them are Stemmer classes that are created by the
> Snowball to Java compiler. I think we can just remove serialVersionUID from
> Stemmer classes. Other than Stemmer classes, Exception classes which extend
> RuntimeException or IOException have serialVersionUID. I'll remove
> serialVersionUID from these Exception classes as well but add
> @SuppressWarnings("serial") just in case.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OPENNLP-1146) remove unnecessary serialVersionUID
[
https://issues.apache.org/jira/browse/OPENNLP-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210432#comment-16210432
]
ASF GitHub Bot commented on OPENNLP-1146:
-
kojisekig closed pull request #277: OPENNLP-1146: remove unnecessary
serialVersionUID
URL: https://github.com/apache/opennlp/pull/277
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/opennlp-tools/src/main/java/opennlp/tools/cmdline/TerminateToolException.java
b/opennlp-tools/src/main/java/opennlp/tools/cmdline/TerminateToolException.java
index 3c5d4303a..1ba69faa5 100644
---
a/opennlp-tools/src/main/java/opennlp/tools/cmdline/TerminateToolException.java
+++
b/opennlp-tools/src/main/java/opennlp/tools/cmdline/TerminateToolException.java
@@ -30,10 +30,9 @@
*
* Note: Do not use this class, internal use only!
*/
+@SuppressWarnings("serial")
public class TerminateToolException extends RuntimeException {
- private static final long serialVersionUID = 1L;
-
private final int code;
private final String message;
diff --git
a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/danishStemmer.java
b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/danishStemmer.java
index 67ad85f3f..5911c67f7 100644
---
a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/danishStemmer.java
+++
b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/danishStemmer.java
@@ -40,8 +40,6 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY
WAY OUT OF THE USE
*/
class danishStemmer extends
opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
-private static final long serialVersionUID = 1L;
-
private final static danishStemmer methodObject = new danishStemmer ();
private final static Among a_0[] = {
diff --git
a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/dutchStemmer.java
b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/dutchStemmer.java
index b402e4cfc..add6cc94a 100644
---
a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/dutchStemmer.java
+++
b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/dutchStemmer.java
@@ -40,8 +40,6 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY
WAY OUT OF THE USE
*/
class dutchStemmer extends
opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
-private static final long serialVersionUID = 1L;
-
private final static dutchStemmer methodObject = new dutchStemmer ();
private final static Among a_0[] = {
diff --git
a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/englishStemmer.java
b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/englishStemmer.java
index 4323166b4..bac057ff5 100644
---
a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/englishStemmer.java
+++
b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/englishStemmer.java
@@ -40,8 +40,6 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY
WAY OUT OF THE USE
*/
class englishStemmer extends
opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
-private static final long serialVersionUID = 1L;
-
private final static englishStemmer methodObject = new englishStemmer
();
private final static Among a_0[] = {
diff --git
a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/finnishStemmer.java
b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/finnishStemmer.java
index ba7215bca..70add1173 100644
---
a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/finnishStemmer.java
+++
b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/finnishStemmer.java
@@ -40,8 +40,6 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY
WAY OUT OF THE USE
*/
class finnishStemmer extends
opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
-private static final long serialVersionUID = 1L;
-
private final static finnishStemmer methodObject = new finnishStemmer
();
private final static Among a_0[] = {
diff --git
a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/frenchStemmer.java
b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/frenchStemmer.java
index 8dd485a09..5cd4ee6e8 100644
---
a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/frenchStemmer.java
+++
b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/frenchStemmer.java
@@ -41,8 +41,6 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY
WAY OUT OF THE USE
*/
class frenchStemmer extends
opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
-private static final long serialVersionUID = 1L;
-
[jira] [Commented] (OPENNLP-1146) remove unnecessary serialVersionUID
[
https://issues.apache.org/jira/browse/OPENNLP-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210427#comment-16210427
]
ASF GitHub Bot commented on OPENNLP-1146:
-
kojisekig commented on issue #277: OPENNLP-1146: remove unnecessary
serialVersionUID
URL: https://github.com/apache/opennlp/pull/277#issuecomment-337771966
The stemmer generated codes have been maintained manually in OPENNLP-952.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> remove unnecessary serialVersionUID
> ---
>
> Key: OPENNLP-1146
> URL: https://issues.apache.org/jira/browse/OPENNLP-1146
> Project: OpenNLP
> Issue Type: Improvement
> Components: Build, Packaging and Test
>Affects Versions: 1.8.2
>Reporter: Koji Sekiguchi
>Assignee: Koji Sekiguchi
>Priority: Trivial
> Fix For: 1.8.3
>
>
> We saw several classes that have unnecessary serialVersionUID constant
> declaration. Most of them are Stemmer classes that are created by the
> Snowball to Java compiler. I think we can just remove serialVersionUID from
> Stemmer classes. Other than Stemmer classes, Exception classes which extend
> RuntimeException or IOException have serialVersionUID. I'll remove
> serialVersionUID from these Exception classes as well but add
> @SuppressWarnings("serial") just in case.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OPENNLP-1146) remove unnecessary serialVersionUID
[
https://issues.apache.org/jira/browse/OPENNLP-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209380#comment-16209380
]
ASF GitHub Bot commented on OPENNLP-1146:
-
jzonthemtn commented on issue #277: OPENNLP-1146: remove unnecessary
serialVersionUID
URL: https://github.com/apache/opennlp/pull/277#issuecomment-337603059
#190 also deals with changes in the stemmer generated code. Regardless of
whether this merged maybe we should make a list and submit pull requests to the
stemmer generator. (Another is adding the `@Generated` annotation to the
class.) Are there others?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> remove unnecessary serialVersionUID
> ---
>
> Key: OPENNLP-1146
> URL: https://issues.apache.org/jira/browse/OPENNLP-1146
> Project: OpenNLP
> Issue Type: Improvement
> Components: Build, Packaging and Test
>Affects Versions: 1.8.2
>Reporter: Koji Sekiguchi
>Assignee: Koji Sekiguchi
>Priority: Trivial
> Fix For: 1.8.3
>
>
> We saw several classes that have unnecessary serialVersionUID constant
> declaration. Most of them are Stemmer classes that are created by the
> Snowball to Java compiler. I think we can just remove serialVersionUID from
> Stemmer classes. Other than Stemmer classes, Exception classes which extend
> RuntimeException or IOException have serialVersionUID. I'll remove
> serialVersionUID from these Exception classes as well but add
> @SuppressWarnings("serial") just in case.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OPENNLP-1146) remove unnecessary serialVersionUID
[
https://issues.apache.org/jira/browse/OPENNLP-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209372#comment-16209372
]
ASF GitHub Bot commented on OPENNLP-1146:
-
kottmann commented on issue #277: OPENNLP-1146: remove unnecessary
serialVersionUID
URL: https://github.com/apache/opennlp/pull/277#issuecomment-337601383
The default is a reasonable value. The idea is that you can change this in
case you have a use case of serializing and deserializing objects from
different versions of OpenNLP. This is something our users really should not do.
And if they do it anyway, and we want to support that, we can by setting the
version to indicate backward compatibility has been broken.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> remove unnecessary serialVersionUID
> ---
>
> Key: OPENNLP-1146
> URL: https://issues.apache.org/jira/browse/OPENNLP-1146
> Project: OpenNLP
> Issue Type: Improvement
> Components: Build, Packaging and Test
>Affects Versions: 1.8.2
>Reporter: Koji Sekiguchi
>Assignee: Koji Sekiguchi
>Priority: Trivial
> Fix For: 1.8.3
>
>
> We saw several classes that have unnecessary serialVersionUID constant
> declaration. Most of them are Stemmer classes that are created by the
> Snowball to Java compiler. I think we can just remove serialVersionUID from
> Stemmer classes. Other than Stemmer classes, Exception classes which extend
> RuntimeException or IOException have serialVersionUID. I'll remove
> serialVersionUID from these Exception classes as well but add
> @SuppressWarnings("serial") just in case.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OPENNLP-1146) remove unnecessary serialVersionUID
[
https://issues.apache.org/jira/browse/OPENNLP-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209373#comment-16209373
]
ASF GitHub Bot commented on OPENNLP-1146:
-
kottmann commented on issue #277: OPENNLP-1146: remove unnecessary
serialVersionUID
URL: https://github.com/apache/opennlp/pull/277#issuecomment-337601383
The default is a reasonable value. The idea is that you can change this in
case you have a use case of serializing and deserializing objects from
different versions of OpenNLP. This is something our users really should not do.
And if they do it anyway, and we want to support that, we can by setting the
version to indicate backward compatibility has been broken.
+1 to merge this, not sure we should maintain the stemmer code
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> remove unnecessary serialVersionUID
> ---
>
> Key: OPENNLP-1146
> URL: https://issues.apache.org/jira/browse/OPENNLP-1146
> Project: OpenNLP
> Issue Type: Improvement
> Components: Build, Packaging and Test
>Affects Versions: 1.8.2
>Reporter: Koji Sekiguchi
>Assignee: Koji Sekiguchi
>Priority: Trivial
> Fix For: 1.8.3
>
>
> We saw several classes that have unnecessary serialVersionUID constant
> declaration. Most of them are Stemmer classes that are created by the
> Snowball to Java compiler. I think we can just remove serialVersionUID from
> Stemmer classes. Other than Stemmer classes, Exception classes which extend
> RuntimeException or IOException have serialVersionUID. I'll remove
> serialVersionUID from these Exception classes as well but add
> @SuppressWarnings("serial") just in case.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OPENNLP-1146) remove unnecessary serialVersionUID
[
https://issues.apache.org/jira/browse/OPENNLP-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209369#comment-16209369
]
ASF GitHub Bot commented on OPENNLP-1146:
-
kottmann commented on issue #277: OPENNLP-1146: remove unnecessary
serialVersionUID
URL: https://github.com/apache/opennlp/pull/277#issuecomment-337601383
The default is a reasonable value. The idea is that you can change this in
case you have a use case of serializing and deserializing objects from
different versions of OpenNLP. This is something our users really should not do.
And if they do it anyway, and we want to support that we can, by setting the
version to indicate backward compatibility has been broken.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> remove unnecessary serialVersionUID
> ---
>
> Key: OPENNLP-1146
> URL: https://issues.apache.org/jira/browse/OPENNLP-1146
> Project: OpenNLP
> Issue Type: Improvement
> Components: Build, Packaging and Test
>Affects Versions: 1.8.2
>Reporter: Koji Sekiguchi
>Assignee: Koji Sekiguchi
>Priority: Trivial
> Fix For: 1.8.3
>
>
> We saw several classes that have unnecessary serialVersionUID constant
> declaration. Most of them are Stemmer classes that are created by the
> Snowball to Java compiler. I think we can just remove serialVersionUID from
> Stemmer classes. Other than Stemmer classes, Exception classes which extend
> RuntimeException or IOException have serialVersionUID. I'll remove
> serialVersionUID from these Exception classes as well but add
> @SuppressWarnings("serial") just in case.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
