[
https://issues.apache.org/jira/browse/OPENNLP-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482161#comment-16482161
]
ASF GitHub Bot commented on OPENNLP-1198:
-
kojisekig opened a new pull request #319: OPENNLP-1198: add more tests to
NGramGeneratorTest
URL: https://github.com/apache/opennlp/pull/319
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with OPENNLP- where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> add more tests to NGramGeneratorTest
>
>
> Key: OPENNLP-1198
> URL: https://issues.apache.org/jira/browse/OPENNLP-1198
> Project: OpenNLP
> Issue Type: Test
> Components: Build, Packaging and Test
>Affects Versions: 1.8.4
>Reporter: Koji Sekiguchi
>Priority: Trivial
>
> At present, NGramGeneratorTest has only 2-gram test against the example
> sentence "This is a sentence". I think we'd better to have 1-gram, 3-gram and
> 4-gram test cases for this example sentence.
> In addition, it checks the return values by doing like this:
> {code}
> Assert.assertEquals(3, ngrams.size());
> Assert.assertTrue(ngrams.contains("This-is"));
> Assert.assertTrue(ngrams.contains("is-a"));
> Assert.assertTrue(ngrams.contains("a-sentence"));
> {code}
> but it cannot check the sequence. I think we should check it like this,
> instead:
> {code}
> Assert.assertEquals(3, ngrams.size());
> Assert.assertEquals("This-is", ngrams.get(0));
> Assert.assertEquals("is-a", ngrams.get(1));
> Assert.assertEquals("a-sentence", ngrams.get(2));
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
