[jira] [Commented] (OPENNLP-1461) Create OpenNLP on Jenkins
[ https://issues.apache.org/jira/browse/OPENNLP-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688112#comment-17688112 ] Richard Zowalla commented on OPENNLP-1461: -- [~jzemerick] Here are some details: https://cwiki.apache.org/confluence/display/INFRA/Jenkins - might be possible via Whimsy. > Create OpenNLP on Jenkins > - > > Key: OPENNLP-1461 > URL: https://issues.apache.org/jira/browse/OPENNLP-1461 > Project: OpenNLP > Issue Type: Sub-task >Reporter: Richard Zowalla >Assignee: Jeff Zemerick >Priority: Major > > Create OpenNLP on https://ci-builds.apache.org/ > It might be just possible for you after logging in _or_ requires an INFRA > ticket. Didn't find any documentation about .it -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OPENNLP-1463) Create a Jenkins job to run the eval tests
Richard Zowalla created OPENNLP-1463: Summary: Create a Jenkins job to run the eval tests Key: OPENNLP-1463 URL: https://issues.apache.org/jira/browse/OPENNLP-1463 Project: OpenNLP Issue Type: Sub-task Reporter: Richard Zowalla Assignee: Richard Zowalla If the eval data is available on nightlies.a.o, we need a job to actually run the evaluation tests on Jenkins. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OPENNLP-1462) Get the eval data via a Jenkins job to nightlies.a.o
Richard Zowalla created OPENNLP-1462: Summary: Get the eval data via a Jenkins job to nightlies.a.o Key: OPENNLP-1462 URL: https://issues.apache.org/jira/browse/OPENNLP-1462 Project: OpenNLP Issue Type: Sub-task Reporter: Richard Zowalla Assignee: Richard Zowalla Evaluation data needs to be deployed to nightlies.a.o To do so, we need to follow the steps outlined in https://nightlies.apache.org/jenkins-publishing.html Note, that we only need to conduct this steps once. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OPENNLP-1461) Create OpenNLP on Jenkins
Richard Zowalla created OPENNLP-1461: Summary: Create OpenNLP on Jenkins Key: OPENNLP-1461 URL: https://issues.apache.org/jira/browse/OPENNLP-1461 Project: OpenNLP Issue Type: Sub-task Reporter: Richard Zowalla Assignee: Jeff Zemerick Create OpenNLP on https://ci-builds.apache.org/ It might be just possible for you after logging in _or_ requires an INFRA ticket. Didn't find any documentation about .it -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OPENNLP-1460) Run Evaluation Tests on Jenkins CI
Richard Zowalla created OPENNLP-1460: Summary: Run Evaluation Tests on Jenkins CI Key: OPENNLP-1460 URL: https://issues.apache.org/jira/browse/OPENNLP-1460 Project: OpenNLP Issue Type: Task Reporter: Richard Zowalla I had a quick chat with [~jzemerick] and talked with [~mawiesne] last week. It would be neat to run the eval tests in CI (and not just on local machines before releases). I asked INFRA about the license implications and they said, that there isn't a problem if it isn't redistributed. They suggest to add the data to https://nightlies.apache.org/ Data can be published from Jenkins: https://nightlies.apache.org/jenkins-publishing.html Tasks: * Get OpenNLP on Jenkins * Get the eval data via a Jenkins job to nightlies.a.o * Create a Jenkins job to run the eval tests with the data hosted at nightlies.a.o -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (OPENNLP-1460) Run Evaluation Tests on Jenkins CI
[ https://issues.apache.org/jira/browse/OPENNLP-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Richard Zowalla reassigned OPENNLP-1460: Assignee: Richard Zowalla > Run Evaluation Tests on Jenkins CI > -- > > Key: OPENNLP-1460 > URL: https://issues.apache.org/jira/browse/OPENNLP-1460 > Project: OpenNLP > Issue Type: Task >Reporter: Richard Zowalla >Assignee: Richard Zowalla >Priority: Major > > I had a quick chat with [~jzemerick] and talked with [~mawiesne] last week. > It would be neat to run the eval tests in CI (and not just on local machines > before releases). > I asked INFRA about the license implications and they said, that there isn't > a problem if it isn't redistributed. They suggest to add the data to > https://nightlies.apache.org/ > Data can be published from Jenkins: > https://nightlies.apache.org/jenkins-publishing.html > Tasks: > * Get OpenNLP on Jenkins > * Get the eval data via a Jenkins job to nightlies.a.o > * Create a Jenkins job to run the eval tests with the data hosted at > nightlies.a.o -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OPENNLP-985) A condition that is always true.
[
https://issues.apache.org/jira/browse/OPENNLP-985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno P. Kinoshita updated OPENNLP-985:
---
Fix Version/s: 2.1.1
> A condition that is always true.
>
>
> Key: OPENNLP-985
> URL: https://issues.apache.org/jira/browse/OPENNLP-985
> Project: OpenNLP
> Issue Type: Bug
> Components: wsd
>Reporter: JC
>Assignee: Bruno P. Kinoshita
>Priority: Trivial
> Fix For: 2.1.1
>
>
> I've found a code smell or typo in a recent github snapshot. (opennlp-snadbox)
> Path:
> opennlp-wsd/src/main/java/opennlp/tools/disambiguator/datareader/Paragraph.java
> {code:java}
> 85 public boolean contains(String wordTag) {
> 86
> 87 for (Sentence isentence : this.getSsentences()) {
> 88 for (Word iword : isentence.getIwords()) {
> 89 if (iword.equals(iword))
> 90 return true;
> 91 }
> 92 }
> 93
> 94 return false;
> 95 }
> {code}
> Line 89 is always true. This might be a trivial issue but wanted to report
> just in case. Thanks!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (OPENNLP-985) A condition that is always true.
[
https://issues.apache.org/jira/browse/OPENNLP-985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno P. Kinoshita resolved OPENNLP-985.
Resolution: Fixed
> A condition that is always true.
>
>
> Key: OPENNLP-985
> URL: https://issues.apache.org/jira/browse/OPENNLP-985
> Project: OpenNLP
> Issue Type: Bug
> Components: wsd
>Reporter: JC
>Assignee: Bruno P. Kinoshita
>Priority: Trivial
> Fix For: 2.1.1
>
>
> I've found a code smell or typo in a recent github snapshot. (opennlp-snadbox)
> Path:
> opennlp-wsd/src/main/java/opennlp/tools/disambiguator/datareader/Paragraph.java
> {code:java}
> 85 public boolean contains(String wordTag) {
> 86
> 87 for (Sentence isentence : this.getSsentences()) {
> 88 for (Word iword : isentence.getIwords()) {
> 89 if (iword.equals(iword))
> 90 return true;
> 91 }
> 92 }
> 93
> 94 return false;
> 95 }
> {code}
> Line 89 is always true. This might be a trivial issue but wanted to report
> just in case. Thanks!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (OPENNLP-985) A condition that is always true.
[
https://issues.apache.org/jira/browse/OPENNLP-985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno P. Kinoshita reassigned OPENNLP-985:
--
Assignee: Bruno P. Kinoshita
> A condition that is always true.
>
>
> Key: OPENNLP-985
> URL: https://issues.apache.org/jira/browse/OPENNLP-985
> Project: OpenNLP
> Issue Type: Bug
> Components: wsd
>Reporter: JC
>Assignee: Bruno P. Kinoshita
>Priority: Trivial
>
> I've found a code smell or typo in a recent github snapshot. (opennlp-snadbox)
> Path:
> opennlp-wsd/src/main/java/opennlp/tools/disambiguator/datareader/Paragraph.java
> {code:java}
> 85 public boolean contains(String wordTag) {
> 86
> 87 for (Sentence isentence : this.getSsentences()) {
> 88 for (Word iword : isentence.getIwords()) {
> 89 if (iword.equals(iword))
> 90 return true;
> 91 }
> 92 }
> 93
> 94 return false;
> 95 }
> {code}
> Line 89 is always true. This might be a trivial issue but wanted to report
> just in case. Thanks!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OPENNLP-985) A condition that is always true.
[
https://issues.apache.org/jira/browse/OPENNLP-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687953#comment-17687953
]
ASF GitHub Bot commented on OPENNLP-985:
kinow merged PR #1:
URL: https://github.com/apache/opennlp-sandbox/pull/1
> A condition that is always true.
>
>
> Key: OPENNLP-985
> URL: https://issues.apache.org/jira/browse/OPENNLP-985
> Project: OpenNLP
> Issue Type: Bug
> Components: wsd
>Reporter: JC
>Priority: Trivial
>
> I've found a code smell or typo in a recent github snapshot. (opennlp-snadbox)
> Path:
> opennlp-wsd/src/main/java/opennlp/tools/disambiguator/datareader/Paragraph.java
> {code:java}
> 85 public boolean contains(String wordTag) {
> 86
> 87 for (Sentence isentence : this.getSsentences()) {
> 88 for (Word iword : isentence.getIwords()) {
> 89 if (iword.equals(iword))
> 90 return true;
> 91 }
> 92 }
> 93
> 94 return false;
> 95 }
> {code}
> Line 89 is always true. This might be a trivial issue but wanted to report
> just in case. Thanks!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
