[GitHub] [openwhisk-apigateway] mhamann opened a new pull request #357: Fix App ID bug, add unit tests

2019-09-05 Thread GitBox
mhamann opened a new pull request #357: Fix App ID bug, add unit tests URL: https://github.com/apache/openwhisk-apigateway/pull/357 A bug with the App ID OAuth flow was introduced as part of #353 and wasn't caught due to a missing unit test. The unit test wasn't written because it was

[GitHub] [openwhisk] Humbedooh commented on issue #4608: fix indent on labels in .asf.yaml

2019-09-05 Thread GitBox
Humbedooh commented on issue #4608: fix indent on labels in .asf.yaml URL: https://github.com/apache/openwhisk/pull/4608#issuecomment-528676737 FaaS is invalid as it contains uppercase characters. faas would work. This is an

[GitHub] [openwhisk] dgrove-oss merged pull request #4608: fix indent on labels in .asf.yaml

2019-09-05 Thread GitBox
dgrove-oss merged pull request #4608: fix indent on labels in .asf.yaml URL: https://github.com/apache/openwhisk/pull/4608 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [openwhisk-wskdeploy] mrutkows commented on a change in pull request #1054: Honor WSK_CONFIG_FILE if variable is set

2019-09-05 Thread GitBox
mrutkows commented on a change in pull request #1054: Honor WSK_CONFIG_FILE if variable is set URL: https://github.com/apache/openwhisk-wskdeploy/pull/1054#discussion_r321441197 ## File path: cmd/root.go ## @@ -102,21 +102,32 @@ func init() { func initConfig() {

[GitHub] [openwhisk-wskdeploy] mrutkows commented on issue #1054: Honor WSK_CONFIG_FILE if variable is set

2019-09-05 Thread GitBox
mrutkows commented on issue #1054: Honor WSK_CONFIG_FILE if variable is set URL: https://github.com/apache/openwhisk-wskdeploy/pull/1054#issuecomment-528542355 @alvarolopez The build is failing as the linter does not like your go formatting (indentation); could you please fix that so we

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4606: Update k8s client to 4.4.0 from 4.0.3

2019-09-05 Thread GitBox
chetanmeh commented on a change in pull request #4606: Update k8s client to 4.4.0 from 4.0.3 URL: https://github.com/apache/openwhisk/pull/4606#discussion_r321387886 ## File path: common/scala/build.gradle ## @@ -59,7 +59,7 @@ dependencies { compile

[GitHub] [openwhisk] rabbah merged pull request #4607: Add asf.yaml to configure github metadata

2019-09-05 Thread GitBox
rabbah merged pull request #4607: Add asf.yaml to configure github metadata URL: https://github.com/apache/openwhisk/pull/4607 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [openwhisk] rabbah commented on issue #4607: Add asf.yaml to configure github metadata

2019-09-05 Thread GitBox
rabbah commented on issue #4607: Add asf.yaml to configure github metadata URL: https://github.com/apache/openwhisk/pull/4607#issuecomment-528450275 You beat me to it! This is an automated message from the Apache Git Service.

[GitHub] [openwhisk] codecov-io commented on issue #4607: Add asf.yaml to configure github metadata

2019-09-05 Thread GitBox
codecov-io commented on issue #4607: Add asf.yaml to configure github metadata URL: https://github.com/apache/openwhisk/pull/4607#issuecomment-528378824 # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4607?src=pr=h1) Report > Merging

[GitHub] [openwhisk] dgrove-oss merged pull request #4605: add full license headers to vagrant scripts

2019-09-05 Thread GitBox
dgrove-oss merged pull request #4605: add full license headers to vagrant scripts URL: https://github.com/apache/openwhisk/pull/4605 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [openwhisk] codecov-io commented on issue #4605: add full license headers to vagrant scripts

2019-09-05 Thread GitBox
codecov-io commented on issue #4605: add full license headers to vagrant scripts URL: https://github.com/apache/openwhisk/pull/4605#issuecomment-528358151 # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4605?src=pr=h1) Report > Merging

[GitHub] [openwhisk] dgrove-oss opened a new pull request #4607: Add asf.yaml to configure github metadata

2019-09-05 Thread GitBox
dgrove-oss opened a new pull request #4607: Add asf.yaml to configure github metadata URL: https://github.com/apache/openwhisk/pull/4607 Experiment with new ASF feature of using a per-repo yaml file to configure github metadata for a project. See

[GitHub] [openwhisk] duynguyen commented on a change in pull request #4503: Add optional config for appending custom registry to user provided images

2019-09-05 Thread GitBox
duynguyen commented on a change in pull request #4503: Add optional config for appending custom registry to user provided images URL: https://github.com/apache/openwhisk/pull/4503#discussion_r321240007 ## File path: tests/src/test/resources/application.conf.j2 ## @@ -86,6

[GitHub] [openwhisk] chetanmeh opened a new pull request #4606: Update k8s client to 4.4.0 from 4.0.3

2019-09-05 Thread GitBox
chetanmeh opened a new pull request #4606: Update k8s client to 4.4.0 from 4.0.3 URL: https://github.com/apache/openwhisk/pull/4606 Updates `io.fabric8:kubernetes-client` to 4.4.0 from 4.0.3. ## Description Current fabric8 k8s client version is 4.0.3 which does not support

[GitHub] [openwhisk] rabbah commented on a change in pull request #4503: Add optional config for appending custom registry to user provided images

2019-09-05 Thread GitBox
rabbah commented on a change in pull request #4503: Add optional config for appending custom registry to user provided images URL: https://github.com/apache/openwhisk/pull/4503#discussion_r321196314 ## File path: core/invoker/src/main/resources/application.conf ## @@

[GitHub] [openwhisk-deploy-kube] rabbah merged pull request #525: add missing license header

2019-09-05 Thread GitBox
rabbah merged pull request #525: add missing license header URL: https://github.com/apache/openwhisk-deploy-kube/pull/525 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [openwhisk] duynguyen commented on issue #4503: Add option for appending runtimes registry to user provided images

2019-09-05 Thread GitBox
duynguyen commented on issue #4503: Add option for appending runtimes registry to user provided images URL: https://github.com/apache/openwhisk/pull/4503#issuecomment-528279282 @rabbah , @chetanmeh : I have updated the PR according to the comments. Could you please review?

[GitHub] [openwhisk-wskdeploy] alvarolopez commented on issue #1057: Support Description field in corresponding entities

2019-09-05 Thread GitBox
alvarolopez commented on issue #1057: Support Description field in corresponding entities URL: https://github.com/apache/openwhisk-wskdeploy/pull/1057#issuecomment-528266287 @mrutkows I believe that adding the description field worked for me, I need to check and keep you posted, as I