[GitHub] [openwhisk] selfxp commented on a change in pull request #4584: OpenWhisk User Events

2019-09-20 Thread GitBox 
selfxp commented on a change in pull request #4584: OpenWhisk User Events
URL: https://github.com/apache/openwhisk/pull/4584#discussion_r326800406
 
 

 ##
 File path: 
common/scala/src/main/scala/org/apache/openwhisk/core/connector/Message.scala
 ##
 @@ -256,6 +286,7 @@ case class Metric(metricName: String, metricValue: Long) 
extends EventMessageBod
 }
 
 object Metric extends DefaultJsonProtocol {
+  val typeName = "Metric"
 
 Review comment:
   I think it's still being used here: 
https://github.com/apache/openwhisk/blob/f04275a825346da52d8616cf241f7a6ae78dccbc/core/monitoring/user-events/src/main/scala/org/apache/openwhisk/core/monitoring/metrics/EventConsumer.scala#L99


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] tysonnorris merged pull request #4631: Update CosmosDB SDK to v2.5.0

2019-09-20 Thread GitBox 
tysonnorris merged pull request #4631: Update CosmosDB SDK to v2.5.0
URL: https://github.com/apache/openwhisk/pull/4631
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-deploy-kube] dgrove-oss opened a new issue #528: Support Private Registrys in Kubernetes Container Factory

2019-09-20 Thread GitBox 
dgrove-oss opened a new issue #528: Support Private Registrys in Kubernetes 
Container Factory
URL: https://github.com/apache/openwhisk-deploy-kube/issues/528
 
 
   Per discussion on dev list [1] we should make KCF more flexible by loading a 
default Pod spec for user actions from a config map and then adding information 
to that default.
   
   
https://lists.apache.org/thread.html/7f8cadfc04c5a4c7533f71d5e5c9f6371a389da53ebb95b3f65a7c4e@%3Cdev.openwhisk.apache.org%3E


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-deploy-kube] dgrove-oss closed issue #523: kubernetes-sigs/kubeadm-dind-cluster has been replaced by kind

2019-09-20 Thread GitBox 
dgrove-oss closed issue #523: kubernetes-sigs/kubeadm-dind-cluster has been 
replaced by kind
URL: https://github.com/apache/openwhisk-deploy-kube/issues/523
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-deploy-kube] dgrove-oss commented on issue #523: kubernetes-sigs/kubeadm-dind-cluster has been replaced by kind

2019-09-20 Thread GitBox 
dgrove-oss commented on issue #523: kubernetes-sigs/kubeadm-dind-cluster has 
been replaced by kind
URL: 
https://github.com/apache/openwhisk-deploy-kube/issues/523#issuecomment-533607528
 
 
   Updated docs to note deprecation.  Actually switching to kind will be 
tracked by #508 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-deploy-kube] dgrove-oss merged pull request #524: Update dind docs to note deprecation and update project URLs

2019-09-20 Thread GitBox 
dgrove-oss merged pull request #524: Update dind docs to note deprecation and 
update project URLs
URL: https://github.com/apache/openwhisk-deploy-kube/pull/524
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-devtools] vastskymiaow opened a new issue #292: hello-world failed

2019-09-20 Thread GitBox 
vastskymiaow opened a new issue #292: hello-world failed
URL: https://github.com/apache/openwhisk-devtools/issues/292
 
 
   Hi, I come here again.
   
   I am facing anthor problem now. I ran make quick-start. And it then exited 
with error as following:
   
   
   [2019-09-20T14:18:40.495Z] [INFO] [#tid_owHb60ELZv9FBEGuFJF1X97ex9hKCfi7] 
[ShardingContainerPoolBalancer] scheduled activation 
9e0d0fd20217448b8d0fd20217248b39, action 'guest/hello@0.0.1' (managed), ns 
'guest', mem limit 256 MB (std), time limit 6 ms (std) to invoker0
   [2019-09-20T14:18:40.498Z] [INFO] [#tid_owHb60ELZv9FBEGuFJF1X97ex9hKCfi7] 
[ShardingContainerPoolBalancer] posting topic 'invoker0' with activation id 
'9e0d0fd20217448b8d0fd20217248b39' [marker:controller_kafka_start:95]
   [2019-09-20T14:18:40.512Z] [INFO] [#tid_owHb60ELZv9FBEGuFJF1X97ex9hKCfi7] 
[ShardingContainerPoolBalancer] posted to invoker0[0][2] 
[marker:controller_kafka_finish:109:14]
   [2019-09-20T14:18:40.513Z] [INFO] [#tid_owHb60ELZv9FBEGuFJF1X97ex9hKCfi7] 
[ActionsApi]  [marker:controller_loadbalancer_finish:110:22]
   [2019-09-20T14:18:55.531Z] [INFO] [#tid_owHb60ELZv9FBEGuFJF1X97ex9hKCfi7] 
[CouchDbRestStore] [GET] 'local_activations' finding document: 'id: 
guest/9e0d0fd20217448b8d0fd20217248b39' 
[marker:database_getDocument_start:15128]
   [2019-09-20T14:18:55.548Z] [INFO] [#tid_owHb60ELZv9FBEGuFJF1X97ex9hKCfi7] 
[CouchDbRestStore]  [marker:database_getDocument_finish:15145:17]
   [2019-09-20T14:19:10.561Z] [INFO] [#tid_owHb60ELZv9FBEGuFJF1X97ex9hKCfi7] 
[CouchDbRestStore] [GET] 'local_activations' finding document: 'id: 
guest/9e0d0fd20217448b8d0fd20217248b39' 
[marker:database_getDocument_start:30158]
   [2019-09-20T14:19:10.569Z] [INFO] [#tid_owHb60ELZv9FBEGuFJF1X97ex9hKCfi7] 
[CouchDbRestStore]  [marker:database_getDocument_finish:30166:7]
   [2019-09-20T14:19:25.581Z] [INFO] [#tid_owHb60ELZv9FBEGuFJF1X97ex9hKCfi7] 
[CouchDbRestStore] [GET] 'local_activations' finding document: 'id: 
guest/9e0d0fd20217448b8d0fd20217248b39' 
[marker:database_getDocument_start:45178]
   [2019-09-20T14:19:25.587Z] [INFO] [#tid_owHb60ELZv9FBEGuFJF1X97ex9hKCfi7] 
[CouchDbRestStore]  [marker:database_getDocument_finish:45184:6]
   [2019-09-20T14:19:40.531Z] [INFO] [#tid_owHb60ELZv9FBEGuFJF1X97ex9hKCfi7] 
[ActionsApi]  [marker:controller_blockingActivation_finish:60128:60041]
   [2019-09-20T14:19:40.534Z] [INFO] [#tid_owHb60ELZv9FBEGuFJF1X97ex9hKCfi7] 
[BasicHttpService] [marker:http_post.202_counter:60130:60130]
   [2019-09-20T14:19:40.587Z] [INFO] [#tid_TOCsTmvXWA7ZSeLfO2e4wGZP0odoRZiI] 
DELETE /api/v1/namespaces/_/actions/hello 
   [2019-09-20T14:19:40.589Z] [INFO] [#tid_TOCsTmvXWA7ZSeLfO2e4wGZP0odoRZiI] 
[BasicAuthenticationDirective] authenticate: 
23bc46b1-71f6-4ed5-8c54-816aa4f8c502
   [2019-09-20T14:19:40.589Z] [INFO] [#tid_TOCsTmvXWA7ZSeLfO2e4wGZP0odoRZiI] 
[Identity] [GET] serving from cache: 
CacheKey(23bc46b1-71f6-4ed5-8c54-816aa4f8c502) 
[marker:database_cacheHit_counter:3]
   [2019-09-20T14:19:40.595Z] [INFO] [#tid_TOCsTmvXWA7ZSeLfO2e4wGZP0odoRZiI] 
[WhiskAction] [GET] serving from cache: CacheKey(guest/hello) 
[marker:database_cacheHit_counter:8]
   [2019-09-20T14:19:40.598Z] [INFO] [#tid_TOCsTmvXWA7ZSeLfO2e4wGZP0odoRZiI] 
[WhiskAction] invalidating CacheKey(guest/hello) on delete
   [2019-09-20T14:19:40.600Z] [INFO] [#tid_TOCsTmvXWA7ZSeLfO2e4wGZP0odoRZiI] 
[CouchDbRestStore] [DEL] 'local_whisks' deleting document: 'id: guest/hello, 
rev: 1-741ee174f8e27312555d3e9a1909a820' 
[marker:database_deleteDocument_start:14]
   [2019-09-20T14:19:40.620Z] [INFO] [#tid_TOCsTmvXWA7ZSeLfO2e4wGZP0odoRZiI] 
[CouchDbRestStore]  [marker:database_deleteDocument_finish:33:19]
   [2019-09-20T14:19:40.620Z] [INFO] [#tid_TOCsTmvXWA7ZSeLfO2e4wGZP0odoRZiI] 
[WhiskAction] invalidating CacheKey(guest/hello)
   [2019-09-20T14:19:40.625Z] [INFO] [#tid_TOCsTmvXWA7ZSeLfO2e4wGZP0odoRZiI] 
[BasicHttpService] [marker:http_delete.200_counter:39:39]
   Makefile:385: recipe for target 'hello-world' failed
   make: *** [hello-world] Error 1
   
   I have looked up it in the log, but it showed the same infomation. Thank you 
for answering.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-devtools] vastskymiaow opened a new issue #291: make quick-start error

2019-09-20 Thread GitBox 
vastskymiaow opened a new issue #291: make quick-start error
URL: https://github.com/apache/openwhisk-devtools/issues/291
 
 
   Hello,
   when I run `make quick-quick`, it always tell me that:
   
   
   Waiting till all containers are powered up... 
   Pulling redis (redis:2.8)...
   \nIMAGE  STATUS
   minio/minio:RELEASE.2018-07-13T00-09-07Z   Up 57 seconds (healthy)
   \nERROR: Timed out waiting for docker services to launch...
   Makefile:279: recipe for target 'wait-for-docker-compose-up' failed
   make: *** [wait-for-docker-compose-up] Error 1
   
   
   It seems that the launch time of docker exceeds the limit, how can i solve 
it?
   I run it in my VM, with the Ubuntu 16.04, 2 vcpu and 8Gb memory. I think it 
isn't caused by the restrictation of the CPU and memory. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] duynguyen commented on issue #4503: Add optional config for appending custom registry to user provided images

2019-09-20 Thread GitBox 
duynguyen commented on issue #4503: Add optional config for appending custom 
registry to user provided images
URL: https://github.com/apache/openwhisk/pull/4503#issuecomment-533542774
 
 
   thanks @rabbah , @sven-lange-last and @chetanmeh for reviewing and great 
suggestions!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] chetanmeh merged pull request #4503: Add optional config for appending custom registry to user provided images

2019-09-20 Thread GitBox 
chetanmeh merged pull request #4503: Add optional config for appending custom 
registry to user provided images
URL: https://github.com/apache/openwhisk/pull/4503
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] dgrove-oss merged pull request #4627: Add descriptions how to update, remove or rename runtime kinds and language families

2019-09-20 Thread GitBox 
dgrove-oss merged pull request #4627: Add descriptions how to update, remove or 
rename runtime kinds and language families
URL: https://github.com/apache/openwhisk/pull/4627
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] dgrove-oss commented on issue #4627: Add descriptions how to update, remove or rename runtime kinds and language families

2019-09-20 Thread GitBox 
dgrove-oss commented on issue #4627: Add descriptions how to update, remove or 
rename runtime kinds and language families
URL: https://github.com/apache/openwhisk/pull/4627#issuecomment-533525830
 
 
   Thanks for all your work on this @sven-lange-last  -- merging


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] duynguyen commented on a change in pull request #4503: Add optional config for appending custom registry to user provided images

2019-09-20 Thread GitBox 
duynguyen commented on a change in pull request #4503: Add optional config for 
appending custom registry to user provided images
URL: https://github.com/apache/openwhisk/pull/4503#discussion_r326551419
 
 

 ##
 File path: ansible/group_vars/all
 ##
 @@ -55,7 +55,8 @@ whisk:
 # configuration parameters related to support runtimes (see 
org.apache.openwhisk.core.entity.ExecManifest for schema of the manifest).
 # briefly the parameters are:
 #
-#   runtimes_registry: optional registry (with trailing slack) where to pull 
docker images from for runtimes and backbox images
+#   runtimes_registry: optional registry (with trailing slash) where to pull 
docker images from for default runtimes (in manifest)
+#   user_images_registry: optional registry (with trailing slash) where to 
pull docker images from for blackbox images
 
 Review comment:
   They are separately evaluated.
   Earlier there was only one option to add `runtimes_registry` to default 
images. Blackbox images were only evaluated as is (no system registry applied).
   This PR adds `user_images_registry` to apply blackbox images. If this is not 
set, blackbox images are evaluated by its own name.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] sven-lange-last commented on a change in pull request #4609: Add namespace field to activation log

2019-09-20 Thread GitBox 
sven-lange-last commented on a change in pull request #4609: Add namespace 
field to activation log
URL: https://github.com/apache/openwhisk/pull/4609#discussion_r326536398
 
 

 ##
 File path: 
common/scala/src/main/scala/org/apache/openwhisk/core/database/ActivationFileStorage.scala
 ##
 @@ -84,9 +84,11 @@ class ActivationFileStorage(logFilePrefix: String,
 
   private def transcribeLogs(activation: WhiskActivation, additionalFields: 
Map[String, JsValue]) =
 activation.logs.logs.map { log =>
-  val line = JsObject(
-Map("type" -> "user_log".toJson) ++ Map("message" -> log.toJson) ++ 
Map(
-  "activationId" -> activation.activationId.toJson) ++ 
additionalFields)
+  val line =
+JsObject(
+  Map("type" -> "user_log".toJson) ++ Map("message" -> log.toJson) ++ 
Map(
+"activationId" -> activation.activationId.toJson) ++ Map(
+"namespace" -> activation.namespace.asString.toJson) ++ 
additionalFields)
 
 Review comment:
   I guess you also need to update this line in the test to inject the 
`namespace` field:
   
   
https://github.com/apache/openwhisk/blob/37ae815892ae03908c4804c4f826760224f09eea/tests/src/test/scala/org/apache/openwhisk/core/database/ArtifactWithFileStorageActivationStoreTests.scala#L280


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] sven-lange-last commented on a change in pull request #4609: Add namespace field to activation log

2019-09-20 Thread GitBox 
sven-lange-last commented on a change in pull request #4609: Add namespace 
field to activation log
URL: https://github.com/apache/openwhisk/pull/4609#discussion_r326534807
 
 

 ##
 File path: 
common/scala/src/main/scala/org/apache/openwhisk/core/database/ActivationFileStorage.scala
 ##
 @@ -84,9 +84,11 @@ class ActivationFileStorage(logFilePrefix: String,
 
   private def transcribeLogs(activation: WhiskActivation, additionalFields: 
Map[String, JsValue]) =
 activation.logs.logs.map { log =>
-  val line = JsObject(
-Map("type" -> "user_log".toJson) ++ Map("message" -> log.toJson) ++ 
Map(
-  "activationId" -> activation.activationId.toJson) ++ 
additionalFields)
+  val line =
+JsObject(
+  Map("type" -> "user_log".toJson) ++ Map("message" -> log.toJson) ++ 
Map(
+"activationId" -> activation.activationId.toJson) ++ Map(
+"namespace" -> activation.namespace.asString.toJson) ++ 
additionalFields)
 
 Review comment:
   Thanks for attending to my feedback and also covering other log stores.
   
   At the same time: can you please move the `namespace` extension over to 
`ArtifactWithFileStorageActivationStore`? This would be the equivalent class to 
`DockerToActivationFileLogStore` where you inject `namespace` via 
`additionalMetadata`.
   
   `ActivationFileStorage` is just a helper that performs writing of logs and 
activations to a file. The log store implementations that make use of 
`ActivationFileStorage` should decide which additional metadata they want to 
add. `ArtifactWithFileStorageActivationStore` is such a log store.
   
   See 
https://github.com/apache/openwhisk/blob/400a7915115576a363858788a6d080c389a80317/common/scala/src/main/scala/org/apache/openwhisk/core/database/ArtifactWithFileStorageActivationStore.scala#L58-L60
   
   ^^ I suggest to inject the additional `namespace` field here.
   
   Hint: IBM is using the `ActivationFileStorage` in a private implementation 
for IBM's logging system that requires different fields unique to IBM that do 
not make sense in the openwhisk context. That's why we want to keep 
`ActivationFileStorage` as open as possible.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] sven-lange-last edited a comment on issue #4627: Add descriptions how to update, remove or rename runtime kinds and language families

2019-09-20 Thread GitBox 
sven-lange-last edited a comment on issue #4627: Add descriptions how to 
update, remove or rename runtime kinds and language families
URL: https://github.com/apache/openwhisk/pull/4627#issuecomment-533463562
 
 
   @rabbah @dgrove-oss all feedback should be addressed and I added your 
suggestions (thanks a lot for improving wording). Can any of you please merge?
   
   @BillZong thanks for your feedback as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] sven-lange-last commented on issue #4627: Add descriptions how to update, remove or rename runtime kinds and language families

2019-09-20 Thread GitBox 
sven-lange-last commented on issue #4627: Add descriptions how to update, 
remove or rename runtime kinds and language families
URL: https://github.com/apache/openwhisk/pull/4627#issuecomment-533463562
 
 
   @rabbah @dgrove-oss all feedback should be addressed and I added your 
suggestions (thanks a lot for improving wording). Can any of you please merge?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] codecov-io edited a comment on issue #4627: Add descriptions how to update, remove or rename runtime kinds and language families

2019-09-20 Thread GitBox 
codecov-io edited a comment on issue #4627: Add descriptions how to update, 
remove or rename runtime kinds and language families
URL: https://github.com/apache/openwhisk/pull/4627#issuecomment-532154575
 
 
   # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4627?src=pr=h1) 
Report
   > Merging 
[#4627](https://codecov.io/gh/apache/openwhisk/pull/4627?src=pr=desc) into 
[master](https://codecov.io/gh/apache/openwhisk/commit/e9dd2073cd2343545d006cd71ca01dc24114c216?src=pr=desc)
 will **increase** coverage by `34.62%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/openwhisk/pull/4627/graphs/tree.svg?width=650=l0YmsiSAso=150=pr)](https://codecov.io/gh/apache/openwhisk/pull/4627?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#4627   +/-   ##
   ===
   + Coverage   42.92%   77.54%   +34.62% 
   ===
 Files 183  183   
 Lines8305 8306+1 
 Branches  573  572-1 
   ===
   + Hits 3565 6441 +2876 
   + Misses   4740 1865 -2875
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/openwhisk/pull/4627?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...pache/openwhisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/openwhisk/pull/4627/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=)
 | `63.47% <0%> (ø)` | :arrow_up: |
   | 
[...openwhisk/common/tracing/OpenTracingProvider.scala](https://codecov.io/gh/apache/openwhisk/pull/4627/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi90cmFjaW5nL09wZW5UcmFjaW5nUHJvdmlkZXIuc2NhbGE=)
 | `21.15% <0%> (+1.92%)` | :arrow_up: |
   | 
[...re/database/MultipleReadersSingleWriterCache.scala](https://codecov.io/gh/apache/openwhisk/pull/4627/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvTXVsdGlwbGVSZWFkZXJzU2luZ2xlV3JpdGVyQ2FjaGUuc2NhbGE=)
 | `98% <0%> (+2%)` | :arrow_up: |
   | 
[...apache/openwhisk/core/entitlement/Collection.scala](https://codecov.io/gh/apache/openwhisk/pull/4627/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXRsZW1lbnQvQ29sbGVjdGlvbi5zY2FsYQ==)
 | `87.5% <0%> (+2.5%)` | :arrow_up: |
   | 
[.../org/apache/openwhisk/http/PoolingRestClient.scala](https://codecov.io/gh/apache/openwhisk/pull/4627/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2h0dHAvUG9vbGluZ1Jlc3RDbGllbnQuc2NhbGE=)
 | `91.17% <0%> (+2.94%)` | :arrow_up: |
   | 
[...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/openwhisk/pull/4627/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=)
 | `4% <0%> (+4%)` | :arrow_up: |
   | 
[...enwhisk/core/loadBalancer/InvokerSupervision.scala](https://codecov.io/gh/apache/openwhisk/pull/4627/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvbG9hZEJhbGFuY2VyL0ludm9rZXJTdXBlcnZpc2lvbi5zY2FsYQ==)
 | `95.77% <0%> (+4.92%)` | :arrow_up: |
   | 
[...la/org/apache/openwhisk/core/entity/LogLimit.scala](https://codecov.io/gh/apache/openwhisk/pull/4627/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L0xvZ0xpbWl0LnNjYWxh)
 | `94.11% <0%> (+5.88%)` | :arrow_up: |
   | 
[...org/apache/openwhisk/core/entity/MemoryLimit.scala](https://codecov.io/gh/apache/openwhisk/pull/4627/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L01lbW9yeUxpbWl0LnNjYWxh)
 | `93.75% <0%> (+6.25%)` | :arrow_up: |
   | 
[...ain/scala/org/apache/openwhisk/common/Config.scala](https://codecov.io/gh/apache/openwhisk/pull/4627/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Db25maWcuc2NhbGE=)
 | `84.37% <0%> (+6.25%)` | :arrow_up: |
   | ... and [118 
more](https://codecov.io/gh/apache/openwhisk/pull/4627/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/openwhisk/pull/4627?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/openwhisk/pull/4627?src=pr=footer). 
Last update 
[e9dd207...4a92061](https://codecov.io/gh/apache/openwhisk/pull/4627?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

[GitHub] [openwhisk] codecov-io edited a comment on issue #4609: Add namespace field to activation log

2019-09-20 Thread GitBox 
codecov-io edited a comment on issue #4609: Add namespace field to activation 
log
URL: https://github.com/apache/openwhisk/pull/4609#issuecomment-529432553
 
 
   # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4609?src=pr=h1) 
Report
   > Merging 
[#4609](https://codecov.io/gh/apache/openwhisk/pull/4609?src=pr=desc) into 
[master](https://codecov.io/gh/apache/openwhisk/commit/400a7915115576a363858788a6d080c389a80317?src=pr=desc)
 will **decrease** coverage by `5.57%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/openwhisk/pull/4609/graphs/tree.svg?width=650=l0YmsiSAso=150=pr)](https://codecov.io/gh/apache/openwhisk/pull/4609?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4609  +/-   ##
   ==
   - Coverage   84.44%   78.87%   -5.58% 
   ==
 Files 183  183  
 Lines8306 8306  
 Branches  572  572  
   ==
   - Hits 7014 6551 -463 
   - Misses   1292 1755 +463
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/openwhisk/pull/4609?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...penwhisk/core/database/ActivationFileStorage.scala](https://codecov.io/gh/apache/openwhisk/pull/4609/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvQWN0aXZhdGlvbkZpbGVTdG9yYWdlLnNjYWxh)
 | `95.34% <100%> (ø)` | :arrow_up: |
   | 
[...rpool/logging/DockerToActivationFileLogStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4609/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9sb2dnaW5nL0RvY2tlclRvQWN0aXZhdGlvbkZpbGVMb2dTdG9yZS5zY2FsYQ==)
 | `68.08% <100%> (ø)` | :arrow_up: |
   | 
[...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/openwhisk/pull/4609/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh)
 | `0% <0%> (-100%)` | :arrow_down: |
   | 
[...ore/database/cosmosdb/cache/CacheInvalidator.scala](https://codecov.io/gh/apache/openwhisk/pull/4609/diff?src=pr=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3Iuc2NhbGE=)
 | `0% <0%> (-100%)` | :arrow_down: |
   | 
[...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4609/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh)
 | `0% <0%> (-95.89%)` | :arrow_down: |
   | 
[...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala](https://codecov.io/gh/apache/openwhisk/pull/4609/diff?src=pr=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3JDb25maWcuc2NhbGE=)
 | `0% <0%> (-94.74%)` | :arrow_down: |
   | 
[...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/openwhisk/pull/4609/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh)
 | `0% <0%> (-92.6%)` | :arrow_down: |
   | 
[...e/database/cosmosdb/cache/ChangeFeedListener.scala](https://codecov.io/gh/apache/openwhisk/pull/4609/diff?src=pr=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NoYW5nZUZlZWRMaXN0ZW5lci5zY2FsYQ==)
 | `0% <0%> (-86.67%)` | :arrow_down: |
   | 
[...e/database/cosmosdb/cache/KafkaEventProducer.scala](https://codecov.io/gh/apache/openwhisk/pull/4609/diff?src=pr=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0thZmthRXZlbnRQcm9kdWNlci5zY2FsYQ==)
 | `0% <0%> (-76.48%)` | :arrow_down: |
   | 
[...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/openwhisk/pull/4609/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh)
 | `0% <0%> (-74.08%)` | :arrow_down: |
   | ... and [12 
more](https://codecov.io/gh/apache/openwhisk/pull/4609/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/openwhisk/pull/4609?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by

[GitHub] [openwhisk] sven-lange-last commented on a change in pull request #4627: Add descriptions how to update, remove or rename runtime kinds and language families

2019-09-20 Thread GitBox 
sven-lange-last commented on a change in pull request #4627: Add descriptions 
how to update, remove or rename runtime kinds and language families
URL: https://github.com/apache/openwhisk/pull/4627#discussion_r326500766
 
 

 ##
 File path: docs/actions-update.md
 ##
 @@ -0,0 +1,75 @@
+
+## Updating Action Language Runtimes
+
+OpenWhisk supports [several languages and 
runtimes](actions.md#languages-and-runtimes) that can be made
+available for usage in an OpenWhisk deployment. This is done via the [runtimes 
manifest](actions-new.md#the-runtimes-manifest).
+
+Over time, you may have the need for change:
+
+* Update runtimes to address security issues - for example, the latest code 
level of Node.js 10.
+* Remove runtime versions that are no more supported - for example, Node.js 6.
+* Add more languages due to user demand.
+* Remove languages that are no more needed.
+
+While adding and updating languages and runtimes is pretty straightforward, 
removing or renaming languages and runtimes
+requires some caution to prevent problems with preexisting actions.
+
+### Updating runtimes
+
+Follow these steps to update a particular runtime kind:
+
+1. Update the runtimes' container image.
+2. Update the corresponding `image` property in the [runtimes 
manifest](actions-new.md#the-runtimes-manifest) to use the new container image.
+3. Restart / re-deploy controllers and invokers such that they pick up the 
changed runtimes manifest.
+
+Already existing actions of the changed runtime kind will immediately use the 
new container image when the invoker creates a new action container.
+
+Obviously, this approach should only be used if existing actions do not break 
with the new container image. If a new container image is supposed to break 
existing actions, introduce a new runtime kind.
+
+### Removing runtimes
+
+Follow these steps to remove a particular runtime kind under the assumption 
that actions with the runtime kind exist in the system. Clearly, the steps 
below should be spaced out in time to give action owners time to react.
+
+1. Deprecate the runtime kind by setting `"deprecated": true` in the [runtimes 
manifest](actions-new.md#the-runtimes-manifest). This setting prevents that new 
actions can be created with the deprecated action kind. In addition, existing 
actions cannot be changed to the deprecated action kind any more.
+2. Ask owners of existing actions with runtime kind to be removed to update 
their actions to a different action kind.
+3. Create an automated process that identifies all actions with the runtime 
kind to be removed in the system's action artifact store. Either automatically 
remove these actions or change to a different runtime kind.
 
 Review comment:
   Sadly, removing something from production takes very long in IBM. That's why 
we actually haven't removed anything yet. So this step is still ahead of us and 
I have nothing I could share...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] jiangpengcheng commented on issue #4609: Add namespace field to activation log

2019-09-20 Thread GitBox 
jiangpengcheng commented on issue #4609: Add namespace field to activation log
URL: https://github.com/apache/openwhisk/pull/4609#issuecomment-533437866
 
 
   I think this PR doesn't related to any annotations but just add a 
`namespace` field while write `activations`/`activation logs` to a separate 
file, a "sequence activation" will not do that AFAIK


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] jiangpengcheng commented on issue #4615: key 'kind' does not exist

2019-09-20 Thread GitBox 
jiangpengcheng commented on issue #4615: key 'kind' does not exist
URL: https://github.com/apache/openwhisk/issues/4615#issuecomment-533430113
 
 
   closed as merged


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] jiangpengcheng commented on issue #4615: key 'kind' does not exist

2019-09-20 Thread GitBox 
jiangpengcheng commented on issue #4615: key 'kind' does not exist
URL: https://github.com/apache/openwhisk/issues/4615#issuecomment-533430161
 
 
   gg


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] jiangpengcheng closed issue #4615: key 'kind' does not exist

2019-09-20 Thread GitBox 
jiangpengcheng closed issue #4615: key 'kind' does not exist
URL: https://github.com/apache/openwhisk/issues/4615
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services