[GitHub] [openwhisk] chetanmeh commented on issue #4610: subjects (couchdb) view name is hardcoded
chetanmeh commented on issue #4610: subjects (couchdb) view name is hardcoded URL: https://github.com/apache/openwhisk/issues/4610#issuecomment-540920686 @rabbah Can this be closed given PR is merged? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] chetanmeh commented on issue #4672: active activation count for rate limiting is not affected on HTTP response
chetanmeh commented on issue #4672: active activation count for rate limiting is not affected on HTTP response URL: https://github.com/apache/openwhisk/issues/4672#issuecomment-540920450 Activations are stored asynchronously and should not impact the `CompletionMessage` from being sent which impacts the LB counters. Probably #4635 can help here a bit as it would effectively combine the result message and result in calling both process methods at same time This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] BillZong commented on issue #4683: Fix Travis build pip install issue in pre installation step
BillZong commented on issue #4683: Fix Travis build pip install issue in pre installation step URL: https://github.com/apache/openwhisk/pull/4683#issuecomment-540919892 It's been a replicated fix with #4679 . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4680: Enable Standalone User Event Dev mode
chetanmeh commented on a change in pull request #4680: Enable Standalone User Event Dev mode URL: https://github.com/apache/openwhisk/pull/4680#discussion_r333826909 ## File path: core/standalone/README.md ## @@ -93,23 +93,28 @@ $ java -jar openwhisk-standalone.jar -h -d, --data-dir Directory used for storage --dev-kcfEnables KubernetesContainerFactory for local development - --dev-mode Developer mode speeds up the startup by - disabling preflight checks and avoiding - explicit pulls. - --disable-color-logging Disables colored logging - --kafka-docker-port Kafka port for use by docker based services. - If not specified then 9091 or some random - free port (if 9091 is busy) would be used - --kafka-portKafka port. If not specified then 9092 or - some random free port (if 9092 is busy) would - be used - -p, --port Server port + --dev-mode Developer mode speeds up the startup by + disabling preflight checks and avoiding + explicit pulls. + --dev-user-events-port Specify the port for the user-event Review comment: Tried to support that but [scallop](https://github.com/scallop/scallop) arg parser does not support it. If I specify `--dev-user-events-port` then need to provide an explicit value otherwise it gives an error like below ``` [openwhisk] Error: Bad arguments for option 'dev-user-events-port': '' - you should provide exactly one argument for this option ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] neerajmangal opened a new pull request #4683: Fix Travis build pip install issue in pre installation step
neerajmangal opened a new pull request #4683: Fix Travis build pip install issue in pre installation step URL: https://github.com/apache/openwhisk/pull/4683 ## Description ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [ ] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md). - [ ] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] selfxp commented on a change in pull request #4680: Enable Standalone User Event Dev mode
selfxp commented on a change in pull request #4680: Enable Standalone User Event Dev mode URL: https://github.com/apache/openwhisk/pull/4680#discussion_r333822642 ## File path: core/standalone/README.md ## @@ -93,23 +93,28 @@ $ java -jar openwhisk-standalone.jar -h -d, --data-dir Directory used for storage --dev-kcfEnables KubernetesContainerFactory for local development - --dev-mode Developer mode speeds up the startup by - disabling preflight checks and avoiding - explicit pulls. - --disable-color-logging Disables colored logging - --kafka-docker-port Kafka port for use by docker based services. - If not specified then 9091 or some random - free port (if 9091 is busy) would be used - --kafka-portKafka port. If not specified then 9092 or - some random free port (if 9092 is busy) would - be used - -p, --port Server port + --dev-mode Developer mode speeds up the startup by + disabling preflight checks and avoiding + explicit pulls. + --dev-user-events-port Specify the port for the user-event Review comment: Would it make sense to have optional and default to 9095? If user-events is run with an IDE, it will start on this port by default. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] chetanmeh commented on issue #4678: Add NoopActivationStore to simplify local performance testing
chetanmeh commented on issue #4678: Add NoopActivationStore to simplify local performance testing URL: https://github.com/apache/openwhisk/pull/4678#issuecomment-540898589 > would it be also meaningful to profile the DB related path too Yes that can also be done but that just needs default setup configured to work with required backend like Couch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] chetanmeh commented on issue #2926: Missing document for wskadmin
chetanmeh commented on issue #2926: Missing document for wskadmin URL: https://github.com/apache/openwhisk/issues/2926#issuecomment-540898227 @ali-raza-tariq When using `wskadmin-next` you need to create a conf file and pass it as argument. See [setup instructions][1] for details [1]: https://github.com/apache/openwhisk/blob/master/tools/admin/README-NEXT.md#setup This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] style95 closed pull request #4682: 感谢
style95 closed pull request #4682: 感谢 URL: https://github.com/apache/openwhisk/pull/4682 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk-deploy-kube] dgrove-oss merged pull request #536: kind: describe using `kind load` to deploy locally-built image
dgrove-oss merged pull request #536: kind: describe using `kind load` to deploy locally-built image URL: https://github.com/apache/openwhisk-deploy-kube/pull/536 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk-deploy-kube] dgrove-oss commented on a change in pull request #536: kind: describe using `kind load` to deploy locally-built image
dgrove-oss commented on a change in pull request #536: kind: describe using `kind load` to deploy locally-built image URL: https://github.com/apache/openwhisk-deploy-kube/pull/536#discussion_r333742652 ## File path: docs/k8s-kind.md ## @@ -112,6 +112,31 @@ we will use the port forwarding configured by the `extraPortMappings` in kind-cluster.yaml to allow the OpenWhisk apihost property to be set to localhost:31001 +## Hints and Tips + +If you are working on the core OpenWhisk system and want +to use a locally built controller or invoker image to test +your changes, you need to push the image to the docker image +repository inside the `kind` cluster. + +For example, suppose I had a local change to the controller +I wanted to test. To do this, I would build the image normally +(`gradlew distDocker` in `openwhisk`). Then, execute the `kind` +command +```shell +kind load docker-image whisk/controller +``` +Then add a stanza to your `mycluster.yaml` to override the default +behavior of pulling a stable `openwhisk/controller` image from Docker Hub. +```yaml +controller: + imageName: "whisk/controller" + imageTag: "latest" +``` + +Then deploy OpenWhisk normally using `helm install`. The deployed Review comment: we should probably add some documentation on options for selective restarting of individual containers. going to push that off to a future PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] ali-raza-tariq edited a comment on issue #2926: Missing document for wskadmin
ali-raza-tariq edited a comment on issue #2926: Missing document for wskadmin URL: https://github.com/apache/openwhisk/issues/2926#issuecomment-540757341 Hi guys, I am trying to use wskadmin utility and facing some issues. First, I am testing docker-compose deployment and just want test wskadmin control. I tried to use the default executable at `/openwhisk-src/bin/wskadmin` which gave me the same error as @daisy-ycguo ``` property "DB_WHISK_AUTHS" not found in environment or property file property "WHISK_LOGS_DIR" not found in environment or property file property "DB_PASSWORD" not found in environment or property file property "DB_PORT" not found in environment or property file property "DB_PROTOCOL" not found in environment or property file property "DB_WHISK_ACTIONS" not found in environment or property file property "DB_HOST" not found in environment or property file property "DB_WHISK_ACTIVATIONS" not found in environment or property file property "DB_USERNAME" not found in environment or property file ``` After that, I tried to build the wskadmin-next (Gradle build). When I try to use this new executable, it gives me a different error ``` [wskadmin] Error: Incomplete config. Provide application.conf via '-c' option ``` For the record, I am simply trying to create a new namespace using `wskadmin-next user create userA`.From the discussion above, It seems to depend on `whisk.properties` file but I am unable to find any such file in the source directory. Please let me know how I can get it working! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk-release] dgrove-oss opened a new pull request #306: release config used for openwhisk-runtime-go-1.14.0
dgrove-oss opened a new pull request #306: release config used for openwhisk-runtime-go-1.14.0 URL: https://github.com/apache/openwhisk-release/pull/306 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] ali-raza-tariq edited a comment on issue #2926: Missing document for wskadmin
ali-raza-tariq edited a comment on issue #2926: Missing document for wskadmin URL: https://github.com/apache/openwhisk/issues/2926#issuecomment-540757341 Hi guys, I am trying to use wskadmin utility and facing some issues. First, I am testing docker-compose deployment and just want test wskadmin control. I tried to use the default executable at `/openwhisk-src/bin/wskadmin` which gave me the same error as @daisy-ycguo ``` property "DB_WHISK_AUTHS" not found in environment or property file property "WHISK_LOGS_DIR" not found in environment or property file property "DB_PASSWORD" not found in environment or property file property "DB_PORT" not found in environment or property file property "DB_PROTOCOL" not found in environment or property file property "DB_WHISK_ACTIONS" not found in environment or property file property "DB_HOST" not found in environment or property file property "DB_WHISK_ACTIVATIONS" not found in environment or property file property "DB_USERNAME" not found in environment or property file ``` After that, I tried to build the wskadmin-next (Gradle build). When I try to use this new executable, it gives me a different error ``` [wskadmin] Error: Incomplete config. Provide application.conf via '-c' option ``` For the record, I am simply trying to create a new namespace using `wskadmin-next user create userA`.From the discussion above, I seems to depend on `whisk.properties` file but I cannot seem to find any such file in the source directory. Please let me know how I can get it working! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] ali-raza-tariq edited a comment on issue #2926: Missing document for wskadmin
ali-raza-tariq edited a comment on issue #2926: Missing document for wskadmin URL: https://github.com/apache/openwhisk/issues/2926#issuecomment-540757341 Hi guys, I am trying to use wskadmin utility and facing some issues. First, I am testing docker-compose deployment and just want test wskadmin control. I tried to use the default executable at `/openwhisk-src/bin/wskadmin` which gave me the same error as @daisy-ycguo ``` property "DB_WHISK_AUTHS" not found in environment or property file property "WHISK_LOGS_DIR" not found in environment or property file property "DB_PASSWORD" not found in environment or property file property "DB_PORT" not found in environment or property file property "DB_PROTOCOL" not found in environment or property file property "DB_WHISK_ACTIONS" not found in environment or property file property "DB_HOST" not found in environment or property file property "DB_WHISK_ACTIVATIONS" not found in environment or property file property "DB_USERNAME" not found in environment or property file ``` After that, I tried to build the wskadmin-next (Gradle build). When I try to use this new executable, it gives me a different error ``` [wskadmin] Error: Incomplete config. Provide application.conf via '-c' option ``` From the discussion above, I seems to depend on `whisk.properties` file but I cannot seem to find any such file in the source directory. Please let me know how I can get it working! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] ali-raza-tariq edited a comment on issue #2926: Missing document for wskadmin
ali-raza-tariq edited a comment on issue #2926: Missing document for wskadmin URL: https://github.com/apache/openwhisk/issues/2926#issuecomment-540757341 Hi guys, I am trying to use wskadmin utility and facing some issues. First, I am testing docker-compose deployment and just want test wskadmin control. I tried to use the default executable at `/openwhisk-src/bin/wskadmin` which gave me the same error as @daisy-ycguo ``` property "DB_WHISK_AUTHS" not found in environment or property file property "WHISK_LOGS_DIR" not found in environment or property file property "DB_PASSWORD" not found in environment or property file property "DB_PORT" not found in environment or property file property "DB_PROTOCOL" not found in environment or property file property "DB_WHISK_ACTIONS" not found in environment or property file property "DB_HOST" not found in environment or property file property "DB_WHISK_ACTIVATIONS" not found in environment or property file property "DB_USERNAME" not found in environment or property file ``` After that, I tried to build the wskadmin-next (Gradle build). When I try to use this new executable, it gives me a different error ``` [wskadmin] Error: Incomplete config. Provide application.conf via '-c' option ``` From the discussion above, I seems to depend on `whisk.properties` file but I cannot seem to find any such file. Let me know how I can get it working! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] ali-raza-tariq commented on issue #2926: Missing document for wskadmin
ali-raza-tariq commented on issue #2926: Missing document for wskadmin URL: https://github.com/apache/openwhisk/issues/2926#issuecomment-540757341 Hi guys, I am trying to use wskadmin utility and facing some issues. First, I am testing docker-compose deployment and just want test wskadmin control. I tried to use the default executable at `/openwhisk-src/bin/wskadmin` which gave me the same error as @daisy-ycguo This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] rabbah opened a new issue #4681: possibly confusing warning from standalone controller for custom authkeys
rabbah opened a new issue #4681: possibly confusing warning from standalone controller for custom authkeys URL: https://github.com/apache/openwhisk/issues/4681 If you provide a custom application.conf with your own user entry, you get a warning like this: ``` [ WARN ] Configure wsk via below command to connect to this server as [guest] wsk property set --apihost 'http://localhost:3233' --auth '23bc46b1-71f6-4ed5-8c54-816aa4f8c502:123zO3xZCLrMN6v2BKK1dXYFpXlPkccOFqm12CdAsMgRU4VrNZ9lyGVCGuMDGIwP' [ OK ] Server port [3233] is free ``` This is because in my case the host was not configured correctly. The `auth` string in this case is the built-in guest key and not the one I specified. This could be confusing for some users but I'm not sure how to fix it so opening the issue for discussion/ideas. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] chetanmeh opened a new pull request #4680: Enable Standalone User Event Dev mode
chetanmeh opened a new pull request #4680: Enable Standalone User Event Dev mode URL: https://github.com/apache/openwhisk/pull/4680 With #4656 support was added in standalone mode to launch the User Event service along with required Prometheus and Grafana service. This PR adds support for reusing an existing user-event service (say running with IDE) for faster local developement ## Description To enable fast local development of user-event service the Standalone OpenWhisk now support connecting to an existing running service instead of launching a new one via Docker First launch the standalone server with Kafka and pass the port where user-event service would be running (9095 by default) ``` java -jar openwhisk-standalone.jar --dev-user-events-port 9095 --kafka --kafka-ui ``` Then launch the `org.apache.openwhisk.core.monitoring.metrics.Main` via IDE with env set to `KAFKA_HOSTS=localhost:9092` After this one can do normal action invocation and see metrics appear in Grafana ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [ ] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md). - [ ] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] dgrove-oss commented on issue #4679: update travis config to use xenial
dgrove-oss commented on issue #4679: update travis config to use xenial URL: https://github.com/apache/openwhisk/pull/4679#issuecomment-540594464 travisci builds have been failing for the last 5 days while trying to update pip. Before trying to make that work again on our `deprecated-2017Q3` group, I think it is worth making an attempt to move to xenial. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [openwhisk] chetanmeh opened a new pull request #4678: Add NoopActivationStore to simplify local performance testing
chetanmeh opened a new pull request #4678: Add NoopActivationStore to simplify
local performance testing
URL: https://github.com/apache/openwhisk/pull/4678
Adds a `NoopActivationStore` which does not store the activation and acts
like `/dev/null` for the activation response.
## Description
To simplify local performance testing of the overhead of the control plane
flow (invocation logic path in Controller/Invoker) it would be useful have an
`ActivationStore` which does not store the activation result.
This ensures that one can run say 10k activations without worrying about the
storage cost.
### Usage
Below steps demonstrate one way of using this store with Standalone
OpenWhisk server
1. Prepare configuration
Create a `standalone-perf.conf` with below content
```
include classpath("standalone.conf")
whisk {
spi {
LogStoreProvider =
"org.apache.openwhisk.core.containerpool.logging.LogDriverLogStoreProvider"
ActivationStoreProvider =
"org.apache.openwhisk.core.database.memory.NoopActivationStoreProvider"
}
//TODO Configure concurrecny
}
```
here we configure
1. NoopActivationStoreProvider to swallow all the activation result
2. LogDriverLogStoreProvider - Disable the log collection overhead
2. Run the server
```
java -Dlogback.log.level=warn -jar openwhisk-standalone.jar -c
standalone-perf.conf
```
Now attach the [Java Async
Profiler](https://github.com/jvm-profiling-tools/async-profiler). If using
Intellij you can use its [inbuilt support for async
profiler](https://www.jetbrains.com/help/idea/cpu-profiler.html)
3. Run perf test
Create a hello world action and invoke it multiple times
```
ab -p post.json -T application/json -H 'Authorization: Basic
MjNiYzQ2YjEtNzFmNi00ZWQ1LThjNTQtODE2YWE0ZjhjNTAyOjEyM3pPM3haQ0xyTU42djJCS0sxZFhZRnBYbFBrY2NPRnFtMTJDZEFzTWdSVTRWck5aOWx5R1ZDR3VNREdJd1A='
-c 2 -n 1
"http://localhost:3233/api/v1/namespaces/_/actions/hello?blocking=true=true;
```
Post run collect the profiler result and analyze the stats
## Related issue and scope
- [ ] I opened an issue to propose and discuss this change (#)
## My changes affect the following components
- [ ] API
- [ ] Controller
- [ ] Message Bus (e.g., Kafka)
- [ ] Loadbalancer
- [ ] Invoker
- [ ] Intrinsic actions (e.g., sequences, conductors)
- [ ] Data stores (e.g., CouchDB)
- [ ] Tests
- [ ] Deployment
- [ ] CLI
- [ ] General tooling
- [ ] Documentation
## Types of changes
- [ ] Bug fix (generally a non-breaking change which closes an issue).
- [ ] Enhancement or new feature (adds new functionality).
- [ ] Breaking change (a bug fix or enhancement which changes existing
behavior).
## Checklist:
- [ ] I signed an [Apache
CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
- [ ] I reviewed the [style
guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
and followed the recommendations (Travis CI will check :).
- [ ] I added tests to cover my changes.
- [ ] My changes require further changes to the documentation.
- [ ] I updated the documentation where necessary.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
