[GitHub] [openwhisk-wskdeploy] style95 commented on issue #1092: Remove misleading web-export key

2020-03-25 Thread GitBox
style95 commented on issue #1092: Remove misleading web-export key
URL: 
https://github.com/apache/openwhisk-wskdeploy/pull/1092#issuecomment-604176542
 
 
   @mrutkows Thank you for the good comment.
   I would update it accordingly.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [openwhisk-runtime-dotnet] kamyker commented on issue #35: 150kb+ json request crashes whole deployment

2020-03-25 Thread GitBox
kamyker commented on issue #35: 150kb+ json request crashes whole deployment
URL: 
https://github.com/apache/openwhisk-runtime-dotnet/issues/35#issuecomment-604151434
 
 
   Or not, settings any timeout also using command line makes it broken.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [openwhisk-runtime-dotnet] kamyker opened a new issue #35: 150kb+ json request crashes whole deployment

2020-03-25 Thread GitBox
kamyker opened a new issue #35: 150kb+ json request crashes whole deployment
URL: https://github.com/apache/openwhisk-runtime-dotnet/issues/35
 
 
   On 3.1, it's working fine on old 2.2 that ibm is using by default.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [openwhisk-runtime-dotnet] kamyker closed issue #35: 150kb+ json request crashes whole deployment

2020-03-25 Thread GitBox
kamyker closed issue #35: 150kb+ json request crashes whole deployment
URL: https://github.com/apache/openwhisk-runtime-dotnet/issues/35
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [openwhisk-runtime-dotnet] kamyker commented on issue #35: 150kb+ json request crashes whole deployment

2020-03-25 Thread GitBox
kamyker commented on issue #35: 150kb+ json request crashes whole deployment
URL: 
https://github.com/apache/openwhisk-runtime-dotnet/issues/35#issuecomment-604142682
 
 
   Seems like timeout setter on ibm website is broken and instead of 40 sec it 
did 40ms.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [openwhisk-runtime-dotnet] kamyker opened a new issue #35: 150kb+ json request crashes whole deployment

2020-03-25 Thread GitBox
kamyker opened a new issue #35: 150kb+ json request crashes whole deployment
URL: https://github.com/apache/openwhisk-runtime-dotnet/issues/35
 
 
   On 3.1, it's working fine on old 2.2 that ibm is using by default.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [openwhisk-wskdeploy] mrutkows edited a comment on issue #1092: Remove misleading web-export key

2020-03-25 Thread GitBox
mrutkows edited a comment on issue #1092: Remove misleading web-export key
URL: 
https://github.com/apache/openwhisk-wskdeploy/pull/1092#issuecomment-604126519
 
 
   @style95 There is historical context for this web-export being added at a 
higher level than annotations... that is, we had intended that wskdeploy 
manifests would not allow/expose annotations period (at all).  However, we were 
forced by some use cases to add support for it.
   
   My concern is that the code SHOULD still permit the web-export key outside 
annotations (that is still work and not break anyone using it for 3 years), but 
deprecate it.  Then update all examples use cases to use the annotations, but 
preserve at least one functional test to make sure that, although deprecated, 
it still works.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [openwhisk-wskdeploy] mrutkows commented on issue #1092: Remove misleading web-export key

2020-03-25 Thread GitBox
mrutkows commented on issue #1092: Remove misleading web-export key
URL: 
https://github.com/apache/openwhisk-wskdeploy/pull/1092#issuecomment-604126519
 
 
   There is historical context for this web-export being added at a higher 
level than annotations... that is, we had intended that wskdeploy manifests 
would not allow/expose annotations period (at all).  However, we were forced by 
some use cases to add support for it.
   
   My concern is that the code SHOULD still permit the web-export key outside 
annotations (that is still work and not break anyone using it for 3 years), but 
deprecate it.  Then update all examples use cases to use the annotations, but 
preserve at least one functional test to make sure that, although deprecated, 
it still works.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [openwhisk-runtime-dotnet] kamyker edited a comment on issue #26: Raw requests to skip JObject conversion

2020-03-25 Thread GitBox
kamyker edited a comment on issue #26: Raw requests to skip JObject conversion
URL: 
https://github.com/apache/openwhisk-runtime-dotnet/issues/26#issuecomment-604105063
 
 
   > In general the downside of this approach is breaking the openwhisk json 
in/json out abstraction. 
   
   I've noticed in IBM console there's "Raw HTTP handling - When enabled your 
Action receives requests in plain text instead of a JSON body".
   
   I guess it doesn't do anything currently in net, right? That's kind of what 
I'd like to see being implemented.
   
   
https://github.com/apache/openwhisk/blob/master/docs/webactions.md#raw-http-handling
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [openwhisk-runtime-dotnet] kamyker edited a comment on issue #26: Raw requests to skip JObject conversion

2020-03-25 Thread GitBox
kamyker edited a comment on issue #26: Raw requests to skip JObject conversion
URL: 
https://github.com/apache/openwhisk-runtime-dotnet/issues/26#issuecomment-604105063
 
 
   > In general the downside of this approach is breaking the openwhisk json 
in/json out abstraction. 
   
   I've noticed in IBM console there's "Raw HTTP handling - When enabled your 
Action receives requests in plain text instead of a JSON body".
   
   I guess it doesn't do anything currently, right? That's kind of what I'd 
like to see being implemented.
   
   
https://github.com/apache/openwhisk/blob/master/docs/webactions.md#raw-http-handling
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [openwhisk-runtime-dotnet] kamyker edited a comment on issue #26: Raw requests to skip JObject conversion

2020-03-25 Thread GitBox
kamyker edited a comment on issue #26: Raw requests to skip JObject conversion
URL: 
https://github.com/apache/openwhisk-runtime-dotnet/issues/26#issuecomment-604105063
 
 
   > In general the downside of this approach is breaking the openwhisk json 
in/json out abstraction. 
   
   I've noticed in IBM console there's "Raw HTTP handling - When enabled your 
Action receives requests in plain text instead of a JSON body"
   I guess it doesn't do anything currently, right? That's kind of what I'd 
like to see being implemented.
   
   
https://github.com/apache/openwhisk/blob/master/docs/webactions.md#raw-http-handling
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [openwhisk-runtime-dotnet] kamyker commented on issue #26: Raw requests to skip JObject conversion

2020-03-25 Thread GitBox
kamyker commented on issue #26: Raw requests to skip JObject conversion
URL: 
https://github.com/apache/openwhisk-runtime-dotnet/issues/26#issuecomment-604105063
 
 
   > In general the downside of this approach is breaking the openwhisk json 
in/json out abstraction. 
   I've noticed in IBM console there's "Raw HTTP handling - When enabled your 
Action receives requests in plain text instead of a JSON body"
   
   I guess it doesn't do anything currently, right? That's kind of what I'd 
like to see being implemented.
   
   
https://github.com/apache/openwhisk/blob/master/docs/webactions.md#raw-http-handling
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [openwhisk-runtime-dotnet] rabbah commented on issue #34: Running 3.1 on IBM

2020-03-25 Thread GitBox
rabbah commented on issue #34: Running 3.1 on IBM
URL: 
https://github.com/apache/openwhisk-runtime-dotnet/issues/34#issuecomment-604096105
 
 
   That's right. You can even push your own images with your own dependencies 
and use them as "docker actions". The main difference is performance. The 
platform built-in images will load faster whereas the docker actions will have 
occasional slow starts because the image is pulled.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [openwhisk] rabbah commented on issue #4866: Cannot find module Error

2020-03-25 Thread GitBox
rabbah commented on issue #4866: Cannot find module Error
URL: https://github.com/apache/openwhisk/issues/4866#issuecomment-604095205
 
 
   currently there is only one zip file which contains the code and 
dependencies.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [openwhisk] rabbah closed issue #4866: Cannot find module Error

2020-03-25 Thread GitBox
rabbah closed issue #4866: Cannot find module Error
URL: https://github.com/apache/openwhisk/issues/4866
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [openwhisk-runtime-dotnet] kamyker opened a new issue #34: Running 3.1 on IBM

2020-03-25 Thread GitBox
kamyker opened a new issue #34: Running 3.1 on IBM
URL: https://github.com/apache/openwhisk-runtime-dotnet/issues/34
 
 
   You’d need to ask ibm :) 
   
   As an Apache project we’d love the contribution, which you could then build 
and push to dockerhub and use independent of the ibm lifecycle.
   
   _Originally posted by @rabbah in 
https://github.com/apache/openwhisk-runtime-dotnet/issues/22#issuecomment-556197318_
   
   Didn't know it was possible but 3.1 image from docker works fine with ibm 
functions.
   
   Instead of:
   ```
   ibmcloud fn action update {methodName} out.zip --kind dotnet:2.2 --main 
{namespaceName}::{namespaceName}.{className}::{methodName} --web true
   ```
   Simply run:
   ```
   ibmcloud fn action update {methodName} out.zip --docker 
openwhisk/action-dotnet-v3.1 --main 
{namespaceName}::{namespaceName}.{className}::{methodName} --web true
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [openwhisk] beraybentesen commented on issue #4866: Cannot find module Error

2020-03-25 Thread GitBox
beraybentesen commented on issue #4866: Cannot find module Error
URL: https://github.com/apache/openwhisk/issues/4866#issuecomment-603986260
 
 
   @rabbah You're right. I fixed with the correct configuration. And quick 
question, is there a way to update action without uploading zip again ? Let's 
say you just need to update the code itself instead of dependencies etc.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [openwhisk] rabbah commented on issue #4866: Cannot find module Error

2020-03-25 Thread GitBox
rabbah commented on issue #4866: Cannot find module Error
URL: https://github.com/apache/openwhisk/issues/4866#issuecomment-603984859
 
 
   hi @beraybentesen - this isn't very helpful/actionable. Usually this error 
means your function isn't package properly (your zip file is empty or missing 
index.js, package.json or similar). You'll need to share more details so 
someone can help you.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [openwhisk] beraybentesen opened a new issue #4866: Cannot find module Error

2020-03-25 Thread GitBox
beraybentesen opened a new issue #4866: Cannot find module Error
URL: https://github.com/apache/openwhisk/issues/4866
 
 
   After successfully deploying with zip file receiving this when I invoke 
action :
   
"error": "Error: Cannot find module '/nodejsAction/nrx2Fj84'\nat 
Function.Module._resolveFilename (internal/modules/cjs/loader.js:582:15)\n
at Function.Module._load (internal/modules/cjs/loader.js:508:25)\nat 
Module.require (internal/modules/cjs/loader.js:637:17)\nat require 
(internal/modules/cjs/helpers.js:22:18)\nat eval (eval at  
(/nodejsAction/runner.js:55:49), :1:1)\nat 
/nodejsAction/runner.js:55:49\nat process._tickCallback 
(internal/process/next_tick.js:68:7)"
   }


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services