[GitHub] [openwhisk] ningyougang commented on a change in pull request #4058: Add protect feature to avoid update or delete actions by mistake

ningyougang commented on a change in pull request #4058: URL: https://github.com/apache/openwhisk/pull/4058#discussion_r641184253 ## File path: core/controller/src/main/scala/org/apache/openwhisk/core/entitlement/Entitlement.scala ## @@ -231,6 +234,157 @@ protected[core]

[GitHub] [openwhisk] ningyougang commented on a change in pull request #4058: Add protect feature to avoid update or delete actions by mistake

ningyougang commented on a change in pull request #4058: URL: https://github.com/apache/openwhisk/pull/4058#discussion_r641189638 ## File path: core/controller/src/main/scala/org/apache/openwhisk/core/entitlement/Entitlement.scala ## @@ -231,6 +234,157 @@ protected[core]

[GitHub] [openwhisk] codecov-commenter edited a comment on pull request #4963: Implement MongoDBArtifactStore

codecov-commenter edited a comment on pull request #4963: URL: https://github.com/apache/openwhisk/pull/4963#issuecomment-822206043 #

[GitHub] [openwhisk] ningyougang commented on a change in pull request #4058: Add protect feature to avoid update or delete actions by mistake

ningyougang commented on a change in pull request #4058: URL: https://github.com/apache/openwhisk/pull/4058#discussion_r641189638 ## File path: core/controller/src/main/scala/org/apache/openwhisk/core/entitlement/Entitlement.scala ## @@ -231,6 +234,157 @@ protected[core]

[GitHub] [openwhisk] ningyougang commented on a change in pull request #4058: Add protect feature to avoid update or delete actions by mistake

ningyougang commented on a change in pull request #4058: URL: https://github.com/apache/openwhisk/pull/4058#discussion_r641189638 ## File path: core/controller/src/main/scala/org/apache/openwhisk/core/entitlement/Entitlement.scala ## @@ -231,6 +234,157 @@ protected[core]

[GitHub] [openwhisk] ningyougang commented on a change in pull request #4058: Add protect feature to avoid update or delete actions by mistake

ningyougang commented on a change in pull request #4058: URL: https://github.com/apache/openwhisk/pull/4058#discussion_r641189638 ## File path: core/controller/src/main/scala/org/apache/openwhisk/core/entitlement/Entitlement.scala ## @@ -231,6 +234,157 @@ protected[core]

[GitHub] [openwhisk] ningyougang commented on a change in pull request #4058: Add protect feature to avoid update or delete actions by mistake

ningyougang commented on a change in pull request #4058: URL: https://github.com/apache/openwhisk/pull/4058#discussion_r641184253 ## File path: core/controller/src/main/scala/org/apache/openwhisk/core/entitlement/Entitlement.scala ## @@ -231,6 +234,157 @@ protected[core]

[GitHub] [openwhisk] codecov-commenter edited a comment on pull request #4910: Document for prewarmed container

codecov-commenter edited a comment on pull request #4910: URL: https://github.com/apache/openwhisk/pull/4910#issuecomment-632586255 #

[GitHub] [openwhisk] style95 commented on a change in pull request #4963: Implement MongoDBArtifactStore

style95 commented on a change in pull request #4963: URL: https://github.com/apache/openwhisk/pull/4963#discussion_r641160592 ## File path: ansible/README.md ## @@ -196,6 +196,43 @@ ansible-playbook -i environments/$ENVIRONMENT routemgmt.yml - To use the API Gateway, you'll

[GitHub] [openwhisk] style95 commented on a change in pull request #4963: Implement MongoDBArtifactStore

style95 commented on a change in pull request #4963: URL: https://github.com/apache/openwhisk/pull/4963#discussion_r641160592 ## File path: ansible/README.md ## @@ -196,6 +196,43 @@ ansible-playbook -i environments/$ENVIRONMENT routemgmt.yml - To use the API Gateway, you'll

[GitHub] [openwhisk] style95 commented on a change in pull request #4963: Implement MongoDBArtifactStore

style95 commented on a change in pull request #4963: URL: https://github.com/apache/openwhisk/pull/4963#discussion_r641159735 ## File path: ansible/roles/controller/tasks/deploy.yml ## @@ -292,6 +292,19 @@ env: "{{ env | combine(elastic_env) }}" when:

[GitHub] [openwhisk] jiangpengcheng commented on a change in pull request #4963: Implement MongoDBArtifactStore

jiangpengcheng commented on a change in pull request #4963: URL: https://github.com/apache/openwhisk/pull/4963#discussion_r641146517 ## File path: ansible/roles/controller/tasks/deploy.yml ## @@ -292,6 +292,19 @@ env: "{{ env | combine(elastic_env) }}" when:

[GitHub] [openwhisk-intellij-plugin] KeonHee merged pull request #14: Update publisher

KeonHee merged pull request #14: URL: https://github.com/apache/openwhisk-intellij-plugin/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [openwhisk] jiangpengcheng commented on a change in pull request #4963: Implement MongoDBArtifactStore

jiangpengcheng commented on a change in pull request #4963: URL: https://github.com/apache/openwhisk/pull/4963#discussion_r641143641 ## File path: ansible/roles/controller/tasks/deploy.yml ## @@ -292,6 +292,19 @@ env: "{{ env | combine(elastic_env) }}" when:

[GitHub] [openwhisk] style95 commented on a change in pull request #4963: Implement MongoDBArtifactStore

style95 commented on a change in pull request #4963: URL: https://github.com/apache/openwhisk/pull/4963#discussion_r641138601 ## File path: ansible/roles/controller/tasks/deploy.yml ## @@ -292,6 +292,19 @@ env: "{{ env | combine(elastic_env) }}" when:

[GitHub] [openwhisk] style95 commented on a change in pull request #4963: Implement MongoDBArtifactStore

style95 commented on a change in pull request #4963: URL: https://github.com/apache/openwhisk/pull/4963#discussion_r641136377 ## File path: ansible/README.md ## @@ -196,6 +196,43 @@ ansible-playbook -i environments/$ENVIRONMENT routemgmt.yml - To use the API Gateway, you'll

[GitHub] [openwhisk] ningyougang merged pull request #5111: [New Scheduler] Add container message consumer

ningyougang merged pull request #5111: URL: https://github.com/apache/openwhisk/pull/5111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [openwhisk] codecov-commenter edited a comment on pull request #5111: [New Scheduler] Add container message consumer

codecov-commenter edited a comment on pull request #5111: URL: https://github.com/apache/openwhisk/pull/5111#issuecomment-838112791 #

[GitHub] [openwhisk] codecov-commenter edited a comment on pull request #5121: #5120: Unit Tests failing due to testcontainers

codecov-commenter edited a comment on pull request #5121: URL: https://github.com/apache/openwhisk/pull/5121#issuecomment-849949285 #

[GitHub] [openwhisk-vscode-extension] rabbah merged pull request #11: reorganize content in LICENSE/NOTICE files to conform to release policy

rabbah merged pull request #11: URL: https://github.com/apache/openwhisk-vscode-extension/pull/11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [openwhisk-intellij-plugin] rabbah merged pull request #15: changes to NOTICE to conform to release policy

rabbah merged pull request #15: URL: https://github.com/apache/openwhisk-intellij-plugin/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [openwhisk] codecov-commenter edited a comment on pull request #5121: #5120: Unit Tests failing due to testcontainers

codecov-commenter edited a comment on pull request #5121: URL: https://github.com/apache/openwhisk/pull/5121#issuecomment-849949285 #

[GitHub] [openwhisk] codecov-commenter edited a comment on pull request #5121: #5120: Unit Tests failing due to testcontainers

codecov-commenter edited a comment on pull request #5121: URL: https://github.com/apache/openwhisk/pull/5121#issuecomment-849949285 #

[GitHub] [openwhisk] codecov-commenter commented on pull request #5121: #5120: Unit Tests failing due to testcontainers

codecov-commenter commented on pull request #5121: URL: https://github.com/apache/openwhisk/pull/5121#issuecomment-849949285 #

[GitHub] [openwhisk] ddragosd commented on pull request #5121: #5120: Unit Tests failing due to testcontainers

ddragosd commented on pull request #5121: URL: https://github.com/apache/openwhisk/pull/5121#issuecomment-849939249 Thanks for catching this @vrann ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [openwhisk] vrann opened a new pull request #5121: #5120: Unit Tests failing due to testcontainers

vrann opened a new pull request #5121: URL: https://github.com/apache/openwhisk/pull/5121 ## Description Upgraded the version of testcontainers ## Related issue and scope - #5120 Unit Tests failing due to testcontainers ## My changes affect the following components

[GitHub] [openwhisk] vrann opened a new issue #5120: Unit Tests failing due to testcontainers

vrann opened a new issue #5120: URL: https://github.com/apache/openwhisk/issues/5120 ## Environment details: * Travis ## Steps to reproduce the issue: 1. Create PR with no code change (i.e. documentation update) and wait for tests to get executed

[GitHub] [openwhisk-intellij-plugin] dgrove-oss opened a new pull request #15: changes to NOTICE to conform to release policy

dgrove-oss opened a new pull request #15: URL: https://github.com/apache/openwhisk-intellij-plugin/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [openwhisk-vscode-extension] dgrove-oss opened a new pull request #11: reorganize content in LICENSE/NOTICE files to conform to release policy

dgrove-oss opened a new pull request #11: URL: https://github.com/apache/openwhisk-vscode-extension/pull/11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [openwhisk] codecov-commenter edited a comment on pull request #5110: [New Scheduler] Add memory queue for the new scheduler

codecov-commenter edited a comment on pull request #5110: URL: https://github.com/apache/openwhisk/pull/5110#issuecomment-834316259 #

[GitHub] [openwhisk-intellij-plugin] style95 commented on a change in pull request #14: Update publisher

style95 commented on a change in pull request #14: URL: https://github.com/apache/openwhisk-intellij-plugin/pull/14#discussion_r640442119 ## File path: src/main/resources/META-INF/plugin.xml ## @@ -1,7 +1,7 @@ - +https://github.com/apache/openwhisk-intellij-plugin;>

[GitHub] [openwhisk-intellij-plugin] style95 opened a new pull request #14: Update publisher

style95 opened a new pull request #14: URL: https://github.com/apache/openwhisk-intellij-plugin/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] [openwhisk-vscode-extension] style95 merged pull request #10: Use same publisher with netbeans vscode extension

style95 merged pull request #10: URL: https://github.com/apache/openwhisk-vscode-extension/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [openwhisk-vscode-extension] style95 merged pull request #9: Add scancode

style95 merged pull request #9: URL: https://github.com/apache/openwhisk-vscode-extension/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [openwhisk-vscode-extension] upgle opened a new pull request #10: Use same publisher with netbeans vscode extension

upgle opened a new pull request #10: URL: https://github.com/apache/openwhisk-vscode-extension/pull/10 ## Description Need to use the same publisher with the Netbeans to publish extension under ASF vendor. (Apache Netbeans is using `asf` publisher)

[GitHub] [openwhisk-release] style95 commented on a change in pull request #390: Add IDE plugins.

style95 commented on a change in pull request #390: URL: https://github.com/apache/openwhisk-release/pull/390#discussion_r640407271 ## File path: README.md ## @@ -218,11 +218,18 @@ The following table can be used by Release Managers to check the status of all p

[GitHub] [openwhisk] codecov-commenter edited a comment on pull request #5118: [WIP] [New Scheduler] Manage memory queues in scheduler

codecov-commenter edited a comment on pull request #5118: URL: https://github.com/apache/openwhisk/pull/5118#issuecomment-849395420 #

[GitHub] [openwhisk-vscode-extension] style95 commented on a change in pull request #9: Add scancode

style95 commented on a change in pull request #9: URL: https://github.com/apache/openwhisk-vscode-extension/pull/9#discussion_r640399959 ## File path: resource/template/actioncode/sample.js ## @@ -1,3 +1,20 @@ +/* Review comment: I feel it's reasonable to add a

[GitHub] [openwhisk] codecov-commenter edited a comment on pull request #5118: [WIP] [New Scheduler] Manage memory queues in scheduler

codecov-commenter edited a comment on pull request #5118: URL: https://github.com/apache/openwhisk/pull/5118#issuecomment-849395420 #

[GitHub] [openwhisk-vscode-extension] upgle commented on a change in pull request #9: Add scancode

upgle commented on a change in pull request #9: URL: https://github.com/apache/openwhisk-vscode-extension/pull/9#discussion_r640396982 ## File path: resource/template/actioncode/sample.js ## @@ -1,3 +1,20 @@ +/* Review comment: This is not a test code. When a user

[GitHub] [openwhisk-vscode-extension] style95 commented on a change in pull request #9: Add scancode

style95 commented on a change in pull request #9: URL: https://github.com/apache/openwhisk-vscode-extension/pull/9#discussion_r640394126 ## File path: resource/template/actioncode/sample.js ## @@ -1,3 +1,20 @@ +/* Review comment: This is according to the

[GitHub] [openwhisk-vscode-extension] style95 commented on a change in pull request #9: Add scancode

style95 commented on a change in pull request #9: URL: https://github.com/apache/openwhisk-vscode-extension/pull/9#discussion_r640394126 ## File path: resource/template/actioncode/sample.js ## @@ -1,3 +1,20 @@ +/* Review comment: This is according to the

[GitHub] [openwhisk-vscode-extension] upgle commented on a change in pull request #9: Add scancode

upgle commented on a change in pull request #9: URL: https://github.com/apache/openwhisk-vscode-extension/pull/9#discussion_r640392131 ## File path: resource/template/actioncode/sample.js ## @@ -1,3 +1,20 @@ +/* Review comment: I'd liked to know the license is

[GitHub] [openwhisk-intellij-plugin] KeonHee merged pull request #13: Add scancode

KeonHee merged pull request #13: URL: https://github.com/apache/openwhisk-intellij-plugin/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [openwhisk] KeonHee commented on a change in pull request #5118: [WIP] [New Scheduler] Manage memory queues in scheduler

KeonHee commented on a change in pull request #5118: URL: https://github.com/apache/openwhisk/pull/5118#discussion_r640377634 ## File path: core/scheduler/src/main/resources/application.conf ## @@ -25,4 +25,12 @@ whisk{ managed-fraction: 90% blackbox-fraction: 10%

[GitHub] [openwhisk-vscode-extension] style95 opened a new pull request #9: Add scancode

style95 opened a new pull request #9: URL: https://github.com/apache/openwhisk-vscode-extension/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] [openwhisk-intellij-plugin] style95 opened a new pull request #13: Add scancode

style95 opened a new pull request #13: URL: https://github.com/apache/openwhisk-intellij-plugin/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] [openwhisk] codecov-commenter edited a comment on pull request #5111: [New Scheduler] Add container message consumer

codecov-commenter edited a comment on pull request #5111: URL: https://github.com/apache/openwhisk/pull/5111#issuecomment-838112791 #

[GitHub] [openwhisk] codecov-commenter edited a comment on pull request #5118: [WIP] [New Scheduler] Manage memory queues in scheduler

codecov-commenter edited a comment on pull request #5118: URL: https://github.com/apache/openwhisk/pull/5118#issuecomment-849395420 #

[GitHub] [openwhisk] codecov-commenter edited a comment on pull request #5111: [New Scheduler] Add container message consumer

codecov-commenter edited a comment on pull request #5111: URL: https://github.com/apache/openwhisk/pull/5111#issuecomment-838112791 #

[GitHub] [openwhisk] codecov-commenter edited a comment on pull request #5118: [WIP] [New Scheduler] Manage memory queues in scheduler

codecov-commenter edited a comment on pull request #5118: URL: https://github.com/apache/openwhisk/pull/5118#issuecomment-849395420 #

[GitHub] [openwhisk] ningyougang commented on pull request #5118: [WIP] [New Scheduler] Manage memory queues in scheduler

ningyougang commented on pull request #5118: URL: https://github.com/apache/openwhisk/pull/5118#issuecomment-849401707 It is better to add queueManager's relative configuration to

[GitHub] [openwhisk-intellij-plugin] style95 merged pull request #12: Support IDEA 2021.1

style95 merged pull request #12: URL: https://github.com/apache/openwhisk-intellij-plugin/pull/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [openwhisk] codecov-commenter commented on pull request #5118: [WIP] [New Scheduler] Manage memory queues in scheduler

codecov-commenter commented on pull request #5118: URL: https://github.com/apache/openwhisk/pull/5118#issuecomment-849395420 #

[GitHub] [openwhisk] ningyougang commented on pull request #5111: [New Scheduler] Add container message consumer

ningyougang commented on pull request #5111: URL: https://github.com/apache/openwhisk/pull/5111#issuecomment-849388762 @upgle , i am sorry, due to test case error and sub prs depend on this pr, i submited a commit for this pr to solve the test case error. -- This is an automated message