[GitHub] hykych closed issue #2856: How do you limit the concurrent activations with multiple Controller?

2017-10-16 Thread git
hykych closed issue #2856: How do you limit the concurrent activations with multiple Controller? URL: https://github.com/apache/incubator-openwhisk/issues/2856 This is an automated message from the Apache Git Service. To

[GitHub] hykych opened a new issue #2856: How do you limit the concurrent activations with multiple Controller?

2017-10-16 Thread git
hykych opened a new issue #2856: How do you limit the concurrent activations with multiple Controller? URL: https://github.com/apache/incubator-openwhisk/issues/2856 I noticed that you use the `activationByNamespaceId` in `LoadBalancerData` to count the concurrent activations.

[GitHub] hykych closed issue #2733: Have seen your Invoker inplementation, how's its performence and memory cost?

2017-10-16 Thread git
hykych closed issue #2733: Have seen your Invoker inplementation, how's its performence and memory cost? URL: https://github.com/apache/incubator-openwhisk/issues/2733 This is an automated message from the Apache Git

[GitHub] hykych commented on issue #2733: Have seen your Invoker inplementation, how's its performence and memory cost?

2017-10-16 Thread git
hykych commented on issue #2733: Have seen your Invoker inplementation, how's its performence and memory cost? URL: https://github.com/apache/incubator-openwhisk/issues/2733#issuecomment-337089298 @markusthoemmes @rabbah thanks

[GitHub] hykych commented on issue #2856: How do you limit the concurrent activations with multiple Controller?

2017-10-16 Thread git
hykych commented on issue #2856: How do you limit the concurrent activations with multiple Controller? URL: https://github.com/apache/incubator-openwhisk/issues/2856#issuecomment-337089203 @vvraskin thanks This is an

[GitHub] hykych closed issue #2856: How do you limit the concurrent activations with multiple Controller?

2017-10-16 Thread git
hykych closed issue #2856: How do you limit the concurrent activations with multiple Controller? URL: https://github.com/apache/incubator-openwhisk/issues/2856 This is an automated message from the Apache Git Service. To

[GitHub] markusthoemmes commented on issue #2859: LoadBalancerService does not consider concurrent requests when scheduling

2017-10-16 Thread git
markusthoemmes commented on issue #2859: LoadBalancerService does not consider concurrent requests when scheduling URL: https://github.com/apache/incubator-openwhisk/issues/2859#issuecomment-337065359 This is not necessarily related to the shared state, it is also the case with the local

[GitHub] tysonnorris commented on issue #2859: LoadBalancerService does not consider concurrent requests when scheduling

2017-10-16 Thread git
tysonnorris commented on issue #2859: LoadBalancerService does not consider concurrent requests when scheduling URL: https://github.com/apache/incubator-openwhisk/issues/2859#issuecomment-337057445 I think "reading your own writes" is only for the replicated data, which is inherently

[GitHub] dubeejw commented on a change in pull request #2544: Allow CLI to Save Code from Action

2017-10-16 Thread git
dubeejw commented on a change in pull request #2544: Allow CLI to Save Code from Action URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r144978426 ## File path: tests/src/test/scala/whisk/core/cli/test/WskBasicUsageTests.scala ## @@ -811,6 +813,81

[GitHub] mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action

2017-10-16 Thread git
mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r144964356 ## File path: tools/cli/go-whisk-cli/commands/action.go ## @@ -495,6 +513,87 @@ func getExec(args

[GitHub] dubeejw commented on issue #2847: Treat action code as attachments for created/updated actions

2017-10-16 Thread git
dubeejw commented on issue #2847: Treat action code as attachments for created/updated actions URL: https://github.com/apache/incubator-openwhisk/pull/2847#issuecomment-337052534 whisk.core.database.test.CacheConcurrencyTests > the cache should support concurrent CRUD without bogus

[GitHub] mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action

2017-10-16 Thread git
mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r144969129 ## File path: tools/cli/go-whisk-cli/commands/action.go ## @@ -495,6 +513,87 @@ func getExec(args

[GitHub] mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action

2017-10-16 Thread git
mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r144975374 ## File path: tools/cli/go-whisk-cli/commands/util.go ## @@ -851,6 +858,44 @@ func readFile(filename

[GitHub] dubeejw commented on issue #2847: Treat action code as attachments for created/updated actions

2017-10-16 Thread git
dubeejw commented on issue #2847: Treat action code as attachments for created/updated actions URL: https://github.com/apache/incubator-openwhisk/pull/2847#issuecomment-337048815 Can expand test from https://github.com/apache/incubator-openwhisk/pull/2855 after that one is merged.

[GitHub] dubeejw commented on issue #2847: Treat action code as attachments for created/updated actions

2017-10-16 Thread git
dubeejw commented on issue #2847: Treat action code as attachments for created/updated actions URL: https://github.com/apache/incubator-openwhisk/pull/2847#issuecomment-337048815 Can use test from https://github.com/apache/incubator-openwhisk/pull/2855 after that one is merged.

[GitHub] dubeejw commented on issue #2832: Do not cache invalidate when adding a DB attachment

2017-10-16 Thread git
dubeejw commented on issue #2832: Do not cache invalidate when adding a DB attachment URL: https://github.com/apache/incubator-openwhisk/pull/2832#issuecomment-337043697 PG2 2173 ? This is an automated message from the

[GitHub] mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action

2017-10-16 Thread git
mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r144969129 ## File path: tools/cli/go-whisk-cli/commands/action.go ## @@ -495,6 +513,87 @@ func getExec(args

[GitHub] mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action

2017-10-16 Thread git
mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r144967923 ## File path: tools/cli/go-whisk-cli/commands/action.go ## @@ -495,6 +513,87 @@ func getExec(args

[GitHub] mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action

2017-10-16 Thread git
mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r144965678 ## File path: tests/src/test/scala/whisk/core/cli/test/WskBasicUsageTests.scala ## @@ -811,6 +813,81

[GitHub] mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action

2017-10-16 Thread git
mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r144964356 ## File path: tools/cli/go-whisk-cli/commands/action.go ## @@ -495,6 +513,87 @@ func getExec(args

[GitHub] dgrove-oss commented on issue #2828: option to use docker pause/unpause instead of docker-runc pause/unpause

2017-10-16 Thread git
dgrove-oss commented on issue #2828: option to use docker pause/unpause instead of docker-runc pause/unpause URL: https://github.com/apache/incubator-openwhisk/pull/2828#issuecomment-337033927 squashed down to single commit. Please merge once Travis verifies the squashed commit.

[GitHub] mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action

2017-10-16 Thread git
mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r144949391 ## File path: tests/src/test/scala/whisk/core/cli/test/WskBasicUsageTests.scala ## @@ -1347,8

[GitHub] mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action

2017-10-16 Thread git
mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r144948805 ## File path: tests/src/test/scala/whisk/core/cli/test/WskBasicUsageTests.scala ## @@ -811,6 +813,81

[GitHub] vvraskin commented on issue #2859: LoadBalancerService does not consider concurrent requests when scheduling

2017-10-16 Thread git
vvraskin commented on issue #2859: LoadBalancerService does not consider concurrent requests when scheduling URL: https://github.com/apache/incubator-openwhisk/issues/2859#issuecomment-337006404 Good catch. I will try to reproduce it later, but I think you are right, the fact that we

[GitHub] bwmcadams commented on a change in pull request #2802: Akka Usage Cleanup for Actor State safety

2017-10-16 Thread git
bwmcadams commented on a change in pull request #2802: Akka Usage Cleanup for Actor State safety URL: https://github.com/apache/incubator-openwhisk/pull/2802#discussion_r144941287 ## File path: core/invoker/src/main/scala/whisk/core/containerpool/ContainerPool.scala ##

[GitHub] bwmcadams commented on a change in pull request #2802: Akka Usage Cleanup for Actor State safety

2017-10-16 Thread git
bwmcadams commented on a change in pull request #2802: Akka Usage Cleanup for Actor State safety URL: https://github.com/apache/incubator-openwhisk/pull/2802#discussion_r144941287 ## File path: core/invoker/src/main/scala/whisk/core/containerpool/ContainerPool.scala ##

[GitHub] houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-16 Thread git
houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r144934598 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@

[GitHub] dubeejw commented on a change in pull request #2855: Cache database attachments

2017-10-16 Thread git
dubeejw commented on a change in pull request #2855: Cache database attachments URL: https://github.com/apache/incubator-openwhisk/pull/2855#discussion_r144642462 ## File path: common/scala/src/main/scala/whisk/core/database/DocumentFactory.scala ## @@ -245,26 +261,35 @@

[GitHub] tysonnorris commented on issue #2856: How do you limit the concurrent activations with multiple Controller?

2017-10-16 Thread git
tysonnorris commented on issue #2856: How do you limit the concurrent activations with multiple Controller? URL: https://github.com/apache/incubator-openwhisk/issues/2856#issuecomment-336979661 @hykych @vvraskin I just logged #2859 - is this possibly related?

[GitHub] tysonnorris opened a new issue #2859: LoadBalancerService does not consider concurrent requests when scheduling

2017-10-16 Thread git
tysonnorris opened a new issue #2859: LoadBalancerService does not consider concurrent requests when scheduling URL: https://github.com/apache/incubator-openwhisk/issues/2859 Under concurrent requests to controller, LoadBalancerService will not consider concurrent requests when scheduling

[GitHub] csantanapr closed pull request #40: Revert "Add the support of certificate checking"

2017-10-16 Thread git
csantanapr closed pull request #40: Revert "Add the support of certificate checking" URL: https://github.com/apache/incubator-openwhisk-client-go/pull/40 This is an automated message from the Apache Git Service. To respond

[GitHub] csantanapr commented on issue #40: Revert "Add the support of certificate checking"

2017-10-16 Thread git
csantanapr commented on issue #40: Revert "Add the support of certificate checking" URL: https://github.com/apache/incubator-openwhisk-client-go/pull/40#issuecomment-336975635 @houshengbo @mrutkows We are reverting the changes from #39 There was an error introduce, that

[GitHub] mrutkows commented on issue #608: Invalid Runtime not detected / no error generated

2017-10-16 Thread git
mrutkows commented on issue #608: Invalid Runtime not detected / no error generated URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/608#issuecomment-336966727 In addition, issue #306 lists what we SHOULD do (copied below), but I am not confident we test for many of

[GitHub] mrutkows commented on issue #608: Invalid Runtime not detected / no error generated

2017-10-16 Thread git
mrutkows commented on issue #608: Invalid Runtime not detected / no error generated URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/608#issuecomment-336966727 In addition, issue #306 lists what we SHOULD do (copied below), but I am not confident we test for many of

[GitHub] mrutkows commented on issue #608: Invalid Runtime not detected / no error generated

2017-10-16 Thread git
mrutkows commented on issue #608: Invalid Runtime not detected / no error generated URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/608#issuecomment-336966727 In addition, issue #306 lists what we SHOULD do (copied below), but I am not confident we test for many of

[GitHub] mrutkows commented on issue #608: Invalid Runtime not detected / no error generated

2017-10-16 Thread git
mrutkows commented on issue #608: Invalid Runtime not detected / no error generated URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/608#issuecomment-336966727 In addition, issue #306 lists what we SHOULD do (copied below), but I am not confident we test for many of

[GitHub] mrutkows opened a new issue #608: Invalid Runtime not detected / no error generated

2017-10-16 Thread git
mrutkows opened a new issue #608: Invalid Runtime not detected / no error generated URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/608 manifest_parser_test includes a unit test "TestComposeActionsForInvalidRuntime" The actual test is commented out and it simply

[GitHub] dubeejw opened a new pull request #40: Revert "Add the support of certificate checking"

2017-10-16 Thread git
dubeejw opened a new pull request #40: Revert "Add the support of certificate checking" URL: https://github.com/apache/incubator-openwhisk-client-go/pull/40 Reverts apache/incubator-openwhisk-client-go#39 This is an

[GitHub] mrutkows commented on issue #116: discussion: parameters in action sequence

2017-10-16 Thread git
mrutkows commented on issue #116: discussion: parameters in action sequence URL: https://github.com/apache/incubator-openwhisk/issues/116#issuecomment-336948883 The "wskdeploy" grammar/utility support declaration of input and output types (including more robust types that have schema such

[GitHub] mrutkows opened a new pull request #607: WIP: JSON Output support

2017-10-16 Thread git
mrutkows opened a new pull request #607: WIP: JSON Output support URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/607 First part of PR we are "Updating Bad YAML tests to be more descriptive and efficient."

[GitHub] vvraskin commented on issue #2856: How do you limit the concurrent activations with multiple Controller?

2017-10-16 Thread git
vvraskin commented on issue #2856: How do you limit the concurrent activations with multiple Controller? URL: https://github.com/apache/incubator-openwhisk/issues/2856#issuecomment-336924888 Hi @hykych! basically there are two ways you deploy controllers: active-passive (one

[GitHub] cbickel commented on issue #2665: Add ability to use all controllers round robin

2017-10-16 Thread git
cbickel commented on issue #2665: Add ability to use all controllers round robin URL: https://github.com/apache/incubator-openwhisk/pull/2665#issuecomment-336920701 PG3#1191 is ? This is an automated message from the

[GitHub] sven-lange-last commented on issue #2858: Make Docker action container cleanup during invoker startup / shutdown more robust

2017-10-16 Thread git
sven-lange-last commented on issue #2858: Make Docker action container cleanup during invoker startup / shutdown more robust URL: https://github.com/apache/incubator-openwhisk/pull/2858#issuecomment-336915644 PG 1 / 2143 running.

[GitHub] sven-lange-last commented on issue #2858: Make Docker action container cleanup during invoker startup / shutdown more robust

2017-10-16 Thread git
sven-lange-last commented on issue #2858: Make Docker action container cleanup during invoker startup / shutdown more robust URL: https://github.com/apache/incubator-openwhisk/pull/2858#issuecomment-336909014 @markusthoemmes please attend to this PR.

[GitHub] sven-lange-last opened a new pull request #2858: Make Docker action container cleanup during invoker startup / shutdown more robust

2017-10-16 Thread git
sven-lange-last opened a new pull request #2858: Make Docker action container cleanup during invoker startup / shutdown more robust URL: https://github.com/apache/incubator-openwhisk/pull/2858 Remove all Docker containers on the system that match the naming filter `wsk_` at startup and

[GitHub] markusthoemmes commented on issue #2857: Emit metrics via kamon - wip

2017-10-16 Thread git
markusthoemmes commented on issue #2857: Emit metrics via kamon - wip URL: https://github.com/apache/incubator-openwhisk/pull/2857#issuecomment-336870752 Sorry oversaw the **WIP** tag, my bad. This is an automated message

[GitHub] markusthoemmes commented on a change in pull request #2857: Emit metrics via kamon - wip

2017-10-16 Thread git
markusthoemmes commented on a change in pull request #2857: Emit metrics via kamon - wip URL: https://github.com/apache/incubator-openwhisk/pull/2857#discussion_r144826997 ## File path: common/scala/src/main/scala/whisk/common/TransactionId.scala ## @@ -55,7 +55,14 @@

[GitHub] markusthoemmes commented on a change in pull request #2857: Emit metrics via kamon - wip

2017-10-16 Thread git
markusthoemmes commented on a change in pull request #2857: Emit metrics via kamon - wip URL: https://github.com/apache/incubator-openwhisk/pull/2857#discussion_r144827975 ## File path: common/scala/src/main/scala/whisk/common/Logging.scala ## @@ -178,6 +179,34 @@ object

[GitHub] markusthoemmes commented on a change in pull request #2857: Emit metrics via kamon - wip

2017-10-16 Thread git
markusthoemmes commented on a change in pull request #2857: Emit metrics via kamon - wip URL: https://github.com/apache/incubator-openwhisk/pull/2857#discussion_r144826997 ## File path: common/scala/src/main/scala/whisk/common/TransactionId.scala ## @@ -55,7 +55,14 @@

[GitHub] markusthoemmes commented on a change in pull request #2857: Emit metrics via kamon - wip

2017-10-16 Thread git
markusthoemmes commented on a change in pull request #2857: Emit metrics via kamon - wip URL: https://github.com/apache/incubator-openwhisk/pull/2857#discussion_r144825903 ## File path: ansible/group_vars/all ## @@ -105,7 +105,11 @@ limits: controller: basePort:

[GitHub] mhenke1 opened a new pull request #2857: Emit metrics via kamon

2017-10-16 Thread git
mhenke1 opened a new pull request #2857: Emit metrics via kamon URL: https://github.com/apache/incubator-openwhisk/pull/2857 This PR implements the capability to send metric information via Kamon (http://kamon.io/) to statsd (https://github.com/etsy/statsd) instead or additionally to

[GitHub] markusthoemmes closed pull request #2838: Add check to controller and invoker that required databases exist

2017-10-16 Thread git
markusthoemmes closed pull request #2838: Add check to controller and invoker that required databases exist URL: https://github.com/apache/incubator-openwhisk/pull/2838 This is an automated message from the Apache Git

[GitHub] markusthoemmes commented on a change in pull request #2802: Akka Usage Cleanup for Actor State safety

2017-10-16 Thread git
markusthoemmes commented on a change in pull request #2802: Akka Usage Cleanup for Actor State safety URL: https://github.com/apache/incubator-openwhisk/pull/2802#discussion_r144799933 ## File path: core/invoker/src/main/scala/whisk/core/containerpool/ContainerPool.scala

[GitHub] markusthoemmes commented on a change in pull request #2802: Akka Usage Cleanup for Actor State safety

2017-10-16 Thread git
markusthoemmes commented on a change in pull request #2802: Akka Usage Cleanup for Actor State safety URL: https://github.com/apache/incubator-openwhisk/pull/2802#discussion_r144799888 ## File path: core/invoker/src/main/scala/whisk/core/containerpool/ContainerPool.scala

[GitHub] markusthoemmes closed pull request #2854: Improve garbage collector out-out-memory handling and debugging

2017-10-16 Thread git
markusthoemmes closed pull request #2854: Improve garbage collector out-out-memory handling and debugging URL: https://github.com/apache/incubator-openwhisk/pull/2854 This is an automated message from the Apache Git

[GitHub] jthomas commented on issue #76: Add type support for annotations and limits

2017-10-16 Thread git
jthomas commented on issue #76: Add type support for annotations and limits URL: https://github.com/apache/incubator-openwhisk-client-js/pull/76#issuecomment-336813254 LGTM. This is an automated message from the Apache Git

[GitHub] markusthoemmes commented on a change in pull request #2792: Add a controller simulator to drive invoker benchmarks.

2017-10-16 Thread git
markusthoemmes commented on a change in pull request #2792: Add a controller simulator to drive invoker benchmarks. URL: https://github.com/apache/incubator-openwhisk/pull/2792#discussion_r144771977 ## File path: