:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tools/jenkins/apache/dockerhub.groovy
b/tools/jenkins/apache/dockerhub.groovy
index 975e1961c4..c804b23d34 100644
--- a/tools/jenkins/apache/dockerhub.groovy
+++ b/tools/jenkins
dubeejw closed issue #2865: only deploy invoker and controller with jenkins
URL: https://github.com/apache/incubator-openwhisk/issues/2865
This is an automated message from the Apache Git Service.
To respond to the message
:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ansible/edge.yml b/ansible/edge.yml
index cf80ebeb2d..6566d572ae 100644
--- a/ansible/edge.yml
+++ b/ansible/edge.yml
@@ -8,4 +8,3 @@
roles:
- nginx
- cli
- - sdk
of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/action/kafkaFeed.js b/action/kafkaFeed.js
index 3cd42f7..bf55538 100644
--- a/action/kafkaFeed.js
+++ b/action/kafkaFeed.js
@@ -18,6 +18,8
Review comment:
it's encouragement documentation for folks to use `swift:3.1.1` :-)
I can add back, and remove later when we deprecate and announce in mailing
list
This is an automated message from the Apache Git Service.
To respon
e.toJson
+ ))
+
+ val run = wsk.action.invoke(actionName, parameters = Map(
Review comment:
I understand that the trigger will not be fetched on the read based on how
the OpenWhisk infrastructure is setup. However, is there a test to make sure
this provider errors as expected?
-
automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
val status =
result.getFields("status").head.asInstanceOf[JsObject].fields
+
+ config should contain("brokers" -> brokers)
Review comment:
I see two different possible values for dataChanged.
![screen shot 2017-10-17 at 10 33 53
am](https://user-im
val status =
result.getFields("status").head.asInstanceOf[JsObject].fields
+
+ config should contain("brokers" -> brokers)
Review comment:
So we know what the returned trigger name will be. That means the config
property can be compared to a JsObject.
markusthoemmes closed pull request #2648: Overhaul logging
URL: https://github.com/apache/incubator-openwhisk/pull/2648
This is an automated message from the Apache Git Service.
To respond to the message, please log
markusthoemmes commented on issue #2648: Overhaul logging
URL:
https://github.com/apache/incubator-openwhisk/pull/2648#issuecomment-337253953
@mhenke1 is doing all this work.
This is an automated message from the Apache Git
rabbah closed pull request #2812: Implement bulk write of activations in the
Invoker.
URL: https://github.com/apache/incubator-openwhisk/pull/2812
This is an automated message from the Apache Git Service.
To respond
markusthoemmes closed pull request #2689: first stage of support for dynamic
invoker id assignment
URL: https://github.com/apache/incubator-openwhisk/pull/2689
This is an automated message from the Apache Git Service
the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
dubeejw commented on issue #2544: Allow CLI to Save Code from Action
URL:
https://github.com/apache/incubator-openwhisk/pull/2544#issuecomment-337241702
PG4 895 ?
This is an automated message from the Apache Git Service
ython",
-"swift",
-"swift:3",
-"swift:default",
+"python:2",
+"python:3",
+"swift:3.1.1",
Review comm
rabbah closed pull request #2843: Move python runtime into it's own repo
URL: https://github.com/apache/incubator-openwhisk/pull/2843
This is an automated message from the Apache Git Service.
To respond to the message
rabbah closed pull request #2823: Move php runtime into it's own repo
URL: https://github.com/apache/incubator-openwhisk/pull/2823
This is an automated message from the Apache Git Service.
To respond to the message, please
rabbah closed pull request #2822: Move swift runtime into it's own repo
URL: https://github.com/apache/incubator-openwhisk/pull/2822
This is an automated message from the Apache Git Service.
To respond to the message
repos.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure
rabbah closed pull request #2821: Move java runtime into it's own repo
URL: https://github.com/apache/incubator-openwhisk/pull/2821
This is an automated message from the Apache Git Service.
To respond to the message, please
all the
dockerfiles there. thoughts?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service
rabbah closed pull request #2834: Move nodejs runtime into it's own repo
URL: https://github.com/apache/incubator-openwhisk/pull/2834
This is an automated message from the Apache Git Service.
To respond to the message
CI approves?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact
n, isFailed))
+.record(value)
+ }
Review comment:
I have simplified the MetricsEmitter (via amend) to reduce allocations
This is an automated message from the Apache Git Service.
To respond to the message, please log o
avoid loss of information. I will tackle log reduction in a
following commit
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specif
from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
rabbah closed pull request #74: Adding support for responsetype parameter
during route create.
URL: https://github.com/apache/incubator-openwhisk-client-js/pull/74
This is an automated message from the Apache Git Service
la
WhiskProperties.getControllerHosts.split(",").foreach { _ =>
```
?
--------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries abou
^^
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
hykych closed issue #2856: How do you limit the concurrent activations with
multiple Controller?
URL: https://github.com/apache/incubator-openwhisk/issues/2856
This is an automated message from the Apache Git Service
.
However, this is invalid with multiple Controller. Is there anything I
didn't noticed or I made a mistake on that code snippet?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub
hykych closed issue #2733: Have seen your Invoker inplementation, how's its
performence and memory cost?
URL: https://github.com/apache/incubator-openwhisk/issues/2733
This is an automated message from the Apache Git
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
hykych closed issue #2856: How do you limit the concurrent activations with
multiple Controller?
URL: https://github.com/apache/incubator-openwhisk/issues/2856
This is an automated message from the Apache Git Service
impose a bottleneck.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact I
under load.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, plea
equence"))
+}
+
+wsk.action.get(seqName, save = Some(true), expectedExitCode =
MISUSE_EXIT).stderr should include(
+ "Cannot save action sequence")
Review comment:
Yes.
This is an automated message from the Apache Gi
prior to writing out to a file.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@i
ion.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.
err
Review comment:
log an error message indicating that it was the `os.Getwd` function that
failed
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above
return whiskErr
+}
+
+defer file.Close()
+
+file.WriteString(content)
Review comment:
Check the error that WriteString returns
This is an automated message from the Apache Git Service.
To respond to the message, please l
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us
the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
Review comment:
also log an error message indicating that it was the `os.Getwd` function
that failed
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
U
usion by using `kind` as the variable name when it really
holds the runtime name and not the entire kind value. i.e. `nodejs:6` is the
action's exec.kind value; this `kind` var will be set to `nodejs`.
This is an automated message from th
+
+wsk.action.get(seqName, save = Some(true), expectedExitCode =
MISUSE_EXIT).stderr should include(
+ "Cannot save action sequence")
Review comment:
can the CLI handle saving an action with a 50M npm .zip file?
--
prior to writing out to a file.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@i
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us
comment:
Incorrect error message. An empty file actually exists.
--------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For quer
+}
+
+wsk.action.get(seqName, save = Some(true), expectedExitCode =
MISUSE_EXIT).stderr should include(
+ "Cannot save action sequence")
Review comment:
nit. error message consistency. `Cannot save Docker images` is plural.
`Cannot save action sequence` is singular and
ted message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
he `if contains`)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infras
y
failed tests.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
I will get rid of val NS.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
k here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apac
?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
e changing of
`LoadbalancerData.activationCountPerInvoker()` from sync to async. Since
LoadBalancerService is processed with multiple threads, the updates to the
LoadBalancerData are not seen immediately by other threads.
This is an automated message from the Apache G
csantanapr closed pull request #40: Revert "Add the support of certificate
checking"
URL: https://github.com/apache/incubator-openwhisk-client-go/pull/40
This is an automated message from the Apache Git Service.
figuration.
Also this change should go first to main repo `client.go` and then
ported/sync back to this repo
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL a
(PLEASE OPEN A NEW ISSUE FOR FEATURE).
-and if we do not find a runtime key at all in the manifest we should of
course still "default" to "nodejs:default", BUT WE SHOULD PRESENT A WARNING in
the output to the user that we are making this assumption.
---
(PLEASE OPEN A NEW ISSUE FOR FEATURE).
-and if we do not find a runtime key at all in the manifest we should of
course still "default" to "nodejs:default", BUT WE SHOULD PRESENT A WARNING in
the output to the user that we are making this assumption.
---
(PLEASE OPEN A NEW ISSUE FOR FEATURE).
-and if we do not find a runtime key at all in the manifest we should of
course still "default" to "nodejs:default", BUT WE SHOULD PRESENT A WARNING in
the output to the user that we are making this assumption.
---
runtime key at all in the manifest we should of
course still "default" to "nodejs:default", BUT WE SHOULD PRESENT A WARNING in
the output to the user that we are making this assumption.
```
----
This is an automa
d such a named error to
be thrown if the manifest has this field set (and it is not inferred) to an
unknown value.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use
ient-go#39
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
a grammar and means to insert this (perhaps as
annotations) and perform server-side validation (using similar code as to the
client-side).
This is an automated message from the Apache Git Service.
To respond to the message, please log
cient."
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-openwhisk/blob/master/core/controller/src/main/scala/whisk/core/loadBalancer/LoadBalancerService.scala#L105
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above
the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
be printed if it was given by
the developer (we should probably clean that up later and log the lines
explicitly vs. implicitly through this class, but it keeps the changes small
for now)
This is an automated message from the Apache G
n, isFailed))
+.record(value)
+ }
Review comment:
Why not have an overloaded version of `emitMetric` and get rid of the
intermediary types + non-needed allocations?
This is an automated message from the Apache Git Servic
was given by
the developer (we should probably clean that up later and log the lines
explicitly vs. implicitly through this class, but it keeps the changes small
for now)
This is an automated message from the Apache Git Service.
I'll finish that off, then we can clean these up (We
need system props for SPIs for example anyway).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL ab
'
metrics_log: true
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Wi
markusthoemmes closed pull request #2838: Add check to controller and invoker
that required databases exist
URL: https://github.com/apache/incubator-openwhisk/pull/2838
This is an automated message from the Apache Git
+ busyPool = busyPool - sender()
+ busyPool.foreach { _ =>
+feed ! MessageFeed.Processed
+ }
Review comment:
Same as above.
This is an automated message from the Apache Git Service.
To respond to the message
ore like:
```scala
if(busyPool.contains(sender()) {
busyPool = busyPool - sender()
feed ! MessageFeed.Processed
}
```
This is an automated message from the Apache Git Service.
To respond to the message, ple
markusthoemmes closed pull request #2854: Improve garbage collector
out-out-memory handling and debugging
URL: https://github.com/apache/incubator-openwhisk/pull/2854
This is an automated message from the Apache Git
jthomas commented on issue #76: Add type support for annotations and limits
URL:
https://github.com/apache/incubator-openwhisk-client-js/pull/76#issuecomment-336813254
LGTM.
This is an automated message from the Apache Git
eave it this way and then reconfigure on a per-test-basis if necessary.
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
.
However, this is invalid with multiple Controller. Is there anything I
didn't noticed or I made a mistake on that code snippet?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub
dubeejw commented on issue #2855: Cache database attachments
URL:
https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-336660943
PG3 1186 ?
This is an automated message from the Apache Git Service
to develop
this model of composition via _combinators_ and welcome feedback.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment
this
model of composition via _combinators_ and welcome feedback.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries
actions, and also
forwarding parameters around sequence segments.
https://github.com/ibm-functions/composer.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
to the dev list a little while ago). Can we augment the jenkins job
to also publish kube-specific images?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above
)
Review comment:
Not sure we will ever get here. Since I think the function in map will work
even for an empty string.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
1 - 100 of 7292 matches
Mail list logo
