[GitHub] csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file." URL: https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392125914 I see it looks like it only cause problems with generating the logs. But the gradle task continue

[GitHub] csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file." URL: https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392125914 I see it looks like it only cause problems with generating the logs. But the gradle task continue

[GitHub] csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file." URL: https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392119885 Yeah I see Travis is 💚 but I see the failure https://travis-ci.org/apache/incubator-openwhisk/job

[GitHub] csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file." URL: https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392119132 Now that I think about it how come Travis didn't catch this problem in the PR that introduce the he

[GitHub] csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file." URL: https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392118771 @cbickel @jeremiaswerner since you reverted and took the ASF license header, What do you think of h

[GitHub] csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file." URL: https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392118771 @cbickel @jeremiaswerner since you reverted and took the ASF license header out, What do you think

[GitHub] csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file." URL: https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392118219 @mrutkows ^^ This is an automated

[GitHub] csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file." URL: https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392118167 yeah it looks having the `` at the top is the solution and adjust the code scan to assume that xml

[GitHub] csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file." URL: https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392023366 For the most part all files should have an ASF header, if someone can proposed how can we get the x

[GitHub] csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file." URL: https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392022849 What’s the root cause? How do we fix instead of doing a drastic revert with no other options being

[GitHub] csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file." URL: https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392022657 That’s odd how come adding comments at the top of an xml brakes functionality? ---