[GitHub] lornajane commented on issue #3244: Move parameter docs to separate page, add package params docs

2018-02-13 Thread GitBox
lornajane commented on issue #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#issuecomment-365403918 Am I blocking this? I _think_ I've answered all the comments and this PR is ripe for another review, but

[GitHub] lornajane commented on issue #3244: Move parameter docs to separate page, add package params docs

2018-02-07 Thread GitBox
lornajane commented on issue #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#issuecomment-363866122 Some really good review comments here, can we review ALL the docs like this? :) I think we're really

[GitHub] lornajane commented on issue #3244: Move parameter docs to separate page, add package params docs

2018-02-06 Thread GitBox
lornajane commented on issue #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#issuecomment-363392611 I _thought_ I had linked to the parameters doc from everywhere where there already was (or I thought there

[GitHub] lornajane commented on issue #3244: Move parameter docs to separate page, add package params docs

2018-02-06 Thread GitBox
lornajane commented on issue #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#issuecomment-363378267 What a lovely thorough review! Changes made as requested.