lue-kle commented on a change in pull request #3382: Cleanup script for unused entities in the whisks database. URL: https://github.com/apache/incubator-openwhisk/pull/3382#discussion_r172975758
########## File path: tools/db/cleanUpWhisks.py ########## @@ -0,0 +1,150 @@ +#!/usr/bin/env python +"""Python script to delete whisks entries having none existent ns. + +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +""" + +import argparse +import time +import couchdb.client + +skipWhisks = 0 + +try: + long # Python 2 +except NameError: + long = int # Python 3 + +HOUR = 1000 * 60 * 60 +DAY = HOUR * 24 + +# +# simple ring buffer like list +# +class SimpleRingBuffer: + def __init__(self, size): + self.index = -1 + self.data = [] + self.maxsize = size * 2 + + def append(self, ns, bool): + + self.index=(self.index+2)%self.maxsize + + if len(self.data) < self.maxsize: + self.data.append(ns) + self.data.append(bool) Review comment: sure we can use tuples, would than require two checks if the ns exists in the cache. I would suggest to do this change when adapting the script to be used also for kafka and cloudant trigger dbs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
