[GitHub] rabbah commented on issue #41: remove use of state in nodejs app

2018-05-25 Thread GitBox
rabbah commented on issue #41: remove use of state in nodejs app URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/41#issuecomment-392063629 Yes. This is an automated message from the Apache Git

[GitHub] rabbah commented on issue #41: remove use of state in nodejs app

2018-05-24 Thread GitBox
rabbah commented on issue #41: remove use of state in nodejs app URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/41#issuecomment-391913875 @tysonnorris could we factor out the changes to `ActionContainer` to break the cyclic dependence? I looked over those specific

[GitHub] rabbah commented on issue #41: remove use of state in nodejs app

2018-04-23 Thread GitBox
rabbah commented on issue #41: remove use of state in nodejs app URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/41#issuecomment-383641601 Indeed this is legacy defensive code but it has been observed to still catch some lifecycle management bugs in recent memory.

[GitHub] rabbah commented on issue #41: remove use of state in nodejs app

2018-04-23 Thread GitBox
rabbah commented on issue #41: remove use of state in nodejs app URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/41#issuecomment-383641601 Indeed this is legacy defensive code but it has been observed to still catch some lifecycle management bugs in recent memory.