[GitHub] klcodanr opened a new pull request #113: Improve Maven/Java Tooling
klcodanr opened a new pull request #113: Improve Maven/Java Tooling URL: https://github.com/apache/incubator-openwhisk-devtools/pull/113 I added some new features to improve the Java tooling for OpenWhisk: - Annotations which indicate Actions, Packages, Rules and Triggers at a Class level - Maven plugin to parse the annotations and automatically install the code into OpenWhisk during maven builds I provided some documentation and reorganized the repo a bit to group the Java dev tools. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yumeforever commented on issue #1825: Support triggers and rules under package?
yumeforever commented on issue #1825: Support triggers and rules under package? URL: https://github.com/apache/incubator-openwhisk/issues/1825#issuecomment-380799052 Any news on this thread? Any other suggested threads to follow? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #106: Check the LICENSE of achieved files in source codes
houshengbo commented on issue #106: Check the LICENSE of achieved files in source codes URL: https://github.com/apache/incubator-openwhisk-release/issues/106#issuecomment-380849370 @daisy-ycguo @mrutkows In my opinion, all the license concerns raised in this issue come from the license under the files of test cases. I have submitted a PR to exclude the files of test cases out of the source code artifacts we are about to release. The test cases are used to guard the quality of the source code, and they do not play a part of the features of openwhisk we deliver. They do not contribute to the process to build the binaries and docker images either. The test cases are developer-orientated, not end user-orientated. My suggestion is that we can tentatively skip all the licenses going through all the files of test cases for the release process. In future, if we still want to release the "test" separately, we can come over to tackle the licenses for test cases during the release process. However, this issue can leave us a probable low-priority issue, that whether it is worthy to think of license and avoid the unfriendly licenses, when we write new tests; whether we should rewrite the test cases with apache or apache friendly licenses. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #108: Some files in openwhisk-apigateway still have bad headers
houshengbo commented on issue #108: Some files in openwhisk-apigateway still have bad headers URL: https://github.com/apache/incubator-openwhisk-release/issues/108#issuecomment-380850409 I opened the same issue for apigateway repo: https://github.com/apache/incubator-openwhisk-apigateway/issues/288 to raise their concerns. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #108: Some files in openwhisk-apigateway still have bad headers
houshengbo commented on issue #108: Some files in openwhisk-apigateway still have bad headers URL: https://github.com/apache/incubator-openwhisk-release/issues/108#issuecomment-380850409 I opened the same issue for apigateway repo: https://github.com/apache/incubator-openwhisk-apigateway/issues/288 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #106: Check the LICENSE of achieved files in source codes
houshengbo commented on issue #106: Check the LICENSE of achieved files in source codes URL: https://github.com/apache/incubator-openwhisk-release/issues/106#issuecomment-380849370 @daisy-ycguo @mrutkows In my opinion, all the license concerns raised in this issue come from the files of test cases. I have submitted a PR to exclude the files of test cases out of the source code artifacts we are about to release. The test cases are used to safeguard the quality of the source code, and they do not play parts of the features of openwhisk, we deliver. Plus, they do not contribute to the process to build the binaries and docker images either. The test cases are developer-orientated, not end user-orientated. My suggestion is that we can tentatively skip all the licenses going through all the files of test cases for the release process. In future, if we still want to release the "test" separately, we can come over to tackle the licenses for test cases during the release process. However, this issue can leave us a probable low-priority issue, that whether it is worthy to think of license and avoid the unfriendly licenses, when we write new tests; whether we should rewrite the test cases with apache or apache friendly licenses. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on a change in pull request #3541: Point Getting Started to docker-compose
csantanapr commented on a change in pull request #3541: Point Getting Started to docker-compose URL: https://github.com/apache/incubator-openwhisk/pull/3541#discussion_r181151539 ## File path: README.md ## @@ -25,15 +25,27 @@ OpenWhisk is a cloud-first distributed event-based programming service. It provides a programming model to upload event handlers to a cloud service, and register the handlers to respond to various events. Learn more at [http://openwhisk.incubator.apache.org](http://openwhisk.incubator.apache.org). -* [Quick Start](#quick-start) (Vagrant) +* [Quick Start](#quick-start) (Docker-Compose) +* [Vagrant](#vagrant-setup) Review comment: Move Vagrant down after native Add (Windows) [Vagrant](#vagrant-setup) (Windows) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd commented on issue #114: docker-compose doesn't work unless I close chrome
ddragosd commented on issue #114: docker-compose doesn't work unless I close chrome URL: https://github.com/apache/incubator-openwhisk-devtools/issues/114#issuecomment-380884869 Thanks @csantanapr . One idea I have here is to check on which IP is the PORT bound to, in order to avoid this false negative. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on a change in pull request #3541: Point Getting Started to docker-compose
csantanapr commented on a change in pull request #3541: Point Getting Started to docker-compose URL: https://github.com/apache/incubator-openwhisk/pull/3541#discussion_r181151734 ## File path: README.md ## @@ -25,15 +25,27 @@ OpenWhisk is a cloud-first distributed event-based programming service. It provides a programming model to upload event handlers to a cloud service, and register the handlers to respond to various events. Learn more at [http://openwhisk.incubator.apache.org](http://openwhisk.incubator.apache.org). Review comment: Add (Mac and Linux) to quick start line This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #106: Check the LICENSE of achieved files in source codes
mrutkows commented on issue #106: Check the LICENSE of achieved files in source codes URL: https://github.com/apache/incubator-openwhisk-release/issues/106#issuecomment-380886204 @daisy-ycguo @houshengbo We should use the issues already created to track by repo. IMO. **Issues:** openwhisk (LICENSE): https://github.com/apache/incubator-openwhisk-release/issues/93 openwhisk (NOTICE): https://github.com/apache/incubator-openwhisk-release/issues/75 openwhisk-cli (LICENSE): https://github.com/apache/incubator-openwhisk-release/issues/97 openwhisk-cli (NOTICE): https://github.com/apache/incubator-openwhisk-release/issues/76 ... and so forth. we should then start examining the specifics for main openwhisk repo., come decisions based upon these test files after discussion in those issues THEN apply the same principles/rules to the other repos. Of course, we should allow for special cases for each repo. therefore, we have separate issues to track these discussions of special cases. Let us examine first the details of the files for main openwhisk as it should prove to be the most challenging and many more contributors will comment and hopefully help us agree what our community wants to do. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #109: Update LICENSE files to append license information of dependencies
houshengbo commented on issue #109: Update LICENSE files to append license information of dependencies URL: https://github.com/apache/incubator-openwhisk-release/issues/109#issuecomment-380852528 @daisy-ycguo Sure. If we decided to remove the files of test cases from the source code release, we do not need to append the licenses coming from the tests. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mcdan commented on issue #3541: Point Getting Started to docker-compose
mcdan commented on issue #3541: Point Getting Started to docker-compose URL: https://github.com/apache/incubator-openwhisk/pull/3541#issuecomment-380861354 @chetanmeh currently getting a windows VM running so I can check on that for you. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #114: docker-compose doesn't work unless I close chrome
csantanapr commented on issue #114: docker-compose doesn't work unless I close chrome URL: https://github.com/apache/incubator-openwhisk-devtools/issues/114#issuecomment-380891891 Side question any posiblity of having the Makefile work on Windows even if required bash on Windows ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #114: docker-compose doesn't work unless I close chrome
csantanapr commented on issue #114: docker-compose doesn't work unless I close chrome URL: https://github.com/apache/incubator-openwhisk-devtools/issues/114#issuecomment-380891891 Side question any posiblity of having the male file work on Windows even if required bash on Windows ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee closed pull request #3538: Code clean up in test suites
dubee closed pull request #3538: Code clean up in test suites
URL: https://github.com/apache/incubator-openwhisk/pull/3538
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tests/src/test/scala/system/basic/WskBasicTests.scala
b/tests/src/test/scala/system/basic/WskBasicTests.scala
index 6584a1c6b8..6b33086152 100644
--- a/tests/src/test/scala/system/basic/WskBasicTests.scala
+++ b/tests/src/test/scala/system/basic/WskBasicTests.scala
@@ -193,20 +193,20 @@ class WskBasicTests extends TestHelpers with
WskTestHelpers {
}
val stderr = wsk.pkg.create(name, expectedExitCode =
Conflict.intValue).stderr
- stderr should include regex ("""resource already exists""")
+ stderr should include("resource already exists")
}
it should "reject delete of package that does not exist" in {
val name = "nonexistentPackage"
val stderr = wsk.pkg.delete(name, expectedExitCode =
NotFound.intValue).stderr
-stderr should include regex ("""The requested resource does not exist.""")
+stderr should include("The requested resource does not exist.")
}
it should "reject get of package that does not exist" in {
val name = "nonexistentPackage"
val ns = wsk.namespace.whois()
val stderr = wsk.pkg.get(name, expectedExitCode = NotFound.intValue).stderr
-stderr should include regex (s"""The requested resource '$ns/$name' does
not exist""")
+stderr should include(s"The requested resource '$ns/$name' does not exist")
}
behavior of "Wsk Action REST"
@@ -252,25 +252,25 @@ class WskBasicTests extends TestHelpers with
WskTestHelpers {
}
val stderr = wsk.action.create(name, file, expectedExitCode =
Conflict.intValue).stderr
- stderr should include regex ("""resource already exists""")
+ stderr should include("resource already exists")
}
it should "reject delete of action that does not exist" in {
val name = "nonexistentAction"
val stderr = wsk.action.delete(name, expectedExitCode =
NotFound.intValue).stderr
-stderr should include regex ("""The requested resource does not exist.""")
+stderr should include("The requested resource does not exist.")
}
it should "reject invocation of action that does not exist" in {
val name = "nonexistentAction"
val stderr = wsk.action.invoke(name, expectedExitCode =
NotFound.intValue).stderr
-stderr should include regex ("""The requested resource does not exist.""")
+stderr should include("The requested resource does not exist.")
}
it should "reject get of an action that does not exist" in {
val name = "nonexistentAction"
val stderr = wsk.action.get(name, expectedExitCode =
NotFound.intValue).stderr
-stderr should include regex ("""The requested resource does not exist.""")
+stderr should include("The requested resource does not exist.")
}
it should "create, and invoke an action that utilizes a docker container" in
withAssetCleaner(wskprops) {
@@ -697,25 +697,25 @@ class WskBasicTests extends TestHelpers with
WskTestHelpers {
}
val stderr = wsk.trigger.create(name, expectedExitCode =
Conflict.intValue).stderr
- stderr should include regex ("""resource already exists""")
+ stderr should include("resource already exists")
}
it should "reject delete of trigger that does not exist" in {
val name = "nonexistentTrigger"
val stderr = wsk.trigger.delete(name, expectedExitCode =
NotFound.intValue).stderr
-stderr should include regex ("""The requested resource does not exist.""")
+stderr should include("The requested resource does not exist.")
}
it should "reject get of trigger that does not exist" in {
val name = "nonexistentTrigger"
val stderr = wsk.trigger.get(name, expectedExitCode =
NotFound.intValue).stderr
-stderr should include regex ("""The requested resource does not exist.""")
+stderr should include("The requested resource does not exist.")
}
it should "reject firing of a trigger that does not exist" in {
val name = "nonexistentTrigger"
val stderr = wsk.trigger.fire(name, expectedExitCode =
NotFound.intValue).stderr
-stderr should include regex ("""The requested resource does not exist.""")
+stderr should include("The requested resource does not exist.")
}
it should "create and fire a trigger with a rule whose action has been
deleted" in withAssetCleaner(wskprops) {
@@ -969,37 +969,37 @@ class WskBasicTests extends TestHelpers with
WskTestHelpers {
wsk.rule
.create(ruleName, trigger = triggerName, action = actionName,
expectedExitCode = Conflict.intValue)
.stderr
- stderr should include regex ("""resource already
[GitHub] mhamann commented on issue #288: Apache release does not allow to have private license as the header
mhamann commented on issue #288: Apache release does not allow to have private license as the header URL: https://github.com/apache/incubator-openwhisk-apigateway/issues/288#issuecomment-380951190 @ddragosd I think that between Adobe and IBM, we own the original copyright to these files. If that's correct, we should be able to switch everything to the Apache 2.0 license if authorized by you and I collectively. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mhamann commented on issue #288: Apache release does not allow to have private license as the header
mhamann commented on issue #288: Apache release does not allow to have private license as the header URL: https://github.com/apache/incubator-openwhisk-apigateway/issues/288#issuecomment-380951190 @ddragosd I think that between Adobe and IBM, we own the original copyright to these files. If that's correct, we should be able to switch everything to the Apache 2.0 license if authorized by you and me collectively. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] drcariel commented on issue #270: use utils from open and rename duplicate tests to be accurate
drcariel commented on issue #270: use utils from open and rename duplicate tests to be accurate URL: https://github.com/apache/incubator-openwhisk-cli/pull/270#issuecomment-380957183 I've created https://github.com/apache/incubator-openwhisk/pull/3545 to add it back. I am also removing the `tests\dat\actions` and `test\dat\apigw` test dirs here... I will make sure `incubator-openwhisk` has the complete set of test actions tomorrow This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gorkem commented on issue #113: Improve Maven/Java Tooling
gorkem commented on issue #113: Improve Maven/Java Tooling URL: https://github.com/apache/incubator-openwhisk-devtools/pull/113#issuecomment-380962083 @ddragosd sure, looking at it This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new issue #115: make docker failes with Project 'swift3Action' not found in project ':core'.
csantanapr opened a new issue #115: make docker failes with Project 'swift3Action' not found in project ':core'. URL: https://github.com/apache/incubator-openwhisk-devtools/issues/115 Docker for Mac steps to replicate ``` $ make docker building the docker images ... Starting a Gradle Daemon (subsequent builds will be faster) FAILURE: Build failed with an exception. * What went wrong: Project 'swift3Action' not found in project ':core'. * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. * Get more help at https://help.gradle.org BUILD FAILED in 5s make: *** [docker] Error 1 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3544: make docker failes with Project 'swift3Action' not found in project ':core'.
csantanapr commented on issue #3544: make docker failes with Project 'swift3Action' not found in project ':core'. URL: https://github.com/apache/incubator-openwhisk/issues/3544#issuecomment-380953550 wrong repo, correct place -> https://github.com/apache/incubator-openwhisk-devtools/issues/115 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] drcariel opened a new pull request #3545: add timeout.js back
drcariel opened a new pull request #3545: add timeout.js back URL: https://github.com/apache/incubator-openwhisk/pull/3545 needed for https://github.com/apache/incubator-openwhisk-cli/pull/270 to pass ## Description ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [x] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on a change in pull request #862: Documentation for the export feature
pritidesai commented on a change in pull request #862: Documentation for the export feature URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/862#discussion_r181238677 ## File path: docs/export.md ## @@ -0,0 +1,300 @@ +# Using `wskdeploy` for exporting `OpenWhisk` assets + +`wskdeploy export` can be used to export `OpenWhisk` assets previously deployed as a *managed project* via `wskdeploy sync -m manifest.yaml`. `wskdeploy export` will create a manifest for the managed project assets and separate manifests for each managed project that this managed project depends upon, if such dependencies exist and have been described in `manifest.yml` when the managed project has been initially deployed. +The manifest(s) resulting from executing `wskdeploy export` can be later used for deploying at a different `OpenWhisk` instance. The code of actions, which are defined in the packages of the exported project will be saved into folders with the names being the names of the package, the actions belong to. + +## Use Cases + +### Copy `OpenWhisk` Assets + +One common scenario, in which the export feature is useful, is populating a newly installed `OpenWhisk` instance with assets from +another `OpenWhisk` instance. One might consider a scenario, in which an `OpenWhisk` instance is installed on premises with another `OpenWhisk` instance residing in the cloud. Consider, for example using one `OpenWhisk` instance on premises and another one in the cloud (e.g., the second `OpenWhisk` instance can be [IBM Cloud Functions](https://console.bluemix.net/openwhisk/)). A fairly common scenario is that a developer Review comment: @davidbreitgand let me know once you have modified it so that we can merge your doc. thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] drcariel closed pull request #270: use utils from open and rename duplicate tests to be accurate
drcariel closed pull request #270: use utils from open and rename duplicate
tests to be accurate
URL: https://github.com/apache/incubator-openwhisk-cli/pull/270
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tests/src/test/scala/common/TestCLIUtils.scala
b/tests/src/test/scala/common/TestCLIUtils.scala
deleted file mode 100644
index de824b15..
--- a/tests/src/test/scala/common/TestCLIUtils.scala
+++ /dev/null
@@ -1,32 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package common
-
-object TestCLIUtils {
-
-def getTestActionFilename(fileName: String): String = {
-val testDir = scala.util.Properties.userDir.toString()
-s"$testDir/dat/actions/$fileName"
-}
-
-def getTestApiGwFilename(fileName: String): String = {
-val testDir = scala.util.Properties.userDir.toString()
-s"$testDir/dat/apigw/$fileName"
-}
-
-}
diff --git a/tests/src/test/scala/system/basic/WskCliActionTests.scala
b/tests/src/test/scala/system/basic/WskCliActionTests.scala
index 7e008bfc..042f0bd3 100644
--- a/tests/src/test/scala/system/basic/WskCliActionTests.scala
+++ b/tests/src/test/scala/system/basic/WskCliActionTests.scala
@@ -20,7 +20,7 @@ package system.basic
import org.junit.runner.RunWith
import org.scalatest.junit.JUnitRunner
-import common.TestCLIUtils
+import common.TestUtils
import common.TestUtils.NOT_ALLOWED
import common.Wsk
@@ -29,7 +29,7 @@ class WskCliActionTests extends WskActionTests {
override val wsk = new Wsk
it should "not be able to use --kind and --docker at the same time when
running action create or update" in {
-val file = TestCLIUtils.getTestActionFilename(s"echo.js")
+val file = TestUtils.getTestActionFilename(s"echo.js")
Seq(false, true).foreach { updateValue =>
val out = wsk.action.create(name = "kindAndDockerAction", artifact =
Some(file), expectedExitCode = NOT_ALLOWED,
kind = Some("nodejs:6"), docker = Some("mydockerimagename"), update =
updateValue)
diff --git a/tests/src/test/scala/system/basic/WskBasicTests.scala
b/tests/src/test/scala/system/basic/WskCliBasicTests.scala
similarity index 94%
rename from tests/src/test/scala/system/basic/WskBasicTests.scala
rename to tests/src/test/scala/system/basic/WskCliBasicTests.scala
index 27595784..b39ef39e 100644
--- a/tests/src/test/scala/system/basic/WskBasicTests.scala
+++ b/tests/src/test/scala/system/basic/WskCliBasicTests.scala
@@ -27,7 +27,6 @@ import org.scalatest.junit.JUnitRunner
import common.ActivationResult
import common.TestHelpers
-import common.TestCLIUtils
import common.TestUtils
import common.TestUtils._
import common.Wsk
@@ -39,20 +38,12 @@ import spray.json.pimpAny
import whisk.http.Messages
-object WskCliTestHelpers {
- /**
-* Append the current timestamp in ms
-*/
- def withTimestamp(text: String) = s"${text}-${System.currentTimeMillis}"
-
-}
-
@RunWith(classOf[JUnitRunner])
-class WskBasicTests extends TestHelpers with WskTestHelpers {
+class WskCliBasicTests extends TestHelpers with WskTestHelpers {
implicit val wskprops = WskProps()
val wsk = new Wsk
- val defaultAction = Some(TestCLIUtils.getTestActionFilename("hello.js"))
+ val defaultAction = Some(TestUtils.getTestActionFilename("hello.js"))
behavior of "Wsk CLI"
@@ -197,7 +188,7 @@ class WskBasicTests extends TestHelpers with WskTestHelpers
{
it should "create, update, get and list an action" in
withAssetCleaner(wskprops) { (wp, assetHelper) =>
val name = "createAndUpdate"
-val file = Some(TestCLIUtils.getTestActionFilename("hello.js"))
+val file = Some(TestUtils.getTestActionFilename("hello.js"))
val params = Map("a" -> "A".toJson)
assetHelper.withCleaner(wsk.action, name) { (action, _) =>
action.create(name, file, parameters = params)
@@ -216,7 +207,7 @@ class WskBasicTests extends TestHelpers with WskTestHelpers
{
it should "reject create of an action that already exists" in
[GitHub] drcariel opened a new pull request #270: use utils from open and rename duplicate tests to be accurate
drcariel opened a new pull request #270: use utils from open and rename duplicate tests to be accurate URL: https://github.com/apache/incubator-openwhisk-cli/pull/270 - Gets rid of TestCLIUtils entirely to rely on TestUtils in open repo. - Moves timestamp method to sed TestUtils - ~moves ApigwTests to open repo (if possible)~ - Renames Basic _and apigwtests_ tests to reflect what is being tested (the Cli) Companion to https://github.com/apache/incubator-openwhisk/pull/3531 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yadavvipinsonu commented on issue #2317: wsk api authentication issues
yadavvipinsonu commented on issue #2317: wsk api authentication issues
URL:
https://github.com/apache/incubator-openwhisk/issues/2317#issuecomment-38097
@mdeuser thansk for your response !
Based on your comments i tried to install routemgmt.yml file and got below
error
TASK [cli-install : Grab the local CLI from the binaries unarchived into
nginx] *
Thursday 12 April 2018 16:07:52 -0400 (0:00:02.050) 0:00:07.612
fatal: [ansible]: FAILED! => {"changed": false, "dest":
"/home/mparuthickal/openwhisk/ansible/../bin", "gid": 0, "group": "root",
"mode": "0755", "msg": "Request failed", "owner": "mparuthickal", "response":
"HTTP Error 404: Not Found", "size": 4096, "state": "directory", "status_code":
404, "uid": 30040, "url":
"**https://172.17.0.1/cli/go/download/linux/amd64/wsk**"}
Request failed
PLAY RECAP
**
ansible: ok=4changed=1unreachable=0failed=1
Thursday 12 April 2018 16:07:52 -0400 (0:00:00.493) 0:00:08.106
===
Gathering Facts
and one more error i get when trying to run openwhisk.yml file
TASK [cli : Download release archive to build directory ...]
Thursday 12 April 2018 16:19:49 -0400 (0:00:00.359) 0:01:31.037
fatal: [172.17.0.1]: FAILED! => {"changed": false, "msg": "Failed to connect
to github-production-release-asset-2e65be.s3.amazonaws.com at port 443: [Errno
-2] Name or service not known"}
Failed to connect to github-production-release-asset-
2e65be.s3.amazonaws.com at port 443: [Errno -2] Name or service not known
PLAY RECAP
**
172.17.0.1 : ok=10 changed=2unreachable=0failed=1
In first error its trying to download somefile from 172.17.0.1 --- which i
believe is the cause of error ? where and what should i change to avoid this
error.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] drcariel commented on issue #270: use utils from open and rename duplicate tests to be accurate
drcariel commented on issue #270: use utils from open and rename duplicate tests to be accurate URL: https://github.com/apache/incubator-openwhisk-cli/pull/270#issuecomment-380957183 I've created https://github.com/apache/incubator-openwhisk/pull/3545 to add it back. I am also removing the `tests\dat\actions` and `test\dat\apigw` test dirs This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] drcariel commented on issue #270: use utils from open and rename duplicate tests to be accurate
drcariel commented on issue #270: use utils from open and rename duplicate tests to be accurate URL: https://github.com/apache/incubator-openwhisk-cli/pull/270#issuecomment-380957183 I've created https://github.com/apache/incubator-openwhisk/pull/3545 to add it back. I am also removing the `tests\dat\actions` and `test\dat\apigw` test dirs here... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tysonnorris opened a new issue #3542: wsk action get --save should work for docker actions
tysonnorris opened a new issue #3542: wsk action get --save should work for docker actions URL: https://github.com/apache/incubator-openwhisk/issues/3542 ## Environment details: * local deployment ## Steps to reproduce the issue: 1. create a docker action e.g. `wsk action create test --docker alpine:3.6 test.js` 2. get action with `--save` e.g. `wsk action get test --save` 3. result: `error: Cannot save Docker images` ## Provide the expected results and outputs: ``` ok: saved action code to ... ``` ## Provide the actual results and outputs: ``` error: Cannot save Docker images ``` ## Additional information you deem important: * I'm not sure if there is a particular reason this code (not the docker image!) should not be savable? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee closed pull request #3531: More test clean up
dubee closed pull request #3531: More test clean up
URL: https://github.com/apache/incubator-openwhisk/pull/3531
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tests/build.gradle b/tests/build.gradle
index 70eaa309c2..df0ab0dce0 100644
--- a/tests/build.gradle
+++ b/tests/build.gradle
@@ -26,7 +26,7 @@ task testLean(type: Test) {
exclude '**/*Java*'
exclude '**/*ThrottleTests*'
exclude '**/MaxActionDurationTests*'
-exclude '**/*ApiGwTests*'
+exclude '**/*ApiGwRestBasicTests*'
exclude '**/*WskCli*'
}
@@ -36,7 +36,7 @@ task testLeanCli(type: Test) {
exclude '**/*Java*'
exclude '**/*ThrottleTests*'
exclude '**/MaxActionDurationTests*'
-exclude '**/*ApiGwTests*'
+exclude '**/*ApiGwRestBasicTests*'
exclude '**/*Rest*'
}
diff --git a/tests/src/test/scala/common/Wsk.scala
b/tests/src/test/scala/common/Wsk.scala
index e15f030296..f7f03f6bbb 100644
--- a/tests/src/test/scala/common/Wsk.scala
+++ b/tests/src/test/scala/common/Wsk.scala
@@ -743,7 +743,7 @@ class WskNamespace() extends RunWskCmd with
FullyQualifiedNames with BaseNamespa
* @return namespace as string
*/
override def whois()(implicit wskprops: WskProps): String = {
-// the invariant that list() returns a conforming result is enforced in a
test in WskBasicTests
+// the invariant that list() returns a conforming result is enforced in a
test in WskRestBasicTests
val ns = list().stdout.lines.toSeq.last.trim
assert(ns != "_") // this is not permitted
ns
diff --git a/tests/src/test/scala/common/WskTestHelpers.scala
b/tests/src/test/scala/common/WskTestHelpers.scala
index 57a5442ed8..7c948bf79e 100644
--- a/tests/src/test/scala/common/WskTestHelpers.scala
+++ b/tests/src/test/scala/common/WskTestHelpers.scala
@@ -294,4 +294,6 @@ trait WskTestHelpers extends Matchers {
wskadmin.cli(Seq("user", "delete", subject), expectedExitCode).stdout
should include("Subject deleted")
}
}
+ //Append the current timestamp in ms
+ def withTimestamp(text: String) = s"${text}-${System.currentTimeMillis}"
}
diff --git a/tests/src/test/scala/system/basic/WskConsoleTests.scala
b/tests/src/test/scala/system/basic/WskConsoleTests.scala
index 9df9bcb4c0..d03d346e89 100644
--- a/tests/src/test/scala/system/basic/WskConsoleTests.scala
+++ b/tests/src/test/scala/system/basic/WskConsoleTests.scala
@@ -46,11 +46,6 @@ abstract class WskConsoleTests extends TestHelpers with
WskTestHelpers {
val wsk: BaseWsk
val guestNamespace = wskprops.namespace
- /**
- * Append the current timestamp in ms
- */
- def withTimestamp(text: String) = s"${text}-${System.currentTimeMillis}"
-
behavior of "Wsk Activation Console"
it should "show an activation log message for hello world" in
withAssetCleaner(wskprops) { (wp, assetHelper) =>
diff --git a/tests/src/test/scala/system/basic/WskBasicTests.scala
b/tests/src/test/scala/system/basic/WskRestBasicTests.scala
similarity index 99%
rename from tests/src/test/scala/system/basic/WskBasicTests.scala
rename to tests/src/test/scala/system/basic/WskRestBasicTests.scala
index 6b33086152..7412f9b030 100644
--- a/tests/src/test/scala/system/basic/WskBasicTests.scala
+++ b/tests/src/test/scala/system/basic/WskRestBasicTests.scala
@@ -41,17 +41,12 @@ import spray.json.DefaultJsonProtocol._
import whisk.http.Messages
@RunWith(classOf[JUnitRunner])
-class WskBasicTests extends TestHelpers with WskTestHelpers {
+class WskRestBasicTests extends TestHelpers with WskTestHelpers {
implicit val wskprops: common.WskProps = WskProps()
val wsk: common.rest.WskRest = new WskRest
val defaultAction: Some[String] =
Some(TestUtils.getTestActionFilename("hello.js"))
- /**
- * Append the current timestamp in ms
- */
- def withTimestamp(text: String) = s"${text}-${System.currentTimeMillis}"
-
/**
* Retry operations that need to settle the controller cache
*/
diff --git a/tests/src/test/scala/system/basic/WskRuleTests.scala
b/tests/src/test/scala/system/basic/WskRuleTests.scala
index 279e330e5f..29c99eac54 100644
--- a/tests/src/test/scala/system/basic/WskRuleTests.scala
+++ b/tests/src/test/scala/system/basic/WskRuleTests.scala
@@ -74,11 +74,6 @@ abstract class WskRuleTests extends TestHelpers with
WskTestHelpers {
}
}
- /**
- * Append the current timestamp in ms
- */
- def withTimestamp(text: String) = s"$text-${System.currentTimeMillis}"
-
behavior of "Whisk rules"
it should "invoke the action attached on trigger fire, creating an
activation for each entity including the cause" in withAssetCleaner(
diff --git a/tests/src/test/scala/whisk/core/cli/test/ApiGwTests.scala
b/tests/src/test/scala/whisk/core/cli/test/ApiGwRestBasicTests.scala
[GitHub] csantanapr commented on issue #118: Errors on start-docker-compose
csantanapr commented on issue #118: Errors on start-docker-compose URL: https://github.com/apache/incubator-openwhisk-devtools/issues/118#issuecomment-380964539 I was able to fix this by running `docker-compose up` and I got prompted and type `y` ``` ERROR: The image for the service you're trying to recreate has been removed. If you continue, volume data could be lost. Consider backing up your data before continuing. Continue with the new image? [yN]y ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #118: Errors on start-docker-compose
csantanapr closed issue #118: Errors on start-docker-compose URL: https://github.com/apache/incubator-openwhisk-devtools/issues/118 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd commented on issue #113: Improve Maven/Java Tooling
ddragosd commented on issue #113: Improve Maven/Java Tooling URL: https://github.com/apache/incubator-openwhisk-devtools/pull/113#issuecomment-380949388 @klcodanr this looks really nice. One thought I have is regarding the deploy process. Are you familiar with [wskdeploy](https://github.com/apache/incubator-openwhisk-wskdeploy) ? It has more logic to deploy, update, delete, remove what's changed, etc. I'm wondering if it would be a cleaner approach if we were to use the Java Annotations to generate a `wskdeploy` manifest file, and then invoke `wskdeploy` from maven ? cc @mrutkows This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #3544: make docker failes with Project 'swift3Action' not found in project ':core'.
csantanapr closed issue #3544: make docker failes with Project 'swift3Action' not found in project ':core'. URL: https://github.com/apache/incubator-openwhisk/issues/3544 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3543: [discuss] docker compose make quick start hangs
csantanapr commented on issue #3543: [discuss] docker compose make quick start hangs URL: https://github.com/apache/incubator-openwhisk/issues/3543#issuecomment-380953753 wrong repo, correct place https://github.com/apache/incubator-openwhisk-devtools/issues/116 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new issue #116: docker compose make quick start hangs
csantanapr opened a new issue #116: docker compose make quick start hangs URL: https://github.com/apache/incubator-openwhisk-devtools/issues/116 This is a problem I keep hitting. After a while, I would have an old version of `openwhisk/controller:latest` locally. When running `make quick-start` with all defaults it will try to use the local old image, and the controller controller will not start or not start correctly. How can we make this bullet proof for the default case quick start. Add a download step to download the images by default every time? cc @ddragosd This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #3543: [discuss] docker compose make quick start hangs
csantanapr closed issue #3543: [discuss] docker compose make quick start hangs URL: https://github.com/apache/incubator-openwhisk/issues/3543 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on a change in pull request #3541: Point Getting Started to docker-compose
csantanapr commented on a change in pull request #3541: Point Getting Started to docker-compose URL: https://github.com/apache/incubator-openwhisk/pull/3541#discussion_r181243430 ## File path: .project ## @@ -5,6 +5,11 @@ + + org.eclipse.buildship.core.gradleprojectbuilder Review comment: Are you one of those that do `git add .` ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on a change in pull request #3541: Point Getting Started to docker-compose
csantanapr commented on a change in pull request #3541: Point Getting Started to docker-compose URL: https://github.com/apache/incubator-openwhisk/pull/3541#discussion_r181243225 ## File path: mesos.env ## @@ -0,0 +1 @@ +CONFIG_whisk_mesos_master-url = "http://m1.dcos; Review comment: what's this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] drcariel commented on issue #270: use utils from open and rename duplicate tests to be accurate
drcariel commented on issue #270: use utils from open and rename duplicate tests to be accurate URL: https://github.com/apache/incubator-openwhisk-cli/pull/270#issuecomment-380955318 ugh, so I should go add timeout.js back to `incubator-openwhisk`? or just not make any changes to `CLIUtils`? I feel like ideally we should use a single test Utils helper and a single copy of each action code, not a separate actions dir in each repo This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] drcariel commented on issue #270: use utils from open and rename duplicate tests to be accurate
drcariel commented on issue #270: use utils from open and rename duplicate tests to be accurate URL: https://github.com/apache/incubator-openwhisk-cli/pull/270#issuecomment-380955318 ugh, so I should go add timeout.js back to `incubator-openwhisk`? or just not make any changes to `CLIUtils`? I feel like ideally we should use a single test Utils helper and a single copy of each action code This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #270: use utils from open and rename duplicate tests to be accurate
rabbah commented on issue #270: use utils from open and rename duplicate tests to be accurate URL: https://github.com/apache/incubator-openwhisk-cli/pull/270#issuecomment-380969762 Oh never mind this is the cli repo. Good move. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd commented on issue #113: Improve Maven/Java Tooling
ddragosd commented on issue #113: Improve Maven/Java Tooling URL: https://github.com/apache/incubator-openwhisk-devtools/pull/113#issuecomment-380950703 @kameshsampath @gorkem may I ask for your help reviewing this PR, since you made the initial java contributions ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new issue #3543: [discuss] docker compose make quick start hangs
csantanapr opened a new issue #3543: [discuss] docker compose make quick start hangs URL: https://github.com/apache/incubator-openwhisk/issues/3543 This is a problem I keep hitting. After a while, I would have an old version of `openwhisk/controller:latest` locally. When running `make quick-start` with all defaults it will try to use the local old image, and the controller controller will not start or not start correctly. How can we make this bullet proof for the default case quick start. Add a download step to download the images by default every time? cc @ddragosd This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #117: do docker pull for quick start
csantanapr opened a new pull request #117: do docker pull for quick start URL: https://github.com/apache/incubator-openwhisk-devtools/pull/117 Closes #116 Closes #115 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #270: use utils from open and rename duplicate tests to be accurate
rabbah commented on issue #270: use utils from open and rename duplicate tests to be accurate URL: https://github.com/apache/incubator-openwhisk-cli/pull/270#issuecomment-380969610 Wait - why are all the samples being deleted here? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new issue #118: Errors on start-docker-compose
csantanapr opened a new issue #118: Errors on start-docker-compose URL: https://github.com/apache/incubator-openwhisk-devtools/issues/118 I get this error when running docker compose ``` waiting for the database to come up ... on 9.27.118.111 Starting openwhisk_redis_1 ... done Starting openwhisk_db_1... done Starting openwhisk_zookeeper_1 ... done Starting openwhisk_kafka_1 ... done Recreating openwhisk_controller_1 ... Recreating openwhisk_invoker_1... error Starting openwhisk_kafka-rest_1 ... Recreating openwhisk_controller_1 ... error ERROR: for openwhisk_invoker_1 no such image: sha256:084ed5bb83ac0f2b67e33dd8d07a675a594c5b193dc0a3008f7895d4192903a2: No such image: sha256:084ed5bb83ac0f2b67e33dd8d07a675a594c5b193dc0a3008f7895d4192903a2 ERROR: for openwhisk_controller_1 no such image: sha256:429e3ff2b94ce6e0c6889e4873d3f632f83db880b5754c4ed3fe31d0ef58851f: No such image: sha2Starting openwhisk_kafka-rest_1 ... done Starting openwhisk_kafka-topics-ui_1 ... done ERROR: for invoker no such image: sha256:084ed5bb83ac0f2b67e33dd8d07a675a594c5b193dc0a3008f7895d4192903a2: No such image: sha256:084ed5bb83ac0f2b67e33dd8d07a675a594c5b193dc0a3008f7895d4192903a2 ERROR: for controller no such image: sha256:429e3ff2b94ce6e0c6889e4873d3f632f83db880b5754c4ed3fe31d0ef58851f: No such image: sha256:429e3ff2b94ce6e0c6889e4873d3f632f83db880b5754c4ed3fe31d0ef58851f ERROR: The image for the service you're trying to recreate has been removed. If you continue, volume data could be lost. Consider backing up your data before continuing. ERROR: no such image: sha256:429e3ff2b94ce6e0c6889e4873d3f632f83db880b5754c4ed3fe31d0ef58851f: No such image: sha256:429e3ff2b94ce6e0c6889e4873d3f632f83db880b5754c4ed3fe31d0ef58851f ``` This is after downloading all docker images from dockerhub for controller and invoker cc @ddragosd This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation
chetanmeh commented on issue #3517: MemoryArtifactStore for unit testing and
ArtifactStore SPI Validation
URL:
https://github.com/apache/incubator-openwhisk/pull/3517#issuecomment-381031566
@rabbah Currently there is a ignored test `count with skip` in
`ArtifactStoreQueryBehaviors` as it fails for CouchDB. Looks like a count call
with skip does not work as intended so that flow does not work
```
$ curl -H 'Host: localhost:5984' -H 'Authorization: Basic
d2hpc2tfYWRtaW46c29tZV9wYXNzdzByZA==' -H 'Accept: application/json' -H
'User-Agent: akka-http/10.0.10'
'http://localhost:5984/whisk_local_activations/_design/whisks-filters.v2.1.0/_view/activations?startkey=%5B%22artifactTCK_aAAS_ns_zKXPz/testact%22,0%5D=%5B%22artifactTCK_aAAS_ns_zKXPz/testact%22,%22%EF%BF%B0%22,%22%EF%BF%B0%22%5D=4=true'
{"rows":[
]}
```
In above curl for same setup if I remove `skip=4` I get following response
```
{"rows":[
{"key":null,"value":10}
]}
```
Should I create separate issue to track this?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] pulasthi opened a new issue #180: accessing the couchdb instance separately
pulasthi opened a new issue #180: accessing the couchdb instance separately URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/180 Hi Devs, I have a openwhisk cluster deployed, and for my application, I want to access the internal couchDB database 1. From within the function and 2. >From an external location. I have added the svc list below `NAME TYPECLUSTER-IP EXTERNAL-IP PORT(S) AGE apigateway NodePort10.102.34.138 8080:31305/TCP,9000:31295/TCP 7h controller ClusterIP 10.104.235.255 8080/TCP 7h couchdb NodePort10.100.59.2475984:30641/TCP 4h kafkaClusterIP 10.99.132.46 9092/TCP 7h nginxNodePort10.104.182.149 5984:31064/TCP,80:32641/TCP,443:31141/TCP,8443:31389/TCP 3m zookeeperClusterIP 10.102.198.186 2181/TCP,2888/TCP,3888/TCP 7h ` I tried several things but i can't seem to access the couchDB database. I changed the couchDB service from ClusterIp to NodePort. Any help with the following will be greatly appreciated. Lets assume the ip of the mode is 123.45.67.89 1. What host:port to use from with the a function? i thought it would be 123.45.67.89:30641 but it didn't work, 2. What host:port to use from the out side (like a curl call)? Best Regards, Pulasthi This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation
chetanmeh commented on a change in pull request #3517: MemoryArtifactStore for
unit testing and ArtifactStore SPI Validation
URL:
https://github.com/apache/incubator-openwhisk/pull/3517#discussion_r181288290
##
File path:
common/scala/src/main/scala/whisk/core/database/memory/MemoryArtifactStore.scala
##
@@ -0,0 +1,342 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.database.memory
+
+import akka.actor.ActorSystem
+import akka.http.scaladsl.model.ContentType
+import akka.stream.ActorMaterializer
+import akka.stream.scaladsl.{Keep, Sink, Source}
+import akka.util.{ByteString, ByteStringBuilder}
+import spray.json.{DefaultJsonProtocol, DeserializationException, JsObject,
JsString, RootJsonFormat}
+import whisk.common.{Logging, LoggingMarkers, TransactionId}
+import whisk.core.database.StoreUtils._
+import whisk.core.database._
+import whisk.core.entity._
+import whisk.http.Messages
+
+import scala.collection.concurrent.TrieMap
+import scala.concurrent.{ExecutionContext, Future}
+import scala.reflect.ClassTag
+import scala.util.Try
+
+object MemoryArtifactStoreProvider extends ArtifactStoreProvider {
Review comment:
Would add docs. So far no concrete usecase to use them outside testing. One
major reason to put them in main codebase was getting coverage data easily.
Typically Code Coverage data is only calculated for production code but here
I would like to track coverage of Memory store implementation logic such that
it can be ensured that tests cover all aspects of the implementation
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] pritidesai opened a new pull request #268: WIP: adding whisk deploy manifests
pritidesai opened a new pull request #268: WIP: adding whisk deploy manifests URL: https://github.com/apache/incubator-openwhisk-catalog/pull/268 Closes #267 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bbrowning commented on issue #2855: Cache database attachments
bbrowning commented on issue #2855: Cache database attachments URL: https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-381009037 Another update - the tests can be fixed by just removing the "completed uploading attachment..." lines from the expected output checks in ActionsApiTests. The caching works fine as-is when fetching attachments via commands like `wsk action get --save foo`. However, it does not cache actions when fetching attachments via the Invoker. The root cause of this is that the CacheKey wasn't taking the revision into account when updating the cache after calling `getAttachment` and can be fixed by https://gist.github.com/bbrowning/1eb6f24432af96fea264f0152d5cd222 The tests will need to be updated to verify the caching works when a revision is included when getting an action and its attachment. I have manually verified that this works when changed as I linked above. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation
chetanmeh commented on a change in pull request #3517: MemoryArtifactStore for
unit testing and ArtifactStore SPI Validation
URL:
https://github.com/apache/incubator-openwhisk/pull/3517#discussion_r181289802
##
File path:
tests/src/test/scala/whisk/core/database/test/behavior/ArtifactStoreWhisksQueryBehaviors.scala
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.database.test.behavior
+
+import java.time.Instant
+
+import org.scalatest.FlatSpec
+import whisk.common.TransactionId
+import whisk.core.entity.WhiskEntityQueries.TOP
+import whisk.core.entity._
+
+trait ArtifactStoreWhisksQueryBehaviors extends ArtifactStoreBehaviorBase {
+ this: FlatSpec =>
Review comment:
Makes sense. Modified the code to extend `FlatSpec`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] bbrowning commented on issue #2855: Cache database attachments
bbrowning commented on issue #2855: Cache database attachments URL: https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-380986882 I've observed some very poor performance for Java actions and with the help of @rabbah I think I've narrowed it down to the Invokers fetching the Jar attachment on every activation. So, I can confirm both that not caching database attachments is a problem and that this PR is needed. However, I've as of yet been unable to verify that this PR works as intended. https://gist.github.com/bbrowning/6f18deb9f82282700cd3033deaf127b9#file-gistfile1-txt-L29 is a gist of me invoking an action twice in a row with this PR applied. You'll notice that on the highlighted line, the 2nd invocation still fetches the attachment directly from the database. There are also a couple of test failures with the PR when applied to the current codebase. Those look to be related to the reduction of Info level logging and some of the log markers the tests are expecting no longer get logged. Here's the failing test output for reference - https://gist.github.com/bbrowning/727158c6c668d9e81d57543fe67f5ff0 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation
rabbah commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation URL: https://github.com/apache/incubator-openwhisk/pull/3517#discussion_r179639389 ## File path: common/scala/src/main/scala/whisk/core/database/ArtifactStoreExceptions.scala ## @@ -28,3 +28,9 @@ case class DocumentTypeMismatchException(message: String) extends ArtifactStoreE case class DocumentUnreadable(message: String) extends ArtifactStoreException(message) case class PutException(message: String) extends ArtifactStoreException(message) + +sealed abstract class ArtifactStoreRuntimeException(message: String) extends RuntimeException(message) + Review comment: Is this sealed class intended to restrict exceptions for views only vs documents? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation
rabbah commented on a change in pull request #3517: MemoryArtifactStore for
unit testing and ArtifactStore SPI Validation
URL:
https://github.com/apache/incubator-openwhisk/pull/3517#discussion_r181276164
##
File path:
common/scala/src/main/scala/whisk/core/database/DocumentHandler.scala
##
@@ -0,0 +1,463 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.database
+
+import spray.json._
+import spray.json.DefaultJsonProtocol._
+import whisk.common.TransactionId
+import whisk.core.entity.{DocId, UserLimits}
+import whisk.core.entity.EntityPath.PATHSEP
+import whisk.utils.JsHelpers
+
+import scala.collection.immutable.Seq
+import scala.concurrent.Future
+import scala.concurrent.ExecutionContext
+
+/**
+ * Simple abstraction allow accessing a document just by _id. This would be
used
+ * to perform queries related to join support
+ */
+trait DocumentProvider {
+ protected[database] def get(id: DocId)(implicit transid: TransactionId):
Future[Option[JsObject]]
+}
+
+trait DocumentHandler {
+
+ /**
+ * Returns a JsObject having computed fields. This is a substitution for
fields
+ * computed in CouchDB views
+ */
+ def computedFields(js: JsObject): JsObject = JsObject.empty
+
+ /**
+ * Returns the set of field names (including sub document field) which needs
to be fetched as part of
+ * query made for the given view.
+ */
+ def fieldsRequiredForView(ddoc: String, view: String): Set[String] =
Set.empty
+
+ /**
+ * Transforms the query result instance from artifact store as per view
requirements. Some view computation
+ * may result in performing a join operation.
+ *
+ * If the passed instance does not confirm to view conditions that
transformed result would be None. This
+ * would be the case if view condition cannot be completed handled in query
made to artifact store
+ */
+ def transformViewResult(
+ddoc: String,
+view: String,
+startKey: List[Any],
+endKey: List[Any],
+includeDocs: Boolean,
+js: JsObject,
+provider: DocumentProvider)(implicit transid: TransactionId, ec:
ExecutionContext): Future[Seq[JsObject]]
+
+ /**
+ * Determines if the complete document should be fetched even if
`includeDocs` is set to true. For some view computation
+ * complete document (including sub documents) may be needed and for them
its required that complete document must be
+ * fetched as part of query response
+ */
+ def shouldAlwaysIncludeDocs(ddoc: String, view: String): Boolean = false
+
+ def checkIfTableSupported(table: String): Unit = {
+if (!supportedTables.contains(table)) {
+ throw UnsupportedView(table)
+}
+ }
+
+ protected def supportedTables: Set[String]
+}
+
+/**
+ * Base class for handlers which do not perform joins for computing views
+ */
+abstract class SimpleHandler extends DocumentHandler {
+ override def transformViewResult(
+ddoc: String,
+view: String,
+startKey: List[Any],
+endKey: List[Any],
+includeDocs: Boolean,
+js: JsObject,
+provider: DocumentProvider)(implicit transid: TransactionId, ec:
ExecutionContext): Future[Seq[JsObject]] = {
+//Query result from CouchDB have below object structure with actual result
in `value` key
+//So transform the result to confirm to that structure
+val viewResult = JsObject(
+ "id" -> js.fields("_id"),
+ "key" -> createKey(ddoc, view, startKey, js),
+ "value" -> computeView(ddoc, view, js))
+
+val result = if (includeDocs) JsObject(viewResult.fields + ("doc" -> js))
else viewResult
+Future.successful(Seq(result))
+ }
+
+ /**
+ * Computes the view as per viewName. Its passed either the projected object
or actual
+ * object
+ */
+ def computeView(ddoc: String, view: String, js: JsObject): JsObject
+
+ /**
+ * Key is an array which matches the view query key
+ */
+ protected def createKey(ddoc: String, view: String, startKey: List[Any], js:
JsObject): JsArray
+}
+
+object ActivationHandler extends SimpleHandler {
+ val NS_PATH = "nspath"
+ private val commonFields =
+Set("namespace", "name", "version", "publish", "annotations",
"activationId", "start", "cause")
+ private val
[GitHub] rabbah commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation
rabbah commented on a change in pull request #3517: MemoryArtifactStore for
unit testing and ArtifactStore SPI Validation
URL:
https://github.com/apache/incubator-openwhisk/pull/3517#discussion_r181275972
##
File path:
common/scala/src/main/scala/whisk/core/database/memory/MemoryArtifactStore.scala
##
@@ -0,0 +1,342 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.database.memory
+
+import akka.actor.ActorSystem
+import akka.http.scaladsl.model.ContentType
+import akka.stream.ActorMaterializer
+import akka.stream.scaladsl.{Keep, Sink, Source}
+import akka.util.{ByteString, ByteStringBuilder}
+import spray.json.{DefaultJsonProtocol, DeserializationException, JsObject,
JsString, RootJsonFormat}
+import whisk.common.{Logging, LoggingMarkers, TransactionId}
+import whisk.core.database.StoreUtils._
+import whisk.core.database._
+import whisk.core.entity._
+import whisk.http.Messages
+
+import scala.collection.concurrent.TrieMap
+import scala.concurrent.{ExecutionContext, Future}
+import scala.reflect.ClassTag
+import scala.util.Try
+
+object MemoryArtifactStoreProvider extends ArtifactStoreProvider {
Review comment:
can you add a java/scala doc (comment) explaining the purpose of memory
store provider; furthermore, do you anticipate this will be used outside of
testing (in which case should this move to the tests package)?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation
rabbah commented on a change in pull request #3517: MemoryArtifactStore for
unit testing and ArtifactStore SPI Validation
URL:
https://github.com/apache/incubator-openwhisk/pull/3517#discussion_r180482957
##
File path:
tests/src/test/scala/whisk/core/database/test/behavior/ArtifactStoreWhisksQueryBehaviors.scala
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.database.test.behavior
+
+import java.time.Instant
+
+import org.scalatest.FlatSpec
+import whisk.common.TransactionId
+import whisk.core.entity.WhiskEntityQueries.TOP
+import whisk.core.entity._
+
+trait ArtifactStoreWhisksQueryBehaviors extends ArtifactStoreBehaviorBase {
+ this: FlatSpec =>
Review comment:
why not just extend?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on issue #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation
rabbah commented on issue #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation URL: https://github.com/apache/incubator-openwhisk/pull/3517#issuecomment-381007908 @dubee @csantanapr @markusthoemmes a pg to be safe although I expect Travis to be sufficient. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation
rabbah commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation URL: https://github.com/apache/incubator-openwhisk/pull/3517#discussion_r181275606 ## File path: common/scala/src/main/scala/whisk/core/database/memory/MemoryViewMapper.scala ## @@ -0,0 +1,248 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + Review comment: can you add a java/scala doc (comment) explaining the purpose of the view mapper. do you anticipate this will be used outside of testing (in which case should this move to the tests package)? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation
chetanmeh commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation URL: https://github.com/apache/incubator-openwhisk/pull/3517#discussion_r181287479 ## File path: common/scala/src/main/scala/whisk/core/database/ArtifactStoreExceptions.scala ## @@ -28,3 +28,9 @@ case class DocumentTypeMismatchException(message: String) extends ArtifactStoreE case class DocumentUnreadable(message: String) extends ArtifactStoreException(message) case class PutException(message: String) extends ArtifactStoreException(message) + +sealed abstract class ArtifactStoreRuntimeException(message: String) extends RuntimeException(message) + Review comment: Made it `sealed` to follow the pattern used with `ArtifactStoreException` i.e. a base `RuntimeException` which can be used to indicate logical errors in code flow. So can be used for both views and document This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation
chetanmeh commented on a change in pull request #3517: MemoryArtifactStore for
unit testing and ArtifactStore SPI Validation
URL:
https://github.com/apache/incubator-openwhisk/pull/3517#discussion_r181288490
##
File path:
common/scala/src/main/scala/whisk/core/database/DocumentHandler.scala
##
@@ -0,0 +1,463 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.database
+
+import spray.json._
+import spray.json.DefaultJsonProtocol._
+import whisk.common.TransactionId
+import whisk.core.entity.{DocId, UserLimits}
+import whisk.core.entity.EntityPath.PATHSEP
+import whisk.utils.JsHelpers
+
+import scala.collection.immutable.Seq
+import scala.concurrent.Future
+import scala.concurrent.ExecutionContext
+
+/**
+ * Simple abstraction allow accessing a document just by _id. This would be
used
+ * to perform queries related to join support
+ */
+trait DocumentProvider {
+ protected[database] def get(id: DocId)(implicit transid: TransactionId):
Future[Option[JsObject]]
+}
+
+trait DocumentHandler {
+
+ /**
+ * Returns a JsObject having computed fields. This is a substitution for
fields
+ * computed in CouchDB views
+ */
+ def computedFields(js: JsObject): JsObject = JsObject.empty
+
+ /**
+ * Returns the set of field names (including sub document field) which needs
to be fetched as part of
+ * query made for the given view.
+ */
+ def fieldsRequiredForView(ddoc: String, view: String): Set[String] =
Set.empty
+
+ /**
+ * Transforms the query result instance from artifact store as per view
requirements. Some view computation
+ * may result in performing a join operation.
+ *
+ * If the passed instance does not confirm to view conditions that
transformed result would be None. This
+ * would be the case if view condition cannot be completed handled in query
made to artifact store
+ */
+ def transformViewResult(
+ddoc: String,
+view: String,
+startKey: List[Any],
+endKey: List[Any],
+includeDocs: Boolean,
+js: JsObject,
+provider: DocumentProvider)(implicit transid: TransactionId, ec:
ExecutionContext): Future[Seq[JsObject]]
+
+ /**
+ * Determines if the complete document should be fetched even if
`includeDocs` is set to true. For some view computation
+ * complete document (including sub documents) may be needed and for them
its required that complete document must be
+ * fetched as part of query response
+ */
+ def shouldAlwaysIncludeDocs(ddoc: String, view: String): Boolean = false
+
+ def checkIfTableSupported(table: String): Unit = {
+if (!supportedTables.contains(table)) {
+ throw UnsupportedView(table)
+}
+ }
+
+ protected def supportedTables: Set[String]
+}
+
+/**
+ * Base class for handlers which do not perform joins for computing views
+ */
+abstract class SimpleHandler extends DocumentHandler {
+ override def transformViewResult(
+ddoc: String,
+view: String,
+startKey: List[Any],
+endKey: List[Any],
+includeDocs: Boolean,
+js: JsObject,
+provider: DocumentProvider)(implicit transid: TransactionId, ec:
ExecutionContext): Future[Seq[JsObject]] = {
+//Query result from CouchDB have below object structure with actual result
in `value` key
+//So transform the result to confirm to that structure
+val viewResult = JsObject(
+ "id" -> js.fields("_id"),
+ "key" -> createKey(ddoc, view, startKey, js),
+ "value" -> computeView(ddoc, view, js))
+
+val result = if (includeDocs) JsObject(viewResult.fields + ("doc" -> js))
else viewResult
+Future.successful(Seq(result))
+ }
+
+ /**
+ * Computes the view as per viewName. Its passed either the projected object
or actual
+ * object
+ */
+ def computeView(ddoc: String, view: String, js: JsObject): JsObject
+
+ /**
+ * Key is an array which matches the view query key
+ */
+ protected def createKey(ddoc: String, view: String, startKey: List[Any], js:
JsObject): JsArray
+}
+
+object ActivationHandler extends SimpleHandler {
+ val NS_PATH = "nspath"
+ private val commonFields =
+Set("namespace", "name", "version", "publish", "annotations",
"activationId", "start", "cause")
+ private val
[GitHub] pritidesai opened a new pull request #870: WIP: Introducing package level parameters
pritidesai opened a new pull request #870: WIP: Introducing package level parameters URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/870 Closes #803 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3502: Immutable attachments via putAndAttach
rabbah commented on issue #3502: Immutable attachments via putAndAttach URL: https://github.com/apache/incubator-openwhisk/pull/3502#issuecomment-381006472 @dubee @csantanapr @markusthoemmes needs a pg. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3502: Immutable attachments via putAndAttach
rabbah commented on issue #3502: Immutable attachments via putAndAttach URL: https://github.com/apache/incubator-openwhisk/pull/3502#issuecomment-381006472 @dubee @csantanapr @markusthoemmes needs a pg. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tysonnorris commented on issue #3211: implement ContainerFactory.cpuShare to fix #3110
tysonnorris commented on issue #3211: implement ContainerFactory.cpuShare to fix #3110 URL: https://github.com/apache/incubator-openwhisk/pull/3211#issuecomment-381027426 hopefully this will do it This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new issue #114: docker-compose doesn't work unless I close chrome
csantanapr opened a new issue #114: docker-compose doesn't work unless I close chrome URL: https://github.com/apache/incubator-openwhisk-devtools/issues/114 ## environment OS: MacOS 10.13.4 Docker for Mac:version 18.03.0-ce-mac59 (23608) ## Steps to replicate: ``` git clone https://github.com/apache/incubator-openwhisk-devtools cd incubator-openwhisk-devtools/docker-compose make quick-start Downloading source tar ball % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 100 1340 1340 0257 0 --:--:-- --:--:-- --:--:-- 257 100 10.3M0 10.3M0 0 1442k 0 --:--:-- 0:00:07 --:--:-- 1765k Unpacking tarball. downloading the CLI tool ... downloading cli for mac % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 100 6240 6240 0 2455 0 --:--:-- --:--:-- --:--:-- 2456 100 3352k 100 3352k0 0 1184k 0 0:00:02 0:00:02 --:--:-- 1430k Archive: wsk.zip inflating: wsk inflating: NOTICE.txt inflating: README.md inflating: LICENSE.txt host ip address: 172.17.0.1 checking required ports ... Port 443 is taken by PID:8659. make: *** [check-required-ports] Error 1 ``` Then I shutdown the Chrome App This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mcdan opened a new pull request #3541: Point Getting Started to docker-compose
mcdan opened a new pull request #3541: Point Getting Started to docker-compose URL: https://github.com/apache/incubator-openwhisk/pull/3541 ## Description ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [ ] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new issue #288: Apache release does not allow to have private license as the header
houshengbo opened a new issue #288: Apache release does not allow to have private license as the header URL: https://github.com/apache/incubator-openwhisk-apigateway/issues/288 We have MIT license and adobe copyright in below files: ``` MIT openwhisk-apigateway/api-gateway.conf MIT openwhisk-apigateway/tests/test_initialization.t MIT openwhisk-apigateway/conf.d/api_gateway_init.conf MIT openwhisk-apigateway/conf.d/management_apis.conf MIT openwhisk-apigateway/conf.d/commons/common-headers.conf MIT openwhisk-apigateway/conf.d/api_gateway_logging.conf MIT openwhisk-apigateway/conf.d/includes/analytics_endpoints.conf MIT openwhisk-apigateway/conf.d/includes/basic_endpoints.conf MIT openwhisk-apigateway/conf.d/managed_endpoints.conf MIT openwhisk-apigateway/conf.d/default.conf MIT openwhisk-apigateway/conf.d/blacklist.conf ``` We need to decide how to handle them. According to [Apache license policy](http://apache.org/legal/src-headers.html#headers), the copyright owner (or owner's agent) must remove the copyright notice or move them to the NOTICE file, or authorize us to make such modifications. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #107: Do we need to add LICENSE header to binary files?
houshengbo commented on issue #107: Do we need to add LICENSE header to binary files? URL: https://github.com/apache/incubator-openwhisk-release/issues/107#issuecomment-380843723 @daisy-ycguo @mrutkows To me, these files can be left without Apache headers, and we can document it in the MD files. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd commented on issue #3541: Point Getting Started to docker-compose
ddragosd commented on issue #3541: Point Getting Started to docker-compose URL: https://github.com/apache/incubator-openwhisk/pull/3541#issuecomment-380845787 LGTM. We can decide later about the state of Vagrant. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3541: Point Getting Started to docker-compose
chetanmeh commented on issue #3541: Point Getting Started to docker-compose URL: https://github.com/apache/incubator-openwhisk/pull/3541#issuecomment-380848697 Would be helpful to also validate if docker compose based setup works fine on Windows or not and see what minimum Windows version is required for this to work This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai opened a new pull request #869: WIP: converting json blob to its own supported types in annotations
pritidesai opened a new pull request #869: WIP: converting json blob to its own supported types in annotations URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/869 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3537: Add activation logs integration test
markusthoemmes commented on a change in pull request #3537: Add activation logs
integration test
URL:
https://github.com/apache/incubator-openwhisk/pull/3537#discussion_r180973156
##
File path: tests/src/test/scala/system/basic/WskActivationTests.scala
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package system.basic
+
+import org.junit.runner.RunWith
+import org.scalatest.junit.JUnitRunner
+
+import common.{BaseWsk, JsHelpers, TestHelpers, TestUtils, WskProps,
WskTestHelpers}
+
+@RunWith(classOf[JUnitRunner])
+abstract class WskActivationTests extends TestHelpers with WskTestHelpers with
JsHelpers {
+ implicit val wskprops = WskProps()
+
+ val wsk: BaseWsk
+
+ behavior of "Whisk activations"
+
+ it should "fetch logs using activation logs API" in
withAssetCleaner(wskprops) { (wp, assetHelper) =>
+val name = "logFetch"
+val logFormat = "\\d+-\\d+-\\d+T\\d+:\\d+:\\d+.\\d+Z\\s+%s: %s"
+
+assetHelper.withCleaner(wsk.action, name) { (action, _) =>
+ action.create(name, Some(TestUtils.getTestActionFilename("log.js")))
+}
+
+val run = wsk.action.invoke(name, blocking = true)
+
+// Use withActivation() to reduce intermittent failures that may result
from eventually consistent DBs
+withActivation(wsk.activation, run) { activation =>
+ val logs = wsk.activation.logs(Some(activation.activationId)).stdout
Review comment:
I think we'll need to retry this seperately, no? In the CouchDB base
implementation, sure, `withActivation` will cover the retries. Any other
backend might take longer than Couch though, so should we add another round of
retries just around logs?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
