[GitHub] cbickel commented on a change in pull request #3556: Add latency test with gatling.
cbickel commented on a change in pull request #3556: Add latency test with
gatling.
URL:
https://github.com/apache/incubator-openwhisk/pull/3556#discussion_r182325391
##
File path: performance/gatling_tests/src/gatling/resources/data/nodeJSAction.js
##
@@ -0,0 +1,5 @@
+function main(params) {
+var greeting = "Hello" + (params.text || "stranger") + "!";
+console.log(greeting);
+return { payload: greeting };
+}
Review comment:
I checked in these actions here to ensure, that all actions do exactly the
same. By ensuring this, we can also compare the runtimes against each others.
In the `tests/dat/actions` are a lot of actions, but I didn't find one
action, that is doing exactly the same in all languages.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] chetanmeh commented on issue #3546: Fix vagrant not use runc
chetanmeh commented on issue #3546: Fix vagrant not use runc URL: https://github.com/apache/incubator-openwhisk/pull/3546#issuecomment-382259528 @csantanapr Are the steps to change box size similar to one posted by @neerajmangal [here][1]. In that case can we at least leave the config in `Vagrantfile` and just document steps on how to increase the size [1]: https://github.com/apache/incubator-openwhisk/issues/3533#issuecomment-381154231 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] satansk closed pull request #3539: modify the official website in README.md
satansk closed pull request #3539: modify the official website in README.md URL: https://github.com/apache/incubator-openwhisk/pull/3539 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/docs/README.md b/docs/README.md index 89f4465a37..a1648c8950 100644 --- a/docs/README.md +++ b/docs/README.md @@ -69,7 +69,7 @@ This programming model is a perfect match for microservices, mobile, IoT and man - Integration with Serverless Framework --> -Official OpenWhisk project website [http://OpenWhisk.org](http://openwhisk.org). +Official OpenWhisk project website [http://openwhisk.incubator.apache.org](http://openwhisk.incubator.apache.org). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #185: add kube 1.10.1 and minikube 0.26 to test matrix
csantanapr commented on issue #185: add kube 1.10.1 and minikube 0.26 to test matrix URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/185#issuecomment-382251891 @dgrove-oss it looks minikube not coming up in Travis. I tested locally on OSX and it worked fine for me. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #185: add kube 1.10.1 and minikube 0.26 to test matrix
csantanapr opened a new pull request #185: add kube 1.10.1 and minikube 0.26 to test matrix URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/185 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new issue #120: Define format of LICENSE file
mrutkows opened a new issue #120: Define format of LICENSE file URL: https://github.com/apache/incubator-openwhisk-release/issues/120 Use this issue to propose format, SEPARATORs, how to list/categorize lists of "bundled" vs. "non-bundled" dependencies. List which LICENSEs (like MIT or LUA) that we decided to copy in OR copy part and provide URL/link. Add these decisions and the template description to the Markdown file: https://github.com/apache/incubator-openwhisk-release/blob/master/docs/license_compliance.md We could even check in the sample file here in this repo. for people to copy. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new issue #119: Add XML to table of LICENSE inclusions
mrutkows opened a new issue #119: Add XML to table of LICENSE inclusions URL: https://github.com/apache/incubator-openwhisk-release/issues/119 Add to here: https://github.com/apache/incubator-openwhisk-release/blob/master/docs/license_compliance.md This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #118: Describe scanCode plus Apache RAT usage
mrutkows commented on issue #118: Describe scanCode plus Apache RAT usage URL: https://github.com/apache/incubator-openwhisk-release/issues/118#issuecomment-382226244 Can point to scanCode's config file "ASF-Release.cfg" and RAT .pom file: https://github.com/apache/incubator-openwhisk-release/blob/master/tools/lib/pom.xml This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new issue #118: Describe scanCode plus Apache RAT usage
mrutkows opened a new issue #118: Describe scanCode plus Apache RAT usage URL: https://github.com/apache/incubator-openwhisk-release/issues/118 scanCode = PR RAT = during release build/publish This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #116: Review list of proposed ScanCode exclusions for default configuration.
mrutkows commented on issue #116: Review list of proposed ScanCode exclusions for default configuration. URL: https://github.com/apache/incubator-openwhisk-release/issues/116#issuecomment-382225464 @daisy-ycguo @houshengbo we reviewed this list of exclusions and confirmed it was a summary or accumulation of all exclusions for all repos. that was created in March by Daisy and is already reflected in the .pom file. These should be reflected in scanCode.py as well. See: https://github.com/apache/incubator-openwhisk-release/blob/master/tools/lib/pom.xml This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #116: Review list of proposed ScanCode exclusions for default configuration.
mrutkows commented on issue #116: Review list of proposed ScanCode exclusions for default configuration. URL: https://github.com/apache/incubator-openwhisk-release/issues/116#issuecomment-382225464 @daisy-ycguo @houshengbo we reviewed this list of exclusions and confirmed it was a summary or accumulation of all exclusions for all repos. that was created in March. These should be reflected in scanCode.py. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mdeuser commented on issue #2317: wsk api authentication issues
mdeuser commented on issue #2317: wsk api authentication issues URL: https://github.com/apache/incubator-openwhisk/issues/2317#issuecomment-382217982 @yadavvipinsonu - have you been following these instructions? https://github.com/apache/incubator-openwhisk/blob/master/tools/ubuntu-setup/README.md there's also an openwhisk slack project you might want to consider for more interactive help with your issue. `openwhisk-team.slack.com` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xingzhou commented on issue #184: helm: get runtimes from runtimes.json
xingzhou commented on issue #184: helm: get runtimes from runtimes.json URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/184#issuecomment-382217933 other parts looks great to me This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xingzhou commented on issue #184: helm: get runtimes from runtimes.json
xingzhou commented on issue #184: helm: get runtimes from runtimes.json URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/184#issuecomment-382217814 @dgrove-oss, I remembered we used to use `lifecycleHook` to download the runtime once a invoker instance is started. So compared to `initContainer`, which one do you think is better? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3546: Fix vagrant not use runc
csantanapr commented on issue #3546: Fix vagrant not use runc
URL:
https://github.com/apache/incubator-openwhisk/pull/3546#issuecomment-382214334
@mdeuser can you test this branch one more time.
I remove the disksize plugin since you reported problems running on Windows.
I just a got a clean deploy
```
default: Swagger UI URL:
https://192.168.33.16/api/v1/docs/index.html?url=/api/v1/api-docs
default: ++ echo 'Swagger UI URL:
https://192.168.33.16/api/v1/docs/index.html?url=/api/v1/api-docs'
default: ++ wsk action invoke /whisk.system/utils/echo -p message hello
--result
default: {
default: "message": "hello"
default: }
default: +++ date
default: ++ echo 'Wed Apr 18 01:21:10 UTC 2018: build-deploy-end'
```
skipping the runtimes I was able to not run out of disk space
```
vagrant@ubuntu-xenial:~$ df -h
Filesystem Size Used Avail Use% Mounted on
udev2.0G 0 2.0G 0% /dev
tmpfs 396M 6.3M 389M 2% /run
/dev/sda1 9.7G 5.4G 4.3G 56% /
tmpfs 2.0G 0 2.0G 0% /dev/shm
tmpfs 5.0M 0 5.0M 0% /run/lock
tmpfs 2.0G 0 2.0G 0% /sys/fs/cgroup
tmpfs 396M 0 396M 0% /run/user/1000
vagrant 466G 412G 55G 89% /vagrant
home_vagrant_openwhisk 466G 412G 55G 89% /home/vagrant/openwhisk
```
My timings:
```
vagrant@ubuntu-xenial:~$ cat /tmp/vagrant-times.txt
Wed Apr 18 01:03:47 UTC 2018: ubuntu-setup-start
Wed Apr 18 01:06:41 UTC 2018: ubuntu-setup-end
Wed Apr 18 01:06:42 UTC 2018: couchdb-setup-start
Wed Apr 18 01:07:20 UTC 2018: couchdb-setup-end
Wed Apr 18 01:07:27 UTC 2018: build-core-start
Wed Apr 18 01:15:30 UTC 2018: build-core-end
Wed Apr 18 01:15:30 UTC 2018: build-cli-start
Wed Apr 18 01:18:13 UTC 2018: build-cli-end
Wed Apr 18 01:18:13 UTC 2018: deploy-start
Wed Apr 18 01:21:10 UTC 2018: build-deploy-end
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr commented on issue #3546: Fix vagrant not use runc
csantanapr commented on issue #3546: Fix vagrant not use runc
URL:
https://github.com/apache/incubator-openwhisk/pull/3546#issuecomment-382214334
@mdeuser can you test this branch one more time.
I remove the disksize plugin since you reported problems running on Windows.
I just a got a clean deploy
```
default: Swagger UI URL:
https://192.168.33.16/api/v1/docs/index.html?url=/api/v1/api-docs
default: ++ echo 'Swagger UI URL:
https://192.168.33.16/api/v1/docs/index.html?url=/api/v1/api-docs'
default: ++ wsk action invoke /whisk.system/utils/echo -p message hello
--result
default: {
default: "message": "hello"
default: }
default: +++ date
default: ++ echo 'Wed Apr 18 01:21:10 UTC 2018: build-deploy-end'
```
skipping the runtimes I was able to not run out of disk space
```
vagrant@ubuntu-xenial:~$ df -h
Filesystem Size Used Avail Use% Mounted on
udev2.0G 0 2.0G 0% /dev
tmpfs 396M 6.3M 389M 2% /run
/dev/sda1 9.7G 5.4G 4.3G 56% /
tmpfs 2.0G 0 2.0G 0% /dev/shm
tmpfs 5.0M 0 5.0M 0% /run/lock
tmpfs 2.0G 0 2.0G 0% /sys/fs/cgroup
tmpfs 396M 0 396M 0% /run/user/1000
vagrant 466G 412G 55G 89% /vagrant
home_vagrant_openwhisk 466G 412G 55G 89% /home/vagrant/openwhisk
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] houshengbo closed pull request #39: Add scancode to Travis using the ASF Release configuration.
houshengbo closed pull request #39: Add scancode to Travis using the ASF
Release configuration.
URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/39
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/core/nodejs8Action/build.gradle b/core/nodejs8Action/build.gradle
index f796acb..b4dd28a 100644
--- a/core/nodejs8Action/build.gradle
+++ b/core/nodejs8Action/build.gradle
@@ -33,4 +33,4 @@ task cleanup(type: Delete) {
delete 'app.js'
delete 'runner.js'
delete 'src'
-}
\ No newline at end of file
+}
diff --git a/tools/travis/build.sh b/tools/travis/build.sh
index 19ea582..f952128 100755
--- a/tools/travis/build.sh
+++ b/tools/travis/build.sh
@@ -23,11 +23,16 @@ set -ex
SCRIPTDIR=$(cd $(dirname "$0") && pwd)
ROOTDIR="$SCRIPTDIR/../.."
WHISKDIR="$ROOTDIR/../openwhisk"
+UTILDIR="$ROOTDIR/../incubator-openwhisk-utilities"
export OPENWHISK_HOME=$WHISKDIR
IMAGE_PREFIX="testing"
+# run scancode using the ASF Release configuration
+cd $UTILDIR
+scancode/scanCode.py --config scancode/ASF-Release.cfg $ROOTDIR
+
# Build OpenWhisk
cd $WHISKDIR
diff --git a/tools/travis/setup.sh b/tools/travis/setup.sh
index 1da8c03..c74fad6 100755
--- a/tools/travis/setup.sh
+++ b/tools/travis/setup.sh
@@ -24,9 +24,11 @@ SCRIPTDIR=$(cd $(dirname "$0") && pwd)
ROOTDIR="$SCRIPTDIR/../.."
HOMEDIR="$SCRIPTDIR/../../../"
-# OpenWhisk stuff
+# clone OpenWhisk repo. in order to run scanCode.py
cd $HOMEDIR
+git clone https://github.com/apache/incubator-openwhisk-utilities.git
+
+# OpenWhisk stuff
git clone --depth=1 https://github.com/apache/incubator-openwhisk.git openwhisk
cd openwhisk
./tools/travis/setup.sh
-
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] tysonnorris closed pull request #2992: create SPI for SeedNodesProvider; MarathonSeedNodesProvider to provid…
tysonnorris closed pull request #2992: create SPI for SeedNodesProvider;
MarathonSeedNodesProvider to provid…
URL: https://github.com/apache/incubator-openwhisk/pull/2992
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/common/scala/src/main/resources/application.conf
b/common/scala/src/main/resources/application.conf
index 4c36319523..9f7448312e 100644
--- a/common/scala/src/main/resources/application.conf
+++ b/common/scala/src/main/resources/application.conf
@@ -12,7 +12,10 @@ akka.http {
max-open-requests = 512
}
}
-
+whisk.cluster.discovery {
+#interval to wait for next health checks during mesos seed node discovery
+marathon-check-interval-seconds = 1
+}
#kamon related configuration
kamon {
diff --git a/common/scala/src/main/resources/reference.conf
b/common/scala/src/main/resources/reference.conf
index 8048d43bd4..9821b8fb77 100644
--- a/common/scala/src/main/resources/reference.conf
+++ b/common/scala/src/main/resources/reference.conf
@@ -1,4 +1,4 @@
-whisk.spi {
+whisk.spi{
ArtifactStoreProvider = whisk.core.database.CouchDbStoreProvider
MessagingProvider = whisk.connector.kafka.KafkaMessagingProvider
ContainerFactoryProvider =
whisk.core.containerpool.docker.DockerContainerFactoryProvider
diff --git a/common/scala/src/main/scala/whisk/core/WhiskConfig.scala
b/common/scala/src/main/scala/whisk/core/WhiskConfig.scala
index 7e6148038d..fb7f5f6769 100644
--- a/common/scala/src/main/scala/whisk/core/WhiskConfig.scala
+++ b/common/scala/src/main/scala/whisk/core/WhiskConfig.scala
@@ -215,6 +215,7 @@ object WhiskConfig {
object ConfigKeys {
val loadbalancer = "whisk.loadbalancer"
+ val cluster = "whisk.cluster"
val couchdb = "whisk.couchdb"
val kafka = "whisk.kafka"
val kafkaCommon = s"$kafka.common"
diff --git a/core/controller/build.gradle b/core/controller/build.gradle
index 0b904440af..cf1197bf1e 100644
--- a/core/controller/build.gradle
+++ b/core/controller/build.gradle
@@ -15,6 +15,8 @@ repositories {
dependencies {
compile 'com.typesafe.akka:akka-distributed-data_2.11:2.5.4'
+compile
"com.lightbend.akka.management:akka-management-cluster-bootstrap_2.11:0.10.0"
+compile
"com.lightbend.akka.discovery:akka-discovery-marathon-api_2.11:0.10.0"
compile "org.scala-lang:scala-library:${gradle.scala.version}"
compile project(':common:scala')
}
diff --git a/core/controller/src/main/resources/application.conf
b/core/controller/src/main/resources/application.conf
index bbc298b1e3..1daed6ee5f 100644
--- a/core/controller/src/main/resources/application.conf
+++ b/core/controller/src/main/resources/application.conf
@@ -10,6 +10,9 @@ whisk {
controller {
protocol: http
}
+ cluster {
+use-cluster-bootstrap: false #true enables use of Akka Management + Akka
Cluster Bootstrap; otherwise, static list of seed nodes is required
+ }
}
# http://doc.akka.io/docs/akka-http/current/scala/http/configuration.html
@@ -81,3 +84,55 @@ akka {
#distributed-data.notify-subscribers-interval = 0.01
}
}
+akka {
+ discovery {
+#method = marathon-api
+marathon-api {
+ class = akka.discovery.marathon.MarathonApiSimpleServiceDiscovery
+
+ # URL for getting list of apps from Marathon. Verified on OSS DC/OS 1.8,
1.9
+ app-api-url = "http://192.168.99.100:8080/v2/apps";
+
+ # The name of the akka management port - this cannot have underscores or
dashes (env var name)
+ app-port-name = "akkamgmthttp"
+
+ # Used to find other apps running by Marathon. This will be passed as
the label query string parameter
+ # to the apps-api-url defined above.
+ # `%s` will be replaced with the configured effective name, which
defaults to the actor system name
+ app-label-query = "ACTOR_SYSTEM_NAME==%s"
+}
+ }
+
+ management {
+http {
+ # The hostname where the HTTP Server for Http Cluster Management will be
started.
+ # This defines the interface to use.
+ # InetAddress.getLocalHost.getHostAddress is used not overriden or empty
+
+ hostname = ${?HOST}
+
+ port = 1
+ port = ${?PORT_1}
+
+ bind-hostname = 0.0.0.0
+ bind-port = 1
+}
+
+cluster.bootstrap {
+
+ # Configuration for the first phase of bootstraping, during which
contact points are discovered
+ # using the configured service discovery mechanism.
+ contact-point-discovery {
+
+# Marathon API discovery uses effective-name when it's defined.
+#
+# Marathon API dicsovery uses this value to substitute to the query
`app-label-query`
+#
+# It should match with application LABEL value declared in Marathon
description.
+#
+effective-name= "whisk-controller
[GitHub] tysonnorris commented on issue #2992: create SPI for SeedNodesProvider; MarathonSeedNodesProvider to provid…
tysonnorris commented on issue #2992: create SPI for SeedNodesProvider; MarathonSeedNodesProvider to provid… URL: https://github.com/apache/incubator-openwhisk/pull/2992#issuecomment-382188987 closing in favor of #3548 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #39: Add scancode to Travis using the ASF Release configuration.
mrutkows opened a new pull request #39: Add scancode to Travis using the ASF Release configuration. URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/39 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Juice10 commented on issue #865: Documentation - Produce a comprehensive list of errors and warnings
Juice10 commented on issue #865: Documentation - Produce a comprehensive list of errors and warnings URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/865#issuecomment-382182099 Maybe we could take a page from React and make sure our error messages are helpful. Example: https://codeburst.io/the-true-delight-of-reacts-error-and-warning-messages-137002a3bbd4 I have seen some other libraries include a link in the error message to documentation that explains how to get past the error message or warning. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Juice10 opened a new issue #872: Docs still recommend deprecated `manifest.yaml` definitions
Juice10 opened a new issue #872: Docs still recommend deprecated `manifest.yaml` definitions URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/872 https://github.com/apache/incubator-openwhisk-wskdeploy/pull/743 removed the deprecated `package:` parameter from the `manifest.yml` but the docs where never updated to reflect that. These docs still refer to the old `package:` definition of the `manifest.yaml`: https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/docs/wskdeploy_package_minimal.md#packages https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/docs/examples/manifest_package_minimal.yaml eg. ```yaml package: name: hello_world_package version: 1.0 license: Apache-2.0 ``` When I try running that I get all kinds of errors. ``` $ ./wskdeploy Info: The API host is [10.11.71.125:443], from .wskprops. Info: The auth key is set, from .wskprops. Info: The namespace is [guest], from .wskprops. Info: The apigw access token is set, from .wskprops. panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x4 pc=0x28b27c] goroutine 1 [running]: github.com/apache/incubator-openwhisk-wskdeploy/vendor/github.com/apache/incubator-openwhisk-client-go/whisk.GetUrlBase(0x10a9a968, 0x10, 0x7f, 0x0, 0x0) /home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/vendor/github.com/apache/incubator-openwhisk-client-go/whisk/wskprops.go:72 +0xac github.com/apache/incubator-openwhisk-wskdeploy/vendor/github.com/apache/incubator-openwhisk-client-go/whisk.NewClient(0x10a9ab20, 0x10aa2050, 0x58d1ec, 0x10aa2050, 0x0) /home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/vendor/github.com/apache/incubator-openwhisk-client-go/whisk/client.go:129 +0x6a7 github.com/apache/incubator-openwhisk-wskdeploy/deployers.glob..func5(0x10aa2050, 0x17, 0x0, 0x0) /home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/deployers/whiskclient.go:80 +0x3f github.com/apache/incubator-openwhisk-wskdeploy/cmd.Deploy(0x1, 0x109971e4) /home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/cmd/root.go:202 +0x3b9 github.com/apache/incubator-openwhisk-wskdeploy/cmd.RootCmdImp(0x57a3c0, 0x58d1ec, 0x0, 0x0, 0x0, 0x0) /home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/cmd/root.go:50 +0x14 github.com/apache/incubator-openwhisk-wskdeploy/vendor/github.com/spf13/cobra.(*Command).execute(0x57a3c0, 0x10996018, 0x0, 0x0, 0x57a3c0, 0x10996018) /home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/vendor/github.com/spf13/cobra/command.go:632 +0x2df github.com/apache/incubator-openwhisk-wskdeploy/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x57a3c0, 0x3aab11, 0x0, 0x0) /home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/vendor/github.com/spf13/cobra/command.go:722 +0x285 github.com/apache/incubator-openwhisk-wskdeploy/vendor/github.com/spf13/cobra.(*Command).Execute(0x57a3c0, 0x109f8450, 0x1091c0f0) /home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/vendor/github.com/spf13/cobra/command.go:681 +0x1b github.com/apache/incubator-openwhisk-wskdeploy/cmd.Execute() /home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/cmd/root.go:56 +0x1d main.main() /home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/main.go:26 +0x11 ``` Might be a good idea to also add validation to the `manifest.yaml` file so we don't give crash whenever they have an outdated `manifest.yml` but inform them in a nicer way. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on a change in pull request #868: Append bundled dependencies into LICENSE file
pritidesai commented on a change in pull request #868: Append bundled dependencies into LICENSE file URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/868#discussion_r182258652 ## File path: LICENSE.txt ## @@ -200,3 +200,824 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. + + This distribution has a binary dependency on jibber_jabber (https://github.com/cloudfoundry-attic/jibber_jabber), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on afero (https://github.com/spf13/afero), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on cobra (https://github.com/spf13/cobra), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on mousetrap (https://github.com/inconshreveable/mousetrap), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on stacktrace (https://github.com/palantir/stacktrace), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on yaml (https://github.com/go-yaml/yaml), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on properties (https://github.com/magiconair/properties), + which is available under a "2-clause BSD" license. (as below) + + goproperties - properties file decoder for Go Review comment: how about we add a link to this license file here https://github.com/magiconair/properties/blob/master/LICENSE and every where else. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on a change in pull request #868: Append bundled dependencies into LICENSE file
pritidesai commented on a change in pull request #868: Append bundled dependencies into LICENSE file URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/868#discussion_r182263319 ## File path: LICENSE.txt ## @@ -200,3 +200,824 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. Review comment: Thanks a bunch @daisy-ycguo for adding such a comprehensive list of dependencies, you have got most of all except one `incubator-openwhisk-client-go` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on a change in pull request #868: Append bundled dependencies into LICENSE file
pritidesai commented on a change in pull request #868: Append bundled dependencies into LICENSE file URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/868#discussion_r182259098 ## File path: LICENSE.txt ## @@ -200,3 +200,824 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. + + This distribution has a binary dependency on jibber_jabber (https://github.com/cloudfoundry-attic/jibber_jabber), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on afero (https://github.com/spf13/afero), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on cobra (https://github.com/spf13/cobra), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on mousetrap (https://github.com/inconshreveable/mousetrap), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on stacktrace (https://github.com/palantir/stacktrace), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on yaml (https://github.com/go-yaml/yaml), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on properties (https://github.com/magiconair/properties), + which is available under a "2-clause BSD" license. (as below) + + goproperties - properties file decoder for Go + + Copyright (c) 2013-2018 - Frank Schroeder + + All rights reserved. + + Redistribution and use in source and binary forms, with or without + modification, are permitted provided that the following conditions are met: + + 1. Redistributions of source code must retain the above copyright notice, this + list of conditions and the following disclaimer. + 2. Redistributions in binary form must reproduce the above copyright notice, + this list of conditions and the following disclaimer in the documentation + and/or other materials provided with the distribution. + + THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND + ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED + WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE + DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR + ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES + (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; + LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND + ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS + SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + + This distribution has a binary dependency on fsnotify (https://github.com/fsnotify/fsnotify), + which is available under a "3-clause BSD" license. ( as below) + +Copyright (c) 2012 The Go Authors. All rights reserved. +Copyright (c) 2012 fsnotify Authors. All rights reserved. + +Redistribution and use in source and binary forms, with or without +modification, are permitted provided that the following conditions are +met: + + * Redistributions of source code must retain the above copyright +notice, this list of conditions and the following disclaimer. + * Redistributions in binary form must reproduce the above +copyright notice, this list of conditions and the following disclaimer +in the documentation and/or other materials provided with the +distribution. + * Neither the name of Google Inc. nor the names of its +contributors may be used to endorse or promote products derived from +this software without specific prior written permission. + +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + + This distribution has a binary dependency on go-querystring (https://github.com/google/go-querystring), Review comment: can we add a separation between two depen
[GitHub] pritidesai commented on a change in pull request #868: Append bundled dependencies into LICENSE file
pritidesai commented on a change in pull request #868: Append bundled dependencies into LICENSE file URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/868#discussion_r182258295 ## File path: LICENSE.txt ## @@ -200,3 +200,824 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. + + This distribution has a binary dependency on jibber_jabber (https://github.com/cloudfoundry-attic/jibber_jabber), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on afero (https://github.com/spf13/afero), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on cobra (https://github.com/spf13/cobra), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on mousetrap (https://github.com/inconshreveable/mousetrap), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on stacktrace (https://github.com/palantir/stacktrace), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on yaml (https://github.com/go-yaml/yaml), Review comment: `yaml` is a go library, isn't it? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on a change in pull request #868: Append bundled dependencies into LICENSE file
pritidesai commented on a change in pull request #868: Append bundled dependencies into LICENSE file URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/868#discussion_r182256769 ## File path: LICENSE.txt ## @@ -200,3 +200,824 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. + Review comment: @daisy-ycguo please add a list of references from where you composed following list of dependencies, for example, `Godeps.json` or `build.gradle` etc. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on a change in pull request #868: Append bundled dependencies into LICENSE file
pritidesai commented on a change in pull request #868: Append bundled dependencies into LICENSE file URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/868#discussion_r182262662 ## File path: LICENSE.txt ## @@ -200,3 +200,824 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. + + This distribution has a binary dependency on jibber_jabber (https://github.com/cloudfoundry-attic/jibber_jabber), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on afero (https://github.com/spf13/afero), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on cobra (https://github.com/spf13/cobra), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on mousetrap (https://github.com/inconshreveable/mousetrap), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on stacktrace (https://github.com/palantir/stacktrace), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on yaml (https://github.com/go-yaml/yaml), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on properties (https://github.com/magiconair/properties), + which is available under a "2-clause BSD" license. (as below) + + goproperties - properties file decoder for Go + + Copyright (c) 2013-2018 - Frank Schroeder + + All rights reserved. + + Redistribution and use in source and binary forms, with or without + modification, are permitted provided that the following conditions are met: + + 1. Redistributions of source code must retain the above copyright notice, this + list of conditions and the following disclaimer. + 2. Redistributions in binary form must reproduce the above copyright notice, + this list of conditions and the following disclaimer in the documentation + and/or other materials provided with the distribution. + + THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND + ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED + WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE + DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR + ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES + (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; + LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND + ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS + SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + + This distribution has a binary dependency on fsnotify (https://github.com/fsnotify/fsnotify), + which is available under a "3-clause BSD" license. ( as below) + +Copyright (c) 2012 The Go Authors. All rights reserved. +Copyright (c) 2012 fsnotify Authors. All rights reserved. + +Redistribution and use in source and binary forms, with or without +modification, are permitted provided that the following conditions are +met: + + * Redistributions of source code must retain the above copyright +notice, this list of conditions and the following disclaimer. + * Redistributions in binary form must reproduce the above +copyright notice, this list of conditions and the following disclaimer +in the documentation and/or other materials provided with the +distribution. + * Neither the name of Google Inc. nor the names of its +contributors may be used to endorse or promote products derived from +this software without specific prior written permission. + +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + + This distribution has a binary dependency on go-querystring (https://github.com/google/go-querystring), + which is available under a "3-clause BSD" license. ( as bel
[GitHub] pritidesai commented on a change in pull request #868: Append bundled dependencies into LICENSE file
pritidesai commented on a change in pull request #868: Append bundled dependencies into LICENSE file URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/868#discussion_r182258652 ## File path: LICENSE.txt ## @@ -200,3 +200,824 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. + + This distribution has a binary dependency on jibber_jabber (https://github.com/cloudfoundry-attic/jibber_jabber), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on afero (https://github.com/spf13/afero), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on cobra (https://github.com/spf13/cobra), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on mousetrap (https://github.com/inconshreveable/mousetrap), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on stacktrace (https://github.com/palantir/stacktrace), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on yaml (https://github.com/go-yaml/yaml), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on properties (https://github.com/magiconair/properties), + which is available under a "2-clause BSD" license. (as below) + + goproperties - properties file decoder for Go Review comment: how about we add a link to this license file here https://github.com/magiconair/properties/blob/master/LICENSE This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on a change in pull request #868: Append bundled dependencies into LICENSE file
pritidesai commented on a change in pull request #868: Append bundled dependencies into LICENSE file URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/868#discussion_r182258951 ## File path: LICENSE.txt ## @@ -200,3 +200,824 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. + + This distribution has a binary dependency on jibber_jabber (https://github.com/cloudfoundry-attic/jibber_jabber), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on afero (https://github.com/spf13/afero), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on cobra (https://github.com/spf13/cobra), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on mousetrap (https://github.com/inconshreveable/mousetrap), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on stacktrace (https://github.com/palantir/stacktrace), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on yaml (https://github.com/go-yaml/yaml), + which is available under Apache License, Version 2. (as above) + + This distribution has a binary dependency on properties (https://github.com/magiconair/properties), + which is available under a "2-clause BSD" license. (as below) + + goproperties - properties file decoder for Go + + Copyright (c) 2013-2018 - Frank Schroeder + + All rights reserved. + + Redistribution and use in source and binary forms, with or without + modification, are permitted provided that the following conditions are met: + + 1. Redistributions of source code must retain the above copyright notice, this + list of conditions and the following disclaimer. + 2. Redistributions in binary form must reproduce the above copyright notice, + this list of conditions and the following disclaimer in the documentation + and/or other materials provided with the distribution. + + THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND + ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED + WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE + DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR + ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES + (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; + LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND + ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS + SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + + This distribution has a binary dependency on fsnotify (https://github.com/fsnotify/fsnotify), Review comment: adding link https://github.com/fsnotify/fsnotify/blob/master/LICENSE here? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tysonnorris closed pull request #3548: Implement possibility to discover cluster nodes via Akka Management.
tysonnorris closed pull request #3548: Implement possibility to discover
cluster nodes via Akka Management.
URL: https://github.com/apache/incubator-openwhisk/pull/3548
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ansible/roles/controller/tasks/deploy.yml
b/ansible/roles/controller/tasks/deploy.yml
index 87167f5041..d543a40442 100644
--- a/ansible/roles/controller/tasks/deploy.yml
+++ b/ansible/roles/controller/tasks/deploy.yml
@@ -93,21 +93,9 @@
set_fact:
controller_args: "{{ controller.arguments }} {{ jmx.jvmCommonArgs }}
-Djava.rmi.server.hostname={{ inventory_hostname }}
-Dcom.sun.management.jmxremote.rmi.port={{ jmx.rmiBasePortController +
(controller_index | int) }} -Dcom.sun.management.jmxremote.port={{
jmx.basePortController + (controller_index | int) }}"
-- name: create seed nodes list
+- name: populate environment variables for controller
set_fact:
-seed_nodes_list: "{{ seed_nodes_list | default([]) }} + [
\"{{item.1}}:{{controller.akka.cluster.basePort+item.0}}\" ]"
- with_indexed_items:
- - "{{ controller.akka.cluster.seedNodes }}"
-
-- name: (re)start controller
- docker_container:
-name: "{{ controller_name }}"
-image: "{{ docker_registry }}{{ docker.image.prefix }}/controller:{{
docker.image.tag }}"
-state: started
-recreate: true
-restart_policy: "{{ docker.restart.policy }}"
-hostname: "{{ controller_name }}"
-env:
+controller_env:
"JAVA_OPTS": "-Xmx{{ controller.heap }} -XX:+CrashOnOutOfMemoryError
-XX:+UseGCOverheadLimit -XX:ErrorFile=/logs/java_error.log
-XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=/logs"
"CONTROLLER_OPTS": "{{ controller_args | default(controller.arguments)
}}"
"CONTROLLER_INSTANCES": "{{ controller.instances }}"
@@ -171,7 +159,6 @@
"CONFIG_whisk_runtimes_bypassPullForLocalImages": "{{
runtimes_bypass_pull_for_local_images | default() }}"
"CONFIG_whisk_runtimes_localImagePrefix": "{{
runtimes_local_image_prefix | default() }}"
- "AKKA_CLUSTER_SEED_NODES": "{{seed_nodes_list | join(' ') }}"
"METRICS_KAMON": "{{ metrics.kamon.enabled }}"
"METRICS_KAMON_TAGS": "{{ metrics.kamon.tags }}"
"METRICS_LOG": "{{ metrics.log.enabled }}"
@@ -199,6 +186,28 @@
"CONFIG_logback_log_level": "{{ controller.loglevel }}"
"CONFIG_whisk_transactions_stride": "{{ transactions.stride | default()
}}"
+
+- name: create seed nodes list
+ set_fact:
+seed_nodes_list: "{{ seed_nodes_list | default([]) }} + [ '{{ item.1 }}:{{
controller.akka.cluster.basePort+item.0 }}' ]"
+ with_indexed_items:
+ - "{{ controller.akka.cluster.seedNodes }}"
+
+- name: add seed nodes to controller environment
+ set_fact:
+controller_env: "{{ controller_env | default({}) |
combine({'CONFIG_akka_cluster_seedNodes_' ~ item.0:
'akka.tcp://controller-actor-system@' ~ item.1}) }}"
+ with_indexed_items: "{{ seed_nodes_list }}"
+
+
+- name: (re)start controller
+ docker_container:
+name: "{{ controller_name }}"
+image: "{{ docker_registry }}{{ docker.image.prefix }}/controller:{{
docker.image.tag }}"
+state: started
+recreate: true
+restart_policy: "{{ docker.restart.policy }}"
+hostname: "{{ controller_name }}"
+env: "{{ controller_env }}"
volumes:
- "{{ whisk_logs_dir }}/{{ controller_name }}:/logs"
- "{{ controller.confdir }}/{{ controller_name }}:/conf"
diff --git a/common/scala/src/main/scala/whisk/core/WhiskConfig.scala
b/common/scala/src/main/scala/whisk/core/WhiskConfig.scala
index c9683d62db..36f74e02fd 100644
--- a/common/scala/src/main/scala/whisk/core/WhiskConfig.scala
+++ b/common/scala/src/main/scala/whisk/core/WhiskConfig.scala
@@ -205,6 +205,7 @@ object WhiskConfig {
}
object ConfigKeys {
+ val cluster = "whisk.cluster"
val loadbalancer = "whisk.loadbalancer"
val couchdb = "whisk.couchdb"
diff --git a/core/controller/build.gradle b/core/controller/build.gradle
index 2a184d15d7..8a50af38b9 100644
--- a/core/controller/build.gradle
+++ b/core/controller/build.gradle
@@ -15,6 +15,9 @@ repositories {
dependencies {
compile "org.scala-lang:scala-library:${gradle.scala.version}"
+compile
'com.lightbend.akka.management:akka-management-cluster-bootstrap_2.11:0.11.0'
+compile
'com.lightbend.akka.discovery:akka-discovery-kubernetes-api_2.11:0.11.0'
+compile
'com.lightbend.akka.discovery:akka-discovery-marathon-api_2.11:0.11.0'
compile project(':common:scala')
}
diff --git a/core/controller/src/main/resources/application.conf
b/core/controller/src/main/resources/application.conf
index 446d5fed34..e72bbc3b38 100644
--- a/core/controller/src/main/resources/application.conf
+++ b/core/controller/src/main/resources/application.con
[GitHub] yadavvipinsonu commented on issue #2317: wsk api authentication issues
yadavvipinsonu commented on issue #2317: wsk api authentication issues
URL:
https://github.com/apache/incubator-openwhisk/issues/2317#issuecomment-382166164
Hi @mdeuser @akrabat @rabbah @jthomas @jcrossley3
I tried to run installRouteMgmt.sh , by passing all the parameters required
to it in both(ubuntu and cent-OS ) environments
AUTH="23bc46b1-71f6-4ed5-8c54-816aa4f8c502:123zO3xZCLrMN6v2BKK1dXYFpXlPkccOFqm12CdAsMgRU4VrNZ9lyGVCGuMDGIwP"
APIHOST="https://10.123.70.204";
NAMESPACE="guest"
OPENWHISK_HOME="/home/ubuntu/incubator-openwhisk-devtools/docker-compose/openwhisk-master"
WSK_CLI="/home/ubuntu/incubator-openwhisk-devtools/docker-compose/openwhisk-master/bin/wsk"
GW_USER=""
GW_PWD=""
GW_HOST_V2="https://10.123.70.204:9000/v1";
then ran below command
$WSK_CLI -i --apihost "$APIHOST" package update --auth "$AUTH" --shared no
"$NAMESPACE/apimgmt" -a description "This package manages the gateway API
configuration." -p gwUser "$GW_USER" -p gwPwd "$GW_PWD" -p gwUrlV2
"$GW_HOST_V2" -d -v
Output
ubuntu@ip-10-123-70-204:~/incubator-openwhisk-devtools/docker-compose/openwhisk-master/bin$
$WSK_CLI -i --apihost "$APIHOST" package update --auth "$AUTH" --shared no
"$NAMESPACE/apimgmt" -a description "This package manages the gateway API
configuration." -p gwUser "$GW_USER" -p gwPwd "$GW_PWD" -p gwUrlV2
"$GW_HOST_V2" -d -v
[commands.NewQualifiedName]:132:[Inf] Qualified pkg+entity (EntityName):
guest/apimgmt
[commands.NewQualifiedName]:133:[Inf] Qualified namespace: guest
[commands.NewQualifiedName]:134:[Inf] Qualified package: guest
[commands.NewQualifiedName]:135:[Inf] Qualified entity: apimgmt
[-cli/commands.parseShared]:988:[Err] Sharing is 'false'
[k-cli/commands/package.go]:224:[Inf] Parsing parameters:
[]string{"{\"gwUser\": \"\"}", "{\"gwPwd\": \"\"}", "{\"gwUrlV2\":
\"https://10.123.70.204:9000/v1\"}"}
[mmands.getJSONFromStrings]:058:[Inf] Convert content to JSON:
[]string{"{\"gwUser\": \"\"}", "{\"gwPwd\": \"\"}", "{\"gwUrlV2\":
\"https://10.123.70.204:9000/v1\"}"}
[mmands.getJSONFromStrings]:068:[Inf] Created map 'map[gwUser:]' from
'{"gwUser": ""}'
[mmands.getJSONFromStrings]:068:[Inf] Created map 'map[gwUser: gwPwd:]' from
'{"gwPwd": ""}'
[mmands.getJSONFromStrings]:068:[Inf] Created map 'map[gwUser: gwPwd:
gwUrlV2:https://10.123.70.204:9000/v1]' from '{"gwUrlV2":
"https://10.123.70.204:9000/v1"}'
[.getKeyValueFormattedJSON]:091:[Inf] Created key/value format '[{gwUser }
{gwPwd } {gwUrlV2 https://10.123.70.204:9000/v1}]' from 'map[gwPwd:
gwUrlV2:https://10.123.70.204:9000/v1 gwUser:]'
[k-cli/commands/package.go]:235:[Inf] Parsing annotations:
[]string{"{\"description\": \"This package manages the gateway API
configuration.\"}"}
[mmands.getJSONFromStrings]:058:[Inf] Convert content to JSON:
[]string{"{\"description\": \"This package manages the gateway API
configuration.\"}"}
[mmands.getJSONFromStrings]:068:[Inf] Created map 'map[description:This
package manages the gateway API configuration.]' from '{"description": "This
package manages the gateway API configuration."}'
[.getKeyValueFormattedJSON]:091:[Inf] Created key/value format
'[{description This package manages the gateway API configuration.}]' from
'map[description:This package manages the gateway API configuration.]'
[k.(*Client).addAuthHeader]:298:[Inf] Adding basic auth header; using authkey
REQUEST:
[PUT]
https://10.123.70.204/api/v1/namespaces/guest/packages/guest/apimgmt?overwrite=true
Req Headers
{
"Authorization": [
"Basic
MjNiYzQ2YjEtNzFmNi00ZWQ1LThjNTQtODE2YWE0ZjhjNTAyOjEyM3pPM3haQ0xyTU42djJCS0sxZFhZRnBYbFBrY2NPRnFtMTJDZEFzTWdSVTRWck5aOWx5R1ZDR3VNREdJd1A="
],
"Content-Type": [
"application/json"
],
"User-Agent": [
"OpenWhisk-CLI/1.0 (2018-04-17T03:17:54.816+)"
]
}
Req Body
{"namespace":"guest","name":"guest/apimgmt","publish":false,"annotations":[{"key":"description","value":"This
package manages the gateway API
configuration."}],"parameters":[{"key":"gwUser","value":""},{"key":"gwPwd","value":""},{"key":"gwUrlV2","value":"https://10.123.70.204:9000/v1"}]}
[go/whisk.PrintRequestInfo]:458:[Inf] Req Body (ASCII quoted string):
"{\"namespace\":\"guest\",\"name\":\"guest/apimgmt\",\"publish\":false,\"annotations\":[{\"key\":\"description\",\"value\":\"This
package manages the gateway API
configuration.\"}],\"parameters\":[{\"key\":\"gwUser\",\"value\":\"\"},{\"key\":\"gwPwd\",\"value\":\"\"},{\"key\":\"gwUrlV2\",\"value\":\"https://10.123.70.204:9000/v1\"}]}\n";
RESPONSE:Got response with code 404
Resp Headers
{
"Connection": [
"keep-alive"
],
"Content-Length": [
"64"
],
"Content-Type": [
"application/json"
],
"Date": [
"Tue, 17 Apr 2018 21:41:26 GMT"
],
"Server": [
"openwhisk/api-gateway-1.9.3.1
[GitHub] sciabarracom opened a new pull request #45: Image actionloop-swift based on the actionloop (goproxy)
sciabarracom opened a new pull request #45: Image actionloop-swift based on the actionloop (goproxy) URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/45 To build the image you need as a base image the actionloop image. Currently you have to build it from https://github.com/sciabarracom/incubator-openwhisk-runtime-go because the proxy is not yet fully merged in apache/incubator-openwhisk-runtime-go The epilogue does not yet support Codable (I cannot code enough swift to fix it). However the image is able to accept binaries and "simple" swift source actions. The image can also work as offline compiler. For example if you have a src/main.swift, you can do: docker run -v $PWD/src:/src $PWD/out:/out actionloop-swift-v4.1 compile it will produce a out/main also with a function "hello" in src/hello.swift docker run -v $PWD/src:/src $PWD/out:/out actionloop-swift-v4.1 compile hello will use the function hello and produce the out/hello binary This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yadavvipinsonu commented on issue #2317: wsk api authentication issues
yadavvipinsonu commented on issue #2317: wsk api authentication issues URL: https://github.com/apache/incubator-openwhisk/issues/2317#issuecomment-382111360 Hi @mdeuser @akrabat @rabbah @jthomas @jcrossley3 We are trying to install and use openwhisk in corporate environment. Cent-OS is the preferred operating system that we want to use. Is there any documentation , webpages that have all the steps in detail for the installation process. It seems api functions (api list ,create) are not working when we tried installation through below links 1. https://github.com/apache/incubator-openwhisk 2. https://github.com/apache/incubator-openwhisk-devtools 3. https://blog.krugazor.eu/2017/12/openwhisk-centos-installation-part-2/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #184: helm: get runtimes from runtimes.json
dgrove-oss commented on issue #184: helm: get runtimes from runtimes.json URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/184#issuecomment-382145921 @xingzhou -- does this change look sensible to you? Seems to do what I want, but I'm still early on learning helm. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss opened a new pull request #184: helm: get runtimes from runtimes.json
dgrove-oss opened a new pull request #184: helm: get runtimes from runtimes.json URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/184 1. The set of runtimes is now read from runtimes.json (or runtime-minimal-travis.json) instead of being hardwired. 2. Add init container to invoker_deployment to do docker pull of runtimes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3558: WebTrigger (WebAction async)
rabbah commented on issue #3558: WebTrigger (WebAction async) URL: https://github.com/apache/incubator-openwhisk/issues/3558#issuecomment-382143947 Note the reason for suggesting a different URI (vs a header) is for general convenience. Often when firing a webhook configuring the http request with a custom header is not part of the available feature set from the source. In general calling this a trigger may suggest one can attach a rule and get 1-n broadcasting. So we’re carefully considering here that this is a 1-1 case to async invoke the webaction only for now. No custom codes/response or rules, yet. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3558: WebTrigger (WebAction async)
rabbah commented on issue #3558: WebTrigger (WebAction async) URL: https://github.com/apache/incubator-openwhisk/issues/3558#issuecomment-382143947 Note the reason for suggesting an different URI (vs a header) is for general convenience. Often when firing a webhook configuring the http request with a custom header is not part of the available feature set from the source. In general calling this a trigger may suggest one can attach a rule and get 1-n broadcasting. So we’re carefully considering here that this is a 1-1 case to async invoke the webaction only for now. No custom codes/response or rules, yet. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new issue #3558: WebTrigger (WebAction async)
csantanapr opened a new issue #3558: WebTrigger (WebAction async)
URL: https://github.com/apache/incubator-openwhisk/issues/3558
So far in multiple occasions have talk to customers/users using OpenWhisk
that they have a need to call a Web Action but want the Action to return right
away but continue to do business logic.
One tangible use case is Web Analytics:
Web sites will call a web url on APIGateway, they would get back 202
response right away with the activation id of the web action.
The action will process the http request, taking more time (i.e. 1 second).
The web site doesn't have to wait 1 second for it.
The current way of achieving is not optimal and I see a lot of folks copy
pasting the same solution.
Were the web action will invoke another action that does the real work in
async for example using the npm package "openwhisk" and then returning 202 with
the activation id back to web client.
For every call it would generate 2 action invocations and user might reach
concurrent or minuteRate limits, in addition creating activation records for
web actions that don't do much just schedule an action.
The proposal is to have a url for the web action that the controller will
return right away with 202 and the activation id back to web client, and
schedule the web action to run async.
Web Action url sync => `https://${APIHOST}/api/v1/web/guest/demo/hello`
Web Trigger url async =>
`https://${APIHOST}/api/v1/web/trigger/guest/demo/hello`
This might sound like a Web Hook, but I think Web Hook have a bit more
complexity and a Web Hook I would say is an implementation using the Web Action
sync url.
Ref: https://webhooks.pbworks.com/w/page/13385124/FrontPage
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] houshengbo opened a new pull request #38: Add the licenses of the dependencies into LICENSE
houshengbo opened a new pull request #38: Add the licenses of the dependencies into LICENSE URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/38 Partially-closes: apache/incubator-openwhisk-release#109 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #117: Update project_licenses.md to include tracking issues and latest PR updates
houshengbo closed pull request #117: Update project_licenses.md to include tracking issues and latest PR updates URL: https://github.com/apache/incubator-openwhisk-release/pull/117 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee closed pull request #26: update spray json import
dubee closed pull request #26: update spray json import
URL: https://github.com/apache/incubator-openwhisk-package-deploy/pull/26
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tests/src/test/scala/packages/DeployTests.scala
b/tests/src/test/scala/packages/DeployTests.scala
index c85c3b1..178f6b3 100644
--- a/tests/src/test/scala/packages/DeployTests.scala
+++ b/tests/src/test/scala/packages/DeployTests.scala
@@ -22,8 +22,8 @@ import org.junit.runner.RunWith
import org.scalatest.BeforeAndAfterAll
import org.scalatest.junit.JUnitRunner
import common.{TestHelpers, Wsk, WskProps, WskTestHelpers}
-import spray.json.DefaultJsonProtocol.StringJsonFormat
import spray.json._
+import spray.json.DefaultJsonProtocol._
@RunWith(classOf[JUnitRunner])
class DeployTests extends TestHelpers
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] yadavvipinsonu opened a new issue #3557: API functionality not working
yadavvipinsonu opened a new issue #3557: API functionality not working URL: https://github.com/apache/incubator-openwhisk/issues/3557 Hi , We are trying to install and use openwhisk in corporate environment. Cent-OS is the preferred operating system that we want to use. Is there any documentation , webpages that have all the steps in detail for the installation process. It seems api functions (api list ,create) are not working when we tried installation through below links https://github.com/apache/incubator-openwhisk https://github.com/apache/incubator-openwhisk-devtools https://blog.krugazor.eu/2017/12/openwhisk-centos-installation-part-2/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yadavvipinsonu commented on issue #2317: wsk api authentication issues
yadavvipinsonu commented on issue #2317: wsk api authentication issues URL: https://github.com/apache/incubator-openwhisk/issues/2317#issuecomment-382111360 Hi @mdeuser , We are trying to install and use openwhisk in corporate environment. Cent-OS is the preferred operating system that we want to use. Is there any documentation , webpages that have all the steps in detail for the installation process. It seems api functions (api list ,create) are not working when we tried installation through below links 1. https://github.com/apache/incubator-openwhisk 2. https://github.com/apache/incubator-openwhisk-devtools 3. https://blog.krugazor.eu/2017/12/openwhisk-centos-installation-part-2/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3556: Add latency test with gatling.
rabbah commented on a change in pull request #3556: Add latency test with gatling. URL: https://github.com/apache/incubator-openwhisk/pull/3556#discussion_r182193807 ## File path: performance/README.md ## @@ -61,3 +61,33 @@ You can run the simulation with (in OPENWHISK_HOME) ``` OPENWHISK_HOST="openwhisk.mydomain.com" CONNECTIONS="10" REQUESTS_PER_SEC="50" ./gradlew gatlingRun-ApiV1Simulation ``` + +# LatencySimulation + +This simulation creates actions of the following four kinds: nodejs:default, swift:default, java:default and +python:default. +Afterwards the action is invoked once. This is the cold-start and will not be part of the thresholds. +Next, the action will be invoked 100 times one after each other. The last step is, that the action will be deleted. + +Once one language is finished, the next kind will be taken. They are not running in parallel. There are never more than +1 activations in the system, as we only want to meassure latency of warm activations. Review comment: Is this guaranteed with a blocking invoke then? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3556: Add latency test with gatling.
rabbah commented on a change in pull request #3556: Add latency test with
gatling.
URL:
https://github.com/apache/incubator-openwhisk/pull/3556#discussion_r182194427
##
File path: performance/gatling_tests/src/gatling/resources/data/nodeJSAction.js
##
@@ -0,0 +1,5 @@
+function main(params) {
+var greeting = "Hello" + (params.text || "stranger") + "!";
+console.log(greeting);
+return { payload: greeting };
+}
Review comment:
It seems unnecessary to duplicate these tests aren’t there a consistent set
of basic actions for all runtimes in the tests/dat/actions folder?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3556: Add latency test with gatling.
rabbah commented on a change in pull request #3556: Add latency test with gatling. URL: https://github.com/apache/incubator-openwhisk/pull/3556#discussion_r182193281 ## File path: performance/README.md ## @@ -61,3 +61,33 @@ You can run the simulation with (in OPENWHISK_HOME) ``` OPENWHISK_HOST="openwhisk.mydomain.com" CONNECTIONS="10" REQUESTS_PER_SEC="50" ./gradlew gatlingRun-ApiV1Simulation ``` + +# LatencySimulation Review comment: Latency Simulation? (Two words?) Please backtick the kinds below. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3556: Add latency test with gatling.
rabbah commented on a change in pull request #3556: Add latency test with gatling. URL: https://github.com/apache/incubator-openwhisk/pull/3556#discussion_r182194131 ## File path: performance/README.md ## @@ -61,3 +61,33 @@ You can run the simulation with (in OPENWHISK_HOME) ``` OPENWHISK_HOST="openwhisk.mydomain.com" CONNECTIONS="10" REQUESTS_PER_SEC="50" ./gradlew gatlingRun-ApiV1Simulation ``` + +# LatencySimulation + +This simulation creates actions of the following four kinds: nodejs:default, swift:default, java:default and +python:default. +Afterwards the action is invoked once. This is the cold-start and will not be part of the thresholds. +Next, the action will be invoked 100 times one after each other. The last step is, that the action will be deleted. + +Once one language is finished, the next kind will be taken. They are not running in parallel. There are never more than +1 activations in the system, as we only want to meassure latency of warm activations. Review comment: I think you’re expecting this invariant to hold irrespective of number of controllers or invokers in system. If so can you add this stipulation as well? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #117: Update project_licenses.md to include tracking issues and latest PR updates
mrutkows opened a new pull request #117: Update project_licenses.md to include tracking issues and latest PR updates URL: https://github.com/apache/incubator-openwhisk-release/pull/117 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai closed pull request #866: Export blackbox
pritidesai closed pull request #866: Export blackbox
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/866
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/cmd/export.go b/cmd/export.go
index 3585da51..51129473 100644
--- a/cmd/export.go
+++ b/cmd/export.go
@@ -29,7 +29,6 @@ import (
"github.com/apache/incubator-openwhisk-wskdeploy/deployers"
"github.com/apache/incubator-openwhisk-wskdeploy/parsers"
"github.com/apache/incubator-openwhisk-wskdeploy/utils"
- "github.com/apache/incubator-openwhisk-wskdeploy/wskderrors"
"github.com/apache/incubator-openwhisk-wskdeploy/wski18n"
"github.com/spf13/cobra"
)
@@ -83,16 +82,18 @@ func ExportAction(actionName string, packageName string,
maniyaml *parsers.YAML,
// store function file under action package name subdirectory
in the specified manifest folder
functionDir := filepath.Join(manifestDir, packageName)
- os.MkdirAll(functionDir, os.ModePerm)
- // save code file at the full path
+ // save the code in file
filename, err := saveCode(*wskAction, functionDir)
if err != nil {
return err
}
- // store function in manifest under path relative to manifest
root
- parsedAction.Function = filepath.Join(packageName, filename)
+ if filename != "" {
+ // store function in manifest if action has code section
+ parsedAction.Function = filepath.Join(packageName,
filename)
+ }
+
pkg.Actions[wskAction.Name] = parsedAction
}
@@ -307,7 +308,6 @@ func ExportCmdImp(cmd *cobra.Command, args []string) error {
const (
JAVA_EXT = ".jar"
ZIP_EXT = ".zip"
- BLACKBOX = "blackbox"
JAVA = "java"
)
@@ -330,13 +330,10 @@ func saveCode(action whisk.Action, directory string)
(string, error) {
exec = *action.Exec
runtime = strings.Split(exec.Kind, ":")[0]
- if strings.ToLower(runtime) == BLACKBOX {
- return "",
wskderrors.NewInvalidRuntimeError(wski18n.T(wski18n.ID_ERR_CANT_SAVE_DOCKER_RUNTIME),
- directory, action.Name, BLACKBOX,
utils.ListOfSupportedRuntimes(utils.SupportedRunTimes))
- }
-
if exec.Code != nil {
code = *exec.Code
+ } else {
+ return "", nil
}
var filename = ""
@@ -349,6 +346,8 @@ func saveCode(action whisk.Action, directory string)
(string, error) {
filename = action.Name + "." +
utils.FileRuntimeExtensionsMap[action.Exec.Kind]
}
+ os.MkdirAll(directory, os.ModePerm)
+
path := filepath.Join(directory, filename)
if err := utils.WriteFile(path, code); err != nil {
diff --git a/parsers/yamlparser.go b/parsers/yamlparser.go
index a4a8b792..551733a6 100644
--- a/parsers/yamlparser.go
+++ b/parsers/yamlparser.go
@@ -18,6 +18,8 @@
package parsers
import (
+ "strings"
+
"github.com/apache/incubator-openwhisk-client-go/whisk"
"github.com/apache/incubator-openwhisk-wskdeploy/utils"
"github.com/apache/incubator-openwhisk-wskdeploy/wskenv"
@@ -39,6 +41,7 @@ const (
YAML_KEY_SEQUENCE = "sequence"
YAML_KEY_TRIGGER= "trigger"
YAML_KEY_SOURCE = "source"
+ YAML_KEY_BLACKBOX = "blackbox"
)
// YAML schema key values
@@ -400,7 +403,6 @@ func (yaml *YAML) ComposeParsersAction(wskact whisk.Action)
*Action {
action.Name = wskact.Name
action.Namespace = wskact.Namespace
action.Version = wskact.Version
- action.Runtime = wskact.Exec.Kind
action.Inputs = make(map[string]Parameter)
for _, keyval := range wskact.Parameters {
@@ -410,6 +412,15 @@ func (yaml *YAML) ComposeParsersAction(wskact
whisk.Action) *Action {
}
action.Annotations = filterAnnotations(wskact.Annotations)
+
+ runtime := strings.Split(wskact.Exec.Kind, ":")[0]
+ if strings.ToLower(runtime) == YAML_KEY_BLACKBOX {
+ // storing blackbox image reference without saving the code as
its impossible
+ action.Docker = wskact.Exec.Image
+ } else {
+ action.Runtime = wskact.Exec.Kind
+ }
+
return action
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache
[GitHub] mdeuser commented on a change in pull request #276: allow exclusion of api_host validation
mdeuser commented on a change in pull request #276: allow exclusion of api_host
validation
URL:
https://github.com/apache/incubator-openwhisk-cli/pull/276#discussion_r182186977
##
File path: tests/src/test/scala/whisk/core/cli/test/WskCliBasicUsageTests.scala
##
@@ -555,7 +558,9 @@ class WskCliBasicUsageTests extends TestHelpers with
WskTestHelpers {
withActivation(wsk.activation, run) { activation =>
activation.response.status shouldBe "success"
val fields = activation.response.result.get.convertTo[Map[String,
String]]
- fields("api_host") shouldBe WhiskProperties.getApiHostForAction
+ if (!noApiHostCheck) {
Review comment:
@drcariel - nit.. double negative is a littler harder to read than `if
(apiHostCheck) {`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mdeuser commented on a change in pull request #276: allow exclusion of api_host validation
mdeuser commented on a change in pull request #276: allow exclusion of api_host
validation
URL:
https://github.com/apache/incubator-openwhisk-cli/pull/276#discussion_r182186977
##
File path: tests/src/test/scala/whisk/core/cli/test/WskCliBasicUsageTests.scala
##
@@ -555,7 +558,9 @@ class WskCliBasicUsageTests extends TestHelpers with
WskTestHelpers {
withActivation(wsk.activation, run) { activation =>
activation.response.status shouldBe "success"
val fields = activation.response.result.get.convertTo[Map[String,
String]]
- fields("api_host") shouldBe WhiskProperties.getApiHostForAction
+ if (!noApiHostCheck) {
Review comment:
@drcariel - nit.. double negative is a littler harder to read that `if
(apiHostCheck) {`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] beemarie commented on issue #26: update spray json import
beemarie commented on issue #26: update spray json import URL: https://github.com/apache/incubator-openwhisk-package-deploy/pull/26#issuecomment-382098740 @dubee feel free to merge if it LGTY This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee opened a new pull request #277: Remove JSON.parseFull references
dubee opened a new pull request #277: Remove JSON.parseFull references URL: https://github.com/apache/incubator-openwhisk-cli/pull/277 Remove `JSON.parseFull` references as it is deprecated causing Travis to fail. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #28: Add the licenses of the dependencies into LICENSE
houshengbo opened a new pull request #28: Add the licenses of the dependencies into LICENSE URL: https://github.com/apache/incubator-openwhisk-runtime-docker/pull/28 Partially-closes: apache/incubator-openwhisk-release#109 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #95: Document LICENSE file Exclusions for incubator-openwhisk-apigateway
mrutkows commented on issue #95: Document LICENSE file Exclusions for incubator-openwhisk-apigateway URL: https://github.com/apache/incubator-openwhisk-release/issues/95#issuecomment-382090902 apigateway repo. now uses ASF "strict" scancode config. after PR https://github.com/apache/incubator-openwhisk-apigateway/pull/273 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #108: Some files in openwhisk-apigateway still have bad headers
mrutkows commented on issue #108: Some files in openwhisk-apigateway still have bad headers URL: https://github.com/apache/incubator-openwhisk-release/issues/108#issuecomment-382095267 @daisy-ycguo @houshengbo Thanks for writing and merging PR https://github.com/apache/incubator-openwhisk-apigateway/pull/239 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] beemarie commented on a change in pull request #26: update spray json import
beemarie commented on a change in pull request #26: update spray json import
URL:
https://github.com/apache/incubator-openwhisk-package-deploy/pull/26#discussion_r182180542
##
File path: tests/src/test/scala/packages/DeployTests.scala
##
@@ -22,7 +22,6 @@ import org.junit.runner.RunWith
import org.scalatest.BeforeAndAfterAll
import org.scalatest.junit.JUnitRunner
import common.{TestHelpers, Wsk, WskProps, WskTestHelpers}
-import spray.json.DefaultJsonProtocol.StringJsonFormat
Review comment:
Yeah, you're right.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mrutkows commented on issue #95: Document LICENSE file Exclusions for incubator-openwhisk-apigateway
mrutkows commented on issue #95: Document LICENSE file Exclusions for incubator-openwhisk-apigateway URL: https://github.com/apache/incubator-openwhisk-release/issues/95#issuecomment-382090902 apigateway repo. now uses ASF "strict" scancode config. ater PR https://github.com/apache/incubator-openwhisk-apigateway/pull/289 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #289: Use ASF strict license checking configuration for scancode.
mrutkows commented on issue #289: Use ASF strict license checking configuration for scancode. URL: https://github.com/apache/incubator-openwhisk-apigateway/pull/289#issuecomment-382090406 @mhamann thanks Matt This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mhamann closed pull request #289: Use ASF strict license checking configuration for scancode.
mhamann closed pull request #289: Use ASF strict license checking configuration for scancode. URL: https://github.com/apache/incubator-openwhisk-apigateway/pull/289 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/tools/build/scanCode.cfg b/tools/build/scanCode.cfg deleted file mode 100644 index fa451e0..000 --- a/tools/build/scanCode.cfg +++ /dev/null @@ -1,43 +0,0 @@ -# scanCode.py configuration file - -# List of filenames containing the text of valid license (headers) -# These files SHOULD be in the same directory path where scanCode.py -# resides. -[Licenses] -ASFLicenseHeaderLua.txt - -# Filters (path/filename) with wildcards and associated scan checks -# that are to be run against them. The checks are actual valid -# function names found in scanCode.py. -[Includes] -*=is_not_symlink -*.scala=has_block_license, no_tabs, no_trailing_spaces, eol_at_eof -*.py=no_tabs, no_trailing_spaces, eol_at_eof -*.java=has_block_license, no_tabs, no_trailing_spaces, eol_at_eof -*.js=no_tabs, no_trailing_spaces, eol_at_eof -*.gradle=no_tabs, no_trailing_spaces, eol_at_eof -*.md=no_tabs, eol_at_eof -*.go=has_block_license, no_trailing_spaces, eol_at_eof -*.lua=has_block_license -build.xml=no_tabs, no_trailing_spaces, eol_at_eof -deploy.xml=no_tabs, no_trailing_spaces, eol_at_eof - -# List of paths (inclusive of subdirectories) to exlude from code scanning -[Excludes] -# General exclusions -.tox -.git -.bin - -# OpenWhisk APIGateway exclusions -lua_install -tests/lua_modules - -[Options] -# Not all code files allow licenses to appear starting at the first character -# of the file. This option tells the scan to allow licenses to appear starting -# within first 'x' characters of each code file (as provided by this option's -# value). -LICENSE_SLACK_LENGTH=500 - -[Regex] \ No newline at end of file diff --git a/tools/travis/build.sh b/tools/travis/build.sh index c8d72e7..f5f91e2 100755 --- a/tools/travis/build.sh +++ b/tools/travis/build.sh @@ -24,10 +24,11 @@ SCRIPTDIR="$(cd "$(dirname "$0")" && pwd)" ROOTDIR="$SCRIPTDIR/../.." HOMEDIR="$ROOTDIR/.." WHISKDIR="$ROOTDIR/../openwhisk" +UTILDIR="$ROOTDIR/../incubator-openwhisk-utilities" -# run the scancode util. against project source code starting at its root -cd $HOMEDIR -incubator-openwhisk-utilities/scancode/scanCode.py $ROOTDIR --config $ROOTDIR/tools/build/scanCode.cfg +# run scancode util. against project source using the ASF strict configuration +cd $UTILDIR +scancode/scanCode.py --config scancode/ASF-Release.cfg $ROOTDIR # Install OpenWhisk cd $WHISKDIR/ansible This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #14: Add the license of dependencies into LICENSE file
houshengbo opened a new pull request #14: Add the license of dependencies into LICENSE file URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/14 Partially-closes: apache/incubator-openwhisk-release#109 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on a change in pull request #26: update spray json import
dubee commented on a change in pull request #26: update spray json import
URL:
https://github.com/apache/incubator-openwhisk-package-deploy/pull/26#discussion_r182174361
##
File path: tests/src/test/scala/packages/DeployTests.scala
##
@@ -22,7 +22,6 @@ import org.junit.runner.RunWith
import org.scalatest.BeforeAndAfterAll
import org.scalatest.junit.JUnitRunner
import common.{TestHelpers, Wsk, WskProps, WskTestHelpers}
-import spray.json.DefaultJsonProtocol.StringJsonFormat
Review comment:
Might need `import spray.json.DefaultJsonProtocol._`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubee closed pull request #264: remove use of messageHubProduce action in health test and use java producer
dubee closed pull request #264: remove use of messageHubProduce action in
health test and use java producer
URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/264
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tests/src/test/scala/system/health/BasicHealthTest.scala
b/tests/src/test/scala/system/health/BasicHealthTest.scala
index c80458c..799b4db 100644
--- a/tests/src/test/scala/system/health/BasicHealthTest.scala
+++ b/tests/src/test/scala/system/health/BasicHealthTest.scala
@@ -17,6 +17,8 @@
package system.health
+import java.util.concurrent.{TimeUnit, TimeoutException}
+
import system.utils.KafkaUtils
import scala.concurrent.duration.DurationInt
@@ -34,6 +36,7 @@ import common.WskTestHelpers
import spray.json._
import spray.json.DefaultJsonProtocol._
import com.jayway.restassured.RestAssured
+import org.apache.kafka.clients.producer.ProducerRecord
import whisk.utils.retry;
@RunWith(classOf[JUnitRunner])
@@ -163,15 +166,21 @@ class BasicHealthTest
val key = "TheKey"
println("Producing a message")
- withActivation(wsk.activation,
wsk.action.invoke(s"$messagingPackage/$messageHubProduce", Map(
-"user" -> kafkaUtils.getAsJson("user"),
-"password" -> kafkaUtils.getAsJson("password"),
-"kafka_brokers_sasl" -> kafkaUtils.getAsJson("brokers"),
-"topic" -> topic.toJson,
-"key" -> key.toJson,
-"value" -> currentTime.toJson
- ))) {
-_.response.success shouldBe true
+ val producer = kafkaUtils.createProducer()
+ val record = new ProducerRecord(topic, key, currentTime)
+ val future = producer.send(record)
+
+ producer.flush()
+ producer.close()
+
+ try {
+val result = future.get(60, TimeUnit.SECONDS)
+
+println(s"Produced record to topic: ${result.topic()} on partition:
${result.partition()} at offset: ${result.offset()} with key: $key and value:
$currentTime.")
+ } catch {
+case e: TimeoutException =>
+ fail(s"TimeoutException received waiting for message to be produced
to topic: $topic with key: $key and value: $value. ${e.getMessage}")
+case e: Exception => throw e
}
retry({
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] drcariel closed pull request #276: allow exclusion of api_host validation
drcariel closed pull request #276: allow exclusion of api_host validation
URL: https://github.com/apache/incubator-openwhisk-cli/pull/276
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/tests/src/test/scala/whisk/core/cli/test/WskCliBasicUsageTests.scala
b/tests/src/test/scala/whisk/core/cli/test/WskCliBasicUsageTests.scala
index 0e8ab1c4..e4a1ae99 100644
--- a/tests/src/test/scala/whisk/core/cli/test/WskCliBasicUsageTests.scala
+++ b/tests/src/test/scala/whisk/core/cli/test/WskCliBasicUsageTests.scala
@@ -57,6 +57,9 @@ class WskCliBasicUsageTests extends TestHelpers with
WskTestHelpers {
val wsk = new Wsk
val defaultAction = Some(TestUtils.getTestActionFilename("hello.js"))
val usrAgentHeaderRegEx = """\bUser-Agent\b": \[\s+"OpenWhisk\-CLI/1.\d+.*"""
+ // certain environments may return router IP address instead of api_host
string causing a failure
+ // Set to true to avoid apihost check
+ val noApiHostCheck = false
behavior of "Wsk CLI usage"
@@ -555,7 +558,9 @@ class WskCliBasicUsageTests extends TestHelpers with
WskTestHelpers {
withActivation(wsk.activation, run) { activation =>
activation.response.status shouldBe "success"
val fields = activation.response.result.get.convertTo[Map[String,
String]]
- fields("api_host") shouldBe WhiskProperties.getApiHostForAction
+ if (!noApiHostCheck) {
+fields("api_host") shouldBe WhiskProperties.getApiHostForAction
+ }
fields("api_key") shouldBe wskprops.authKey
fields("namespace") shouldBe namespace
fields("action_name") shouldBe s"/$namespace/$name"
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] drcariel opened a new pull request #276: allow exclusion of api_host validation
drcariel opened a new pull request #276: allow exclusion of api_host validation URL: https://github.com/apache/incubator-openwhisk-cli/pull/276 certain environments may return router IP address instead of api_host string causing a failure Overriding noApiHostCheck to true will avoid the apihost check This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] beemarie opened a new pull request #26: update spray json import
beemarie opened a new pull request #26: update spray json import URL: https://github.com/apache/incubator-openwhisk-package-deploy/pull/26 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #103: Document LICENSE file Exclusions for incubator-openwhisk-runtime-php
mrutkows commented on issue #103: Document LICENSE file Exclusions for incubator-openwhisk-runtime-php URL: https://github.com/apache/incubator-openwhisk-release/issues/103#issuecomment-382080939 Vincent merged PR https://github.com/apache/incubator-openwhisk-runtime-php/pull/13#event-1579337468 @daisy-ycguo after this merge, do all files we determined need LICENSE headers have them? Are there any exclusions that we need to list on markdown here? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #116: Review list of proposed ScanCode exclusions for default configuration.
mrutkows commented on issue #116: Review list of proposed ScanCode exclusions for default configuration. URL: https://github.com/apache/incubator-openwhisk-release/issues/116#issuecomment-382080439 My first comment is that scancode default config today excludes "wski18n" which includes all JSON and generated file "i18n_resources.go"; do we wish the default config to be more precise by listing "i18n_resources.go" and use the default *.json to get all the country specific data files used for translated strings? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new issue #116: Review list of proposed ScanCode exclusions for default configuration.
mrutkows opened a new issue #116: Review list of proposed ScanCode exclusions for default configuration. URL: https://github.com/apache/incubator-openwhisk-release/issues/116 Looking at issue (apigateway): https://github.com/apache/incubator-openwhisk-apigateway/issues/273 It includes what looks like a comprehnsive list of exclusions for all repos. (verify with @daisy-ycguo). They appear a follows: ``` **/*.json **/**.gradle **/gradlew **/gradle/** **/.** **/templates/** **/*.j2.* **/.github/** **/auth.whisk.system **/auth.guest **/i18n_resources.go ``` we should review this list, discuss and open an Issue for update to ScanCode in the utilities repo. once we agree. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #273: A list of source files missing Apache license headers
mrutkows commented on issue #273: A list of source files missing Apache license headers URL: https://github.com/apache/incubator-openwhisk-apigateway/issues/273#issuecomment-382078711 Also, I am removing the local copy of scancode.cfg in this PR https://github.com/apache/incubator-openwhisk-apigateway/pull/289 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #273: A list of source files missing Apache license headers
mrutkows commented on issue #273: A list of source files missing Apache license headers URL: https://github.com/apache/incubator-openwhisk-apigateway/issues/273#issuecomment-382078469 @daisy-ycguo is your exclusion list specific to this repo.? or is it a general list for all repos? If that is the case, we should track the general exclusion in a tracking Issue under the "release" repo. and perhaps submit a specific issue to scancode (i.e, utilities repo) which we link in the tracking issue. We should discuss the general exclusion list in detail. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] abaruni commented on a change in pull request #264: remove use of messageHubProduce action in health test and use java producer
abaruni commented on a change in pull request #264: remove use of
messageHubProduce action in health test and use java producer
URL:
https://github.com/apache/incubator-openwhisk-package-kafka/pull/264#discussion_r182162754
##
File path: tests/src/test/scala/system/health/BasicHealthTest.scala
##
@@ -163,15 +166,21 @@ class BasicHealthTest
val key = "TheKey"
println("Producing a message")
- withActivation(wsk.activation,
wsk.action.invoke(s"$messagingPackage/$messageHubProduce", Map(
-"user" -> kafkaUtils.getAsJson("user"),
-"password" -> kafkaUtils.getAsJson("password"),
-"kafka_brokers_sasl" -> kafkaUtils.getAsJson("brokers"),
-"topic" -> topic.toJson,
-"key" -> key.toJson,
-"value" -> currentTime.toJson
- ))) {
-_.response.success shouldBe true
+ val producer = kafkaUtils.createProducer()
+ val record = new ProducerRecord(topic, key, currentTime)
+ val future = producer.send(record)
+
+ producer.flush()
+ producer.close()
+
+ try {
+val result = future.get(60, TimeUnit.SECONDS)
+
+println(s"Produced record to topic: ${result.topic()} on partition:
${result.partition()} at offset: ${result.offset()} with key: $key and value:
$currentTime.")
+ } catch {
Review comment:
i don't think it's necessary to retry at this time. if we do encounter
failed sending in the future then it is something we should revisit and likely
implement. this has less of a chance of failure compared to the produce action
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] abaruni commented on a change in pull request #264: remove use of messageHubProduce action in health test and use java producer
abaruni commented on a change in pull request #264: remove use of
messageHubProduce action in health test and use java producer
URL:
https://github.com/apache/incubator-openwhisk-package-kafka/pull/264#discussion_r182162353
##
File path: tests/src/test/scala/system/health/BasicHealthTest.scala
##
@@ -163,15 +166,21 @@ class BasicHealthTest
val key = "TheKey"
println("Producing a message")
- withActivation(wsk.activation,
wsk.action.invoke(s"$messagingPackage/$messageHubProduce", Map(
-"user" -> kafkaUtils.getAsJson("user"),
-"password" -> kafkaUtils.getAsJson("password"),
-"kafka_brokers_sasl" -> kafkaUtils.getAsJson("brokers"),
-"topic" -> topic.toJson,
-"key" -> key.toJson,
-"value" -> currentTime.toJson
- ))) {
-_.response.success shouldBe true
+ val producer = kafkaUtils.createProducer()
+ val record = new ProducerRecord(topic, key, currentTime)
+ val future = producer.send(record)
+
+ producer.flush()
+ producer.close()
Review comment:
```
/**
* Close this producer. This method blocks until all previously sent
requests complete.
* This method is equivalent to close(Long.MAX_VALUE,
TimeUnit.MILLISECONDS).
```
It should be safe. the call to flush will make it available immediately for
sending.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubee commented on a change in pull request #264: remove use of messageHubProduce action in health test and use java producer
dubee commented on a change in pull request #264: remove use of
messageHubProduce action in health test and use java producer
URL:
https://github.com/apache/incubator-openwhisk-package-kafka/pull/264#discussion_r182158374
##
File path: tests/src/test/scala/system/health/BasicHealthTest.scala
##
@@ -163,15 +166,21 @@ class BasicHealthTest
val key = "TheKey"
println("Producing a message")
- withActivation(wsk.activation,
wsk.action.invoke(s"$messagingPackage/$messageHubProduce", Map(
-"user" -> kafkaUtils.getAsJson("user"),
-"password" -> kafkaUtils.getAsJson("password"),
-"kafka_brokers_sasl" -> kafkaUtils.getAsJson("brokers"),
-"topic" -> topic.toJson,
-"key" -> key.toJson,
-"value" -> currentTime.toJson
- ))) {
-_.response.success shouldBe true
+ val producer = kafkaUtils.createProducer()
+ val record = new ProducerRecord(topic, key, currentTime)
+ val future = producer.send(record)
+
+ producer.flush()
+ producer.close()
Review comment:
Is it safe to close the producer before we are guaranteed that the message
was sent?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubee commented on a change in pull request #264: remove use of messageHubProduce action in health test and use java producer
dubee commented on a change in pull request #264: remove use of
messageHubProduce action in health test and use java producer
URL:
https://github.com/apache/incubator-openwhisk-package-kafka/pull/264#discussion_r182158205
##
File path: tests/src/test/scala/system/health/BasicHealthTest.scala
##
@@ -163,15 +166,21 @@ class BasicHealthTest
val key = "TheKey"
println("Producing a message")
- withActivation(wsk.activation,
wsk.action.invoke(s"$messagingPackage/$messageHubProduce", Map(
-"user" -> kafkaUtils.getAsJson("user"),
-"password" -> kafkaUtils.getAsJson("password"),
-"kafka_brokers_sasl" -> kafkaUtils.getAsJson("brokers"),
-"topic" -> topic.toJson,
-"key" -> key.toJson,
-"value" -> currentTime.toJson
- ))) {
-_.response.success shouldBe true
+ val producer = kafkaUtils.createProducer()
+ val record = new ProducerRecord(topic, key, currentTime)
+ val future = producer.send(record)
+
+ producer.flush()
+ producer.close()
+
+ try {
+val result = future.get(60, TimeUnit.SECONDS)
+
+println(s"Produced record to topic: ${result.topic()} on partition:
${result.partition()} at offset: ${result.offset()} with key: $key and value:
$currentTime.")
+ } catch {
Review comment:
Should we retry the send if an exception occurs?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] drcariel opened a new pull request #276: allow exclusion of api_host validation
drcariel opened a new pull request #276: allow exclusion of api_host validation URL: https://github.com/apache/incubator-openwhisk-cli/pull/276 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss opened a new pull request #183: update for INVOKER_USE_RUNC being moved to PureCondig.
dgrove-oss opened a new pull request #183: update for INVOKER_USE_RUNC being moved to PureCondig. URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/183 Update envvar name for upstream PR #3211 which moved the INVOKER_USE_RUNC flag to PureConfig / application.conf. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #13: Add license header
houshengbo closed pull request #13: Add license header URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/13 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/core/php7.1Action/Dockerfile b/core/php7.1Action/Dockerfile index f3cd93f..20eea35 100644 --- a/core/php7.1Action/Dockerfile +++ b/core/php7.1Action/Dockerfile @@ -1,7 +1,23 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for additional +# information regarding copyright ownership. The ASF licenses this file to you +# under the Apache License, Version 2.0 (the # "License"); you may not use this +# file except in compliance with the License. You may obtain a copy of the License +# at: +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software distributed +# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR +# CONDITIONS OF ANY KIND, either express or implied. See the License for the +# specific language governing permissions and limitations under the License. +# + FROM php:7.1-alpine RUN \ - + apk update && apk upgrade && \ # install dependencies This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #16: Add license headers
houshengbo closed pull request #16: Add license headers URL: https://github.com/apache/incubator-openwhisk-runtime-python/pull/16 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/core/python2Action/CHANGELOG.md b/core/python2Action/CHANGELOG.md index 5905061..bd1c0f2 100644 --- a/core/python2Action/CHANGELOG.md +++ b/core/python2Action/CHANGELOG.md @@ -1,3 +1,21 @@ + + # Python 2 OpenWhisk Runtime Container diff --git a/core/python2Action/Dockerfile b/core/python2Action/Dockerfile index 0d84504..47310f9 100644 --- a/core/python2Action/Dockerfile +++ b/core/python2Action/Dockerfile @@ -1,3 +1,19 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for additional +# information regarding copyright ownership. The ASF licenses this file to you +# under the Apache License, Version 2.0 (the # "License"); you may not use this +# file except in compliance with the License. You may obtain a copy of the License +# at: +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software distributed +# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR +# CONDITIONS OF ANY KIND, either express or implied. See the License for the +# specific language governing permissions and limitations under the License. +# + # Dockerfile for Python 2 actions, similar to the Python 3-based core/pythonAction FROM python:2.7.12-alpine diff --git a/core/pythonAction/CHANGELOG.md b/core/pythonAction/CHANGELOG.md index 278e93e..c415938 100644 --- a/core/pythonAction/CHANGELOG.md +++ b/core/pythonAction/CHANGELOG.md @@ -1,3 +1,21 @@ + + # Python 3 OpenWhisk Runtime Container diff --git a/core/pythonAction/Dockerfile b/core/pythonAction/Dockerfile index 017df09..df38484 100644 --- a/core/pythonAction/Dockerfile +++ b/core/pythonAction/Dockerfile @@ -1,3 +1,19 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for additional +# information regarding copyright ownership. The ASF licenses this file to you +# under the Apache License, Version 2.0 (the # "License"); you may not use this +# file except in compliance with the License. You may obtain a copy of the License +# at: +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software distributed +# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR +# CONDITIONS OF ANY KIND, either express or implied. See the License for the +# specific language governing permissions and limitations under the License. +# + # Dockerfile for python actions, overrides and extends ActionRunner from actionProxy FROM openwhisk/dockerskeleton:1.0.0 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mhamann commented on issue #289: Use ASF strict license checking configuration for scancode.
mhamann commented on issue #289: Use ASF strict license checking configuration for scancode. URL: https://github.com/apache/incubator-openwhisk-apigateway/pull/289#issuecomment-382060838 @mrutkows it looks like the scan tool is also scanning dependencies which have been pulled in as part of Openresty/lua, whereas the scanner should only scan files that are part of this repo. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #27: Add license headers
houshengbo closed pull request #27: Add license headers
URL: https://github.com/apache/incubator-openwhisk-runtime-docker/pull/27
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/core/actionProxy/Dockerfile b/core/actionProxy/Dockerfile
index 4c1c687..8237bd3 100644
--- a/core/actionProxy/Dockerfile
+++ b/core/actionProxy/Dockerfile
@@ -1,3 +1,19 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
contributor
+# license agreements. See the NOTICE file distributed with this work for
additional
+# information regarding copyright ownership. The ASF licenses this file to you
+# under the Apache License, Version 2.0 (the # "License"); you may not use this
+# file except in compliance with the License. You may obtain a copy of the
License
+# at:
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
distributed
+# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
+# CONDITIONS OF ANY KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations under the License.
+#
+
# Dockerfile for docker skeleton (useful for running blackbox binaries,
scripts, or Python 3 actions) .
FROM python:3.6.1-alpine
diff --git a/sdk/docker/Dockerfile b/sdk/docker/Dockerfile
index 3fb6146..c7bcdc4 100644
--- a/sdk/docker/Dockerfile
+++ b/sdk/docker/Dockerfile
@@ -1,6 +1,22 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
contributor
+# license agreements. See the NOTICE file distributed with this work for
additional
+# information regarding copyright ownership. The ASF licenses this file to you
+# under the Apache License, Version 2.0 (the # "License"); you may not use this
+# file except in compliance with the License. You may obtain a copy of the
License
+# at:
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
distributed
+# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
+# CONDITIONS OF ANY KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations under the License.
+#
+
# Dockerfile for example whisk docker action
FROM dockerskeleton
-
+
ENV FLASK_PROXY_PORT 8080
### Add source file(s)
diff --git a/sdk/docker/example.c b/sdk/docker/example.c
index 35f61a4..d884af2 100644
--- a/sdk/docker/example.c
+++ b/sdk/docker/example.c
@@ -1,3 +1,24 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+ */
+
#include
/**
@@ -14,4 +35,4 @@ int main(int argc, char *argv[]) {
printf("This is an example log message from an arbitrary C program!\n");
printf("{ \"msg\": \"Hello from arbitrary C program!\", \"args\": %s }",
(argc == 1) ? "undefined" : argv[1]);
-}
\ No newline at end of file
+}
diff --git a/tests/dat/blackbox/badaction/Dockerfile
b/tests/dat/blackbox/badaction/Dockerfile
index f342e3d..6bfdde9 100644
--- a/tests/dat/blackbox/badaction/Dockerfile
+++ b/tests/dat/blackbox/badaction/Dockerfile
@@ -1,6 +1,22 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
contributor
+# license agreements. See the NOTICE file distributed with this work for
additional
+# information regarding copyright ownership. The ASF licenses this file to you
+# under the Apache License, Version 2.0 (the # "License"); you may not use this
+# file except in compliance with the License. You may obtain a copy of the
License
+# at:
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
distributed
+# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
+# CONDITIONS OF ANY KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations under the License.
+#
+
# Dockerfile for example whis
[GitHub] houshengbo closed pull request #37: Add license headers
houshengbo closed pull request #37: Add license headers URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/37 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/core/nodejs6Action/CHANGELOG.md b/core/nodejs6Action/CHANGELOG.md index 2c777a7..306d4c6 100644 --- a/core/nodejs6Action/CHANGELOG.md +++ b/core/nodejs6Action/CHANGELOG.md @@ -1,3 +1,21 @@ + + # NodeJS 6 OpenWhisk Runtime Container ## 1.8.1 @@ -105,6 +123,3 @@ Node version = 6.9.1 - [xml2js v0.4.17](https://www.npmjs.com/package/xml2js) - Simple XML to JavaScript object converter. It supports bi-directional conversion. - [xmlhttprequest v1.8.0](https://www.npmjs.com/package/xmlhttprequest) - node-XMLHttpRequest is a wrapper for the built-in http client to emulate the browser XMLHttpRequest object. - [yauzl v2.7.0](https://www.npmjs.com/package/yauzl) - yet another unzip library for node. For zipping. - - - diff --git a/core/nodejs6Action/Dockerfile b/core/nodejs6Action/Dockerfile index 86a25c6..c57d863 100644 --- a/core/nodejs6Action/Dockerfile +++ b/core/nodejs6Action/Dockerfile @@ -1,3 +1,19 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for additional +# information regarding copyright ownership. The ASF licenses this file to you +# under the Apache License, Version 2.0 (the # "License"); you may not use this +# file except in compliance with the License. You may obtain a copy of the License +# at: +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software distributed +# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR +# CONDITIONS OF ANY KIND, either express or implied. See the License for the +# specific language governing permissions and limitations under the License. +# + FROM nodejsactionbase # based on https://github.com/nodejs/docker-node diff --git a/core/nodejs8Action/CHANGELOG.md b/core/nodejs8Action/CHANGELOG.md index 03aa2d1..c162638 100644 --- a/core/nodejs8Action/CHANGELOG.md +++ b/core/nodejs8Action/CHANGELOG.md @@ -1,3 +1,21 @@ + + # NodeJS 8 OpenWhisk Runtime Container ## 1.5.1 @@ -39,4 +57,4 @@ Change: Initial release Node version = 8.9.1 -- [openwhisk v3.10.0](https://www.npmjs.com/package/openwhisk) - JavaScript client library for the OpenWhisk platform. Provides a wrapper around the OpenWhisk APIs. \ No newline at end of file +- [openwhisk v3.10.0](https://www.npmjs.com/package/openwhisk) - JavaScript client library for the OpenWhisk platform. Provides a wrapper around the OpenWhisk APIs. diff --git a/core/nodejs8Action/Dockerfile b/core/nodejs8Action/Dockerfile index 6d5e772..225d5f7 100644 --- a/core/nodejs8Action/Dockerfile +++ b/core/nodejs8Action/Dockerfile @@ -1,3 +1,19 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for additional +# information regarding copyright ownership. The ASF licenses this file to you +# under the Apache License, Version 2.0 (the # "License"); you may not use this +# file except in compliance with the License. You may obtain a copy of the License +# at: +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software distributed +# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR +# CONDITIONS OF ANY KIND, either express or implied. See the License for the +# specific language governing permissions and limitations under the License. +# + FROM node:8.11.1 RUN apt-get update && apt-get install -y \ imagemagick \ diff --git a/core/nodejsActionBase/Dockerfile b/core/nodejsActionBase/Dockerfile index 65de3d4..4a1443a 100644 --- a/core/nodejsActionBase/Dockerfile +++ b/core/nodejsActionBase/Dockerfile @@ -1,3 +1,19 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for additional +# information regarding copyright ownership. The ASF licenses this file to you +# under the Apache License, Version 2.0 (the # "License"); you may not use this +# file except in compliance with the License. You may obtain a copy of the License +# at: +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software distributed +# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR +# CONDITIONS OF ANY KIND, either express or implied. See the License for the +# specific language governing permissions and limitations under the License. +#
[GitHub] houshengbo closed pull request #33: Add license headers
houshengbo closed pull request #33: Add license headers URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/33 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/CHANGELOG.md b/CHANGELOG.md index 489e504..83d7ed9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,10 +1,28 @@ + + # Java 8 OpenWhisk Runtime Container ## 1.0.1 -Changes: +Changes: - Allow custom name for main Class ## 1.0.0 -Changes: +Changes: - Initial release diff --git a/core/javaAction/Dockerfile b/core/javaAction/Dockerfile index e8f43a5..601d879 100644 --- a/core/javaAction/Dockerfile +++ b/core/javaAction/Dockerfile @@ -1,3 +1,19 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for additional +# information regarding copyright ownership. The ASF licenses this file to you +# under the Apache License, Version 2.0 (the # "License"); you may not use this +# file except in compliance with the License. You may obtain a copy of the License +# at: +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software distributed +# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR +# CONDITIONS OF ANY KIND, either express or implied. See the License for the +# specific language governing permissions and limitations under the License. +# + FROM adoptopenjdk/openjdk8-openj9:jdk8u162-b12_openj9-0.8.0 RUN rm -rf /var/lib/apt/lists/* && apt-get clean && apt-get update \ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #75: Add the licenses of the dependencies into LICENSE
houshengbo opened a new pull request #75: Add the licenses of the dependencies into LICENSE URL: https://github.com/apache/incubator-openwhisk-client-go/pull/75 Partially-closes: apache/incubator-openwhisk-release#109 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #95: Document LICENSE file Exclusions for incubator-openwhisk-apigateway
mrutkows commented on issue #95: Document LICENSE file Exclusions for incubator-openwhisk-apigateway URL: https://github.com/apache/incubator-openwhisk-release/issues/95#issuecomment-382047505 We need to adhere to this LUA LICENSE requirement: "The only requirement is that if you do use Lua, then you should give us credit by including the copyright notice somewhere in your product or its documentation." This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #95: Document LICENSE file Exclusions for incubator-openwhisk-apigateway
mrutkows commented on issue #95: Document LICENSE file Exclusions for incubator-openwhisk-apigateway URL: https://github.com/apache/incubator-openwhisk-release/issues/95#issuecomment-382047159 API gateway excludes the following runtime directories.. ``` # incubator-openwhisk-apigateway exclusions lua_install tests/lua_modules ``` It appears that the LUA License is an MIT derivative: https://www.lua.org/license.html ``` Lua is free software distributed under the terms of the MIT license reproduced here. Lua may be used for any purpose, including commercial purposes, at absolutely no cost. No paperwork, no royalties, no GNU-like "copyleft" restrictions, either. Just download it and use it. Lua is certified Open Source software. [osi certified] Its license is simple and liberal and is compatible with GPL. Lua is not in the public domain and PUC-Rio keeps its copyright. The spirit of the Lua license is that you are free to use Lua for any purpose at no cost without having to ask us. The only requirement is that if you do use Lua, then you should give us credit by including the copyright notice somewhere in your product or its documentation. A nice, but optional, way to give us further credit is to include a Lua logo and a link to our site in a web page for your product. ``` I have excluded them in the ASF-Release.cfg file for scanCode.py using: https://github.com/apache/incubator-openwhisk-utilities/pull/25 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #25: Update ASF config to include openwhisk-apigateway scancode exclusions
houshengbo closed pull request #25: Update ASF config to include openwhisk-apigateway scancode exclusions URL: https://github.com/apache/incubator-openwhisk-utilities/pull/25 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/scancode/ASF-Release.cfg b/scancode/ASF-Release.cfg index 143006f..c4014a9 100644 --- a/scancode/ASF-Release.cfg +++ b/scancode/ASF-Release.cfg @@ -28,21 +28,25 @@ deploy.xml=no_tabs, no_trailing_spaces, eol_at_eof # List of paths (inclusive of subdirectories) to exlude from code scanning [Excludes] -# General exclusions +# General tooling exclusions .tox .git .bin -# OpenWhisk binary artifact exclusion -bin - -# 'vendor' and cache directory create by gograble build tool +# Gohgradle build tool exclusions for created 'vendor' and cache directories .gogradle vendor +# incubator-openwhisk binary artifact exclusions +bin + # Jenkins/test generated reports tests/build/reports +# incubator-openwhisk-apigateway exclusions +lua_install +tests/lua_modules + # incubator-openwhisk-client-go, incubator-openwhisk-wskdeploy autogenerated Go files wski18n This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss closed pull request #182: Use helm to deploy openwhisk on top of kuberentes.
dgrove-oss closed pull request #182: Use helm to deploy openwhisk on top of kuberentes. URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/182 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/helm/Chart.yaml b/helm/Chart.yaml new file mode 100644 index 000..c6d25f3 --- /dev/null +++ b/helm/Chart.yaml @@ -0,0 +1,9 @@ +apiVersion: v1 +description: A Helm chart to deploy Apache OpenWhisk for Kubernetes +name: openwhisk +version: 0.1.0 +keywords: + - Apache OpenWhisk +maintainers: + - name: Tom Xing +email: xingz...@cn.ibm.com diff --git a/helm/README.md b/helm/README.md new file mode 100644 index 000..3624054 --- /dev/null +++ b/helm/README.md @@ -0,0 +1,137 @@ +## Overview + +[Apache OpenWhisk](http://www.openwhisk.org) is a popular container-native serverless platform. +This chart targets to deploy an OpenWhisk cluster over Kubernetes cluster. + +This chart is designed to deploy the following 6 kinds of containers on a running Kubernetes cluster: + +- `zookeeper`: deployed in Kubernetes as a `Service`(backended by a `Deployment`). Provides `zookeeper` service for `kafka` node. +- `kafka`: deployed in Kubernetes as a `StatefulSet`. Depends on `zookeeper` service and provides message service for `controller` node and `invoker` node. +- `couchdb`: deployed in Kubernetes as a `Service`(backended by a `Deployment`). Provides database service for `controller` node and `invoker` node. +- `controller`: OpenWhisk controller component, deployed as a `StatefulSet`. +- `invoker`: OpenWhisk invoker component, deployed as a `StatefulSet`. +- `nginx`: deployed in Kubernetes as a combination of a `Service`(of type `NodePort`, backended by a `Deployment`), a `ConfigMap` and a `Secret`. Provides public access endpoint for end user to visit OpenWhisk. + +By default, deploying this chart will result in deploying 6 containers in a Kubernetes cluster, which forms a minimum deployment of a workable OpenWhisk environment. Please modify `values.yaml` and corresponding template files to deploy a bigger customized OpenWhisk cluster. + +## Deployment Steps + +Please follow the following steps in this section to use [Helm](https://github.com/kubernetes/helm) to deploy this chart. + +### Step 1. Prepare Docker Images + +The first step is to prepare docker images used by this chart on your Kubernetes node. Here is a summary of the images needed: + +- `zookeeper`: uses `zookeeper:3.4` at present. +- `kafka`: uses `wurstmeister/kafka:0.11.0.1`. +- `couchdb`: uses `openwhisk/kube-couchdb`, this is a pre-built docker image made from official `openwhisk-on-kubernetes`. For more information, please check the [docker file](https://github.com/apache/incubator-openwhisk-deploy-kube/blob/master/docker/couchdb/Dockerfile) for this image. +- `controller`: uses OpenWhisk official `openwhisk/controller` image. +- `invoker`: uses OpenWhisk official `openwhisk/invoker` image. +- `nginx`: uses `nginx:1.11`. + +This chart provides default images for all of the above containers, so you can try deploy without building any images in advance. + +This chart will also automatically pull the following action images for `invoker` once deployment is finished: + +- openwhisk/nodejsactionbase +- openwhisk/nodejs6action +- openwhisk/dockerskeleton +- openwhisk/python2action +- openwhisk/python3action +- openwhisk/action-swift-v3.1.1 +- openwhisk/swift3action +- openwhisk/java8action + +### Step 2. Prepare Kubernetes and Helm + +Make sure that you have a running Kubernetes cluster and a `kubectl` client connected to this cluster. + +Then please install [Helm](https://github.com/kubernetes/helm) and run the following command to init `Helm Tiller`: +```shell +helm init + +``` + +Please check with the following command to make sure `Helm` is up and running: +```shell +kubectl get pods -n kube-system + +``` + +Then grant corresponding cluster role to `Helm` user: +```shell +kubectl create clusterrolebinding tiller-cluster-admin --clusterrole=cluster-admin --serviceaccount=kube-system:default +``` + +Finally, create a new namespace named `openwhisk`: +```shell +kubectl create namespace openwhisk +``` + +Now, you should have an available environment to deploy OpenWhisk! + +### Deploy Charts + +Deployment can be done by using the following single command: +```shell +helm install . --namespace=openwhisk --name=your_release_name +``` + +After a while, if you can see all the pods listed by the following command are in `Running` state, congratulations, you have finished OpenWhisk deployment: +```shell +kubectl get pods -n openwhisk +``` + +### Test Deployment + +Install an [OpenWhisk client](https://github.com/apache/incubator-openwhisk/tree/master/docs) to test the deployed OpenWhisk
[GitHub] dgrove-oss commented on issue #182: Use helm to deploy openwhisk on top of kuberentes.
dgrove-oss commented on issue #182: Use helm to deploy openwhisk on top of kuberentes. URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/182#issuecomment-382040503 This worked smoothly for me modulo needing to override the fixed ingress nodeports on the command line (3 already in use) Going to merge as-is and update to add features like kube vs. docker container factories via subsequent PRs. Great to have this in as a baseline! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #25: Update ASF config to include openwhisk-apigateway scancode exclusions
mrutkows opened a new pull request #25: Update ASF config to include openwhisk-apigateway scancode exclusions URL: https://github.com/apache/incubator-openwhisk-utilities/pull/25 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #271: Add the licenses of the dependencies into LICENSE
houshengbo commented on issue #271: Add the licenses of the dependencies into LICENSE URL: https://github.com/apache/incubator-openwhisk-cli/pull/271#issuecomment-382037781 @daisy-ycguo After I added the licenses of dependencies, I think the current contents of NOTICE and LICENSE have something overlapping. For example, they both explain the licenses of the dependencies. To me, other packages, like Pflag, unix, sys, etc, are the source code dependencies, not the existing components of the project, so we need to remove them from the notice, and keep them in the LICENSE. One example for the component of the project can be openwhisk core needs to deploy kafka, zookeeper services, which are not part of the scala source code, but the necessity of the services. They are components of the openwhisk core service. Kafka and Zookeeper are the components not developed by openwhisk, but used by openwhisk to provide services. What do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #271: Add the licenses of the dependencies into LICENSE
houshengbo commented on issue #271: Add the licenses of the dependencies into LICENSE URL: https://github.com/apache/incubator-openwhisk-cli/pull/271#issuecomment-382037781 @daisy-ycguo After I added the licenses of dependencies, I think the current contents of NOTICE and LICENSE have something overlapping. For example, they both explain the licenses of the dependencies. To me, other packages, like Pflag, unix, sys, etc, are the source code dependencies, not the existing components of the project, so we need to remove them from the notice, and keep them in the LICENSE. One example for the component of the project can be openwhisk core needs to deploy kafka, zookeeper services, which are not part of the scala source code, but the necessity of the services. They are components of the openwhisk core service. What do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #289: Use ASF strict license checking configuration for scancode.
mrutkows opened a new pull request #289: Use ASF strict license checking configuration for scancode. URL: https://github.com/apache/incubator-openwhisk-apigateway/pull/289 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] abaruni opened a new pull request #264: remove use of messageHubProduce action in health test and use java producer
abaruni opened a new pull request #264: remove use of messageHubProduce action in health test and use java producer URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/264 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo closed issue #106: Check the LICENSE of achieved files in source codes
daisy-ycguo closed issue #106: Check the LICENSE of achieved files in source codes URL: https://github.com/apache/incubator-openwhisk-release/issues/106 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo closed pull request #112: Remove the test cases from the source code artifacts
daisy-ycguo closed pull request #112: Remove the test cases from the source
code artifacts
URL: https://github.com/apache/incubator-openwhisk-release/pull/112
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tools/config.json b/tools/config.json
index 8de1422..f6c606a 100644
--- a/tools/config.json
+++ b/tools/config.json
@@ -1,5 +1,5 @@
{
- "publish_stage": "false",
+ "publish_stage": "true",
"stage_url": "https://dist.apache.org/repos/dist/dev/incubator/openwhisk";,
"release_url":
"https://dist.apache.org/repos/dist/release/incubator/openwhisk";,
"versioning": {
@@ -21,64 +21,64 @@
"openwhisk-runtime-python"
],
"openwhisk": {
-"hash": "fbc0091",
+"hash": "c7271e2",
"repository": "https://github.com/apache/incubator-openwhisk.git";,
"branch": "master"
},
"openwhisk_wskdeploy": {
-"hash": "063263c",
+"hash": "fca1450",
"repository":
"https://github.com/apache/incubator-openwhisk-wskdeploy.git";,
"branch": "master",
"binaries": "yes"
},
"openwhisk_cli": {
-"hash": "ba08720",
+"hash": "ea12cc2",
"repository": "https://github.com/apache/incubator-openwhisk-cli.git";,
"branch": "master",
"binaries": "yes"
},
"openwhisk_client_go": {
-"hash": "012fd0f",
+"hash": "defaf97",
"repository":
"https://github.com/apache/incubator-openwhisk-client-go.git";,
"branch": "master"
},
"openwhisk_catalog": {
-"hash": "654b24b",
+"hash": "d4ce22c",
"repository": "https://github.com/apache/openwhisk-catalog.git";,
"branch": "master"
},
"openwhisk_apigateway": {
-"hash": "6165ffe",
+"hash": "b89c487",
"repository":
"https://github.com/apache/incubator-openwhisk-apigateway.git";,
"branch": "master"
},
"openwhisk_runtime_nodejs": {
-"hash": "71c57b9",
+"hash": "e0b999d",
"repository":
"https://github.com/apache/incubator-openwhisk-runtime-nodejs.git";,
"branch": "master"
},
"openwhisk_runtime_swift": {
-"hash": "3ccad3b",
+"hash": "1ecfbe5",
"repository":
"https://github.com/apache/incubator-openwhisk-runtime-swift.git";,
"branch": "master"
},
"openwhisk_runtime_php": {
-"hash": "c27036c",
+"hash": "712da08",
"repository":
"https://github.com/apache/incubator-openwhisk-runtime-php.git";,
"branch": "master"
},
"openwhisk_runtime_java": {
-"hash": "fd7a9d9",
+"hash": "398c6cc",
"repository":
"https://github.com/apache/incubator-openwhisk-runtime-java.git";,
"branch": "master"
},
"openwhisk_runtime_docker": {
-"hash": "ac679c3",
+"hash": "b94d97d",
"repository":
"https://github.com/apache/incubator-openwhisk-runtime-docker.git";,
"branch": "master"
},
"openwhisk_runtime_python": {
-"hash": "bf4051d",
+"hash": "2a1284d",
"repository":
"https://github.com/apache/incubator-openwhisk-runtime-python.git";,
"branch": "master"
}
diff --git a/tools/package_source_code.sh b/tools/package_source_code.sh
index 6e8effd..2bf2984 100755
--- a/tools/package_source_code.sh
+++ b/tools/package_source_code.sh
@@ -30,7 +30,7 @@ mkdir -p $CURRENT_VERSION_DIR
# Remove bin and build folders
mkdir -p $OPENWHISK_CLEANED_SOURCE_DIR
rm -rf $OPENWHISK_CLEANED_SOURCE_DIR/*
-rsync -rtp --exclude .*\* --exclude bin\* --exclude build\*
$OPENWHISK_SOURCE_DIR/. $OPENWHISK_CLEANED_SOURCE_DIR
+rsync -rtp --exclude .*\* --exclude bin\* --exclude build\* --exclude tests\*
$OPENWHISK_SOURCE_DIR/. $OPENWHISK_CLEANED_SOURCE_DIR
for repo in $(echo $repos | sed "s/,/ /g")
do
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] daisy-ycguo opened a new pull request #37: Add license headers
daisy-ycguo opened a new pull request #37: Add license headers URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/37 To add license headers to 5 files. Closes issue #25. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo commented on issue #99: Document LICENSE file Exclusions for incubator-openwhisk-runtime-nodejs
daisy-ycguo commented on issue #99: Document LICENSE file Exclusions for incubator-openwhisk-runtime-nodejs URL: https://github.com/apache/incubator-openwhisk-release/issues/99#issuecomment-382014366 I suggest to exclude below files from header scanning because they are config files with few creativity. ``` openwhisk-runtime-nodejs/tests/src/test/resources/application.conf openwhisk-runtime-nodejs/ansible/environments/local/group_vars/all openwhisk-runtime-nodejs/ansible/environments/local/hosts ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo commented on issue #25: Some source files miss Apache license headers
daisy-ycguo commented on issue #25: Some source files miss Apache license headers URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/issues/25#issuecomment-382014252 I suggest to exclude below files from header scanning because they are config files with few creativity. ``` openwhisk-runtime-nodejs/tests/src/test/resources/application.conf openwhisk-runtime-nodejs/ansible/environments/local/group_vars/all openwhisk-runtime-nodejs/ansible/environments/local/hosts ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
