[GitHub] ningyougang commented on issue #3606: Increase nginx security by adapting ssl_ciphers.

[GitBox]

ningyougang commented on issue #3606: Increase nginx security by adapting 
ssl_ciphers.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3606#issuecomment-389394531
 
 
   @sven-lange-last ,thinks.  already fixed.
   
   Why that problem happened?
   because `the random key` which is generated by client  is very long, it is 
failed to use like `ECDHE-ECDSA-AES256-GCM-SHA384` to decrypt it.
   So should upgrade jdk version from `jdk1.8.0_102` to `jdk1.8.0_161(or more 
high version)`,there has a Critical configuration: `crypto.policy=unlimited` in 
/jre/lib/security/java.security (old jdk version didn't has this 
configuration)
   
   refer to:
   
https://stackoverflow.com/questions/38203971/javax-net-ssl-sslhandshakeexception-received-fatal-alert-handshake-failure
   
https://confluence.atlassian.com/jirakb/sslhandshakeexception-received-fatal-alert-handshake_failure-due-to-no-overlap-in-cipher-suite-943544397.html


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] style95 opened a new pull request #3663: Support SPI for ContainerPool and ContainerProxy

[GitBox]

style95 opened a new pull request #3663: Support SPI for ContainerPool and 
ContainerProxy
URL: https://github.com/apache/incubator-openwhisk/pull/3663
 
 
   This closes #3662.
   
   ## Description
   It will apply SPI to `ContainerPool` and `ContainerProxy`.
   Current `ContainerPool` and `ContainerProxy` are renamed with `Default` 
prefix.
   
   ## Related issue and scope
   
   - [x] I opened an issue to propose and discuss this change (#3662)
   
   ## My changes affect the following components
   
   
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [x] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [x] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing 
behavior).
   
   ## Checklist:
   
   
   - [x] I signed an [Apache 
CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style 
guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
 and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ningyougang commented on issue #3606: Increase nginx security by adapting ssl_ciphers.

[GitBox]

ningyougang commented on issue #3606: Increase nginx security by adapting 
ssl_ciphers.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3606#issuecomment-389394531
 
 
   @sven-lange-last ,thinks.  already fixed.
   Why that problem happened?
   because `the random key` which is generated by client  is very long, it is 
failed to use like `ECDHE-ECDSA-AES256-GCM-SHA384` to decrypt it.
   So should upgrade jdk version from `jdk1.8.0_102` to `jdk1.8.0_161(or more 
high version)`,there has a Critical configuration: `crypto.policy=unlimited` in 
/jre/lib/security/java.security (old jdk version didn't has this 
configuration)
   
   refer to:
   
https://stackoverflow.com/questions/38203971/javax-net-ssl-sslhandshakeexception-received-fatal-alert-handshake-failure
   
https://confluence.atlassian.com/jirakb/sslhandshakeexception-received-fatal-alert-handshake_failure-due-to-no-overlap-in-cipher-suite-943544397.html


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] style95 opened a new issue #3662: SPI for ContainerProxy and ContainerPool

[GitBox]

style95 opened a new issue #3662: SPI for ContainerProxy and ContainerPool
URL: https://github.com/apache/incubator-openwhisk/issues/3662
 
 
   As of now, SPI concept is applied in many parts of OpenWhisk.
   If same concept is applied to `ContainerProxy` and `ContainerPool`, it would 
give users more options and make OW more flexible.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #60: Swift 4.1 issue discovered around Structs with two Strings

[GitBox]

csantanapr commented on issue #60: Swift 4.1 issue discovered around Structs 
with two Strings
URL: 
https://github.com/apache/incubator-openwhisk-runtime-swift/issues/60#issuecomment-389382971
 
 
   More data points from today
   I was able to compile the code with no errors in 4.2 and development 
snapshots
   
https://swift.org/builds/swift-4.2-branch/ubuntu1404/swift-4.2-DEVELOPMENT-SNAPSHOT-2018-05-14-a/swift-4.2-DEVELOPMENT-SNAPSHOT-2018-05-14-a-ubuntu14.04.tar.gz
   
   
https://swift.org/builds/development/ubuntu1604/swift-DEVELOPMENT-SNAPSHOT-2018-05-14-a/swift-DEVELOPMENT-SNAPSHOT-2018-05-14-a-ubuntu16.04.tar.gz
   
   So it looks like the problem is already fixed in the swift-4.2 branch.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #60: Swift 4.1 issue discovered around Structs with two Strings

[GitBox]

csantanapr commented on issue #60: Swift 4.1 issue discovered around Structs 
with two Strings
URL: 
https://github.com/apache/incubator-openwhisk-runtime-swift/issues/60#issuecomment-389381980
 
 
   I created a bug in swift bug tracker here: 
https://bugs.swift.org/browse/SR-7696
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] daisy-ycguo commented on issue #716: Some source files are missing Apache license headers

[GitBox]

daisy-ycguo commented on issue #716: Some source files are missing Apache 
license headers
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/716#issuecomment-389367329
 
 
   No. This repo is all good. We can close this issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] daisy-ycguo closed issue #716: Some source files are missing Apache license headers

[GitBox]

daisy-ycguo closed issue #716: Some source files are missing Apache license 
headers
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/716
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr closed pull request #185: add kube 1.10.1 and minikube 0.26 to test matrix

[GitBox]

csantanapr closed pull request #185: add kube 1.10.1 and minikube 0.26 to test 
matrix
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/185
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.travis.yml b/.travis.yml
index 7b38ed4..7226bea 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,4 +1,9 @@
 sudo: required
+dist: trusty
+
+language: go
+go:
+  - 1.9.2
 
 env:
   global:
@@ -8,6 +13,7 @@ env:
 - OW_CONTAINER_FACTORY=docker TRAVIS_KUBE_VERSION=v1.7.4 
TRAVIS_MINIKUBE_VERSION=v0.23.0
 - OW_CONTAINER_FACTORY=docker TRAVIS_KUBE_VERSION=v1.8.0 
TRAVIS_MINIKUBE_VERSION=v0.25.2
 - OW_CONTAINER_FACTORY=docker TRAVIS_KUBE_VERSION=v1.9.0 
TRAVIS_MINIKUBE_VERSION=v0.25.2
+- OW_CONTAINER_FACTORY=docker TRAVIS_KUBE_VERSION=v1.10.0 
TRAVIS_MINIKUBE_VERSION=v0.26.1
 - OW_CONTAINER_FACTORY=kube   TRAVIS_KUBE_VERSION=v1.8.0 
TRAVIS_MINIKUBE_VERSION=v0.25.2
 
 services:
diff --git a/README.md b/README.md
index d89c762..3691c92 100644
--- a/README.md
+++ b/README.md
@@ -37,6 +37,7 @@ Travis CI testing.
 1.7.4 | 0.23.0 |
 1.8.0 | 0.25.2 |
 1.9.0 | 0.25.2 |
+1.10.0 | 0.26.1 |
 
 For details on setting up Minikube, see these 
[instructions](/docs/setting_up_minikube/README.md).
 
diff --git a/docs/setting_up_minikube/README.md 
b/docs/setting_up_minikube/README.md
index 805ea8c..97f21c3 100644
--- a/docs/setting_up_minikube/README.md
+++ b/docs/setting_up_minikube/README.md
@@ -21,21 +21,29 @@ asdf plugin-add kubectl
 asdf plugin-add minikube
 ```
 
-### Install asdf plugin minikube@0.23.0 and kubectl@1.7.4
+### Install asdf plugin minikube and kubectl
+For example this will setup versions 0.26.1 and 1.10.0, check the versions 
that are supported in the Travis matric config 
[../.travis.yml](../.travis.yml#L7)
 ```
-asdf install kubectl 1.7.4
-asdf global kubectl 1.7.4
-asdf install minikube 0.23.0
-asdf global minikube 0.23.0
+asdf install minikube 0.26.1
+asdf global minikube 0.26.1
+asdf install kubectl 1.10.0
+asdf global kubectl 1.10.0
 ```
 
 ## Create the minikube VM
 You will want at least 4GB of memory and 2 CPUs for Minikube to run OpenWhisk.
 If you have a larger machine, you may want to provision more (especially more 
memory).
 
-Start Minikube with:
+Configure minikube and persist config:
 ```
-minikube start --cpus 2 --memory 4096 --kubernetes-version=v1.7.4
+minikube config set kubernetes-version v1.10.0
+minikube config set cpus 2
+minikube config set memory 4096
+```
+
+Then start minikube VM:
+```
+minikube start
 ```
 
 ## Setup Docker network in promiscuous mode
@@ -44,8 +52,16 @@ Put the docker network in promiscuous mode.
 minikube ssh -- sudo ip link set docker0 promisc on
 ```
 
+**Tip**: Make sure to setup the Docker network after `minkube start` if you 
ran `minkube delete` as this configuration will be lost.
+
 Your Minikube cluster should now be ready to deploy OpenWhisk.
 
+Delete minkube VM:
+This is useful if you plan to test with a different combination of minkube and 
kubernetes versions.
+```
+minikube delete
+```
+
 # Troubleshooting
 
 For some combinations of Minikube and Kubernetes versions, you may need to 
workaround a [Minikube DNS 
issue](https://github.com/kubernetes/minikube/issues/2240#issuecomment-348319371).
 A common symptom of this issue is that the OpenWhisk couchdb pod will fail to 
start with the error that it is unable to resolve `github.com` when cloning the 
openwhisk git repo. A work around is to delete the minikube cluster, issue the 
command `minikube config set bootstrapper kubeadm` and then redo the `minikube 
start` command above.
diff --git a/tools/travis/setup.sh b/tools/travis/setup.sh
index d952477..f018847 100755
--- a/tools/travis/setup.sh
+++ b/tools/travis/setup.sh
@@ -24,7 +24,9 @@ mkdir $HOME/.kube || true
 touch $HOME/.kube/config
 
 export KUBECONFIG=$HOME/.kube/config
-sudo -E /usr/local/bin/minikube start --vm-driver=none 
--kubernetes-version=$TRAVIS_KUBE_VERSION
+# --vm-driver=none, use host docker (avoid docker-in-docker)
+# --bootstrapper=localkube, works around 
https://github.com/kubernetes/minikube/issues/2704
+sudo -E /usr/local/bin/minikube start --vm-driver=none 
--bootstrapper=localkube --kubernetes-version=$TRAVIS_KUBE_VERSION
 
 # Wait until we have a ready node in minikube
 TIMEOUT=0


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr closed pull request #3657: Remove additional quote in pip install command

[GitBox]

csantanapr closed pull request #3657: Remove additional quote in pip install 
command
URL: https://github.com/apache/incubator-openwhisk/pull/3657
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/tools/macos/README.md b/tools/macos/README.md
index 4298b581f2..3ed6ecb891 100644
--- a/tools/macos/README.md
+++ b/tools/macos/README.md
@@ -51,7 +51,7 @@ brew install scala
 # install pip
 sudo easy_install pip
 # install script prerequisites
-sudo -H pip install docker==2.2.1 ansible==2.5.2 jinja2==2.9.6 couchdb==1.1 
httplib2==0.9.2 requests==2.10.0' | bash
+sudo -H pip install docker==2.2.1 ansible==2.5.2 jinja2==2.9.6 couchdb==1.1 
httplib2==0.9.2 requests==2.10.0 | bash
 ```
 
 # Build


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds

[GitBox]

csantanapr commented on issue #3661: Restrict allowed namespaces when creating 
action of certain kinds
URL: 
https://github.com/apache/incubator-openwhisk/pull/3661#issuecomment-389358442
 
 
   So this issue about implementing identity (i.e. IAM) with scopes (i.e. 
oauth) and these pre-defined scopes associated with certain permissions or 
exclusions?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds

[GitBox]

rabbah commented on issue #3661: Restrict allowed namespaces when creating 
action of certain kinds
URL: 
https://github.com/apache/incubator-openwhisk/pull/3661#issuecomment-389357800
 
 
   My rationale is that this is just one example of an entitlement that can 
arise: longer limits on duration, higher memory reservation, longer sequences 
or compositions to name obvious ones. All of these should be addressed in a 
canonical way and fit logically as part of entitlement in my view. You are 
right to point out that the interface for entitlement is too narrow today 
because it ignores the kind or additional resource requirements I noted. 
   
   I’d favor encapsulating these checks in a well defined interface vs 
integrating it with the action api handler. 
   
   Further, note that the approach of white listing namespaces as done with a 
deployment configuration makes it more static whereas I view such lists as 
something that will be dynamic: the privileges should perhaps be part of the 
identity record (like other limits today) and we should provide an interface to 
black list and white list (or rather change the rights of the subject). 
   
   I know this broadens scope much more than you’ve done. We can discuss the 
design and work toward that but allow a transient path to make progress in the 
meantime. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds

[GitBox]

rabbah commented on issue #3661: Restrict allowed namespaces when creating 
action of certain kinds
URL: 
https://github.com/apache/incubator-openwhisk/pull/3661#issuecomment-389357800
 
 
   My rationale is that this is just one example of an entitlement that can 
arise: longer limits on duration, higher memory reservation, longer sequences 
or compositions to name obvious ones. All of these should be addressed in a 
canonical way and fit logically as part of entitlement in my view. You are 
right to point out that the interface for entitlement is too narrow today 
because it ignores the kind or additional resource requirements I noted. 
   
   I’d favor encapsulating these checks in a well defined interface vs 
integrating it with the action api handler. 
   
   Further, note that the approach of white listing namespaces a done with a 
deployment configuration makes it more static whereas I view such lists as 
something that will be dynamic: the privileges should perhaps be part of the 
identity record (like other limits today) and we should provide an interface to 
black list and white list (or rather change the rights of the subject). 
   
   I know this broadens scope much more than you’ve done. We can discuss the 
design and work toward that but allow a transient path to make progress in the 
meantime. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds

[GitBox]

csantanapr commented on issue #3661: Restrict allowed namespaces when creating 
action of certain kinds
URL: 
https://github.com/apache/incubator-openwhisk/pull/3661#issuecomment-389356922
 
 
   >there is a need to restrict the creation of new actions to a particular 
whitelist of accepted namespaces.
   
   
   I don’t understand why there is a need to restrict?
   
   Do you have a more real use case on this applicable ? private deployment, or 
public multi tenant, etc 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai closed pull request #151: Update ASF license exlcusion table with latest info.

[GitBox]

pritidesai closed pull request #151: Update ASF license exlcusion table with 
latest info.
URL: https://github.com/apache/incubator-openwhisk-release/pull/151
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/license_compliance.md b/docs/license_compliance.md
index 3ffd683..6f9aeca 100644
--- a/docs/license_compliance.md
+++ b/docs/license_compliance.md
@@ -45,24 +45,26 @@ For convenience, we provide a summary listing of all 
project LICENSE and NOTICE
 
 In accordance with Apache LICENSE policies, the table below lists files/file 
types that the community affirms MUST have an Apache LICENSE header since they 
are creating works representing Intellectual Property.
 
-In addition, the type of header used (i.e., "full" ASF header or ASF approved 
"minified" header) is noted along with the justification as is allowed by 
Apache policy.
+In addition, the recommended type of approved ASF license header (i.e., "full" 
or "minified" header) is noted as best practice.
 
 | File type | ASF Header Type | Rationale |
 | --- | --- | --- |
-| Source Code (e.g., .scala, .go, .java, .py, etc.) | Full ASF license header 
| |
-| Action Functions (source) (e.g., .js, .py, .swift, etc, particularly under 
`tests/dat` folder.) | Mini ASF license header | Needs IP protection; Use 
"Mini" header as best practice for performance reasons. |
-| Documentation (e.g., `*.md`, `.html`) | Full ASF license header | |
-| YAML files (`*.yaml`, `*.yml`) | Full or Mini ASF license header | |
-| XML files (`*.xml`) | Full or Mini ASF license header | |
-| Docker file (`dockerfile`) | Full ASF license header | |
-| Script files (`*.sh`) | Mini ASF license header | |
-| Makefile | Full ASF license header | |
-| `build.gradle` and `settings.gradle` | Full ASF license header | build 
script and configuration for building with Gradle |
-| `gradle/docker.gradle` | Full ASF license header | build script to generate 
docker image using Gradle |
-| `*.conf` | Full or Mini ASF license header | Configuration file |
+| Source Code (e.g., *.scala, *.go, *.java, *.py, etc.) | Full | |
+| Documentation (e.g., `*.md`) | Full | |
+| Web Content (e.g., `*.html`, `.css`) | Full | |
+| Scala Configurations (`*.conf`) | Full | Scala (Java)  configuration files 
may contain code or interfaces. |
+| Action Functions (source) (e.g., .js, .py, .swift, etc, particularly under 
`tests/dat` folder.) | Mini | Needs IP protection; Use "Mini" header as best 
practice for performance reasons. |
+| Makefile | Full | May contain functional code |
+| Docker file (`dockerfile`) | Mini | |
+| Script files (`*.sh`) | Mini | Contains functional scripting code |
+| YAML files (`*.yaml`, `*.yml`) | Mini | |
+| XML files (`*.xml`) | Mini | |
+| `build.gradle` and `settings.gradle` | Full | Contains build script and 
configuration for building with Gradle |
+| `gradle/docker.gradle` | Full | build script to generate docker image using 
Gradle |
 
 
  Notes
+- Full ASF License headers are always accepted regardless if a "Mini" header 
is recommended as best practice.
 - Action source files used in performance testing may be added to "[Known 
exclusions](#known-exclusions)" when justified.
 
 
@@ -72,18 +74,17 @@ In accordance with Apache LICENSE policies, the table below 
lists general exclus
 
 | File type | Rationale |
 | --- | --- |
-| Git configuration files (`.gitattributes`, `.gitignore`) | Not much 
creativity |
-| Gradle files | Not much 
creativity |
-| IDE configuration files (e.g., `.project`)   | Not much 
creativity |
-| Template files (`*.j2`)  | Not much 
creativity |
-| JSON files (`*.json`)| JSON files don't 
support comments |
-| `i18n_resources.go`  | Not much 
creativity. The file is auto-generated; not able to add header |
-| `*.env`  | Configuration 
file. Not much creativity. See a sample 
[here](https://github.com/apache/incubator-openwhisk/blob/master/ansible/environments/distributed/files/openstack/openstack.env)
 |
-| `*.cfg`  | Configuration 
file. Not much creativity. See a sample 
[here](https://github.com/apache/incubator-openwhisk/blob/master/ansible/ansible.cfg)
 |
-| `*.ini`  | Configuration 
file. Not much creativity. See a sample 
[here](https://github.com/apache/incubator-openwhisk/blob/master/ansible/files/package-versions.ini)
 |
-| `*.properties`   | Configuration 
file. Not much creativity. See a sample 

[GitHub] asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds

[GitBox]

asteed commented on issue #3661: Restrict allowed namespaces when creating 
action of certain kinds
URL: 
https://github.com/apache/incubator-openwhisk/pull/3661#issuecomment-389353549
 
 
   Is this a privilege check on a subject or on a resource only? 
   The entirety of the check is that the particular target is supportive of 
housing the requested kind. 
   
   My initial, albeit inexperienced concern with placing it within Entitlement 
is exposing the _action-specific_ notion of kinds within Entitlement. I'd be 
happy to know others' thoughts, however


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #3660: Python (*.py) and YAML (.yml) files missing ASF license headers

[GitBox]

rabbah commented on issue #3660: Python (*.py) and YAML (.yml) files missing 
ASF license headers
URL: 
https://github.com/apache/incubator-openwhisk/issues/3660#issuecomment-389351017
 
 
   This file: `incubator-openwhisk/actionRuntimes/actionProxy/invoke.py` unlike 
the others is a python script - should it be a proper header vs mini one? What 
is the criteria being applied for future reference (apologies if that’s 
documented somewhere and I missed it)?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #3660: Python (*.py) and YAML (.yml) files missing ASF license headers

[GitBox]

rabbah commented on issue #3660: Python (*.py) and YAML (.yml) files missing 
ASF license headers
URL: 
https://github.com/apache/incubator-openwhisk/issues/3660#issuecomment-389351017
 
 
   incubator-openwhisk/actionRuntimes/actionProxy/invoke.py
   
   Unlike the others is a python script - should it be a proper header vs mini 
one? What is the criteria being applied (apologies if that’s documented 
somewhere and I missed it) for future reference. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds

[GitBox]

rabbah commented on issue #3661: Restrict allowed namespaces when creating 
action of certain kinds
URL: 
https://github.com/apache/incubator-openwhisk/pull/3661#issuecomment-389350167
 
 
   I can see how a need for this arises - the integration should be through the 
entitlement abstraction however, because I can imagine subjects and privileges 
are likely dynamically changing, and because this cleary is a privilege check 
for a subject operating on a resource.  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds

[GitBox]

asteed commented on issue #3661: Restrict allowed namespaces when creating 
action of certain kinds
URL: 
https://github.com/apache/incubator-openwhisk/pull/3661#issuecomment-389348864
 
 
   Sample whitelist to be used in 
`common/scala/src/main/resources/application.conf`
   ```
   whisk {
   ...
   runtimes {
   ...
   whitelists {
 "nodejs:6": ["guest"],
 python: ["supergroup"],
 blackbox: ["ADMIN"]
   }
   }
   }
   ```
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds

[GitBox]

asteed commented on issue #3661: Restrict allowed namespaces when creating 
action of certain kinds
URL: 
https://github.com/apache/incubator-openwhisk/pull/3661#issuecomment-389348864
 
 
   Sample whitelist to be used in 
`common/scala/src/main/resources/application.conf`
   ```
   whisk {
   ...
   runtimes {
   ...
   whitelists = {
 "nodejs:6": ["guest"],
 python: ["supergroup"],
 blackbox: ["ADMIN"]
   }
   }
   }
   ```
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds

[GitBox]

asteed commented on issue #3661: Restrict allowed namespaces when creating 
action of certain kinds
URL: 
https://github.com/apache/incubator-openwhisk/pull/3661#issuecomment-389348864
 
 
   Sample whitelist to be used in 
`common/scala/src/main/resources/application.confapplication.conf`
   ```
   whisk {
   ...
   runtimes {
   ...
   whitelists = {
 "nodejs:6": ["guest"],
 python: ["supergroup"],
 blackbox: ["ADMIN"]
   }
   }
   }
   ```
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai commented on a change in pull request #870: WIP: Project and Package parameters

[GitBox]

pritidesai commented on a change in pull request #870: WIP: Project and Package 
parameters
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/870#discussion_r188462314
 
 

 ##
 File path: deployers/deploymentreader.go
 ##
 @@ -102,6 +102,28 @@ func (reader *DeploymentReader) getPackageMap() 
map[string]parsers.Package {
return packMap
 }
 
+func (reader *DeploymentReader) getListOfParameters(inputs 
map[string]parsers.Parameter) whisk.KeyValueArr {
 
 Review comment:
   these two functions were as a common utility functions for 
`deploymentreader`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai commented on a change in pull request #870: WIP: Project and Package parameters

[GitBox]

pritidesai commented on a change in pull request #870: WIP: Project and Package 
parameters
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/870#discussion_r188461996
 
 

 ##
 File path: cmd/utils.go
 ##
 @@ -0,0 +1,174 @@
+/*
 
 Review comment:
   this utility is added to read and parser CLI `--param` and `--param-file`. 
All key value pairs from `--param` are stored in `utils.Flags.param`, also 
error is reported if `--param` does not have key value pair. Same for 
`--param-file`, error is reported if it does not have a file name or invalid 
file name, else, the entire JSON payload is read and stored in 
`utils.Flags.param` overwriting the ones specified in `--param`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3659: Assure all Dockerfiles have ASF header.

[GitBox]

codecov-io commented on issue #3659: Assure all Dockerfiles have ASF header.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3659#issuecomment-389263532
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3659?src=pr=h1)
 Report
   > Merging 
[#3659](https://codecov.io/gh/apache/incubator-openwhisk/pull/3659?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/403d3417f09f145969a936f322c620f6bc5204ff?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3659/graphs/tree.svg?src=pr=650=l0YmsiSAso=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3659?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#3659   +/-   ##
   ===
 Coverage   74.49%   74.49%   
   ===
 Files 126  126   
 Lines5990 5990   
 Branches  390  390   
   ===
 Hits 4462 4462   
 Misses   1528 1528
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3659?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3659?src=pr=footer).
 Last update 
[403d341...7a1277c](https://codecov.io/gh/apache/incubator-openwhisk/pull/3659?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai closed pull request #3659: Assure all Dockerfiles have ASF header.

[GitBox]

pritidesai closed pull request #3659: Assure all Dockerfiles have ASF header.
URL: https://github.com/apache/incubator-openwhisk/pull/3659
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/actionRuntimes/actionProxy/Dockerfile 
b/actionRuntimes/actionProxy/Dockerfile
index 5ca674f16d..32bf71bb24 100644
--- a/actionRuntimes/actionProxy/Dockerfile
+++ b/actionRuntimes/actionProxy/Dockerfile
@@ -1,2 +1,5 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more 
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+
 # Dockerfile for docker skeleton (useful for running blackbox binaries, 
scripts, or Python 3 actions) .
 FROM openwhisk/dockerskeleton:1.3.0
diff --git a/actionRuntimes/javaAction/Dockerfile 
b/actionRuntimes/javaAction/Dockerfile
index 4fd54cb1b7..8c5c1acec3 100644
--- a/actionRuntimes/javaAction/Dockerfile
+++ b/actionRuntimes/javaAction/Dockerfile
@@ -1 +1,4 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more 
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+
 FROM openwhisk/java8action:1.1.0
diff --git a/actionRuntimes/nodejs6Action/Dockerfile 
b/actionRuntimes/nodejs6Action/Dockerfile
index 17541e0a11..1a382ff4a0 100644
--- a/actionRuntimes/nodejs6Action/Dockerfile
+++ b/actionRuntimes/nodejs6Action/Dockerfile
@@ -1 +1,4 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more 
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+
 FROM openwhisk/nodejs6action:1.9.0
diff --git a/actionRuntimes/nodejs8Action/Dockerfile 
b/actionRuntimes/nodejs8Action/Dockerfile
index 2853c5b332..4ae3778c1e 100644
--- a/actionRuntimes/nodejs8Action/Dockerfile
+++ b/actionRuntimes/nodejs8Action/Dockerfile
@@ -1 +1,4 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more 
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+
 FROM openwhisk/action-nodejs-v8:1.6.0
diff --git a/actionRuntimes/php7.1Action/Dockerfile 
b/actionRuntimes/php7.1Action/Dockerfile
index 0b6941474f..885c6ba653 100644
--- a/actionRuntimes/php7.1Action/Dockerfile
+++ b/actionRuntimes/php7.1Action/Dockerfile
@@ -1 +1,4 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more 
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+
 FROM openwhisk/action-php-v7.1:1.0.0
diff --git a/actionRuntimes/python2Action/Dockerfile 
b/actionRuntimes/python2Action/Dockerfile
index a3ff63ebde..f06d8c4994 100644
--- a/actionRuntimes/python2Action/Dockerfile
+++ b/actionRuntimes/python2Action/Dockerfile
@@ -1 +1,4 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more 
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+
 FROM openwhisk/python2action:1.0.0
diff --git a/actionRuntimes/pythonAction/Dockerfile 
b/actionRuntimes/pythonAction/Dockerfile
index 1f67c38b23..ccc727f123 100644
--- a/actionRuntimes/pythonAction/Dockerfile
+++ b/actionRuntimes/pythonAction/Dockerfile
@@ -1 +1,4 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more 
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+
 FROM openwhisk/python3action:1.0.0
diff --git a/actionRuntimes/swift3.1.1Action/Dockerfile 
b/actionRuntimes/swift3.1.1Action/Dockerfile
index 1f1de159c7..f735d276ea 100755
--- a/actionRuntimes/swift3.1.1Action/Dockerfile
+++ b/actionRuntimes/swift3.1.1Action/Dockerfile
@@ -1 +1,4 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more 
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+
 FROM openwhisk/action-swift-v3.1.1:1.0.0
diff --git a/actionRuntimes/swift4.1Action/Dockerfile 
b/actionRuntimes/swift4.1Action/Dockerfile
index a0408c1f88..fda4404ae8 100755
--- a/actionRuntimes/swift4.1Action/Dockerfile
+++ b/actionRuntimes/swift4.1Action/Dockerfile
@@ -1 +1,4 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more 
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+
 FROM openwhisk/action-swift-v4.1:1.0.5
diff --git a/common/scala/Dockerfile b/common/scala/Dockerfile
index 885880dc3b..9e5ac3b96f 100644
--- a/common/scala/Dockerfile
+++ b/common/scala/Dockerfile
@@ -1,18 +1,5 @@
-#
 # Licensed to the Apache Software Foundation (ASF) under one or more 
contributor
-# license agreements.  See the NOTICE file distributed with this work for 
additional
-# information regarding copyright ownership.  The ASF licenses this file to you
-# under the Apache License, Version 2.0 (the # "License"); you may not use this
-# file except in compliance with the License.  You may obtain a copy of 

[GitHub] codecov-io commented on issue #3659: Assure all Dockerfiles have ASF header.

[GitBox]

codecov-io commented on issue #3659: Assure all Dockerfiles have ASF header.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3659#issuecomment-389263532
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3659?src=pr=h1)
 Report
   > Merging 
[#3659](https://codecov.io/gh/apache/incubator-openwhisk/pull/3659?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/403d3417f09f145969a936f322c620f6bc5204ff?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3659/graphs/tree.svg?height=150=l0YmsiSAso=650=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3659?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#3659   +/-   ##
   ===
 Coverage   74.49%   74.49%   
   ===
 Files 126  126   
 Lines5990 5990   
 Branches  390  390   
   ===
 Hits 4462 4462   
 Misses   1528 1528
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3659?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3659?src=pr=footer).
 Last update 
[403d341...7a1277c](https://codecov.io/gh/apache/incubator-openwhisk/pull/3659?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai commented on a change in pull request #870: WIP: Project and Package parameters

[GitBox]

pritidesai commented on a change in pull request #870: WIP: Project and Package 
parameters
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/870#discussion_r188456475
 
 

 ##
 File path: cmd/root.go
 ##
 @@ -68,23 +75,25 @@ func init() {
// TODO() Publish command, not completed
// TODO() Report command, not completed
// TODO() have a single function that conditionally (i.e., Trace=true) 
prints ALL Flags
-   RootCmd.PersistentFlags().StringVar(, "config", "", 
wski18n.T(wski18n.ID_CMD_FLAG_CONFIG))
 
 Review comment:
   Converted all hard coded strings to CONST, for example, "config" to 
`FLAG_CONFIG`, etc


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai commented on a change in pull request #870: WIP: Project and Package parameters

[GitBox]

pritidesai commented on a change in pull request #870: WIP: Project and Package 
parameters
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/870#discussion_r188456309
 
 

 ##
 File path: cmd/root.go
 ##
 @@ -53,7 +52,15 @@ func RootCmdImp(cmd *cobra.Command, args []string) error {
 // Execute adds all child commands to the root command sets flags 
appropriately.
 // This is called by main.main(). It only needs to happen once to the rootCmd.
 func Execute() {
-   if err := RootCmd.Execute(); err != nil {
 
 Review comment:
   Adding support for `--param` and `--param-file`, parsing these two CLI 
options and reading their values into `utils.Flag.params`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai commented on a change in pull request #870: WIP: Project and Package parameters

[GitBox]

pritidesai commented on a change in pull request #870: WIP: Project and Package 
parameters
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/870#discussion_r188456092
 
 

 ##
 File path: cmd/report.go
 ##
 @@ -18,246 +18,24 @@
 package cmd
 
 import (
-   "fmt"
 
 Review comment:
   Cleaning up `cmd/report.go` as this code was not maintained and doesn't work 
with a basic use case. We are trying to redefine report functionality. Will add 
implementation as needed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows commented on issue #716: Some source files are missing Apache license headers

[GitBox]

mrutkows commented on issue #716: Some source files are missing Apache license 
headers
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/716#issuecomment-389333913
 
 
   @daisy-ycguo which files are still missing ASF license headers (or not 
documented as exclusions) that would not be fixed by someone fixing issue #909 
or Issue #889 ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows commented on issue #716: Some source files are missing Apache license headers

[GitBox]

mrutkows commented on issue #716: Some source files are missing Apache license 
headers
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/716#issuecomment-389333913
 
 
   @daisy-ycguo which files are still missing ASF license headers (or not 
documented as exclusions)?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai commented on a change in pull request #870: WIP: Project and Package parameters

[GitBox]

pritidesai commented on a change in pull request #870: WIP: Project and Package 
parameters
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/870#discussion_r188455701
 
 

 ##
 File path: cmd/export.go
 ##
 @@ -41,6 +41,8 @@ var exportCmd = {
 }
 
 var config *whisk.Config
+var wskpropsPath string
 
 Review comment:
   these two variables were defined in `cmd/report.go` which are not needed for 
report command but used by export and therefore adding them to `cmd/export.go`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows opened a new issue #3660: Python (*.py) and YAML (.yml) files missing ASF license headers

[GitBox]

mrutkows opened a new issue #3660: Python (*.py) and YAML (.yml) files missing 
ASF license headers
URL: https://github.com/apache/incubator-openwhisk/issues/3660
 
 
   The following files need ASF Minified (or "Mini") License headers added to 
them (or documented as an "Exclusion here: ):
   
   ```
   
 incubator-openwhisk/actionRuntimes/actionProxy/invoke.py]:
 incubator-openwhisk/ansible/apigateway.yml]:
 incubator-openwhisk/ansible/boot_instances_dist.yml]:
 incubator-openwhisk/ansible/controller.yml]:
 incubator-openwhisk/ansible/couchdb.yml]:
 incubator-openwhisk/ansible/edge.yml]:
 incubator-openwhisk/ansible/initdb.yml]:
 incubator-openwhisk/ansible/invoker.yml]:
 incubator-openwhisk/ansible/kafka.yml]:
 incubator-openwhisk/ansible/logs.yml]:
 incubator-openwhisk/ansible/openwhisk.yml]:
 incubator-openwhisk/ansible/postdeploy.yml]:
 incubator-openwhisk/ansible/prereq.yml]:
 incubator-openwhisk/ansible/prereq_build.yml]:
 incubator-openwhisk/ansible/properties.yml]:
 incubator-openwhisk/ansible/provision_env_dist.yml
 incubator-openwhisk/ansible/publish.yml
 incubator-openwhisk/ansible/recreateDesignDocs.yml
 incubator-openwhisk/ansible/registry.yml
 incubator-openwhisk/ansible/roles/apigateway/tasks/clean.yml
 incubator-openwhisk/ansible/roles/apigateway/tasks/deploy.yml
 incubator-openwhisk/ansible/roles/apigateway/tasks/main.yml
 incubator-openwhisk/ansible/roles/cli-install/tasks/clean.yml
 incubator-openwhisk/ansible/roles/cli-install/tasks/deploy.yml
 incubator-openwhisk/ansible/roles/cli-install/tasks/main.yml
 incubator-openwhisk/ansible/roles/cli/tasks/clean.yml
 incubator-openwhisk/ansible/roles/cli/tasks/deploy.yml
 incubator-openwhisk/ansible/roles/cli/tasks/main.yml
 incubator-openwhisk/ansible/roles/controller/tasks/clean.yml
 incubator-openwhisk/ansible/roles/controller/tasks/deploy.yml
 incubator-openwhisk/ansible/roles/controller/tasks/join_akka_cluster.yml
 incubator-openwhisk/ansible/roles/controller/tasks/main.yml
 incubator-openwhisk/ansible/roles/couchdb/tasks/clean.yml
 incubator-openwhisk/ansible/roles/couchdb/tasks/deploy.yml
 incubator-openwhisk/ansible/roles/couchdb/tasks/main.yml
 incubator-openwhisk/ansible/roles/docker/tasks/clean.yml
 incubator-openwhisk/ansible/roles/docker/tasks/deploy.yml
 incubator-openwhisk/ansible/roles/docker/tasks/main.yml
 incubator-openwhisk/ansible/roles/invoker/tasks/clean.yml
 incubator-openwhisk/ansible/roles/invoker/tasks/deploy.yml
 incubator-openwhisk/ansible/roles/invoker/tasks/main.yml
 incubator-openwhisk/ansible/roles/kafka/tasks/clean.yml
 incubator-openwhisk/ansible/roles/kafka/tasks/deploy.yml
 incubator-openwhisk/ansible/roles/kafka/tasks/main.yml
 incubator-openwhisk/ansible/roles/nginx/tasks/clean.yml
 incubator-openwhisk/ansible/roles/nginx/tasks/deploy.yml
 incubator-openwhisk/ansible/roles/nginx/tasks/main.yml
 incubator-openwhisk/ansible/roles/prereq/tasks/clean.yml
 incubator-openwhisk/ansible/roles/prereq/tasks/deploy.yml
 incubator-openwhisk/ansible/roles/prereq/tasks/main.yml
 incubator-openwhisk/ansible/roles/redis/tasks/clean.yml
 incubator-openwhisk/ansible/roles/redis/tasks/deploy.yml
 incubator-openwhisk/ansible/roles/redis/tasks/main.yml
 incubator-openwhisk/ansible/roles/registry/tasks/clean.yml
 incubator-openwhisk/ansible/roles/registry/tasks/deploy.yml
 incubator-openwhisk/ansible/roles/registry/tasks/gencert.yml
 incubator-openwhisk/ansible/roles/registry/tasks/main.yml
 incubator-openwhisk/ansible/roles/registry/tasks/publish.yml
 incubator-openwhisk/ansible/roles/routemgmt/tasks/clean.yml
 incubator-openwhisk/ansible/roles/routemgmt/tasks/deploy.yml
 incubator-openwhisk/ansible/roles/routemgmt/tasks/main.yml
 incubator-openwhisk/ansible/roles/whiskhost/tasks/addUser.yml
 incubator-openwhisk/ansible/roles/whiskhost/tasks/clean.yml
 incubator-openwhisk/ansible/roles/whiskhost/tasks/deploy.yml
 incubator-openwhisk/ansible/roles/whiskhost/tasks/main.yml
 incubator-openwhisk/ansible/roles/whiskhost/tasks/patchKernel.yml
 incubator-openwhisk/ansible/roles/zookeeper/tasks/clean.yml
 incubator-openwhisk/ansible/roles/zookeeper/tasks/deploy.yml
 incubator-openwhisk/ansible/roles/zookeeper/tasks/main.yml
 incubator-openwhisk/ansible/routemgmt.yml
 incubator-openwhisk/ansible/setup.yml
 incubator-openwhisk/ansible/tasks/db/checkDb.yml
 incubator-openwhisk/ansible/tasks/db/recreateDb.yml
 incubator-openwhisk/ansible/tasks/db/recreateDoc.yml
 incubator-openwhisk/ansible/tasks/docker_login.yml
 incubator-openwhisk/ansible/tasks/initdb.yml
 incubator-openwhisk/ansible/tasks/installOpenwhiskCatalog.yml
 incubator-openwhisk/ansible/tasks/recreateViews.yml
 incubator-openwhisk/ansible/tasks/wipeDatabase.yml
   

[GitHub] csantanapr closed pull request #3616: Use ‘docker.host’ java property as a way to set Docker access for Runtime unit tests

[GitBox]

csantanapr closed pull request #3616: Use ‘docker.host’ java property as a way 
to set Docker access for Runtime unit tests
URL: https://github.com/apache/incubator-openwhisk/pull/3616
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/tests/src/test/scala/actionContainers/ActionContainer.scala 
b/tests/src/test/scala/actionContainers/ActionContainer.scala
index cba29d986d..3ee1f47314 100644
--- a/tests/src/test/scala/actionContainers/ActionContainer.scala
+++ b/tests/src/test/scala/actionContainers/ActionContainer.scala
@@ -30,13 +30,13 @@ import scala.concurrent.duration.DurationInt
 import scala.sys.process.ProcessLogger
 import scala.sys.process.stringToProcess
 import scala.util.Random
+import scala.util.{Failure, Success}
 
 import org.apache.commons.lang3.StringUtils
 import org.scalatest.FlatSpec
 import org.scalatest.Matchers
 
 import akka.actor.ActorSystem
-import common.WhiskProperties
 import spray.json._
 import whisk.core.entity.Exec
 
@@ -88,14 +88,38 @@ object ActionContainer {
   }
 
   private lazy val dockerCmd: String = {
-val version = WhiskProperties.getProperty("whisk.version.name")
-// Check if we are running on docker-machine env.
-val hostStr = if (version.toLowerCase().contains("mac")) {
-  s" --host tcp://${WhiskProperties.getMainDockerEndpoint} "
-} else {
-  " "
+/*
+ * The docker host is set to a provided property 'docker.host' if it's
+ * available; otherwise by the environment variable DOCKER_HOST
+ * (which is usually set, especially for DOCKER_MACHINE).
+ *
+ * The plan is to move builds to using 'gradle-docker-plugin', which know
+ * its docker socket and to have it pass the docker socket implicitly using
+ * 'systemProperty "docker.host", docker.url'.  Eventually, we will also
+ * need to handle TLS certificates here.  Again, 'gradle-docker-plugin'
+ * knows where they are; we will just add system properties to get the
+ * information onto the docker command line.
+ */
+val dockerCmdString = dockerBin +
+  sys.props
+.get("docker.host")
+.orElse(sys.env.get("DOCKER_HOST"))
+.map(" --host " + _)
+.getOrElse("")
+// Test here that this actually works, otherwise throw a somewhat 
understandable error message
+proc(s"$dockerCmdString info").onComplete {
+  case Success((v, _, _)) if (v != 0) =>
+throw new RuntimeException(s"""Unable to connect to docker host using 
$dockerCmdString as command string.
+  |The docker host is determined using the Java property 'docker.host' 
or
+  |the envirnoment variable 'DOCKER_HOST'. Please verify that one or 
the
+  |other is set for your build/test process.""".stripMargin)
+  case Success((v, _, _)) if (v == 0) =>
+  // Do nothing
+  case Failure(t) =>
+throw t
 }
-s"$dockerBin $hostStr"
+
+dockerCmdString
   }
 
   private def docker(command: String): String = s"$dockerCmd $command"
@@ -145,8 +169,9 @@ object ActionContainer {
 
 // ...find out its IP address...
 val (ip, port) =
-  if (WhiskProperties.getProperty("whisk.version.name") == "local" &&
-  WhiskProperties.onMacOSX()) {
+  if (System.getProperty("os.name").toLowerCase().contains("mac") && 
!sys.env
+.get("DOCKER_HOST")
+.exists(_.trim.nonEmpty)) {
 // on MacOSX, where docker for mac does not permit communicating with 
container directly
 val p = 8988 // port must be available or docker run will fail
 createContainer(Some(p))


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #3616: Use ‘docker.host’ java property as a way to set Docker access for Runtime unit tests

[GitBox]

csantanapr commented on issue #3616: Use ‘docker.host’ java property as a way 
to set Docker access for Runtime unit tests
URL: 
https://github.com/apache/incubator-openwhisk/pull/3616#issuecomment-389331548
 
 
   PG3/2269  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai closed pull request #907: Fix makefile ASF header & use ICF as example of curl usage.

[GitBox]

pritidesai closed pull request #907: Fix makefile ASF header & use ICF as 
example of curl usage.
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/907
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/Dockerfile b/Dockerfile
index a2a04c19..2c5123b0 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,17 +1,18 @@
 #
-# Licensed to the Apache Software Foundation (ASF) under one or more 
contributor
-# license agreements.  See the NOTICE file distributed with this work for 
additional
-# information regarding copyright ownership.  The ASF licenses this file to you
-# under the Apache License, Version 2.0 (the # "License"); you may not use this
-# file except in compliance with the License.  You may obtain a copy of the 
License
-# at:
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
 #
-# http://www.apache.org/licenses/LICENSE-2.0
+# http://www.apache.org/licenses/LICENSE-2.0
 #
-# Unless required by applicable law or agreed to in writing, software 
distributed
-# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
-# CONDITIONS OF ANY KIND, either express or implied.  See the License for the
-# specific language governing permissions and limitations under the License.
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
 #
 
 FROM golang:1.8
diff --git a/Makefile b/Makefile
index 291fc2a2..844c49f7 100644
--- a/Makefile
+++ b/Makefile
@@ -1,17 +1,18 @@
 #
-# Licensed to the Apache Software Foundation (ASF) under one or more 
contributor
-# license agreements.  See the NOTICE file distributed with this work for 
additional
-# information regarding copyright ownership.  The ASF licenses this file to you
-# under the Apache License, Version 2.0 (the # "License"); you may not use this
-# file except in compliance with the License.  You may obtain a copy of the 
License
-# at:
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
 #
-# http://www.apache.org/licenses/LICENSE-2.0
+# http://www.apache.org/licenses/LICENSE-2.0
 #
-# Unless required by applicable law or agreed to in writing, software 
distributed
-# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
-# CONDITIONS OF ANY KIND, either express or implied.  See the License for the
-# specific language governing permissions and limitations under the License.
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
 #
 
 SOURCEDIR=.
diff --git a/docs/examples/deployment_hello_world_triggerrule_bindings.yaml 
b/docs/examples/deployment_hello_world_triggerrule_bindings.yaml
index 8eef162b..dbe0a608 100644
--- a/docs/examples/deployment_hello_world_triggerrule_bindings.yaml
+++ b/docs/examples/deployment_hello_world_triggerrule_bindings.yaml
@@ -1,18 +1,5 @@
-#
 # Licensed to the Apache Software Foundation (ASF) under one or more 
contributor
-# license agreements.  See the NOTICE file distributed with this work for 
additional
-# information regarding copyright ownership.  The ASF licenses this file to you
-# under the Apache License, Version 2.0 (the # "License"); you may not use this
-# file except in compliance with the License.  You may obtain a copy of the 
License
-# at:
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software 
distributed
-# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
-# CONDITIONS OF ANY KIND, either express or implied.  See the License for the
-# specific language governing permissions and 

[GitHub] mrutkows commented on issue #909: Fix LICENSE headers in all YAML/.js under "tests" folder

[GitBox]

mrutkows commented on issue #909: Fix LICENSE headers in all YAML/.js under 
"tests" folder
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/909#issuecomment-389322738
 
 
   Tried to fix as many as possible, but needed this issue to track the 
remaining ones.  Scancode results indicate the following files have issues:
   
   ```
   $ ./scanCode.py --config NoExclusions.cfg  
../../incubator-openwhisk-wskdeploy/
   Reading configuration file [NoExclusions.cfg]...
   Scanning files starting at [../../incubator-openwhisk-wskdeploy/]...
   Scan detected 117 error(s) in 116 file(s):
 
[../../incubator-openwhisk-wskdeploy/tests/apps/openwhisk-githubslackbot/manifest.yaml]:
  1: file does not include required license header.
 
[../../incubator-openwhisk-wskdeploy/tests/apps/owbp-cloudant-trigger/runtimes/node/actions/process-change.js]:
  1: file does not include required license header.
 
[../../incubator-openwhisk-wskdeploy/tests/apps/owbp-cloudant-trigger/runtimes/node/manifest.yaml]:
  1: file does not include required license header.
 
[../../incubator-openwhisk-wskdeploy/tests/apps/owbp-cloudant-trigger/runtimes/php/manifest.yaml]:
  1: file does not include required license header.
 
[../../incubator-openwhisk-wskdeploy/tests/apps/owbp-cloudant-trigger/runtimes/python/manifest.yaml]:
  1: file does not include required license header.
 
[../../incubator-openwhisk-wskdeploy/tests/apps/owbp-cloudant-trigger/runtimes/swift/manifest.yaml]:
  1: file does not include required license header.
 
[../../incubator-openwhisk-wskdeploy/tests/dat/deployment_compose_trigger.yaml]:
  1: file does not include required license header.
 
[../../incubator-openwhisk-wskdeploy/tests/dat/deployment_data_action_with_inputs_outputs.yaml]:
  1: file does not include required license header.
 
[../../incubator-openwhisk-wskdeploy/tests/dat/deployment_data_packages.yaml]:
  1: file does not include required license header.
 
[../../incubator-openwhisk-wskdeploy/tests/dat/deployment_data_packages_env_var.yaml]:
  1: file does not include required license header.
 
[../../incubator-openwhisk-wskdeploy/tests/dat/deployment_data_project.yaml]:
  1: file does not include required license header.
 
[../../incubator-openwhisk-wskdeploy/tests/dat/deployment_data_project_package.yaml]:
  1: file does not include required license header.
 
[../../incubator-openwhisk-wskdeploy/tests/dat/deployment_data_project_packages_env_var.yaml]:
  1: file does not include required license header.
 
[../../incubator-openwhisk-wskdeploy/tests/dat/deployment_data_project_packages_env_var_con.yaml]:
  1: file does not include required license header.
 
[../../incubator-openwhisk-wskdeploy/tests/dat/deployment_validate_action_annotations.yaml]:
  1: file does not include required license header.
 
[../../incubator-openwhisk-wskdeploy/tests/dat/deployment_validate_credentials.yaml]:
  1: file does not include required license header.
 
[../../incubator-openwhisk-wskdeploy/tests/dat/deployment_validate_deployment_reader.yaml]:
  1: file does not include required license header.
 
[../../incubator-openwhisk-wskdeploy/tests/dat/manifest_bad_yaml_invalid_comment.yaml]:
  1: file does not include required license header.
 
[../../incubator-openwhisk-wskdeploy/tests/dat/manifest_bad_yaml_invalid_key_mapping_value.yaml]:
  1: file does not include required license header.
 
[../../incubator-openwhisk-wskdeploy/tests/dat/manifest_bad_yaml_invalid_package_key.yaml]:
  1: file does not include required license header.
 
[../../incubator-openwhisk-wskdeploy/tests/dat/manifest_bad_yaml_missing_root_key.yaml]:
  1: file does not include required license header.
 
[../../incubator-openwhisk-wskdeploy/tests/dat/manifest_data_compose_actions_for_annotations.yaml]:
  1: file does not include required license header.
 
[../../incubator-openwhisk-wskdeploy/tests/dat/manifest_data_compose_actions_for_docker.yaml]:
  1: file does not include required license header.
 
[../../incubator-openwhisk-wskdeploy/tests/dat/manifest_data_compose_actions_for_function.yaml]:
  1: file does not include required license header.
 
[../../incubator-openwhisk-wskdeploy/tests/dat/manifest_data_compose_actions_for_function_and_code.yaml]:
  1: file does not include required license header.
 
[../../incubator-openwhisk-wskdeploy/tests/dat/manifest_data_compose_actions_for_function_with_remote_dir.yaml]:
  1: file does not include required license header.
 
[../../incubator-openwhisk-wskdeploy/tests/dat/manifest_data_compose_actions_for_invalid_web.yaml]:
  1: file does not include required license header.
 

[GitHub] mrutkows opened a new issue #909: Fix LICENSE headers in all YAML/.js under "tests" folder

[GitBox]

mrutkows opened a new issue #909: Fix LICENSE headers in all YAML/.js under 
"tests" folder
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/909
 
 
   It appears that all the files under the "tests" folder (manifest.yaml, 
deployment.yaml or *.js) have 2 issues:
   
   1) they picked up a "bad" hash header that was never found in scancode.py 
because we had excluded "tests" folder from scans.
   2) It appears we adopted a "full" ASF header when we SHOULD use a mini header
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows opened a new issue #908: Remove unused YAML in validate-packages-in-manifest/manifest.yaml

[GitBox]

mrutkows opened a new issue #908: Remove unused YAML in 
validate-packages-in-manifest/manifest.yaml
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/908
 
 
   There are some dependencies commented out in the YAML grammar; please remove 
if no longer needed or complete missing functionality.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] greenfireman closed issue #3634: Creating an action from zip: 413 Request Entity Too Large

[GitBox]

greenfireman closed issue #3634: Creating an action from zip: 413 Request 
Entity Too Large
URL: https://github.com/apache/incubator-openwhisk/issues/3634
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3616: Use ‘docker.host’ java property as a way to set Docker access for Runtime unit tests

[GitBox]

codecov-io commented on issue #3616: Use ‘docker.host’ java property as a way 
to set Docker access for Runtime unit tests
URL: 
https://github.com/apache/incubator-openwhisk/pull/3616#issuecomment-386876914
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3616?src=pr=h1)
 Report
   > Merging 
[#3616](https://codecov.io/gh/apache/incubator-openwhisk/pull/3616?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/403d3417f09f145969a936f322c620f6bc5204ff?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3616/graphs/tree.svg?width=650=l0YmsiSAso=150=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3616?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#3616   +/-   ##
   ===
 Coverage   74.49%   74.49%   
   ===
 Files 126  126   
 Lines5990 5990   
 Branches  390  390   
   ===
 Hits 4462 4462   
 Misses   1528 1528
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3616?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3616?src=pr=footer).
 Last update 
[403d341...fa44248](https://codecov.io/gh/apache/incubator-openwhisk/pull/3616?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai closed pull request #906: Resolves issue #899

[GitBox]

pritidesai closed pull request #906: Resolves issue #899
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/906
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/parsers/yamlparser.go b/parsers/yamlparser.go
index 0b7c1585..77f35da1 100644
--- a/parsers/yamlparser.go
+++ b/parsers/yamlparser.go
@@ -403,6 +403,7 @@ func (yaml *YAML) ComposeParsersAction(wskact whisk.Action) 
*Action {
action.Name = wskact.Name
action.Namespace = wskact.Namespace
action.Version = wskact.Version
+   action.Main = wskact.Exec.Main
 
action.Inputs = make(map[string]Parameter)
for _, keyval := range wskact.Parameters {
diff --git a/tests/src/integration/common/wskdeploy.go 
b/tests/src/integration/common/wskdeploy.go
index abcbc3ab..32938a23 100644
--- a/tests/src/integration/common/wskdeploy.go
+++ b/tests/src/integration/common/wskdeploy.go
@@ -171,6 +171,10 @@ func (Wskdeploy *Wskdeploy) 
ManagedDeploymentOnlyManifest(manifestPath string) (
return Wskdeploy.RunCommand("sync", "-m", manifestPath)
 }
 
+func (Wskdeploy *Wskdeploy) ManagedDeploymentManifestAndProject(manifestPath 
string, projectName string) (string, error) {
+   return Wskdeploy.RunCommand("sync", "-m", manifestPath, 
"--projectname", projectName)
+}
+
 func (Wskdeploy *Wskdeploy) ManagedDeployment(manifestPath string, 
deploymentPath string) (string, error) {
return Wskdeploy.RunCommand("sync", "-m", manifestPath, "-d", 
deploymentPath)
 }
diff --git a/tests/src/integration/export/export_test.go 
b/tests/src/integration/export/export_test.go
index 6cc01240..63f8fceb 100644
--- a/tests/src/integration/export/export_test.go
+++ b/tests/src/integration/export/export_test.go
@@ -62,6 +62,29 @@ func TestExport(t *testing.T) {
assert.Equal(t, nil, err, "Failed to undeploy the lib2.")
 }
 
+func TestExportHelloWorld(t *testing.T) {
+   projectName := "HELLO_WORLD"
+   wskdeploy := common.NewWskdeploy()
+
+   _, err := 
wskdeploy.ManagedDeploymentManifestAndProject(manifestHelloWorldPath, 
projectName)
+   assert.Equal(t, nil, err, "Failed to deploy manifest file.")
+
+   _, err = wskdeploy.ExportProject(projectName, 
targetManifestHelloWorldPath)
+   assert.Equal(t, nil, err, "Failed to export project.")
+
+   _, err = os.Stat(targetManifestHelloWorldPath)
+   assert.Equal(t, nil, err, "Missing exported manifest file")
+
+   _, err = wskdeploy.UndeployManifestPathOnly(manifestHelloWorldPath)
+   assert.Equal(t, nil, err, "Failed to undeploy")
+
+   _, err = 
wskdeploy.ManagedDeploymentManifestAndProject(targetManifestHelloWorldPath, 
projectName)
+   assert.Equal(t, nil, err, "Failed to redeploy exported project.")
+
+   _, err = 
wskdeploy.UndeployManifestPathOnly(targetManifestHelloWorldPath)
+   assert.Equal(t, nil, err, "Failed to undeploy exported project")
+}
+
 func TestExport2Pack(t *testing.T) {
projectName := "2pack"
wskdeploy := common.NewWskdeploy()
@@ -93,6 +116,8 @@ var (
targetManifestFolder = os.Getenv("GOPATH") + 
"/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/export/tmp/"
targetManifestPath   = targetManifestFolder + "manifest.yaml"
 
-   manifest2PackPath   = os.Getenv("GOPATH") + 
"/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/export/manifest_2pack.yaml"
-   target2PackManifestPath = targetManifestFolder + 
"exported2packmanifest.yaml"
+   manifestHelloWorldPath   = os.Getenv("GOPATH") + 
"/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/helloworld/manifest.yaml"
+   targetManifestHelloWorldPath = targetManifestFolder + "manifest.yaml"
+   manifest2PackPath= os.Getenv("GOPATH") + 
"/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/export/manifest_2pack.yaml"
+   target2PackManifestPath  = targetManifestFolder + 
"exported2packmanifest.yaml"
 )


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubee commented on a change in pull request #3616: Use ‘docker.host’ java property as a way to set Docker access for Runtime unit tests

[GitBox]

dubee commented on a change in pull request #3616: Use ‘docker.host’ java 
property as a way to set Docker access for Runtime unit tests
URL: 
https://github.com/apache/incubator-openwhisk/pull/3616#discussion_r188415148
 
 

 ##
 File path: tests/src/test/scala/actionContainers/ActionContainer.scala
 ##
 @@ -88,14 +88,38 @@ object ActionContainer {
   }
 
   private lazy val dockerCmd: String = {
-val version = WhiskProperties.getProperty("whisk.version.name")
-// Check if we are running on docker-machine env.
-val hostStr = if (version.toLowerCase().contains("mac")) {
-  s" --host tcp://${WhiskProperties.getMainDockerEndpoint} "
-} else {
-  " "
+/*
+ * The docker host is set to a provided property 'docker.host' if it's
+ * available; otherwise by the environment variable DOCKER_HOST
+ * (which is usually set, especially for DOCKER_MACHINE).
+ *
+ * The plan is to move builds to using 'gradle-docker-plugin', which know
+ * its docker socket and to have it pass the docker socket implicitly using
+ * 'systemProperty "docker.host", docker.url'.  Eventually, we will also
+ * need to handle TLS certificates here.  Again, 'gradle-docker-plugin'
+ * knows where they are; we will just add system properties to get the
+ * information onto the docker command line.
+ */
+val dockerCmdString = dockerBin +
+  sys.props
+.get("docker.host")
+.orElse(sys.env.get("DOCKER_HOST"))
+.map(" --host " + _)
+.getOrElse("")
+// Test here that this actually works, otherwise throw a somewhat 
understandable error message
+proc(s"$dockerCmdString info").onComplete {
+  case Success((v, _, _)) if (v != 0) =>
+throw new RuntimeException("""Unable to connect to docker host using 
'$d' as command string.
 
 Review comment:
   Add `s` in front of the string as well.
   
   ```
   s"""Unable to connect to docker host using '$dockerCmdString' as command 
string.
 |The docker host is determined using the Java property 
'docker.host' or
 |the envirnoment variable 'DOCKER_HOST'. Please verify that one or 
the
 |other is set for your build/test process.""".stripMargin
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3616: Use ‘docker.host’ java property as a way to set Docker access for Runtime unit tests

[GitBox]

codecov-io commented on issue #3616: Use ‘docker.host’ java property as a way 
to set Docker access for Runtime unit tests
URL: 
https://github.com/apache/incubator-openwhisk/pull/3616#issuecomment-386876914
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3616?src=pr=h1)
 Report
   > Merging 
[#3616](https://codecov.io/gh/apache/incubator-openwhisk/pull/3616?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/403d3417f09f145969a936f322c620f6bc5204ff?src=pr=desc)
 will **decrease** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3616/graphs/tree.svg?width=650=150=pr=l0YmsiSAso)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3616?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3616  +/-   ##
   ==
   - Coverage   74.49%   74.47%   -0.02% 
   ==
 Files 126  126  
 Lines5990 5990  
 Branches  390  390  
   ==
   - Hits 4462 4461   -1 
   - Misses   1528 1529   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3616?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3616/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==)
 | `84.61% <0%> (-3.85%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3616?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3616?src=pr=footer).
 Last update 
[403d341...c9b1bb4](https://codecov.io/gh/apache/incubator-openwhisk/pull/3616?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubee commented on a change in pull request #3616: Use ‘docker.host’ java property as a way to set Docker access for Runtime unit tests

[GitBox]

dubee commented on a change in pull request #3616: Use ‘docker.host’ java 
property as a way to set Docker access for Runtime unit tests
URL: 
https://github.com/apache/incubator-openwhisk/pull/3616#discussion_r188415148
 
 

 ##
 File path: tests/src/test/scala/actionContainers/ActionContainer.scala
 ##
 @@ -88,14 +88,38 @@ object ActionContainer {
   }
 
   private lazy val dockerCmd: String = {
-val version = WhiskProperties.getProperty("whisk.version.name")
-// Check if we are running on docker-machine env.
-val hostStr = if (version.toLowerCase().contains("mac")) {
-  s" --host tcp://${WhiskProperties.getMainDockerEndpoint} "
-} else {
-  " "
+/*
+ * The docker host is set to a provided property 'docker.host' if it's
+ * available; otherwise by the environment variable DOCKER_HOST
+ * (which is usually set, especially for DOCKER_MACHINE).
+ *
+ * The plan is to move builds to using 'gradle-docker-plugin', which know
+ * its docker socket and to have it pass the docker socket implicitly using
+ * 'systemProperty "docker.host", docker.url'.  Eventually, we will also
+ * need to handle TLS certificates here.  Again, 'gradle-docker-plugin'
+ * knows where they are; we will just add system properties to get the
+ * information onto the docker command line.
+ */
+val dockerCmdString = dockerBin +
+  sys.props
+.get("docker.host")
+.orElse(sys.env.get("DOCKER_HOST"))
+.map(" --host " + _)
+.getOrElse("")
+// Test here that this actually works, otherwise throw a somewhat 
understandable error message
+proc(s"$dockerCmdString info").onComplete {
+  case Success((v, _, _)) if (v != 0) =>
+throw new RuntimeException("""Unable to connect to docker host using 
'$d' as command string.
 
 Review comment:
   Add `s` in front of the string as well.
   
   ```
   s"""Unable to connect to docker host using '$d' as command string.
 |The docker host is determined using the Java property 
'docker.host' or
 |the envirnoment variable 'DOCKER_HOST'. Please verify that one or 
the
 |other is set for your build/test process.""".stripMargin
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubee commented on a change in pull request #3616: Use ‘docker.host’ java property as a way to set Docker access for Runtime unit tests

[GitBox]

dubee commented on a change in pull request #3616: Use ‘docker.host’ java 
property as a way to set Docker access for Runtime unit tests
URL: 
https://github.com/apache/incubator-openwhisk/pull/3616#discussion_r188406381
 
 

 ##
 File path: tests/src/test/scala/actionContainers/ActionContainer.scala
 ##
 @@ -88,14 +88,38 @@ object ActionContainer {
   }
 
   private lazy val dockerCmd: String = {
-val version = WhiskProperties.getProperty("whisk.version.name")
-// Check if we are running on docker-machine env.
-val hostStr = if (version.toLowerCase().contains("mac")) {
-  s" --host tcp://${WhiskProperties.getMainDockerEndpoint} "
-} else {
-  " "
+/*
+ * The docker host is set to a provided property 'docker.host' if it's
+ * available; otherwise by the environment variable DOCKER_HOST
+ * (which is usually set, especially for DOCKER_MACHINE).
+ *
+ * The plan is to move builds to using 'gradle-docker-plugin', which know
+ * its docker socket and to have it pass the docker socket implicitly using
+ * 'systemProperty "docker.host", docker.url'.  Eventually, we will also
+ * need to handle TLS certificates here.  Again, 'gradle-docker-plugin'
+ * knows where they are; we will just add system properties to get the
+ * information onto the docker command line.
+ */
+val dockerCmdString = dockerBin +
+  sys.props
+.get("docker.host")
+.orElse(sys.env.get("DOCKER_HOST"))
+.map(" --host " + _)
+.getOrElse("")
+// Test here that this actually works, otherwise throw a somewhat 
understandable error message
+proc(s"$dockerCmdString info").onComplete {
+  case Success((v, _, _)) if (v != 0) =>
+throw new RuntimeException("""Unable to connect to docker host using 
'$d' as command string.
 
 Review comment:
   What is `$d`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3416: Refactor and unit test PoolingRestClient

[GitBox]

codecov-io commented on issue #3416: Refactor and unit test PoolingRestClient
URL: 
https://github.com/apache/incubator-openwhisk/pull/3416#issuecomment-386083423
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3416?src=pr=h1)
 Report
   > Merging 
[#3416](https://codecov.io/gh/apache/incubator-openwhisk/pull/3416?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/403d3417f09f145969a936f322c620f6bc5204ff?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3416/graphs/tree.svg?src=pr=650=l0YmsiSAso=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3416?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3416  +/-   ##
   ==
   - Coverage   74.49%   74.48%   -0.01% 
   ==
 Files 126  126  
 Lines5990 5988   -2 
 Branches  390  389   -1 
   ==
   - Hits 4462 4460   -2 
 Misses   1528 1528
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3416?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...scala/whisk/core/database/CloudantRestClient.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3416/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQ2xvdWRhbnRSZXN0Q2xpZW50LnNjYWxh)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...ontainerpool/logging/ElasticSearchRestClient.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3416/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9sb2dnaW5nL0VsYXN0aWNTZWFyY2hSZXN0Q2xpZW50LnNjYWxh)
 | `76.08% <100%> (ø)` | :arrow_up: |
   | 
[.../src/main/scala/whisk/http/PoolingRestClient.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3416/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvUG9vbGluZ1Jlc3RDbGllbnQuc2NhbGE=)
 | `91.17% <100%> (-0.5%)` | :arrow_down: |
   | 
[.../scala/whisk/core/database/CouchDbRestClient.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3416/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQ291Y2hEYlJlc3RDbGllbnQuc2NhbGE=)
 | `84.78% <100%> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3416?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3416?src=pr=footer).
 Last update 
[403d341...d74f305](https://codecov.io/gh/apache/incubator-openwhisk/pull/3416?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dgrove-oss opened a new pull request #200: add ingress configuration for IBM Cloud Standard Clusters to Helm deploy

[GitBox]

dgrove-oss opened a new pull request #200: add ingress configuration for IBM 
Cloud Standard Clusters to Helm deploy
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/200
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3619: Provide an activation store SPI

[GitBox]

codecov-io commented on issue #3619: Provide an activation store SPI
URL: 
https://github.com/apache/incubator-openwhisk/pull/3619#issuecomment-387224274
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619?src=pr=h1)
 Report
   > Merging 
[#3619](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/403d3417f09f145969a936f322c620f6bc5204ff?src=pr=desc)
 will **increase** coverage by `0.11%`.
   > The diff coverage is `77.77%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/graphs/tree.svg?width=650=150=l0YmsiSAso=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #3619  +/-   ##
   =
   + Coverage   74.49%   74.6%   +0.11% 
   =
 Files 126 127   +1 
 Lines59905993   +3 
 Branches  390 371  -19 
   =
   + Hits 44624471   +9 
   + Misses   15281522   -6
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[.../src/main/scala/whisk/core/entity/WhiskStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1doaXNrU3RvcmUuc2NhbGE=)
 | `96.87% <ø> (ø)` | :arrow_up: |
   | 
[...src/main/scala/whisk/core/controller/Actions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9BY3Rpb25zLnNjYWxh)
 | `91.28% <ø> (ø)` | :arrow_up: |
   | 
[...rc/main/scala/whisk/core/entity/ActivationId.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0FjdGl2YXRpb25JZC5zY2FsYQ==)
 | `89.47% <ø> (ø)` | :arrow_up: |
   | 
[...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[.../main/scala/whisk/core/controller/Controller.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9Db250cm9sbGVyLnNjYWxh)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...hisk/core/controller/actions/SequenceActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1NlcXVlbmNlQWN0aW9ucy5zY2FsYQ==)
 | `31.13% <0%> (+0.85%)` | :arrow_up: |
   | 
[...isk/core/controller/actions/PrimitiveActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1ByaW1pdGl2ZUFjdGlvbnMuc2NhbGE=)
 | `87.5% <100%> (+0.47%)` | :arrow_up: |
   | 
[...main/scala/whisk/core/controller/Activations.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9BY3RpdmF0aW9ucy5zY2FsYQ==)
 | `96.61% <100%> (ø)` | :arrow_up: |
   | 
[...rc/main/scala/whisk/core/controller/Triggers.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9UcmlnZ2Vycy5zY2FsYQ==)
 | `81.02% <100%> (+0.3%)` | :arrow_up: |
   | 
[...la/whisk/core/entity/ArtifactActivationStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0FydGlmYWN0QWN0aXZhdGlvblN0b3JlLnNjYWxh)
 | `86.66% <86.66%> (ø)` | |
   | ... and [1 
more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619?src=pr=footer).
 Last update 
[403d341...722fdb3](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the 

[GitHub] codecov-io commented on issue #3659: Assure all Dockerfiles have ASF header.

[GitBox]

codecov-io commented on issue #3659: Assure all Dockerfiles have ASF header.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3659#issuecomment-389263532
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3659?src=pr=h1)
 Report
   > Merging 
[#3659](https://codecov.io/gh/apache/incubator-openwhisk/pull/3659?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/403d3417f09f145969a936f322c620f6bc5204ff?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3659/graphs/tree.svg?width=650=l0YmsiSAso=150=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3659?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#3659   +/-   ##
   ===
 Coverage   74.49%   74.49%   
   ===
 Files 126  126   
 Lines5990 5990   
 Branches  390  390   
   ===
 Hits 4462 4462   
 Misses   1528 1528
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3659?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3659?src=pr=footer).
 Last update 
[403d341...03718c3](https://codecov.io/gh/apache/incubator-openwhisk/pull/3659?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai closed pull request #85: Fix Makefile to use latest Hash ASF license header.

[GitBox]

pritidesai closed pull request #85: Fix Makefile to use latest Hash ASF license 
header.
URL: https://github.com/apache/incubator-openwhisk-client-go/pull/85
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/Makefile b/Makefile
index 397ba6bf..e4cde074 100644
--- a/Makefile
+++ b/Makefile
@@ -1,17 +1,18 @@
 #
-# Licensed to the Apache Software Foundation (ASF) under one or more 
contributor
-# license agreements.  See the NOTICE file distributed with this work for 
additional
-# information regarding copyright ownership.  The ASF licenses this file to you
-# under the Apache License, Version 2.0 (the # "License"); you may not use this
-# file except in compliance with the License.  You may obtain a copy of the 
License
-# at:
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
 #
-# http://www.apache.org/licenses/LICENSE-2.0
+# http://www.apache.org/licenses/LICENSE-2.0
 #
-# Unless required by applicable law or agreed to in writing, software 
distributed
-# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
-# CONDITIONS OF ANY KIND, either express or implied.  See the License for the
-# specific language governing permissions and limitations under the License.
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
 #
 
 deps:


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sciabarra commented on issue #30: Fixes for #10, #24 and #25

[GitBox]

sciabarra commented on issue #30: Fixes for #10, #24 and #25
URL: 
https://github.com/apache/incubator-openwhisk-runtime-go/pull/30#issuecomment-389255955
 
 
   https://imgur.com/a/DU0HXR0 the same commit 06473d3 failing here is building 
properly in my travis (private). Also the error suggest me of an out of memory. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sciabarra closed pull request #30: Fixes for #10, #24 and #25

[GitBox]

sciabarra closed pull request #30: Fixes for #10, #24 and #25
URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/30
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.gitignore b/.gitignore
index a35ea03..cacf376 100644
--- a/.gitignore
+++ b/.gitignore
@@ -8,6 +8,7 @@ vendor/
 actionProxyLoop/proxy
 golang1.10/proxy
 openwhisk/_test/exec
+openwhisk/_test/exec.go
 openwhisk/_test/hi
 openwhisk/_test/hello_greeting
 openwhisk/_test/hello_message
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index c29a74e..0f7f858 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -1,19 +1,19 @@
-[![License](https://img.shields.io/badge/license-Apache--2.0-blue.svg)](http://www.apache.org/licenses/LICENSE-2.0)
 
 
@@ -36,18 +36,18 @@ Instructions on how to do this can be found here:
 [http://www.apache.org/licenses/#clas](http://www.apache.org/licenses/#clas)
 
 Once submitted, you will receive a confirmation email from the Apache Software 
Foundation (ASF) and be added to
-the following list: http://people.apache.org/unlistedclas.html. 
+the following list: http://people.apache.org/unlistedclas.html.
 
 Project committers will use this list to verify pull requests (PRs) come from 
contributors that have signed a CLA.
 
-We look forward to your contributions! 
+We look forward to your contributions!
 
 ## Raising issues
 
-Please raise any bug reports or enhancement requests on the respective project 
repository's GitHub issue tracker. Be sure to search the 
+Please raise any bug reports or enhancement requests on the respective project 
repository's GitHub issue tracker. Be sure to search the
 list to see if your issue has already been raised.
 
-A good bug report is one that make it easy for us to understand what you were 
trying to do and what went wrong. 
+A good bug report is one that make it easy for us to understand what you were 
trying to do and what went wrong.
 Provide as much context as possible so we can try to recreate the issue.
 
 A good enhancement request comes with an explanation of what you are trying to 
do and how that enhancement would help you.
diff --git a/LICENSE-filetype.txt b/LICENSE-filetype.txt
new file mode 100644
index 000..c03a05c
--- /dev/null
+++ b/LICENSE-filetype.txt
@@ -0,0 +1,25 @@
+The MIT License
+
+Copyright (c) Tomas Aparicio
+
+Permission is hereby granted, free of charge, to any person
+obtaining a copy of this software and associated documentation
+files (the "Software"), to deal in the Software without
+restriction, including without limitation the rights to use,
+copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the
+Software is furnished to do so, subject to the following
+conditions:
+
+The above copyright notice and this permission notice shall be
+included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+OTHER DEALINGS IN THE SOFTWARE.
+
diff --git a/LICENSE-testify.txt b/LICENSE-testify.txt
new file mode 100644
index 000..8b79c3f
--- /dev/null
+++ b/LICENSE-testify.txt
@@ -0,0 +1,22 @@
+Copyright (c) 2012 - 2013 Mat Ryer and Tyler Bunnell
+
+Please consider promoting this project if you find it useful.
+
+Permission is hereby granted, free of charge, to any person 
+obtaining a copy of this software and associated documentation 
+files (the "Software"), to deal in the Software without restriction, 
+including without limitation the rights to use, copy, modify, merge, 
+publish, distribute, sublicense, and/or sell copies of the Software, 
+and to permit persons to whom the Software is furnished to do so, 
+subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included
+in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, 
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES 
+OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. 
+IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, 
+DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT 
+OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE 
+OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
\ No newline at end of file
diff --git a/LICENSE.txt b/LICENSE.txt

[GitHub] mrutkows opened a new pull request #907: Fix makefile ASF header & use ICF as example of curl usage.

[GitBox]

mrutkows opened a new pull request #907: Fix makefile ASF header & use ICF as 
example of curl usage.
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/907
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows opened a new pull request #85: Fix Makefile to use latest Hash ASF license header.

[GitBox]

mrutkows opened a new pull request #85: Fix Makefile to use latest Hash ASF 
license header.
URL: https://github.com/apache/incubator-openwhisk-client-go/pull/85
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows commented on issue #153: Change JDK used to build main OW to be "pluggable" for building Source (release)

[GitBox]

mrutkows commented on issue #153: Change JDK used to build main OW to be 
"pluggable" for building Source (release)
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/153#issuecomment-389247011
 
 
   Note: need to look at runtime-java perhaps as well
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows opened a new issue #153: Change JDK used to build main OW to be "pluggable" for building Source (release)

[GitBox]

mrutkows opened a new issue #153: Change JDK used to build main OW to be 
"pluggable" for building Source (release)
URL: https://github.com/apache/incubator-openwhisk-release/issues/153
 
 
   Related to Issue [#3607 - Change the JDK to use 
openjdk8-openj9](https://github.com/apache/incubator-openwhisk/issues/3607).
   
   We need to show that we allow people to build with a JDK of their choosing 
(we can default to one like Oracle), but should likely make this pluggable via 
an Env. var. (or configurable parm.)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dgrove-oss commented on issue #152: Lightbend copyright appears, no LICENSE attribution

[GitBox]

dgrove-oss commented on issue #152: Lightbend copyright appears, no LICENSE 
attribution
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/152#issuecomment-389245851
 
 
   @markusthoemmes 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows closed issue #142: Replace or remove Pair.java from main openwhisk repo.

[GitBox]

mrutkows closed issue #142: Replace or remove Pair.java from main openwhisk 
repo.
URL: https://github.com/apache/incubator-openwhisk-release/issues/142
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows commented on issue #142: Replace or remove Pair.java from main openwhisk repo.

[GitBox]

mrutkows commented on issue #142: Replace or remove Pair.java from main 
openwhisk repo.
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/142#issuecomment-389245057
 
 
   closed by PR https://github.com/apache/incubator-openwhisk/pull/3624


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows opened a new issue #152: Lightbend copyright appears, no LICENSE attribution

[GitBox]

mrutkows opened a new issue #152: Lightbend copyright appears, no LICENSE 
attribution
URL: https://github.com/apache/incubator-openwhisk-release/issues/152
 
 
   
[incubator-openwhisk/blob/master/common/scala/src/main/scala/whisk/core/database/MultipleReadersSingleWriterCache.scala](https://github.com/apache/incubator-openwhisk/blob/master/common/scala/src/main/scala/whisk/core/database/MultipleReadersSingleWriterCache.scala)
 contains:
   
   ```
   /*
* Cache base implementation:
* Copyright (C) 2017 Lightbend Inc. 
*/
   ```
   
   Where did this code come from (project?). Under what license?  why is it not 
attributed?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jasonpet closed pull request #276: Use websocket.org for WebSocket tests

[GitBox]

jasonpet closed pull request #276: Use websocket.org for WebSocket tests
URL: https://github.com/apache/incubator-openwhisk-catalog/pull/276
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/tests/src/test/scala/packages/websocket/WebSocketTests.scala 
b/tests/src/test/scala/packages/websocket/WebSocketTests.scala
index 54353eb..c870c1b 100644
--- a/tests/src/test/scala/packages/websocket/WebSocketTests.scala
+++ b/tests/src/test/scala/packages/websocket/WebSocketTests.scala
@@ -17,7 +17,6 @@
 
 package packages.websocket
 
-import java.io.File
 import java.net.URI
 
 import scala.concurrent.duration.DurationInt
@@ -37,18 +36,12 @@ class WebSocketTests extends TestHelpers with 
WskTestHelpers with BeforeAndAfter
 
   val websocketSendAction = "/whisk.system/websocket/send"
 
-  val containerName = "websocketServerOW"
-  val userDir: String = System.getProperty("user.dir")
-  val websocketDir: String = userDir + "/dat/websocket"
-  val websocketHost: String = wskprops.apihost
-  val websocketPort = "20002"
-
   behavior of "Websocket action"
 
   /**
* This test requires a websocket server running on the given URI.
*/
-  val serverURI: URI = new URI(s"ws://$websocketHost:$websocketPort")
+  val serverURI: URI = new URI("ws://echo.websocket.org")
 
   it should "Use the websocket action to send a payload" in {
 val uniquePayload = s"The cow says ${System.currentTimeMillis()}".toJson
@@ -90,68 +83,4 @@ class WebSocketTests extends TestHelpers with WskTestHelpers 
with BeforeAndAfter
 }
   }
 
-  override def beforeAll() {
-
-val websocketServer =
-  """
- | const WebSocket = require("ws");
- | const wss = new WebSocket.Server({ port: 8080 });
- | wss.on("connection", function connection(ws) {
- |  ws.on("message", function incoming(message) {
- |ws.send(message);
- |  });
- | });
- """.replace("\r", "").stripMargin.lines.mkString
-TestUtils.runCmd(TestUtils.DONTCARE_EXIT, new File("."), "docker", "kill", 
containerName)
-TestUtils.runCmd(TestUtils.DONTCARE_EXIT, new File("."), "docker", "rm", 
containerName)
-TestUtils.runCmd(
-  0,
-  new File("."),
-  "docker",
-  "run",
-  "-d",
-  "-p",
-  "20002:8080",
-  "--name",
-  containerName,
-  "node",
-  "sh",
-  "-c",
-  s"npm install ws; echo '$websocketServer' | node")
-sleepUntilContainerRunning()
-
-  }
-
-  def sleepUntilContainerRunning() {
-var counter = 12
-var running = false
-do {
-  counter = counter - 1
-  val isdb2Running = TestUtils
-.runCmd(
-  TestUtils.DONTCARE_EXIT,
-  new File("."),
-  "docker",
-  "exec",
-  "-t",
-  containerName,
-  "curl",
-  "http://localhost:8080;,
-  "--connect-timeout",
-  "5")
-
-  if (isdb2Running.exitCode != 0) {
-println("sleeping 5 seconds to wait for websocket server")
-Thread.sleep(5000)
-  } else {
-running = true
-  }
-} while (counter > 0 && !running)
-running shouldBe true
-  }
-
-  override def afterAll() {
-TestUtils.runCmd(TestUtils.DONTCARE_EXIT, new File("."), "docker", "kill", 
containerName)
-TestUtils.runCmd(TestUtils.DONTCARE_EXIT, new File("."), "docker", "rm", 
containerName)
-  }
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubee commented on issue #276: Use websocket.org for WebSocket tests

[GitBox]

dubee commented on issue #276: Use websocket.org for WebSocket tests
URL: 
https://github.com/apache/incubator-openwhisk-catalog/pull/276#issuecomment-389225885
 
 
   Using the WebSocket demo from https://www.websocket.org/echo.html.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3562: ArtifactStore implementation for CosmosDB

[GitBox]

codecov-io commented on issue #3562: ArtifactStore implementation for CosmosDB
URL: 
https://github.com/apache/incubator-openwhisk/pull/3562#issuecomment-384942423
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562?src=pr=h1)
 Report
   > Merging 
[#3562](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/403d3417f09f145969a936f322c620f6bc5204ff?src=pr=desc)
 will **decrease** coverage by `3.62%`.
   > The diff coverage is `16.12%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562/graphs/tree.svg?src=pr=l0YmsiSAso=650=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3562  +/-   ##
   ==
   - Coverage   74.49%   70.86%   -3.63% 
   ==
 Files 126  134   +8 
 Lines5990 6387 +397 
 Branches  390  406  +16 
   ==
   + Hits 4462 4526  +64 
   - Misses   1528 1861 +333
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh)
 | `0% <0%> (ø)` | |
   | 
[...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh)
 | `0% <0%> (ø)` | |
   | 
[...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=)
 | `0% <0%> (ø)` | |
   | 
[...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh)
 | `0% <0%> (ø)` | |
   | 
[...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh)
 | `0% <0%> (ø)` | |
   | 
[...hisk/core/database/cosmosdb/ReferenceCounted.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUmVmZXJlbmNlQ291bnRlZC5zY2FsYQ==)
 | `100% <100%> (ø)` | |
   | 
[.../scala/src/main/scala/whisk/core/WhiskConfig.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvV2hpc2tDb25maWcuc2NhbGE=)
 | `92.3% <100%> (+0.05%)` | :arrow_up: |
   | 
[...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh)
 | `92% <92%> (ø)` | |
   | 
[.../whisk/core/database/cosmosdb/IndexingPolicy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvSW5kZXhpbmdQb2xpY3kuc2NhbGE=)
 | `93.1% <93.1%> (ø)` | |
   | ... and [7 
more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562?src=pr=footer).
 Last update 
[403d341...ecc82cb](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubee commented on issue #276: Use websocket.org for WebSocket tests

[GitBox]

dubee commented on issue #276: Use websocket.org for WebSocket tests
URL: 
https://github.com/apache/incubator-openwhisk-catalog/pull/276#issuecomment-389225885
 
 
   Using the WebSocket demo here https://www.websocket.org/echo.html.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubee opened a new pull request #276: Use websocket.org for WebSocket tests

[GitBox]

dubee opened a new pull request #276: Use websocket.org for WebSocket tests
URL: https://github.com/apache/incubator-openwhisk-catalog/pull/276
 
 
   Instead of setting up a WebSocket server for the WebSocket test suite, use 
`websocket.org` instead.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3658: Assure nginx verifies upstream ssl certs

[GitBox]

codecov-io commented on issue #3658: Assure nginx verifies upstream ssl certs
URL: 
https://github.com/apache/incubator-openwhisk/pull/3658#issuecomment-389210516
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3658?src=pr=h1)
 Report
   > Merging 
[#3658](https://codecov.io/gh/apache/incubator-openwhisk/pull/3658?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/403d3417f09f145969a936f322c620f6bc5204ff?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3658/graphs/tree.svg?width=650=pr=l0YmsiSAso=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3658?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#3658   +/-   ##
   ===
 Coverage   74.49%   74.49%   
   ===
 Files 126  126   
 Lines5990 5990   
 Branches  390  390   
   ===
 Hits 4462 4462   
 Misses   1528 1528
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3658?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3658?src=pr=footer).
 Last update 
[403d341...c300b4f](https://codecov.io/gh/apache/incubator-openwhisk/pull/3658?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] vvraskin opened a new pull request #3658: Assure nginx verifies upstream ssl certs

[GitBox]

vvraskin opened a new pull request #3658: Assure nginx verifies upstream ssl 
certs
URL: https://github.com/apache/incubator-openwhisk/pull/3658
 
 
   
   
   ## Description
   
   
   Verify upstream ssl certs. This prevents from a potential MITM attack in 
case the path between edge and controller is compromised. 
   
   ## Related issue and scope
   
   - [ ] I opened an issue to propose and discuss this change (#)
   
   ## My changes affect the following components
   
   
   
   - [x] Deployment
   - [x] Nginx
   
   ## Types of changes
   
   - [x] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing 
behavior).
   
   ## Checklist:
   
   
   - [x] I signed an [Apache 
CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style 
guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
 and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on a change in pull request #3657: Remove additional quote in pip install command

[GitBox]

rabbah commented on a change in pull request #3657: Remove additional quote in 
pip install command
URL: 
https://github.com/apache/incubator-openwhisk/pull/3657#discussion_r188295694
 
 

 ##
 File path: tools/macos/README.md
 ##
 @@ -51,7 +51,7 @@ brew install scala
 # install pip
 sudo easy_install pip
 # install script prerequisites
-sudo -H pip install docker==2.2.1 ansible==2.5.2 jinja2==2.9.6 couchdb==1.1 
httplib2==0.9.2 requests==2.10.0' | bash
+sudo -H pip install docker==2.2.1 ansible==2.5.2 jinja2==2.9.6 couchdb==1.1 
httplib2==0.9.2 requests==2.10.0 | bash
 
 Review comment:
   this `'` matches the one on line 40 
https://github.com/apache/incubator-openwhisk/pull/3657/files#diff-35b51f3cf01d8ad81f668514d8c74622R40.
 It's not an accident.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubee commented on issue #3655: the availablePermits of an invokerSlot may exceed the maxAllowed value when number of controller changed

[GitBox]

dubee commented on issue #3655: the availablePermits of an invokerSlot may 
exceed the maxAllowed value when number of controller changed
URL: 
https://github.com/apache/incubator-openwhisk/issues/3655#issuecomment-389173745
 
 
   @markusthoemmes 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3657: Remove additional quote in pip install command

[GitBox]

codecov-io commented on issue #3657: Remove additional quote in pip install 
command
URL: 
https://github.com/apache/incubator-openwhisk/pull/3657#issuecomment-389173216
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3657?src=pr=h1)
 Report
   > Merging 
[#3657](https://codecov.io/gh/apache/incubator-openwhisk/pull/3657?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/403d3417f09f145969a936f322c620f6bc5204ff?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3657/graphs/tree.svg?src=pr=650=l0YmsiSAso=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3657?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#3657   +/-   ##
   ===
 Coverage   74.49%   74.49%   
   ===
 Files 126  126   
 Lines5990 5990   
 Branches  390  390   
   ===
 Hits 4462 4462   
 Misses   1528 1528
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3657?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3657?src=pr=footer).
 Last update 
[403d341...6aa3fac](https://codecov.io/gh/apache/incubator-openwhisk/pull/3657?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr closed pull request #199: helm improvements

[GitBox]

csantanapr closed pull request #199: helm improvements
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/199
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/helm/README.md b/helm/README.md
index eff997d..c774a2e 100644
--- a/helm/README.md
+++ b/helm/README.md
@@ -88,7 +88,13 @@ where `minikube ip` returns `192.168.99.100`.
 whisk:
   ingress:
 api_host: 192.168.99.100:31001
-apigw_url: 192.168.99.100:31004
+apigw_url: http://192.168.99.100:31004
+
+nginx:
+  httpsNodePort: 31001
+
+apigw:
+  apiNodePort: 31004
 ```
 
 Deployment can be done by using the following single command:
diff --git a/helm/templates/_affinity.tpl b/helm/templates/_affinity.tpl
index 8f3267d..efa0d73 100644
--- a/helm/templates/_affinity.tpl
+++ b/helm/templates/_affinity.tpl
@@ -1,7 +1,7 @@
 # This file defines template snippets for scheduler affinity and anti-affinity
 
-{{/* Generic control-plane affinity */}}
-{{- define "affinity.controlPlane" -}}
+{{/* Generic core affinity */}}
+{{- define "affinity.core" -}}
 # prefer to not run on an invoker node (only prefer because of single node 
clusters)
 nodeAffinity:
   preferredDuringSchedulingIgnoredDuringExecution:
@@ -12,7 +12,7 @@ nodeAffinity:
 operator: NotIn
 values:
 - {{ .Values.affinity.invokerNodeLabel }}
-# prefer to run on a control-plane node
+# prefer to run on a core node
 nodeAffinity:
   preferredDuringSchedulingIgnoredDuringExecution:
   - weight: 80
@@ -21,7 +21,32 @@ nodeAffinity:
   - key: openwhisk-role
 operator: In
 values:
-- {{ .Values.affinity.controlPlaneNodeLabel }}
+- {{ .Values.affinity.coreNodeLabel }}
+{{- end -}}
+
+
+{{/* Generic edge affinity */}}
+{{- define "affinity.edge" -}}
+# prefer to not run on an invoker node (only prefer because of single node 
clusters)
+nodeAffinity:
+  preferredDuringSchedulingIgnoredDuringExecution:
+  - weight: 100
+preference:
+  matchExpressions:
+  - key: openwhisk-role
+operator: NotIn
+values:
+- {{ .Values.affinity.invokerNodeLabel }}
+# prefer to run on a edge node
+nodeAffinity:
+  preferredDuringSchedulingIgnoredDuringExecution:
+  - weight: 80
+preference:
+  matchExpressions:
+  - key: openwhisk-role
+operator: In
+values:
+- {{ .Values.affinity.edgeNodeLabel }}
 {{- end -}}
 
 
diff --git a/helm/templates/_helpers.tpl b/helm/templates/_helpers.tpl
index 19dc021..917d311 100644
--- a/helm/templates/_helpers.tpl
+++ b/helm/templates/_helpers.tpl
@@ -1,28 +1,34 @@
-{{/* Generate kafka url without port */}}
-{{- define "kafka_url_without_port" -}}
-{{ .Values.kafka.name }}.{{ .Release.Namespace }}
+{{/* hostname for apigateway */}}
+{{- define "apigw_host" -}}
+{{ .Values.apigw.name }}.{{ .Release.Namespace }}.svc.cluster.local
 {{- end -}}
 
-{{/* Generate Zookeeper service address */}}
-{{- define "zookeeper_service_address" -}}
-{{ .Values.zookeeper.name }}.{{ .Release.Namespace }}:{{ 
.Values.zookeeper.port }}
+{{/* hostname for controller */}}
+{{- define "controller_host" -}}
+{{ .Values.controller.name }}.{{ .Release.Namespace }}.svc.cluster.local
 {{- end -}}
 
-{{/* Generate Couchdb url without port */}}
-{{- define "couchdb_url_without_port" -}}
-{{ .Values.db.name }}.{{ .Release.Namespace }}
+{{/* hostname for database */}}
+{{- define "db_host" -}}
+{{ .Values.db.name }}.{{ .Release.Namespace }}.svc.cluster.local
+{{- end -}}
+
+{{/* hostname for kafka */}}
+{{- define "kafka_host" -}}
+{{ .Values.kafka.name }}.{{ .Release.Namespace }}.svc.cluster.local
+{{- end -}}
+
+{{/* hostname for zookeeper */}}
+{{- define "zookeeper_host" -}}
+{{ .Values.zookeeper.name }}.{{ .Release.Namespace }}.svc.cluster.local
 {{- end -}}
 
 {{/* Runtimes manifest */}}
 {{- define "runtimes_manifest" -}}
-{{- if .Values.travis -}}
-{{ .Files.Get "runtimes-minimal-travis.json" | quote }}
-{{- else -}}
-{{ .Files.Get "runtimes.json" | quote }}
-{{- end -}}
+{{ .Files.Get .Values.whisk.runtimes | quote }}
 {{- end -}}
 
-{{/* Environment variables required for accessing CouchDB */}}
+{{/* Environment variables required for accessing CouchDB from a pod */}}
 {{- define "whisk.dbEnvVars" -}}
 - name: "CONFIG_whisk_couchdb_username"
   value: {{ .Values.db.auth.username | quote }}
@@ -31,11 +37,11 @@
 - name: "CONFIG_whisk_couchdb_port"
   value: {{ .Values.db.port | quote}}
 - name: "CONFIG_whisk_couchdb_protocol"
-  value: "http"
+  value: {{ .Values.db.protocol | quote }}
 - name: "CONFIG_whisk_couchdb_host"
-  value: {{ include "couchdb_url_without_port" . | quote }}
+  value: {{ include "db_host" . | quote }}
 - name: "CONFIG_whisk_couchdb_provider"
-  value: "CouchDB"
+  value: {{ .Values.db.provider | quote }}
 - 

[GitHub] codecov-io commented on issue #3657: Remove additional quote in pip install command

[GitBox]

codecov-io commented on issue #3657: Remove additional quote in pip install 
command
URL: 
https://github.com/apache/incubator-openwhisk/pull/3657#issuecomment-389173216
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3657?src=pr=h1)
 Report
   > Merging 
[#3657](https://codecov.io/gh/apache/incubator-openwhisk/pull/3657?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/403d3417f09f145969a936f322c620f6bc5204ff?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3657/graphs/tree.svg?token=l0YmsiSAso=pr=650=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3657?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#3657   +/-   ##
   ===
 Coverage   74.49%   74.49%   
   ===
 Files 126  126   
 Lines5990 5990   
 Branches  390  390   
   ===
 Hits 4462 4462   
 Misses   1528 1528
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3657?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3657?src=pr=footer).
 Last update 
[403d341...6aa3fac](https://codecov.io/gh/apache/incubator-openwhisk/pull/3657?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] imesh opened a new pull request #3657: Remove additional quote in pip install command

[GitBox]

imesh opened a new pull request #3657: Remove additional quote in pip install 
command
URL: https://github.com/apache/incubator-openwhisk/pull/3657
 
 
   The pip install command given in the tools/mac/README.md file has an 
additional quote. As a result the command fails:
   
   ```
   sudo -H pip install docker==2.2.1 ansible==2.5.2 jinja2==2.9.6 couchdb==1.1 
httplib2==0.9.2 requests==2.10.0 | bash
   ```
   
   ## Description
   The additional quote in the above pip install command was removed in the 
"Setting up OpenWhisk with Docker for Mac" README.md file.
   
   ## My changes affect the following components
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [x] Documentation
   
   ## Types of changes
   - [x] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing 
behavior).
   
   ## Checklist:
   - [x] I signed an [Apache 
CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style 
guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
 and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [x] I updated the documentation where necessary.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3656: Limit the max value of availablePermits of ForcableSemaphore

[GitBox]

codecov-io commented on issue #3656: Limit the max value of availablePermits of 
ForcableSemaphore
URL: 
https://github.com/apache/incubator-openwhisk/pull/3656#issuecomment-389115907
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656?src=pr=h1)
 Report
   > Merging 
[#3656](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/403d3417f09f145969a936f322c620f6bc5204ff?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `66.66%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656/graphs/tree.svg?token=l0YmsiSAso=650=pr=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3656  +/-   ##
   ==
   - Coverage   74.49%   74.48%   -0.01% 
   ==
 Files 126  126  
 Lines5990 5992   +2 
 Branches  390  396   +6 
   ==
   + Hits 4462 4463   +1 
   - Misses   1528 1529   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==)
 | `85.71% <66.66%> (-2.75%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656?src=pr=footer).
 Last update 
[403d341...8e89254](https://codecov.io/gh/apache/incubator-openwhisk/pull/3656?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jiangpengcheng opened a new pull request #3656: Limit the max value of availablePermits of ForcableSemaphore

[GitBox]

jiangpengcheng opened a new pull request #3656: Limit the max value of 
availablePermits of ForcableSemaphore
URL: https://github.com/apache/incubator-openwhisk/pull/3656
 
 
   make sure it's not greater than the currentInvokerThreshold
   
   ## Description
   in some case, the `availablePermits` may exceed the  
`currentInvokerThreshold`, which may cause some invokers take more invoking 
requests than the number they can handle and other invokers are still idle
   
   ## Related issue and scope
   - [x] I opened an issue to propose and discuss this change (#3655)
   
   ## My changes affect the following components
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [x] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   - [x] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing 
behavior).
   
   ## Checklist:
   - [x] I signed an [Apache 
CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style 
guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
 and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jiangpengcheng opened a new issue #3655: the availablePermits of an invokerSlot may exceed the maxAllowed value when number of controller changed

[GitBox]

jiangpengcheng opened a new issue #3655: the availablePermits of an invokerSlot 
may exceed the maxAllowed value when number of controller changed
URL: https://github.com/apache/incubator-openwhisk/issues/3655
 
 
   ## Environment details:
   
   * native CentOS 7.3.1611 with docker 17.05-ce
   * 4 controllers and 9 invokers, with invokerThreShold=16 and numCore * 
coreShare=20
   
   ## Steps to reproduce the issue:
   
   1. invoke a single action in a infinitely loop in every one second
   
   action code is:
   ```js
   function main() {
   sleep(5)
   return {payload: 'Hello world'};
   }
   
   function sleep(d){
 for(var t = Date.now();Date.now() - t <= d;);
   }
   ```
   
   and the loop script is:
   
   ```shell
   #!/bin/bash
   while true
   do
 wsk -i action invoke hello --result
 sleep 1s
   done
   ```
   
   as the `hello` action's execution time is about 50-51 seconds and it's 
invoked in every one second, there will be around 50 running containers in the 
cluster(make sure no other actions are invoked), which will make the home 
invoker(let's say it's invoker5) overloaded, while the cluster is still capable
   
   2. stop a controller manually to simulate a failure and terminate the loop 
script in step 1
   
   3. wait for all running actions finished, and then execute the loop script 
in step1 again
   
   
   ## Provide the expected results and outputs:
   
   in the home invoker(invoker5), the total running containers should be:
   
   ```shell
   # docker-runc list | grep running | wc -l
   19
   ```
   *19 = 16(running containers) + 2(prewarmed containers) + 1(invoker 
container)*
   
   ## Provide the actual results and outputs:
   
   ```
   # docker-runc list | grep running | wc -l
   23
   ```
   *23 = 20(running containers) + 2(prewarmed containers) + 1(invoker 
container)*
   
   ## Explain
   the reason is while cluster is changed, the `ShardingContainerPoolBalancer` 
will throw away the old `invokerSlots` and create a new sequence to replace it:
   
   ```scala
   def updateCluster(newSize: Int): Unit = {
 val actualSize = newSize max 1 // if a cluster size < 1 is reported, falls 
back to a size of 1 (alone)
 if (_clusterSize != actualSize) {
   _clusterSize = actualSize
   val newTreshold = (totalInvokerThreshold / actualSize) max 1 // letting 
this fall below 1 doesn't make sense
   currentInvokerThreshold = newTreshold
   _invokerSlots = _invokerSlots.map(_ => new 
ForcableSemaphore(currentInvokerThreshold))
   
   logging.info(
 this,
 s"loadbalancer cluster size changed to $actualSize active nodes. 
invokerThreshold = $currentInvokerThreshold")(
 TransactionId.loadbalancer)
 }
   }
   ```
   then the new states of all item in invokerSlots are all set to the max 
value(5=16/3 in this case), but there are still some invoking permits for some 
invokers not released(4 in there for the home invoker), when these running 
actions are finished and release its permit, the `sync.permits` may exceed the 
`currentInvokerThreshold`, which may cause the home invoker take more invoking 
requests than its capacity
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3654: Issues/3653 - Ansible playbook openwhisk.yml fails to find whisk/cont…

[GitBox]

codecov-io commented on issue #3654: Issues/3653 - Ansible playbook 
openwhisk.yml fails to find whisk/cont…
URL: 
https://github.com/apache/incubator-openwhisk/pull/3654#issuecomment-389104773
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3654?src=pr=h1)
 Report
   > Merging 
[#3654](https://codecov.io/gh/apache/incubator-openwhisk/pull/3654?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/403d3417f09f145969a936f322c620f6bc5204ff?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3654/graphs/tree.svg?src=pr=l0YmsiSAso=650=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3654?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#3654   +/-   ##
   ===
 Coverage   74.49%   74.49%   
   ===
 Files 126  126   
 Lines5990 5990   
 Branches  390  390   
   ===
 Hits 4462 4462   
 Misses   1528 1528
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3654?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3654?src=pr=footer).
 Last update 
[403d341...d11b301](https://codecov.io/gh/apache/incubator-openwhisk/pull/3654?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mgencur opened a new pull request #3654: Issues/3653 - Ansible playbook openwhisk.yml fails to find whisk/cont…

[GitBox]

mgencur opened a new pull request #3654: Issues/3653 - Ansible playbook 
openwhisk.yml fails to find whisk/cont…
URL: https://github.com/apache/incubator-openwhisk/pull/3654
 
 
   …roller image
   
   Fixes https://github.com/apache/incubator-openwhisk/issues/3653
   
   ## My changes affect the following components
   
   Ansible playbook
   
   ## Types of changes
   - [ x] Bug fix (generally a non-breaking change which closes an issue).
   
   ## Checklist:
   
   I still haven't signed the Apache CLA. I'll do that ASAP.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mgencur opened a new issue #3653: Ansible playbook openwhisk.yml fails to find whisk/controller image

[GitBox]

mgencur opened a new issue #3653: Ansible playbook openwhisk.yml fails to find 
whisk/controller image
URL: https://github.com/apache/incubator-openwhisk/issues/3653
 
 
   The relevant part of the stack trace is below:
   
   TASK [controller : (re)start controller] 
**
   Tuesday 15 May 2018  10:22:12 +0200 (0:00:00.258)   0:01:37.639 
*** 
   fatal: [controller0]: FAILED! => {"changed": false, "msg": "Error pulling 
image whisk/controller:latest - 404 Client Error: Not Found (\"pull access 
denied for whisk/controller, repository does not exist or may require 'docker 
login'\")"}
   
   Error pulling image whisk/controller:latest - 404 Client Error: Not Found
   ("pull access denied for whisk/controller, repository does not exist or may
   require 'docker login'")
   
   PLAY RECAP 

   controller0: ok=21   changed=6unreachable=0failed=1  
 
   kafka0 : ok=11   changed=6unreachable=0failed=0 
   
   If you are reporting an enhancement request, please include information on 
what you are trying to achieve and why that enhancement would help you.
   
   For more information about reporting issues, see
   
https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md#raising-issues
   
   Use the commands below to provide key information from your environment:
   You do not have to include this information if this is a feature request.
   -->
   
   ## Environment details:
   
   * local deployment, vagrant, native ubuntu, Mac OS, Bluemix, ...   
   * version of docker, vagrant, ubuntu, ...
   
   ## Steps to reproduce the issue:
   
   1.   
   2.   
   3.   
   
   
   ## Provide the expected results and outputs:
   
   ```
   output comes here
   ```
   
   
   ## Provide the actual results and outputs:
   
   ```
   output comes here
   ```
   
   ## Additional information you deem important:
   * issue happens only occasionally or under certain circumstances   
   * changes you did or observed in the environment
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3652: Disable Slf4jLogger startup log in test runs

[GitBox]

codecov-io commented on issue #3652: Disable Slf4jLogger startup log in test 
runs
URL: 
https://github.com/apache/incubator-openwhisk/pull/3652#issuecomment-389057442
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3652?src=pr=h1)
 Report
   > Merging 
[#3652](https://codecov.io/gh/apache/incubator-openwhisk/pull/3652?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/403d3417f09f145969a936f322c620f6bc5204ff?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3652/graphs/tree.svg?src=pr=l0YmsiSAso=650=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3652?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#3652   +/-   ##
   ===
 Coverage   74.49%   74.49%   
   ===
 Files 126  126   
 Lines5990 5990   
 Branches  390  390   
   ===
 Hits 4462 4462   
 Misses   1528 1528
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3652?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3652?src=pr=footer).
 Last update 
[403d341...fac8645](https://codecov.io/gh/apache/incubator-openwhisk/pull/3652?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3652: Disable Slf4jLogger startup log in test runs

[GitBox]

codecov-io commented on issue #3652: Disable Slf4jLogger startup log in test 
runs
URL: 
https://github.com/apache/incubator-openwhisk/pull/3652#issuecomment-389057442
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3652?src=pr=h1)
 Report
   > Merging 
[#3652](https://codecov.io/gh/apache/incubator-openwhisk/pull/3652?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/403d3417f09f145969a936f322c620f6bc5204ff?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3652/graphs/tree.svg?width=650=l0YmsiSAso=150=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3652?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#3652   +/-   ##
   ===
 Coverage   74.49%   74.49%   
   ===
 Files 126  126   
 Lines5990 5990   
 Branches  390  390   
   ===
 Hits 4462 4462   
 Misses   1528 1528
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3652?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3652?src=pr=footer).
 Last update 
[403d341...fac8645](https://codecov.io/gh/apache/incubator-openwhisk/pull/3652?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] norricorp commented on issue #3651: switching vagrant to use cli remote mode

[GitBox]

norricorp commented on issue #3651: switching vagrant to use cli remote mode
URL: 
https://github.com/apache/incubator-openwhisk/pull/3651#issuecomment-389056299
 
 
   Updated git, run again and it worked - many thanks for such a quick 
response. 
   Never did find out where goPrepare task in gradle was though ...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services