[GitHub] sechunOH commented on issue #3579: Using non root user in controller
sechunOH commented on issue #3579: Using non root user in controller URL: https://github.com/apache/incubator-openwhisk/pull/3579#issuecomment-391225668 @fmaschler This may not right but I think user namespace remapping is applied to invoker machines. So you can see argument 'userns=host' in invoker ansible deployment script. But Runtime containers may be spawned by invoker are using usernamespace remap, so root privileged processes in runtime containers are not really root privileged on the invoker host. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3562: ArtifactStore implementation for CosmosDB
codecov-io commented on issue #3562: ArtifactStore implementation for CosmosDB URL: https://github.com/apache/incubator-openwhisk/pull/3562#issuecomment-384942423 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562?src=pr=h1) Report > Merging [#3562](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/8a3b4472d5ef420f0216cc8e42932d87f428ed30?src=pr=desc) will **decrease** coverage by `3.61%`. > The diff coverage is `16.12%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3562 +/- ## == - Coverage 74.49% 70.88% -3.62% == Files 126 134 +8 Lines5994 6391 +397 Branches 392 409 +17 == + Hits 4465 4530 +65 - Misses 1529 1861 +332 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562?src=pr=tree) | Coverage Δ | | |---|---|---| | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (ø)` | | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (ø)` | | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (ø)` | | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (ø)` | | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (ø)` | | | [...hisk/core/database/cosmosdb/ReferenceCounted.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUmVmZXJlbmNlQ291bnRlZC5zY2FsYQ==) | `100% <100%> (ø)` | | | [.../scala/src/main/scala/whisk/core/WhiskConfig.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvV2hpc2tDb25maWcuc2NhbGE=) | `92.3% <100%> (+0.05%)` | :arrow_up: | | [...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <92%> (ø)` | | | [.../whisk/core/database/cosmosdb/IndexingPolicy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvSW5kZXhpbmdQb2xpY3kuc2NhbGE=) | `93.1% <93.1%> (ø)` | | | ... and [8 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562?src=pr=footer). Last update [8a3b447...a70c2f5](https://codecov.io/gh/apache/incubator-openwhisk/pull/3562?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3685: Enable test code coverage collection for containers
codecov-io commented on issue #3685: Enable test code coverage collection for containers URL: https://github.com/apache/incubator-openwhisk/pull/3685#issuecomment-390943297 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685?src=pr=h1) Report > Merging [#3685](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/8a3b4472d5ef420f0216cc8e42932d87f428ed30?src=pr=desc) will **increase** coverage by `10.59%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3685 +/- ## === + Coverage 74.49% 85.08% +10.59% === Files 126 126 Lines5994 5994 Branches 392 392 === + Hits 4465 5100 +635 + Misses 1529 894 -635 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../scala/src/main/scala/whisk/core/entity/Exec.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWMuc2NhbGE=) | `84.51% <0%> (+0.64%)` | :arrow_up: | | [...r/src/main/scala/whisk/core/controller/Rules.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9SdWxlcy5zY2FsYQ==) | `89.93% <0%> (+0.67%)` | :arrow_up: | | [...cala/src/main/scala/whisk/http/ErrorResponse.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvRXJyb3JSZXNwb25zZS5zY2FsYQ==) | `90.9% <0%> (+1.13%)` | :arrow_up: | | [...isk/core/controller/actions/PrimitiveActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1ByaW1pdGl2ZUFjdGlvbnMuc2NhbGE=) | `88.54% <0%> (+1.52%)` | :arrow_up: | | [...cala/whisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `93.56% <0%> (+1.75%)` | :arrow_up: | | [...re/database/MultipleReadersSingleWriterCache.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvTXVsdGlwbGVSZWFkZXJzU2luZ2xlV3JpdGVyQ2FjaGUuc2NhbGE=) | `96.49% <0%> (+1.75%)` | :arrow_up: | | [...on/scala/src/main/scala/whisk/common/Logging.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Mb2dnaW5nLnNjYWxh) | `89.65% <0%> (+2.29%)` | :arrow_up: | | [.../scala/src/main/scala/whisk/core/WhiskConfig.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvV2hpc2tDb25maWcuc2NhbGE=) | `94.57% <0%> (+2.32%)` | :arrow_up: | | [...src/main/scala/whisk/core/controller/Actions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9BY3Rpb25zLnNjYWxh) | `93.84% <0%> (+2.56%)` | :arrow_up: | | [...ala/src/main/scala/whisk/core/entity/DocInfo.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0RvY0luZm8uc2NhbGE=) | `87.09% <0%> (+3.22%)` | :arrow_up: | | ... and [30 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685?src=pr=footer). Last update [8a3b447...c77d316](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated
[GitHub] chetanmeh commented on a change in pull request #3562: ArtifactStore implementation for CosmosDB
chetanmeh commented on a change in pull request #3562: ArtifactStore
implementation for CosmosDB
URL:
https://github.com/apache/incubator-openwhisk/pull/3562#discussion_r190121616
##
File path:
common/scala/src/main/scala/whisk/core/database/cosmosdb/CosmosDBArtifactStoreProvider.scala
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.database.cosmosdb
+
+import java.io.Closeable
+
+import akka.actor.ActorSystem
+import akka.stream.ActorMaterializer
+import com.microsoft.azure.cosmosdb.rx.AsyncDocumentClient
+import spray.json.RootJsonFormat
+import whisk.common.Logging
+import whisk.core.database._
+import pureconfig._
+import whisk.core.ConfigKeys
+import whisk.core.database.cosmosdb.CosmosDBUtil.createClient
+import whisk.core.entity.{DocumentReader, WhiskActivation, WhiskAuth,
WhiskEntity}
+
+import scala.reflect.ClassTag
+
+case class CosmosDBConfig(endpoint: String, key: String, db: String)
+
+case class ClientHolder(client: AsyncDocumentClient) extends Closeable {
+ override def close(): Unit = client.close()
+}
+
+object CosmosDBArtifactStoreProvider extends ArtifactStoreProvider {
+ type DocumentClientRef = ReferenceCounted[ClientHolder]#CountedReference
+ private lazy val config =
loadConfigOrThrow[CosmosDBConfig](ConfigKeys.cosmosdb)
+ private var clientRef: ReferenceCounted[ClientHolder] = _
Review comment:
Even in that case `getOrCreateReference` may be required as currently there
can be multiple shutdown calls made. In case of object level instance we would
need to change the shutdown approach and move it to provider level
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] chetanmeh commented on issue #3562: ArtifactStore implementation for CosmosDB
chetanmeh commented on issue #3562: ArtifactStore implementation for CosmosDB URL: https://github.com/apache/incubator-openwhisk/pull/3562#issuecomment-391218477 > On this last one, I think it is a defect of WhiskStore that multiple calls to WhiskEntityStore.datastore() will return multiple unique instances One benefit of this approach is that future test using `MemoryArtifactStore` can work without any side effect of other tests. Caching the result of call of `makeStore` would make `shutdown` handling tricky. Currently each eventual owner of store instance is responsible for shutdown. Probably in that case we need to have a shutdown support at provider level This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on a change in pull request #3562: ArtifactStore implementation for CosmosDB
chetanmeh commented on a change in pull request #3562: ArtifactStore
implementation for CosmosDB
URL:
https://github.com/apache/incubator-openwhisk/pull/3562#discussion_r190120927
##
File path:
common/scala/src/main/scala/whisk/core/database/cosmosdb/CosmosDBArtifactStoreProvider.scala
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.database.cosmosdb
+
+import java.io.Closeable
+
+import akka.actor.ActorSystem
+import akka.stream.ActorMaterializer
+import com.microsoft.azure.cosmosdb.rx.AsyncDocumentClient
+import spray.json.RootJsonFormat
+import whisk.common.Logging
+import whisk.core.database._
+import pureconfig._
+import whisk.core.ConfigKeys
+import whisk.core.database.cosmosdb.CosmosDBUtil.createClient
+import whisk.core.entity.{DocumentReader, WhiskActivation, WhiskAuth,
WhiskEntity}
+
+import scala.reflect.ClassTag
+
+case class CosmosDBConfig(endpoint: String, key: String, db: String)
+
+case class ClientHolder(client: AsyncDocumentClient) extends Closeable {
+ override def close(): Unit = client.close()
+}
+
+object CosmosDBArtifactStoreProvider extends ArtifactStoreProvider {
+ type DocumentClientRef = ReferenceCounted[ClientHolder]#CountedReference
+ private lazy val config =
loadConfigOrThrow[CosmosDBConfig](ConfigKeys.cosmosdb)
+ private var clientRef: ReferenceCounted[ClientHolder] = _
+
+ override def makeStore[D <: DocumentSerializer: ClassTag](useBatching:
Boolean)(
+implicit jsonFormat: RootJsonFormat[D],
+docReader: DocumentReader,
+actorSystem: ActorSystem,
+logging: Logging,
+materializer: ActorMaterializer): ArtifactStore[D] = {
+makeStoreForClient(config, useBatching, getOrCreateReference(config))
+ }
+
+ def makeStore[D <: DocumentSerializer: ClassTag](config: CosmosDBConfig,
useBatching: Boolean)(
+implicit jsonFormat: RootJsonFormat[D],
+docReader: DocumentReader,
+actorSystem: ActorSystem,
+logging: Logging,
+materializer: ActorMaterializer): ArtifactStore[D] = {
+
+makeStoreForClient(config, useBatching,
createReference(config).reference())
+ }
+
+ private def makeStoreForClient[D <: DocumentSerializer: ClassTag](config:
CosmosDBConfig,
+
useBatching: Boolean,
+clientRef:
DocumentClientRef)(
+implicit jsonFormat: RootJsonFormat[D],
+docReader: DocumentReader,
+actorSystem: ActorSystem,
+logging: Logging,
+materializer: ActorMaterializer): ArtifactStore[D] = {
+
+val classTag = implicitly[ClassTag[D]]
+val (dbName, handler, viewMapper) = handlerAndMapper(classTag)
+
+new CosmosDBArtifactStore(dbName, config, clientRef, handler, viewMapper)
+ }
+
+ private def handlerAndMapper[D](entityType: ClassTag[D])(
+implicit actorSystem: ActorSystem,
+logging: Logging,
+materializer: ActorMaterializer): (String, DocumentHandler,
CosmosDBViewMapper) = {
+entityType.runtimeClass match {
+ case x if x == classOf[WhiskEntity] =>
+("whisks", WhisksHandler, WhisksViewMapper)
+ case x if x == classOf[WhiskActivation] =>
+("activations", ActivationHandler, ActivationViewMapper)
+ case x if x == classOf[WhiskAuth] =>
+("subjects", SubjectHandler, SubjectViewMapper)
+}
+ }
+
+ private def getOrCreateReference(config: CosmosDBConfig) = synchronized {
Review comment:
Each `AsyncDocumentClient` encapsulates a HttpClient which own a pool of
HTTP Connections to CosmosDB. As for all 3 collections we are connecting to
same url at backend it would be better to share the pool.
Compared to this in `CouchDBRestStore` the pool is managed on per
`ActorSystem` level which by design is then shared across various
`ArtifactStore` implementations. In [PoolingRestClient#shutdown][1] method you
would see a note around not closing the pool assuming shutdown is only relevant
for tests. So ref counted approach used in this PR is meant to solve that
[1]:
https://github.com/apache/incubator-openwhisk/blob/master/common/scala/src/main/scala/whisk/http/PoolingRestClient.scala#L150
[GitHub] csantanapr commented on issue #35: Travis Test failing timeout TestStartLatestAction
csantanapr commented on issue #35: Travis Test failing timeout TestStartLatestAction URL: https://github.com/apache/incubator-openwhisk-runtime-go/issues/35#issuecomment-391215175 Travis test are passing now This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #35: Travis Test failing timeout TestStartLatestAction
csantanapr closed issue #35: Travis Test failing timeout TestStartLatestAction URL: https://github.com/apache/incubator-openwhisk-runtime-go/issues/35 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #32: Travis Test failing randomly: Example_shell_nocompiler missing Goodbye!
csantanapr closed issue #32: Travis Test failing randomly: Example_shell_nocompiler missing Goodbye! URL: https://github.com/apache/incubator-openwhisk-runtime-go/issues/32 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #10: Can't run tests in OSX
csantanapr commented on issue #10: Can't run tests in OSX URL: https://github.com/apache/incubator-openwhisk-runtime-go/issues/10#issuecomment-391215081 This is working on OSX with `gradle test` and `cd openwhisk; go test` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #32: Travis Test failing randomly: Example_shell_nocompiler missing Goodbye!
csantanapr commented on issue #32: Travis Test failing randomly: Example_shell_nocompiler missing Goodbye! URL: https://github.com/apache/incubator-openwhisk-runtime-go/issues/32#issuecomment-391215144 Test is passing now in Travis thanks ! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #38: Fix random failures
csantanapr closed pull request #38: Fix random failures
URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/38
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/openwhisk/executor_test.go b/openwhisk/executor_test.go
index db8247b..5c78bea 100644
--- a/openwhisk/executor_test.go
+++ b/openwhisk/executor_test.go
@@ -19,7 +19,6 @@ package openwhisk
import (
"fmt"
"io/ioutil"
- "time"
)
func ExampleNewExecutor_failed() {
@@ -64,7 +63,7 @@ func ExampleNewExecutor_bc() {
case <-proc.exit:
fmt.Println("exit")
}
- time.Sleep(100 * time.Millisecond)
+ waitabit()
proc.Stop()
dump(log)
// Output:
@@ -83,9 +82,9 @@ func ExampleNewExecutor_hello() {
proc.io <- `{"name":"Mike"}`
fmt.Println(<-proc.io)
proc.log <- true
- time.Sleep(100 * time.Millisecond)
+ waitabit()
proc.Stop()
- time.Sleep(100 * time.Millisecond)
+ waitabit()
_, ok := <-proc.io
fmt.Printf("io %v\n", ok)
dump(log)
@@ -113,9 +112,9 @@ func ExampleNewExecutor_term() {
}
proc.log <- true
fmt.Printf("exit %v\n", exited)
- time.Sleep(100 * time.Millisecond)
+ waitabit()
proc.Stop()
- time.Sleep(100 * time.Millisecond)
+ waitabit()
_, ok := <-proc.io
fmt.Printf("io %v\n", ok)
dump(log)
diff --git a/openwhisk/util_test.go b/openwhisk/util_test.go
index 190e61d..6ac 100644
--- a/openwhisk/util_test.go
+++ b/openwhisk/util_test.go
@@ -55,7 +55,8 @@ func startTestServer(compiler string) (*httptest.Server,
string, *os.File) {
func stopTestServer(ts *httptest.Server, cur string, buf *os.File) {
runtime.Gosched()
- time.Sleep(1 * time.Second)
+ // wait 2 seconds before declaring a test done
+ time.Sleep(2 * time.Second)
os.Chdir(cur)
ts.Close()
dump(buf)
@@ -162,11 +163,17 @@ func detect(dir, filename string) string {
return kind.Extension
}
+func waitabit() {
+ time.Sleep(1000 * time.Millisecond)
+}
+
func TestMain(m *testing.M) {
sys("_test/build.sh")
sys("_test/zips.sh")
- // increase timeouts
+ // increase timeouts for init
DefaultTimeoutInit = 1000 * time.Millisecond
+ // timeout for drain - shoud less (or you can get stuck on stdout
without getting the stderr)
+ DefaultTimeoutDrain = 100 * time.Millisecond
code := m.Run()
os.Exit(code)
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] KeonHee opened a new issue #3688: [Proposal] Throttler modularization
KeonHee opened a new issue #3688: [Proposal] Throttler modularization
URL: https://github.com/apache/incubator-openwhisk/issues/3688
Throttler counts the current number of activations and controls the new
requests accordingly.
Because all current activation is delivered through loadbalencer to Kafka
and invoker,
To count the number of activations, Throttler must check the loadbalencer
data. For this reason
When a loadbalencer change or modification occurs, throttle related logic
also needs to be changed or verified.
But in the current structure, these relationships are not clearly apparent.
So Throttler needs to be modular.
This means that there is a possibility that Throttle logic will not be
considered when designing loadbalencer, which may lead to bugs.
You can still find the coupling with a specific LoadBalancer, as shown below.
https://github.com/apache/incubator-openwhisk/blob/master/core/controller/src/main/scala/whisk/core/entitlement/Entitlement.scala#L136
```scala
private val activationThrottleCalculator = loadBalancer match {
case _: ShardingContainerPoolBalancer => calculateIndividualLimit _
case _ => calculateLimit _
}
```
So... The three ways I suggest
1. Managing throttlers as trait, making them inner-class by LoadBalancer and
providing them as factory methods
2. LoadBalancer provides `throttleCheck` method
3. Provided by spi
So, what do you think about the need to refactor the way Loadbalancer
provides the method or object to check the Throttler?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] tysonnorris opened a new pull request #3687: Concurrency limit per action
tysonnorris opened a new pull request #3687: Concurrency limit per action
URL: https://github.com/apache/incubator-openwhisk/pull/3687
## Description
After #2795 which only provides system-wider concurrency settings, this will
allow per-action concurrency limit.
To use it:
* specify `whisk.concurrency-limit` configs e.g.
```
whisk.concurrency-limit {
min = 1
max = 500
std = 1
}
```
* enable concurrency in actions using: `"limits":{"concurrency":125}` in the
action json
In a later PR, additional changes will be useful in cli, e.g. to enable a
concurrency flag: `wsk action create --concurrency 125`
## Related issue and scope
- [ ] I opened an issue to propose and discuss this change (#)
## My changes affect the following components
- [ ] API
- [x] Controller
- [ ] Message Bus (e.g., Kafka)
- [ ] Loadbalancer
- [x] Invoker
- [ ] Intrinsic actions (e.g., sequences, conductors)
- [ ] Data stores (e.g., CouchDB)
- [ ] Tests
- [ ] Deployment
- [ ] CLI
- [ ] General tooling
- [ ] Documentation
## Types of changes
- [ ] Bug fix (generally a non-breaking change which closes an issue).
- [x] Enhancement or new feature (adds new functionality).
- [ ] Breaking change (a bug fix or enhancement which changes existing
behavior).
## Checklist:
- [x] I signed an [Apache
CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
- [x] I reviewed the [style
guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
and followed the recommendations (Travis CI will check :).
- [ ] I added tests to cover my changes.
- [ ] My changes require further changes to the documentation.
- [ ] I updated the documentation where necessary.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mrutkows commented on issue #108: Some files in openwhisk-apigateway still have bad headers
mrutkows commented on issue #108: Some files in openwhisk-apigateway still have bad headers URL: https://github.com/apache/incubator-openwhisk-release/issues/108#issuecomment-391201494 @daisy-ycguo @houshengbo please review current source files and see if we can close this issue. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo commented on issue #3555: Do test files need license headers?
daisy-ycguo commented on issue #3555: Do test files need license headers? URL: https://github.com/apache/incubator-openwhisk/issues/3555#issuecomment-391199573 We have all files with Apache headers following our policy documented [here](https://github.com/apache/incubator-openwhisk-release/blob/master/docs/license_compliance.md), including test files. We also documented every files in the exclusion list, refer [here](https://github.com/apache/incubator-openwhisk-release/blob/master/docs/license_exclusions.md). So I think we can close this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo commented on issue #3555: Do test files need license headers?
daisy-ycguo commented on issue #3555: Do test files need license headers? URL: https://github.com/apache/incubator-openwhisk/issues/3555#issuecomment-391199573 We have all files with Apache headers following our policy documented [here](https://github.com/apache/incubator-openwhisk-release/blob/master/docs/license_compliance.md). We also documented every files in the exclusion list, refer [here](https://github.com/apache/incubator-openwhisk-release/blob/master/docs/license_exclusions.md). So I think we can close this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo closed issue #3555: Do test files need license headers?
daisy-ycguo closed issue #3555: Do test files need license headers? URL: https://github.com/apache/incubator-openwhisk/issues/3555 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo closed issue #3264: A list of source files miss Apache license headers
daisy-ycguo closed issue #3264: A list of source files miss Apache license headers URL: https://github.com/apache/incubator-openwhisk/issues/3264 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo commented on issue #3264: A list of source files miss Apache license headers
daisy-ycguo commented on issue #3264: A list of source files miss Apache license headers URL: https://github.com/apache/incubator-openwhisk/issues/3264#issuecomment-391199408 We have all files with Apache headers following our policy documented [here](https://github.com/apache/incubator-openwhisk-release/blob/master/docs/license_compliance.md). We also documented every files in the exclusion list, refer [here](https://github.com/apache/incubator-openwhisk-release/blob/master/docs/license_exclusions.md). So I think we can close this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo commented on issue #3264: A list of source files miss Apache license headers
daisy-ycguo commented on issue #3264: A list of source files miss Apache license headers URL: https://github.com/apache/incubator-openwhisk/issues/3264#issuecomment-391199408 We have all files with Apache headers following our policy documented in [this document](https://github.com/apache/incubator-openwhisk-release/blob/master/docs/license_compliance.md). We also documented every files in the exclusion list, refer [here](https://github.com/apache/incubator-openwhisk-release/blob/master/docs/license_exclusions.md). So I think we can close this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #870: Project and Package Inputs
pritidesai commented on issue #870: Project and Package Inputs URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/870#issuecomment-391198982 I think I am ready, lets merge this This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo closed pull request #53: Add header to build.gradle and settings.gradle
daisy-ycguo closed pull request #53: Add header to build.gradle and
settings.gradle
URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/53
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
Unicorn! GitHub
body {
background-color: #f1f1f1;
margin: 0;
font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;
}
.container { margin: 50px auto 40px auto; width: 600px; text-align:
center; }
a { color: #4183c4; text-decoration: none; }
a:hover { text-decoration: underline; }
h1 { letter-spacing: -1px; line-height: 60px; font-size: 60px;
font-weight: 100; margin: 0px; text-shadow: 0 1px 0 #fff; }
p { color: rgba(0, 0, 0, 0.5); margin: 10px 0 10px; font-size: 18px;
font-weight: 200; line-height: 1.6em;}
ul { list-style: none; margin: 25px 0; padding: 0; }
li { display: table-cell; font-weight: bold; width: 1%; }
.logo { display: inline-block; margin-top: 35px; }
.logo-img-2x { display: none; }
@media
only screen and (-webkit-min-device-pixel-ratio: 2),
only screen and ( min--moz-device-pixel-ratio: 2),
only screen and ( -o-min-device-pixel-ratio: 2/1),
only screen and (min-device-pixel-ratio: 2),
only screen and (min-resolution: 192dpi),
only screen and (min-resolution: 2dppx) {
.logo-img-1x { display: none; }
.logo-img-2x { display: inline-block; }
}
#suggestions {
margin-top: 35px;
color: #ccc;
}
#suggestions a {
color: #66;
font-weight: 200;
font-size: 14px;
margin: 0 10px;
}
This page is taking way too long to load.
Sorry about that. Please try refreshing and contact us if the problem
persists.
https://github.com/contact;>Contact Support
https://status.github.com;>GitHub Status
https://twitter.com/githubstatus;>@githubstatus
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] daisy-ycguo commented on issue #62: Add headers to build.gradle and settings.gradle
daisy-ycguo commented on issue #62: Add headers to build.gradle and settings.gradle URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/62#issuecomment-391194813 Close it since PR #63 already includes it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed pull request #303: Fix minor scancode EOL error in index.html.
mrutkows closed pull request #303: Fix minor scancode EOL error in index.html. URL: https://github.com/apache/incubator-openwhisk-apigateway/pull/303 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/html/index.html b/html/index.html index 9c9244a..409b6ab 100644 --- a/html/index.html +++ b/html/index.html @@ -40,4 +40,4 @@ An NGINX and Openresty based API Gateway. http://openresty.org/;>openresty.org - \ No newline at end of file + This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo commented on issue #53: Add header to build.gradle and settings.gradle
daisy-ycguo commented on issue #53: Add header to build.gradle and settings.gradle URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/53#issuecomment-391194754 Close it since PR #54 already includes it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo closed pull request #62: Add headers to build.gradle and settings.gradle
daisy-ycguo closed pull request #62: Add headers to build.gradle and
settings.gradle
URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/62
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
Unicorn! GitHub
body {
background-color: #f1f1f1;
margin: 0;
font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;
}
.container { margin: 50px auto 40px auto; width: 600px; text-align:
center; }
a { color: #4183c4; text-decoration: none; }
a:hover { text-decoration: underline; }
h1 { letter-spacing: -1px; line-height: 60px; font-size: 60px;
font-weight: 100; margin: 0px; text-shadow: 0 1px 0 #fff; }
p { color: rgba(0, 0, 0, 0.5); margin: 10px 0 10px; font-size: 18px;
font-weight: 200; line-height: 1.6em;}
ul { list-style: none; margin: 25px 0; padding: 0; }
li { display: table-cell; font-weight: bold; width: 1%; }
.logo { display: inline-block; margin-top: 35px; }
.logo-img-2x { display: none; }
@media
only screen and (-webkit-min-device-pixel-ratio: 2),
only screen and ( min--moz-device-pixel-ratio: 2),
only screen and ( -o-min-device-pixel-ratio: 2/1),
only screen and (min-device-pixel-ratio: 2),
only screen and (min-resolution: 192dpi),
only screen and (min-resolution: 2dppx) {
.logo-img-1x { display: none; }
.logo-img-2x { display: inline-block; }
}
#suggestions {
margin-top: 35px;
color: #ccc;
}
#suggestions a {
color: #66;
font-weight: 200;
font-size: 14px;
margin: 0 10px;
}
This page is taking way too long to load.
Sorry about that. Please try refreshing and contact us if the problem
persists.
https://github.com/contact;>Contact Support
https://status.github.com;>GitHub Status
https://twitter.com/githubstatus;>@githubstatus
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr commented on issue #10: Phase 3: Remove IBM license header
csantanapr commented on issue #10: Phase 3: Remove IBM license header URL: https://github.com/apache/incubator-openwhisk-utilities/issues/10#issuecomment-391193516 Is ok to remove I we use the tool by our own config This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3610: Fixes #3608 - Use --user flag to install locally for the current user
csantanapr commented on issue #3610: Fixes #3608 - Use --user flag to install locally for the current user URL: https://github.com/apache/incubator-openwhisk/pull/3610#issuecomment-391192558 The way I did for the other tasks is using “become: ” Using become: false works for you instead ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #303: Fix minor scancode EOL error in index.html.
mrutkows opened a new pull request #303: Fix minor scancode EOL error in index.html. URL: https://github.com/apache/incubator-openwhisk-apigateway/pull/303 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #278: Add ASF license header to .gradle files.
mrutkows opened a new pull request #278: Add ASF license header to .gradle files. URL: https://github.com/apache/incubator-openwhisk-catalog/pull/278 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #305: Add ASF license header to .gradle files.
mrutkows opened a new pull request #305: Add ASF license header to .gradle files. URL: https://github.com/apache/incubator-openwhisk-cli/pull/305 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #921: Add ASF license header to .gradle files.
mrutkows opened a new pull request #921: Add ASF license header to .gradle files. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/921 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #63: Last files to need ASF License headers.
mrutkows opened a new pull request #63: Last files to need ASF License headers. URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/63 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #25: Last files to need ASF License headers.
mrutkows opened a new pull request #25: Last files to need ASF License headers. URL: https://github.com/apache/incubator-openwhisk-runtime-python/pull/25 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #23: Last files to need ASF License headers.
mrutkows opened a new pull request #23: Last files to need ASF License headers. URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/23 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #54: Last files to need ASF License headers.
mrutkows opened a new pull request #54: Last files to need ASF License headers. URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/54 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #54: Last files to need ASF License headers.
mrutkows opened a new pull request #54: Last files to need ASF License headers. URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/54 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #39: Last files to need ASF License headers.
mrutkows opened a new pull request #39: Last files to need ASF License headers. URL: https://github.com/apache/incubator-openwhisk-runtime-docker/pull/39 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #160: Clean up Openwhisk repo. ASF license header inclusion/exclusion tables
mrutkows opened a new pull request #160: Clean up Openwhisk repo. ASF license header inclusion/exclusion tables URL: https://github.com/apache/incubator-openwhisk-release/pull/160 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #3681: Enable capability to disable a single invoker for maintenance
dubee commented on issue #3681: Enable capability to disable a single invoker for maintenance URL: https://github.com/apache/incubator-openwhisk/issues/3681#issuecomment-391134187 Was able to stop only the actor responsible for ping the controller, which allows for activation records to be posted to the database for user containers that are still running when the actor is stopped. Sample code: https://github.com/dubee/openwhisk/commit/40d655b327a6a2d47343dd08692f0f4d699c7329 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #3681: Enable capability to disable a single invoker for maintenance
dubee commented on issue #3681: Enable capability to disable a single invoker for maintenance URL: https://github.com/apache/incubator-openwhisk/issues/3681#issuecomment-391134187 Was able to stop only the actor responsible for pinging the controller, which allows for activation records to be posted to the database for user containers that are still running when the actor is stopped. Sample code: https://github.com/dubee/openwhisk/commit/40d655b327a6a2d47343dd08692f0f4d699c7329 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai closed pull request #154: Provide per-repo., file-level ASF license header exclusion listing.
pritidesai closed pull request #154: Provide per-repo., file-level ASF license header exclusion listing. URL: https://github.com/apache/incubator-openwhisk-release/pull/154 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/docs/license_compliance.md b/docs/license_compliance.md index 6f9aeca..09f820a 100644 --- a/docs/license_compliance.md +++ b/docs/license_compliance.md @@ -28,19 +28,17 @@ This document describes how the Apache OpenWhisk project's source code and relea ## Policies and rules The Apache OpenWhisk project repositories MUST follow [Apache Release Policy](http://www.apache.org/legal/release-policy.html#licensing). every artifact distributed MUST contain only appropriately licensed code per Apache Licensing Policy. It includes two check points: -- Each package MUST provide a LICENSE file and a NOTICE file. +- Each project repository MUST provide a LICENSE file and a NOTICE file. - With a few exceptions, source files consisting of works submitted directly to the ASF by the copyright owner or owner's agent must contain the appropriate ASF license header. Here are the exceptions: + Files without any degree of creativity don't require a license header. + Sometimes shorter form of ASF license header can be used if the recommended Apache source header is not appropriate. ## Project specific rules -In accordance with Apache LICENSE policies, the following tables lists the specific files, by type, that the community has discussed and have agreed MUST have a license or can be exlcuded. +In accordance with Apache LICENSE policies, the following tables lists the specific files, by type, that the community has discussed and have agreed MUST have an ASF approved Apache 2 license or can be excluded for a valid approved reason. **Note**: These lists are not comprehensive and are intended to be informative only. Each project repository's respective LICENSE and NOTICE files should be considered the canonical source for their specific licensing declarations. -For convenience, we provide a summary listing of all project LICENSE and NOTICE files along with notable dependencies in from this repository's [Apache OpenWhisk LICENSE and NOTICE Summary](project_licenses.md#apache-openWhisk-license-and-notice-summary) file. - ### Project ASF License header policy In accordance with Apache LICENSE policies, the table below lists files/file types that the community affirms MUST have an Apache LICENSE header since they are creating works representing Intellectual Property. @@ -48,20 +46,23 @@ In accordance with Apache LICENSE policies, the table below lists files/file typ In addition, the recommended type of approved ASF license header (i.e., "full" or "minified" header) is noted as best practice. | File type | ASF Header Type | Rationale | -| --- | --- | --- | -| Source Code (e.g., *.scala, *.go, *.java, *.py, etc.) | Full | | -| Documentation (e.g., `*.md`) | Full | | -| Web Content (e.g., `*.html`, `.css`) | Full | | +| :--- | :--- | :--- | +| Source code (e.g., `*.scala`, `*.go`, `*.java`, `*.py`, etc.) | Full | Source code. | +| Action functions (source) (e.g., `.js`, `.py`, `.swift`, etc, particularly under `tests/dat` folder.) | Mini | Source codeUse "Mini" header as best practice for performance reasons. | +| Ansible Group vars. (`*/group_vars/all`) | Mini | Project convention. | +| Docker image build file (`dockerfile`) | Mini | May contain functional (script) code. | +| Documentation (e.g., `*.md`) | Full | Intellectual property. | +| Gradle files (`build.gradle`, `*.gradle`) | Full | May contain functional scripts and code (e.g., Groovy, Kotlin).Includes build (`build.gradle`) and settings (`settings.gradle`)files. | +| Gradle properties files (`*.properties`) | Mini | Project convention. | +| Groovy code (`*.groovy`) | Full | Source code. | +| Makefile | Full | May contain functional (script) code. | | Scala Configurations (`*.conf`) | Full | Scala (Java) configuration files may contain code or interfaces. | -| Action Functions (source) (e.g., .js, .py, .swift, etc, particularly under `tests/dat` folder.) | Mini | Needs IP protection; Use "Mini" header as best practice for performance reasons. | -| Makefile | Full | May contain functional code | -| Docker file (`dockerfile`) | Mini | | -| Script files (`*.sh`) | Mini | Contains functional scripting code | -| YAML files (`*.yaml`, `*.yml`) | Mini | | -| XML files (`*.xml`) | Mini | | -| `build.gradle` and `settings.gradle` | Full | Contains build script and configuration for building with Gradle | -| `gradle/docker.gradle` | Full | build script to generate docker image using Gradle | - +| Scala Properties (`*.properties`) | Mini | Project convention.Example:
[GitHub] dubee commented on issue #3681: Enable capability to disable a single invoker for maintenance
dubee commented on issue #3681: Enable capability to disable a single invoker for maintenance URL: https://github.com/apache/incubator-openwhisk/issues/3681#issuecomment-391122904 Another option might be to disable the `Scheduler` in the invoker to stop it from sending the ping messages back to the controller. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #3681: Enable capability to disable a single invoker for maintenance
dubee commented on issue #3681: Enable capability to disable a single invoker for maintenance URL: https://github.com/apache/incubator-openwhisk/issues/3681#issuecomment-391115371 @markusthoemmes, after some experimenting with terminating an invoker actor system via REST endpoint, I noticed that activation records do not get posted to the database for user containers that are still running after the actor system has been shutdown. Perhaps a better implementation would consist of directly telling the controller an invoker is in maintenance mode, and to take that invoker out of the scheduling system. Sample code: https://github.com/dubee/openwhisk/commit/8a60ee3ddd3e619874966da438774bcff6447e5e This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #3681: Enable capability to disable a single invoker for maintenance
dubee commented on issue #3681: Enable capability to disable a single invoker for maintenance URL: https://github.com/apache/incubator-openwhisk/issues/3681#issuecomment-391115371 @markusthoemmes, after some experimenting with terminating an invoker actor system via REST endpoint, I noticed that activation records do not get posted to the database after the actor system has been shutdown. Perhaps a better implementation would consist of directly telling the controller an invoker is in maintenance mode, and to take that invoker out of the scheduling system. Sample code: https://github.com/dubee/openwhisk/commit/8a60ee3ddd3e619874966da438774bcff6447e5e This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #3681: Enable capability to disable a single invoker for maintenance
dubee commented on issue #3681: Enable capability to disable a single invoker for maintenance URL: https://github.com/apache/incubator-openwhisk/issues/3681#issuecomment-391115371 @markusthoemmes, after some experimenting with terminating an invoker actor system via REST endpoint, I noticed that activation records do not get posted to the database after the actor system has been shutdown. Perhaps a better implementation would consist of directly telling the controller an invoker is in maintenance mode, and to take that invoker out of the scheduling system. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asteed commented on a change in pull request #3661: Restrict allowed namespaces when creating action of certain kinds
asteed commented on a change in pull request #3661: Restrict allowed namespaces when creating action of certain kinds URL: https://github.com/apache/incubator-openwhisk/pull/3661#discussion_r190012297 ## File path: core/controller/src/main/scala/whisk/core/entitlement/Entitlement.scala ## @@ -208,8 +222,12 @@ protected[core] abstract class EntitlementProvider( * @param resource the resource the subject requests access to * @return a promise that completes with success iff the subject is permitted to access the requested resource */ - protected[core] def check(user: Identity, right: Privilege, resource: Resource)( -implicit transid: TransactionId): Future[Unit] = check(user, right, Set(resource)) + protected[core] def checkResource( Review comment: I ran into an issue with these two `check()` methods, in that from my research it appears only one method is allowed to contain a default parameter at a given position in the method's signature [0] I was unable to find a way around it short of more explicitly naming them. I'm open to suggestions for handling this scenario. [0] https://groups.google.com/forum/#!msg/scala-user/FyQK3-cqfaY/fXLHr8QsW_0J This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asteed commented on a change in pull request #3661: Restrict allowed namespaces when creating action of certain kinds
asteed commented on a change in pull request #3661: Restrict allowed namespaces when creating action of certain kinds URL: https://github.com/apache/incubator-openwhisk/pull/3661#discussion_r190012297 ## File path: core/controller/src/main/scala/whisk/core/entitlement/Entitlement.scala ## @@ -208,8 +222,12 @@ protected[core] abstract class EntitlementProvider( * @param resource the resource the subject requests access to * @return a promise that completes with success iff the subject is permitted to access the requested resource */ - protected[core] def check(user: Identity, right: Privilege, resource: Resource)( -implicit transid: TransactionId): Future[Unit] = check(user, right, Set(resource)) + protected[core] def checkResource( Review comment: I ran into an issue with these two `check()` methods, in that from my research it appears that in scala only one method is allowed to contain a default parameter at a given position in the method's signature [0] I was unable to find a way around it short of more explicitly naming them. I'm open to suggestions for handling this scenario [0] https://groups.google.com/forum/#!msg/scala-user/FyQK3-cqfaY/fXLHr8QsW_0J This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds
asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds URL: https://github.com/apache/incubator-openwhisk/pull/3661#issuecomment-391098438 @rabbah @csantanapr I've made changes to move the check into Entitlement. Any additional thoughts regarding my prior comment on separating these two issues? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai opened a new issue #920: produce warnings for env. variable outside of inputs section?
pritidesai opened a new issue #920: produce warnings for env. variable outside
of inputs section?
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/920
With adding new concept of inputs section in manifest/deployment file, whisk
deploy produces failure in case of an input is required but its value (env.
variable) is not set. With this new functionality, there is no need for
producing this kind of warning:
```
wskprint.PrintlnOpenWhiskWarning("Missing Environment Variable " + substr +
".")
```
I have disabled this warning, the only catch is when a variable is
referenced `$USERNAME` in manifest/deployment but not defined under `inputs`
section and not set in env. will go without noticing or producing any warning.
Should we assume that this kind of usage is no longer supported?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubee commented on issue #3619: Provide an activation store SPI
dubee commented on issue #3619: Provide an activation store SPI URL: https://github.com/apache/incubator-openwhisk/pull/3619#issuecomment-391074643 @markusthoemmes, any review comments? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #91: Fix invalid warning message
dubee commented on issue #91: Fix invalid warning message URL: https://github.com/apache/incubator-openwhisk-client-go/pull/91#issuecomment-391074373 @mdeuser, can you review? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee opened a new pull request #91: Fix invalid warning message
dubee opened a new pull request #91: Fix invalid warning message URL: https://github.com/apache/incubator-openwhisk-client-go/pull/91 `IsResponseResultSuccess()` inaccurately generates a debug message indicating a failure. Closes https://github.com/apache/incubator-openwhisk-client-go/issues/89 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #90: whisk.RetApi or *whisk.RestApi?
dubee commented on issue #90: whisk.RetApi or *whisk.RestApi? URL: https://github.com/apache/incubator-openwhisk-client-go/issues/90#issuecomment-391069369 @mdeuser This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee opened a new pull request #304: Run unit and native tests separately
dubee opened a new pull request #304: Run unit and native tests separately URL: https://github.com/apache/incubator-openwhisk-cli/pull/304 `./gradlew --console=plain --info goTest -PgoTags=unit,native` does not run native or unit tests, so running unit and native individually. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #202: Kuberentes v1.9.7 Deployment
dgrove-oss commented on issue #202: Kuberentes v1.9.7 Deployment URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/202#issuecomment-391040280 @otaviof - Please submit an Apache ICLA (https://www.apache.org/licenses/). Thanks for the contribution! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on a change in pull request #202: Kuberentes v1.9.7 Deployment
dgrove-oss commented on a change in pull request #202: Kuberentes v1.9.7 Deployment URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/202#discussion_r189950167 ## File path: kubernetes/apigateway/apigateway.yml ## @@ -49,19 +49,31 @@ spec: values: - apigateway topologyKey: "kubernetes.io/hostname" - volumes: - name: redis-data persistentVolumeClaim: claimName: pv-apigateway-01 - + initContainers: + - name: redis-init +image: busybox +command: + - chown + - -v + - -R + - 999:999 Review comment: but, as @otaviof pointed out via slack, busybox container won't have the same user/group ids as the redis container. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes opened a new pull request #3686: Refactor `ensureTopic` to expose failure details.
markusthoemmes opened a new pull request #3686: Refactor `ensureTopic` to expose failure details. URL: https://github.com/apache/incubator-openwhisk/pull/3686 ensureTopic returns a `Boolean` value of whether it successfully created a topic or not. This changes that behavior to actually return the Exception in case of an error. That enables the client-side code to handle (or log) that failure appropriately while maintaining the ease of checking a successful result by using `isSuccess`. ## My changes affect the following components - [ ] API - [X] Controller - [X] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [X] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [X] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [X] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [X] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [X] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [X] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on a change in pull request #202: Kuberentes v1.9.7 Deployment
dgrove-oss commented on a change in pull request #202: Kuberentes v1.9.7 Deployment URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/202#discussion_r189907823 ## File path: kubernetes/apigateway/apigateway.yml ## @@ -49,19 +49,31 @@ spec: values: - apigateway topologyKey: "kubernetes.io/hostname" - volumes: - name: redis-data persistentVolumeClaim: claimName: pv-apigateway-01 - + initContainers: + - name: redis-init +image: busybox +command: + - chown + - -v + - -R + - 999:999 Review comment: would be nicer to say `redis:redis` instead of `999:999` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] fmaschler commented on issue #3579: Using non root user in controller
fmaschler commented on issue #3579: Using non root user in controller URL: https://github.com/apache/incubator-openwhisk/pull/3579#issuecomment-390959318 Is there any update on this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sciabarracom commented on issue #32: Travis Test failing randomly: Example_shell_nocompiler missing Goodbye!
sciabarracom commented on issue #32: Travis Test failing randomly: Example_shell_nocompiler missing Goodbye! URL: https://github.com/apache/incubator-openwhisk-runtime-go/issues/32#issuecomment-390954856 I increased ALL the timeouts in PR#38. Inclusing notably timeouts for draining log, in some tests and for whole test. The issue is simply that the stderror is not drained before the test end. Now I wait 2 seconds an entire test to end, and 100ms (instead of 5) for reading the stderr. Should be enough? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sciabarracom commented on issue #10: Can't run tests in OSX
sciabarracom commented on issue #10: Can't run tests in OSX
URL:
https://github.com/apache/incubator-openwhisk-runtime-go/issues/10#issuecomment-390953955
I just run all the tests 10 times with no failures after fixing timeours. I
think if it works for you it can be closed.
$ for i in {1..10} ; do echo $i ; go test 2>/dev/null | tail -2 ; done
1
PASS
ok github.com/apache/incubator-openwhisk-runtime-go/openwhisk 63.983s
2
PASS
ok github.com/apache/incubator-openwhisk-runtime-go/openwhisk 61.424s
3
PASS
ok github.com/apache/incubator-openwhisk-runtime-go/openwhisk 60.694s
4
PASS
ok github.com/apache/incubator-openwhisk-runtime-go/openwhisk 60.875s
5
PASS
ok github.com/apache/incubator-openwhisk-runtime-go/openwhisk 61.193s
6
PASS
ok github.com/apache/incubator-openwhisk-runtime-go/openwhisk 62.631s
7
PASS
ok github.com/apache/incubator-openwhisk-runtime-go/openwhisk 62.494s
8
PASS
ok github.com/apache/incubator-openwhisk-runtime-go/openwhisk 60.698s
9
PASS
ok github.com/apache/incubator-openwhisk-runtime-go/openwhisk 60.738s
10
PASS
ok github.com/apache/incubator-openwhisk-runtime-go/openwhisk 60.875s
Note to run tests on OSX you need to have set properly GOROOT and GOPATH.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sciabarracom opened a new pull request #38: Fix random failures
sciabarracom opened a new pull request #38: Fix random failures URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/38 Increased all the timeouts (not only for startup but also for draining log, some tests and the whole execution). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3685: Enable test code coverage collection for containers
codecov-io commented on issue #3685: Enable test code coverage collection for containers URL: https://github.com/apache/incubator-openwhisk/pull/3685#issuecomment-390943297 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685?src=pr=h1) Report > Merging [#3685](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/8a3b4472d5ef420f0216cc8e42932d87f428ed30?src=pr=desc) will **increase** coverage by `10.72%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3685 +/- ## === + Coverage 74.49% 85.21% +10.72% === Files 126 126 Lines5994 5994 Branches 392 392 === + Hits 4465 5108 +643 + Misses 1529 886 -643 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685?src=pr=tree) | Coverage Δ | | |---|---|---| | [...n/scala/whisk/core/database/CouchDbRestStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQ291Y2hEYlJlc3RTdG9yZS5zY2FsYQ==) | `70.37% <0%> (+0.61%)` | :arrow_up: | | [.../scala/src/main/scala/whisk/core/entity/Exec.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWMuc2NhbGE=) | `84.51% <0%> (+0.64%)` | :arrow_up: | | [...r/src/main/scala/whisk/core/controller/Rules.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9SdWxlcy5zY2FsYQ==) | `89.93% <0%> (+0.67%)` | :arrow_up: | | [...cala/src/main/scala/whisk/http/ErrorResponse.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvRXJyb3JSZXNwb25zZS5zY2FsYQ==) | `90.9% <0%> (+1.13%)` | :arrow_up: | | [...isk/core/controller/actions/PrimitiveActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1ByaW1pdGl2ZUFjdGlvbnMuc2NhbGE=) | `88.54% <0%> (+1.52%)` | :arrow_up: | | [...cala/whisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `93.56% <0%> (+1.75%)` | :arrow_up: | | [...re/database/MultipleReadersSingleWriterCache.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvTXVsdGlwbGVSZWFkZXJzU2luZ2xlV3JpdGVyQ2FjaGUuc2NhbGE=) | `96.49% <0%> (+1.75%)` | :arrow_up: | | [...on/scala/src/main/scala/whisk/common/Logging.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Mb2dnaW5nLnNjYWxh) | `89.65% <0%> (+2.29%)` | :arrow_up: | | [.../scala/src/main/scala/whisk/core/WhiskConfig.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvV2hpc2tDb25maWcuc2NhbGE=) | `94.57% <0%> (+2.32%)` | :arrow_up: | | [...src/main/scala/whisk/core/controller/Actions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9BY3Rpb25zLnNjYWxh) | `93.84% <0%> (+2.56%)` | :arrow_up: | | ... and [31 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685?src=pr=footer). Last update [8a3b447...1fc0317](https://codecov.io/gh/apache/incubator-openwhisk/pull/3685?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This
[GitHub] chetanmeh opened a new pull request #3685: Enable test code coverage collection for containers
chetanmeh opened a new pull request #3685: Enable test code coverage collection for containers URL: https://github.com/apache/incubator-openwhisk/pull/3685 Enables collection of test code coverage for code running within containers like Controller and Invoker ## Description So far with #3249 we have been collecting test code coverage data from unit and system test for code which need not be running within container. However some of the code paths can only be exercised within a running container. This PR enables collecting test code coverage stats for such code paths. As explained in #3243 scoverage creates `build/scoverage/scoverage.measurements.xxx` files (xxx maps to threadId) at runtime to record any code path being hit. Instrumented code has compile time configured paths for the data directory. So for code compiled for coverage data collection on travis the instrumented code would try to write the measurement file under _/home/travis/build/apache/incubator-openwhisk/core/controller/build/scoverage_ For normal scenario when code is running outside of container such files are written within `build/scoverage` directory and is accessible when generating reports. However when code runs within container its not possible to access such generated files. To enable that following approach has been taken ### Preparing Instrumented Containers Docker build now supports a `distDockerCoverage` task which generate a new image for controller and invoker containing instrumented code based on `Dockerfile.cov` file. The instrumented container * Is tagged with `cov` tag e.g. `whisk/controller:cov` * Adds scoverage runtime jars and replaces existing openwhisk-common etc jars with those generated by scoverage task * Adds symlinks in container for data directory path ### Running Instrumented Containers Further ansible playbooks are modified to look for `GRADLE_COVERAGE` environment variable to enable some specific tasks. Once enabled the new tasks would 1. Create specific directory for controller and invoker like `/tmp/wskcov/controller` 2. Expose these directory as shared volume with path `/coverage` Once running a path like _/home/travis/build/apache/incubator-openwhisk/core/controller/build/scoverage_ would be symlinked to `/coverage/controller` which inturn is pointing to `/tmp/wskcov/controller/controller` ### Report Generation In test module the report generation task would copy all such measurement files from directories under `/tmp/wskcov` to respective modules. The file names would be changed to ensure that they are unique. Post this report would include stats from code running within containers. ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#3243) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [x] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [x] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo opened a new pull request #62: Add headers to build.gradle and settings.gradle
daisy-ycguo opened a new pull request #62: Add headers to build.gradle and settings.gradle URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/62 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo commented on issue #52: Rename "license" subdir. to "licenses" to conform to other project repos.
daisy-ycguo commented on issue #52: Rename "license" subdir. to "licenses" to conform to other project repos. URL: https://github.com/apache/incubator-openwhisk-runtime-swift/issues/52#issuecomment-390924854 I think this can be closed since we have removed all license files. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo commented on issue #25: Some source files miss Apache license headers
daisy-ycguo commented on issue #25: Some source files miss Apache license headers URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/issues/25#issuecomment-390924346 Since we changed the policy to settings.gradle and build.gradle (see the discussion [here](https://github.com/apache/incubator-openwhisk-release/issues/131)), we need this PR merged. And then we can close this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo commented on issue #25: Some source files miss Apache license headers
daisy-ycguo commented on issue #25: Some source files miss Apache license headers URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/issues/25#issuecomment-390924346 Since we changed the policy to settings.gradle and build.gradle (see the discussion [here](https://github.com/apache/incubator-openwhisk-release/issues/131), we need this PR merged. And then we can close this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo commented on issue #99: Track LICENSE and NOTICE issues for `incubator-openwhisk-runtime-nodejs`
daisy-ycguo commented on issue #99: Track LICENSE and NOTICE issues for `incubator-openwhisk-runtime-nodejs` URL: https://github.com/apache/incubator-openwhisk-release/issues/99#issuecomment-390923852 We need this PR merged: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/53 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo opened a new pull request #53: Add header to build.gradle and settings.gradle
daisy-ycguo opened a new pull request #53: Add header to build.gradle and settings.gradle URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/53 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo commented on issue #889: Change all manifest.yaml and deployment.yaml files to use Mini ASF license header
daisy-ycguo commented on issue #889: Change all manifest.yaml and deployment.yaml files to use Mini ASF license header URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/889#issuecomment-390920256 https://github.com/apache/incubator-openwhisk-wskdeploy/pull/914 is merged. We can close this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo commented on issue #133: Why do wskdeploy "example' .js files have both FULL and MINI ASF headers?
daisy-ycguo commented on issue #133: Why do wskdeploy "example' .js files have both FULL and MINI ASF headers? URL: https://github.com/apache/incubator-openwhisk-release/issues/133#issuecomment-390919435 I think we can close this issue since the PR is merged. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3570: ArtifactStore implementation for MongoDB
codecov-io commented on issue #3570: ArtifactStore implementation for MongoDB URL: https://github.com/apache/incubator-openwhisk/pull/3570#issuecomment-386234242 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3570?src=pr=h1) Report > Merging [#3570](https://codecov.io/gh/apache/incubator-openwhisk/pull/3570?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/be4743deea6866988741b881fae0c5237d79bff3?src=pr=desc) will **decrease** coverage by `0.69%`. > The diff coverage is `53.43%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3570?src=pr=tree) ```diff @@Coverage Diff@@ ## master#3570 +/- ## = - Coverage74.5% 73.81% -0.7% = Files 126 128 +2 Lines5994 6198+204 Branches 392 409 +17 = + Hits 4466 4575+109 - Misses 1528 1623 +95 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3570?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../scala/src/main/scala/whisk/core/WhiskConfig.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3570/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvV2hpc2tDb25maWcuc2NhbGE=) | `92.3% <100%> (+0.05%)` | :arrow_up: | | [...on/scala/src/main/scala/whisk/common/Logging.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3570/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Mb2dnaW5nLnNjYWxh) | `87.5% <100%> (+0.14%)` | :arrow_up: | | [...ala/whisk/core/database/mongodb/MongoDbStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3570/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvbW9uZ29kYi9Nb25nb0RiU3RvcmUuc2NhbGE=) | `50.26% <50.26%> (ø)` | | | [...k/core/database/mongodb/MongoDbStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3570/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvbW9uZ29kYi9Nb25nb0RiU3RvcmVQcm92aWRlci5zY2FsYQ==) | `86.66% <86.66%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3570?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3570?src=pr=footer). Last update [be4743d...4c84cf5](https://codecov.io/gh/apache/incubator-openwhisk/pull/3570?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes closed pull request #3672: Add retries in test around package list and enhance debugging inform…
markusthoemmes closed pull request #3672: Add retries in test around package
list and enhance debugging inform…
URL: https://github.com/apache/incubator-openwhisk/pull/3672
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tests/src/test/scala/whisk/core/cli/test/WskEntitlementTests.scala
b/tests/src/test/scala/whisk/core/cli/test/WskEntitlementTests.scala
index 8a1e5121f1..e2d32a79f7 100644
--- a/tests/src/test/scala/whisk/core/cli/test/WskEntitlementTests.scala
+++ b/tests/src/test/scala/whisk/core/cli/test/WskEntitlementTests.scala
@@ -31,7 +31,6 @@ import spray.json._
import spray.json.DefaultJsonProtocol._
import whisk.core.entity.Subject
import whisk.core.entity.WhiskPackage
-import whisk.utils.retry
import scala.concurrent.duration._
@RunWith(classOf[JUnitRunner])
@@ -48,6 +47,8 @@ abstract class WskEntitlementTests extends TestHelpers with
WskTestHelpers with
disposeAdditionalTestSubject(guestWskProps.namespace)
}
+ def retry[A](block: => A) = whisk.utils.retry(block, 10,
Some(500.milliseconds))
+
val samplePackage = "samplePackage"
val sampleAction = "sampleAction"
val fullSampleActionName = s"$samplePackage/$sampleAction"
@@ -153,13 +154,16 @@ abstract class WskEntitlementTests extends TestHelpers
with WskTestHelpers with
pkg.create(samplePackage, shared = Some(true))(wp)
}
-val packageList = wsk.pkg.list(Some(s"/$guestNamespace"))(defaultWskProps)
-verifyPackageSharedList(packageList, guestNamespace, samplePackage)
+retry {
+ val packageList =
wsk.pkg.list(Some(s"/$guestNamespace"))(defaultWskProps)
+ verifyPackageSharedList(packageList, guestNamespace, samplePackage)
+}
}
def verifyPackageSharedList(packageList: RunResult, namespace: String,
packageName: String): Unit = {
val fullyQualifiedPackageName = s"/$namespace/$packageName"
-packageList.stdout should include regex (fullyQualifiedPackageName +
"""\s+shared""")
+withClue(s"Packagelist is: ${packageList.stdout}; Packagename is:
$fullyQualifiedPackageName")(
+ packageList.stdout should include regex (fullyQualifiedPackageName +
"""\s+shared"""))
}
it should "not list private packages" in withAssetCleaner(guestWskProps) {
(wp, assetHelper) =>
@@ -167,13 +171,16 @@ abstract class WskEntitlementTests extends TestHelpers
with WskTestHelpers with
pkg.create(samplePackage)(wp)
}
-val packageList = wsk.pkg.list(Some(s"/$guestNamespace"))(defaultWskProps)
-verifyPackageNotSharedList(packageList, guestNamespace, samplePackage)
+retry {
+ val packageList =
wsk.pkg.list(Some(s"/$guestNamespace"))(defaultWskProps)
+ verifyPackageNotSharedList(packageList, guestNamespace, samplePackage)
+}
}
def verifyPackageNotSharedList(packageList: RunResult, namespace: String,
packageName: String): Unit = {
val fullyQualifiedPackageName = s"/$namespace/$packageName"
-packageList.stdout should not include (fullyQualifiedPackageName)
+withClue(s"Packagelist is: ${packageList.stdout}; Packagename is:
$fullyQualifiedPackageName")(
+ packageList.stdout should not include (fullyQualifiedPackageName))
}
it should "list shared package actions" in withAssetCleaner(guestWskProps) {
(wp, assetHelper) =>
@@ -188,8 +195,10 @@ abstract class WskEntitlementTests extends TestHelpers
with WskTestHelpers with
}
val fullyQualifiedPackageName = s"/$guestNamespace/$samplePackage"
-val packageList =
wsk.action.list(Some(fullyQualifiedPackageName))(defaultWskProps)
-verifyPackageList(packageList, guestNamespace, samplePackage, sampleAction)
+retry {
+ val packageList =
wsk.action.list(Some(fullyQualifiedPackageName))(defaultWskProps)
+ verifyPackageList(packageList, guestNamespace, samplePackage,
sampleAction)
+}
}
def verifyPackageList(packageList: RunResult, namespace: String,
packageName: String, actionName: String): Unit = {
@@ -369,7 +378,7 @@ abstract class WskEntitlementTests extends TestHelpers with
WskTestHelpers with
trigger.create(name, feed = Some(fullyQualifiedFeedName),
expectedExitCode = timeoutCode)(wp)
}
// with several active controllers race condition with cache
invalidation might occur, thus retry
-retry(wsk.trigger.get("badfeed", expectedExitCode = notFoundCode)(wp),
10, Some(500.milliseconds))
+retry(wsk.trigger.get("badfeed", expectedExitCode = notFoundCode)(wp))
}
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
[GitHub] codecov-io commented on issue #3672: Add retries in test around package list and enhance debugging inform…
codecov-io commented on issue #3672: Add retries in test around package list and enhance debugging inform… URL: https://github.com/apache/incubator-openwhisk/pull/3672#issuecomment-390891793 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3672?src=pr=h1) Report > Merging [#3672](https://codecov.io/gh/apache/incubator-openwhisk/pull/3672?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/be4743deea6866988741b881fae0c5237d79bff3?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3672?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #3672 +/- ## == Coverage74.5% 74.5% == Files 126 126 Lines59945994 Branches 392 392 == Hits 44664466 Misses 15281528 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3672?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3672?src=pr=footer). Last update [be4743d...e2ecffa](https://codecov.io/gh/apache/incubator-openwhisk/pull/3672?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3672: Add retries in test around package list and enhance debugging inform…
markusthoemmes commented on a change in pull request #3672: Add retries in test
around package list and enhance debugging inform…
URL:
https://github.com/apache/incubator-openwhisk/pull/3672#discussion_r189792536
##
File path: tests/src/test/scala/whisk/core/cli/test/WskEntitlementTests.scala
##
@@ -153,27 +153,33 @@ abstract class WskEntitlementTests extends TestHelpers
with WskTestHelpers with
pkg.create(samplePackage, shared = Some(true))(wp)
}
-val packageList = wsk.pkg.list(Some(s"/$guestNamespace"))(defaultWskProps)
-verifyPackageSharedList(packageList, guestNamespace, samplePackage)
+retry({
+ val packageList =
wsk.pkg.list(Some(s"/$guestNamespace"))(defaultWskProps)
+ verifyPackageSharedList(packageList, guestNamespace, samplePackage)
+}, 10, Some(500.milliseconds))
}
def verifyPackageSharedList(packageList: RunResult, namespace: String,
packageName: String): Unit = {
val fullyQualifiedPackageName = s"/$namespace/$packageName"
-packageList.stdout should include regex (fullyQualifiedPackageName +
"""\s+shared""")
+withClue(s"Packagelist is: ${packageList.stdout}; Packagename is:
$fullyQualifiedPackageName")(
+ packageList.stdout should include regex (fullyQualifiedPackageName +
"""\s+shared"""))
}
it should "not list private packages" in withAssetCleaner(guestWskProps) {
(wp, assetHelper) =>
assetHelper.withCleaner(wsk.pkg, samplePackage) { (pkg, _) =>
pkg.create(samplePackage)(wp)
}
-val packageList = wsk.pkg.list(Some(s"/$guestNamespace"))(defaultWskProps)
-verifyPackageNotSharedList(packageList, guestNamespace, samplePackage)
+retry({
+ val packageList =
wsk.pkg.list(Some(s"/$guestNamespace"))(defaultWskProps)
+ verifyPackageNotSharedList(packageList, guestNamespace, samplePackage)
+}, 10, Some(500.milliseconds))
Review comment:
Could we externalize the retry values? Or even easier, provide a local retry
like:
```scala
def retry[A](block: => A) = whisk.utils.retry(block, 10, 500.milliseconds)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sciabarracom commented on issue #32: Travis Test failing randomly: Example_shell_nocompiler missing Goodbye!
sciabarracom commented on issue #32: Travis Test failing randomly: Example_shell_nocompiler missing Goodbye! URL: https://github.com/apache/incubator-openwhisk-runtime-go/issues/32#issuecomment-390881467 Since Go multithreading is cooperative, we have to give an opportunit for the other goroutine to run. And log draining is done by another goroutine. Unfortunately it is not deterministic which goroutine runs. Also since test "ends" it may detect a failure just because there was not enough output collected yet. However, I moved the runtime.Gosched() inside the loop to give an opportunity to run for each line of output isteand of once, and this fixed a lot of issues on OSX. I think however we need also a runtime.Gosched() at the beginning of the loop (where it was originally). Furthermore, there are 2 timeouts now, https://github.com/apache/incubator-openwhisk-runtime-go/blob/master/openwhisk/executor.go#L34 and in the TestMain I only changed one, but there is also a timeout waiting for the log draining. Last but not least there is a timeout after the tests. Will try to increase those timeouts too. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] otaviof commented on a change in pull request #202: Kuberentes v1.9.7 Deployment
otaviof commented on a change in pull request #202: Kuberentes v1.9.7 Deployment URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/202#discussion_r189791286 ## File path: README.md ## @@ -99,6 +99,7 @@ directory tree. Follow the instructions for each step in order. * Deploy [ApiGateway](kubernetes/apigateway) * Deploy [Zookeeper](kubernetes/zookeeper) * Deploy [Kafka](kubernetes/kafka) +* Deploy [CouchDB](kubernetes/couchdb) Review comment: @dgrove-oss that's correct, I'm removing it as well. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
