[GitHub] ddragosd commented on issue #149: Add more consistency to the Docker Compose `make` command line interface
ddragosd commented on issue #149: Add more consistency to the Docker Compose `make` command line interface URL: https://github.com/apache/incubator-openwhisk-devtools/issues/149#issuecomment-413050077 @Juice10 . If you wanna work on a PR we can get it merged. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd commented on issue #150: Add support for Ruby 2.5
ddragosd commented on issue #150: Add support for Ruby 2.5 URL: https://github.com/apache/incubator-openwhisk-devtools/pull/150#issuecomment-413049763 thanks @Juice10 ! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai opened a new pull request #308: replacing remotefile with include
pritidesai opened a new pull request #308: replacing remotefile with include URL: https://github.com/apache/incubator-openwhisk-website/pull/308 loading remote file content is taking 13 seconds on average, replacing it with more efficient way of including scripts/manifests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #307: Add ASF required links and legal text to footer
mrutkows opened a new pull request #307: Add ASF required links and legal text to footer URL: https://github.com/apache/incubator-openwhisk-website/pull/307 Fixes https://github.com/apache/incubator-openwhisk-website/issues/302 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3967: utility Docker images to run ansible playbooks and bash scripts
codecov-io commented on issue #3967: utility Docker images to run ansible playbooks and bash scripts URL: https://github.com/apache/incubator-openwhisk/pull/3967#issuecomment-413034862 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3967?src=pr=h1) Report > Merging [#3967](https://codecov.io/gh/apache/incubator-openwhisk/pull/3967?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/f365d1c84ce5d8595fb686ecd4a8ef9220b23c6b?src=pr=desc) will **decrease** coverage by `4.44%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3967?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3967 +/- ## == - Coverage85.2% 80.75% -4.45% == Files 146 146 Lines7057 7057 Branches 413 413 == - Hits 6013 5699 -314 - Misses 1044 1358 +314 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3967?src=pr=tree) | Coverage Δ | | |---|---|---| | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3967/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3967/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.1%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3967/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3967/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-81.82%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3967/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-58.83%)` | :arrow_down: | | [...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3967/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | | [...rc/main/scala/whisk/common/ForcibleSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3967/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjaWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `88.46% <0%> (-3.85%)` | :arrow_down: | | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3967/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `73.94% <0%> (+15.12%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3967?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3967?src=pr=footer). Last update [f365d1c...11b580a](https://codecov.io/gh/apache/incubator-openwhisk/pull/3967?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Juice10 opened a new issue #5: Add support for the Ruby 2.5 runtime
Juice10 opened a new issue #5: Add support for the Ruby 2.5 runtime URL: https://github.com/apache/incubator-openwhisk-deploy-openshift/issues/5 Ruby 2.5 runtime is now part of Apache OpenWhisk, we still have to add support for it as part of the OpenShift deployment method. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #306: Prioritize linking to the runtimes in the documentation above linking to the runtime repositories
pritidesai commented on issue #306: Prioritize linking to the runtimes in the documentation above linking to the runtime repositories URL: https://github.com/apache/incubator-openwhisk-website/issues/306#issuecomment-413030156 yeah I understand what you are saying now. I had added the links to all different runtimes under Actions section to kind of show listing of supported runtimes and pointing them to repo in one single place:  But after adding [Project Structure](http://openwhisk.apache.org/documentation.html#project-structure), I think we can change those links to point it to respective sections on the doc page as you requested. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Juice10 opened a new pull request #274: Add Ruby 2.5 to the list of runtimes
Juice10 opened a new pull request #274: Add Ruby 2.5 to the list of runtimes URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/274 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #306: Prioritize linking to the runtimes in the documentation above linking to the runtime repositories
pritidesai commented on issue #306: Prioritize linking to the runtimes in the documentation above linking to the runtime repositories URL: https://github.com/apache/incubator-openwhisk-website/issues/306#issuecomment-413028016 wow, thats awesome, let me check the video This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Juice10 commented on issue #306: Prioritize linking to the runtimes in the documentation above linking to the runtime repositories
Juice10 commented on issue #306: Prioritize linking to the runtimes in the documentation above linking to the runtime repositories URL: https://github.com/apache/incubator-openwhisk-website/issues/306#issuecomment-413027824 @pritidesai yeah sorry about that, it's kind of hard to explain in text so I decided to record a little video of it to explain exactly what I mean. Let me know if this clarifies things: https://monosnap.com/file/ypOoOSjiIxsMNmPsOhOpqutQN1GvUL This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai edited a comment on issue #306: Prioritize linking to the runtimes in the documentation above linking to the runtime repositories
pritidesai edited a comment on issue #306: Prioritize linking to the runtimes in the documentation above linking to the runtime repositories URL: https://github.com/apache/incubator-openwhisk-website/issues/306#issuecomment-413025204 @Juice10 I am not sure if I understand the change, the purpose of a link called "PHP" under "Actions" section is to demonstrate how to write functions and create actions using PHP runtime.  The PHP runtime doesnt have this information (we should update the runtime repo first IMO). The runtime repo doesnt show how to create a simple hello world action yet.  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #306: Prioritize linking to the runtimes in the documentation above linking to the runtime repositories
pritidesai commented on issue #306: Prioritize linking to the runtimes in the documentation above linking to the runtime repositories URL: https://github.com/apache/incubator-openwhisk-website/issues/306#issuecomment-413025204 @Juice10 I am not sure if I understand the change, the purpose of a link called "PHP" under "Actions" section is to demonstrate how to create write functions and create actions using PHP runtime.  The PHP runtime doesnt have this information (we should update the runtime repo first IMO). The runtime repo doesnt show how to create a simple hello world action yet.  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Juice10 opened a new pull request #150: Add support for Ruby 2.5
Juice10 opened a new pull request #150: Add support for Ruby 2.5 URL: https://github.com/apache/incubator-openwhisk-devtools/pull/150 Ruby 2.5 runtime has been added to OpenWhisk, this pull request adds support for running it locally. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #3886: Proposing Lean OpenWhisk
codecov-io edited a comment on issue #3886: Proposing Lean OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3886#issuecomment-406254669 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886?src=pr=h1) Report > Merging [#3886](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/f365d1c84ce5d8595fb686ecd4a8ef9220b23c6b?src=pr=desc) will **decrease** coverage by `14.48%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3886 +/- ## === - Coverage85.2% 70.72% -14.49% === Files 146 148+2 Lines7057 6955 -102 Branches 413 431 +18 === - Hits 6013 4919 -1094 - Misses 1044 2036 +992 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886?src=pr=tree) | Coverage Δ | | |---|---|---| | [...main/scala/whisk/connector/lean/LeanProducer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9sZWFuL0xlYW5Qcm9kdWNlci5zY2FsYQ==) | `0% <0%> (ø)` | | | [...main/scala/whisk/connector/lean/LeanConsumer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9sZWFuL0xlYW5Db25zdW1lci5zY2FsYQ==) | `0% <0%> (ø)` | | | [...a/whisk/connector/lean/LeanMessagingProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9sZWFuL0xlYW5NZXNzYWdpbmdQcm92aWRlci5zY2FsYQ==) | `0% <0%> (ø)` | | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...la/src/main/scala/whisk/http/BasicRasService.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvQmFzaWNSYXNTZXJ2aWNlLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.1%)` | :arrow_down: | | [...a/src/main/scala/whisk/http/BasicHttpService.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvQmFzaWNIdHRwU2VydmljZS5zY2FsYQ==) | `0% <0%> (-93.45%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [.../main/scala/whisk/core/controller/Controller.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9Db250cm9sbGVyLnNjYWxh) | `0% <0%> (-82.11%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-81.82%)` | :arrow_down: | | ... and [63 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886?src=pr=footer). Last update [f365d1c...573bb7a](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated
[GitHub] Juice10 opened a new issue #306: Prioritize linking to the runtimes in the documentation above linking to the runtime repositories
Juice10 opened a new issue #306: Prioritize linking to the runtimes in the documentation above linking to the runtime repositories URL: https://github.com/apache/incubator-openwhisk-website/issues/306 In the ["Developers" section](http://openwhisk.incubator.apache.org/documentation.html#developers) of the documentation, the first time you see the runtimes mentioned is in the ["Actions" section](http://openwhisk.incubator.apache.org/documentation.html#actions). The links to these supported programming languages go straight to the GitHub repo for the runtime. Since this is part the developers section I would like to propose linking to documentation on the language instead, from there you can always get to the repo via the provided links. This also really helps with scanning the document. When quickly scanning the documentation, you click the first link you see for the language you are interested in and you'll get the documentation for it as opposed to the runtime code. # Example change PHP link will refer to http://openwhisk.incubator.apache.org/documentation.html#php as opposed to https://github.com/apache/incubator-openwhisk-runtime-php/blob/master/README.md This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #78: update run handler to accept more environment variables
csantanapr opened a new pull request #78: update run handler to accept more environment variables URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/78 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #300: FAQ is MIA
csantanapr commented on issue #300: FAQ is MIA URL: https://github.com/apache/incubator-openwhisk-website/issues/300#issuecomment-413015499 Thanks @pritidesai I didn't see #294 closing this one This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #300: FAQ is MIA
csantanapr closed issue #300: FAQ is MIA URL: https://github.com/apache/incubator-openwhisk-website/issues/300 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #36: update run handler to accept more environment variables
csantanapr opened a new pull request #36: update run handler to accept more environment variables URL: https://github.com/apache/incubator-openwhisk-runtime-python/pull/36 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Juice10 opened a new issue #305: Use descriptive link texts (instead of "here" or "click here")
Juice10 opened a new issue #305: Use descriptive link texts (instead of "here" or "click here") URL: https://github.com/apache/incubator-openwhisk-website/issues/305 Using "here" or "click here" is bad practice when it comes to SEO and Accessibility, we should replace those with something more descriptive. See the articles below for more information on the subject. ### Articles explaining the difference between descriptive links and "click here" links https://webaccess.berkeley.edu/ask-pecan/click-here http://dotmonster.co/blog/why-using-click-here-for-links-is-bad-practice ### Examples of where we are going against the best practice > You can read about the list of OpenWhisk components and its internal flow of processing here. > Here are the instructions and details on how to deploy OpenWhisk on OpenShift. > Download the wsk CLI: Download wsk binary for your local environment into a location in your shell path from here. > Note: Before you proceed with the deployment, please make sure you have the authentication setup as described here. > Here is the list of runtimes supported by OpenWhisk: > The OpenWhisk platform is extensible and you can add new languages or runtimes (with custom packages and third-party dependencies) following the guide described here. > OpenWhisk comes with a list of packages You can get more details on OpenWhisk packages here. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jasonpet closed pull request #11: Update changelog to pick up run handler updates
jasonpet closed pull request #11: Update changelog to pick up run handler updates URL: https://github.com/apache/incubator-openwhisk-runtime-ruby/pull/11 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/core/ruby2.5Action/CHANGELOG.md b/core/ruby2.5Action/CHANGELOG.md new file mode 100644 index 000..52f6a56 --- /dev/null +++ b/core/ruby2.5Action/CHANGELOG.md @@ -0,0 +1,24 @@ + + +# Ruby 2.5 OpenWhisk Runtime Container + +## 1.0.0 +Changes: +- Initial release This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss opened a new pull request #3967: utility Docker images to run ansible playbooks and bash scripts
dgrove-oss opened a new pull request #3967: utility Docker images to run ansible playbooks and bash scripts URL: https://github.com/apache/incubator-openwhisk/pull/3967 Define alpine based utility images that execute bash scripts and ansible playbooks mounted into /task by Kubernetes/Dockers/Mesos/OpenShift. By defining these images as part of the OpenWhisk core project, we can reduce the number of bespoke Docker images in downstream deployment projects. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai closed issue #217: Update GitHub link to Apache org. and suggest new page for "code" (repos).
pritidesai closed issue #217: Update GitHub link to Apache org. and suggest new page for "code" (repos). URL: https://github.com/apache/incubator-openwhisk-website/issues/217 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #217: Update GitHub link to Apache org. and suggest new page for "code" (repos).
pritidesai commented on issue #217: Update GitHub link to Apache org. and suggest new page for "code" (repos). URL: https://github.com/apache/incubator-openwhisk-website/issues/217#issuecomment-413007692 Done with PR #299 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #269: Create scripts/files for each line of code on doc page
pritidesai commented on issue #269: Create scripts/files for each line of code on doc page URL: https://github.com/apache/incubator-openwhisk-website/issues/269#issuecomment-413007416 Done with PR #288 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai closed issue #269: Create scripts/files for each line of code on doc page
pritidesai closed issue #269: Create scripts/files for each line of code on doc page URL: https://github.com/apache/incubator-openwhisk-website/issues/269 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jasonpet closed pull request #68: Update changelog to pick up run handler updates
jasonpet closed pull request #68: Update changelog to pick up run handler updates URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/68 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/core/java8/CHANGELOG.md b/core/java8/CHANGELOG.md index c7da0a1..5dfb31b 100644 --- a/core/java8/CHANGELOG.md +++ b/core/java8/CHANGELOG.md @@ -20,6 +20,10 @@ # Java 8 OpenWhisk Runtime Container +## 1.1.2 +Changes: +- Update run handler to accept more environment variables [#67](https://github.com/apache/incubator-openwhisk-runtime-java/pull/67) + ## 1.1.1 Changes: - Adds log markers. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ScottChapman opened a new issue #277: Should decode not encode UTF-8 messages?
ScottChapman opened a new issue #277: Should decode not encode UTF-8 messages? URL: https://github.com/apache/incubator-openwhisk-package-kafka/issues/277 Discovered that messages containing unicode text appear to be getting corrupted. I suspect it is this: https://github.com/apache/incubator-openwhisk-package-kafka/blob/449bbae13e813ba4dcd11dc33f47ab29d5e3541a/provider/consumer.py#L455 From the [kafka-python docs](https://kafka-python.readthedocs.io/en/master/usage.html)  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jasonpet closed pull request #56: Update changelog to pick run handler updates
jasonpet closed pull request #56: Update changelog to pick run handler updates URL: https://github.com/apache/incubator-openwhisk-runtime-docker/pull/56 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/core/CHANGELOG.md b/core/CHANGELOG.md index fa09b5d..17952ec 100644 --- a/core/CHANGELOG.md +++ b/core/CHANGELOG.md @@ -19,6 +19,10 @@ # Apache OpenWhisk Docker Runtime Container +## 1.3.3 +Changes: + - Update run handler to accept more environment variables [#55](https://github.com/apache/incubator-openwhisk-runtime-docker/pull/55) + ## 1.3.2 Changes: - Fixes bug where a log maker is emitted more than once. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jasonpet closed pull request #79: Update changelogs to pick run handler updates
jasonpet closed pull request #79: Update changelogs to pick run handler updates URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/79 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/core/nodejs6Action/CHANGELOG.md b/core/nodejs6Action/CHANGELOG.md index e986414..97d75fe 100644 --- a/core/nodejs6Action/CHANGELOG.md +++ b/core/nodejs6Action/CHANGELOG.md @@ -19,6 +19,11 @@ # NodeJS 6 OpenWhisk Runtime Container +## 1.11.2 +Change: Update runtime to allow more environment variables + +- Update run handler to accept more environment variables [#78](https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/78) + ## 1.11.1 Change: Update runtime to put runtime npm modules at root level, user npm modules at container invocation level diff --git a/core/nodejs8Action/CHANGELOG.md b/core/nodejs8Action/CHANGELOG.md index b947b26..63153e1 100644 --- a/core/nodejs8Action/CHANGELOG.md +++ b/core/nodejs8Action/CHANGELOG.md @@ -19,6 +19,11 @@ # NodeJS 8 OpenWhisk Runtime Container +## 1.8.2 +Change: Update runtime to allow more environment variables + +- Update run handler to accept more environment variables [#78](https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/78) + ## 1.8.1 Change: Update runtime to put runtime npm modules at root level, user npm modules at container invocation level This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eweiter commented on issue #40: Allow /run endpoint to accept more environment variables
eweiter commented on issue #40: Allow /run endpoint to accept more environment variables URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/40#issuecomment-412997197 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #11: Update changelog to pick up run handler updates
csantanapr opened a new pull request #11: Update changelog to pick up run handler updates URL: https://github.com/apache/incubator-openwhisk-runtime-ruby/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Juice10 opened a new issue #149: Add more consistency to the Docker Compose make command
Juice10 opened a new issue #149: Add more consistency to the Docker Compose make command URL: https://github.com/apache/incubator-openwhisk-devtools/issues/149 The docker compose make commands are lacking some consistency. We currently have `make stop` and `make restart` but no `make start`. We do however have a `make run` and a `make quick-start`. I suggest we alias one of these two to `make start`. We have more inconsistency in the use of `-`'s and `_`'s. Examples: ``` quick-start add-catalog download-catalog quick-start-pause quick-start-info docker_build docker_pull docker_pull_full download-cli ``` I suggest we rename the ones that use underscore (`_`) to dash (`-`) since most of the commands use dash and only a few of them use underscores. For backwards compatibility's sake we should keep the old ones but add a depreciation warning. Let me know what you think of these suggestions. I'm not the expert here, just trying to make things more consistent and intuitive so that new users have an easier time using the tools. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed pull request #304: Renaming Illustrations to illustrations
mrutkows closed pull request #304: Renaming Illustrations to illustrations URL: https://github.com/apache/incubator-openwhisk-website/pull/304 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/images/Illustrations/OW-Abstract Architecture Diagram.png b/images/illustrations/OW-Abstract Architecture Diagram.png similarity index 100% rename from images/Illustrations/OW-Abstract Architecture Diagram.png rename to images/illustrations/OW-Abstract Architecture Diagram.png diff --git a/images/Illustrations/OW-Abstract Architecture Diagram.pptx b/images/illustrations/OW-Abstract Architecture Diagram.pptx similarity index 100% rename from images/Illustrations/OW-Abstract Architecture Diagram.pptx rename to images/illustrations/OW-Abstract Architecture Diagram.pptx diff --git a/images/Illustrations/OW-Deployments.png b/images/illustrations/OW-Deployments.png similarity index 100% rename from images/Illustrations/OW-Deployments.png rename to images/illustrations/OW-Deployments.png diff --git a/images/Illustrations/OW-Deployments.pptx b/images/illustrations/OW-Deployments.pptx similarity index 100% rename from images/Illustrations/OW-Deployments.pptx rename to images/illustrations/OW-Deployments.pptx diff --git a/images/Illustrations/OW-Runtime-Compositions.png b/images/illustrations/OW-Runtime-Compositions.png similarity index 100% rename from images/Illustrations/OW-Runtime-Compositions.png rename to images/illustrations/OW-Runtime-Compositions.png diff --git a/images/Illustrations/OW-Runtime-Compositions.pptx b/images/illustrations/OW-Runtime-Compositions.pptx similarity index 100% rename from images/Illustrations/OW-Runtime-Compositions.pptx rename to images/illustrations/OW-Runtime-Compositions.pptx diff --git a/images/Illustrations/OW-Runtimes.png b/images/illustrations/OW-Runtimes.png similarity index 100% rename from images/Illustrations/OW-Runtimes.png rename to images/illustrations/OW-Runtimes.png diff --git a/images/Illustrations/OW-Runtimes.pptx b/images/illustrations/OW-Runtimes.pptx similarity index 100% rename from images/Illustrations/OW-Runtimes.pptx rename to images/illustrations/OW-Runtimes.pptx diff --git a/images/Illustrations/OW-Utilization-Scaling.png b/images/illustrations/OW-Utilization-Scaling.png similarity index 100% rename from images/Illustrations/OW-Utilization-Scaling.png rename to images/illustrations/OW-Utilization-Scaling.png diff --git a/images/Illustrations/OW-Utilization-Scaling.pptx b/images/illustrations/OW-Utilization-Scaling.pptx similarity index 100% rename from images/Illustrations/OW-Utilization-Scaling.pptx rename to images/illustrations/OW-Utilization-Scaling.pptx diff --git a/images/Illustrations/illustration-integrators.png b/images/illustrations/illustration-integrators.png similarity index 100% rename from images/Illustrations/illustration-integrators.png rename to images/illustrations/illustration-integrators.png diff --git a/images/Illustrations/illustration-integrators.svg b/images/illustrations/illustration-integrators.svg similarity index 100% rename from images/Illustrations/illustration-integrators.svg rename to images/illustrations/illustration-integrators.svg This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #68: Update changelog to pick up run handler updates
csantanapr opened a new pull request #68: Update changelog to pick up run handler updates URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/68 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai opened a new pull request #304: Renaming Illustrations to illustrations
pritidesai opened a new pull request #304: Renaming Illustrations to illustrations URL: https://github.com/apache/incubator-openwhisk-website/pull/304 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #56: Update changelog to pick run handler updates
csantanapr opened a new pull request #56: Update changelog to pick run handler updates URL: https://github.com/apache/incubator-openwhisk-runtime-docker/pull/56 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #79: Update changelogs to pick run handler updates
csantanapr opened a new pull request #79: Update changelogs to pick run handler updates URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/79 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai closed pull request #303: Fix slider plugin file
pritidesai closed pull request #303: Fix slider plugin file URL: https://github.com/apache/incubator-openwhisk-website/pull/303 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/_plugins/ideal_image_slider.rb b/_plugins/ideal_image_slider.rb index ce1a341..abfb650 100644 --- a/_plugins/ideal_image_slider.rb +++ b/_plugins/ideal_image_slider.rb @@ -1,1194 +1,95 @@ - - - - - - - - - - - https://assets-cdn.github.com;> - https://avatars0.githubusercontent.com;> - https://avatars1.githubusercontent.com;> - https://avatars2.githubusercontent.com;> - https://avatars3.githubusercontent.com;> - https://github-cloud.s3.amazonaws.com;> - https://user-images.githubusercontent.com/;> - - - - https://assets-cdn.github.com/assets/frameworks-95aff0b550d3fe338b645a4deebdcb1b.css; /> - https://assets-cdn.github.com/assets/github-e6bb18b320358b77abe040d2eb46b547.css; /> - - - - - - - - jekyll-ideal-image-slider/ideal_image_slider.rb at master · jekylltools/jekyll-ideal-image-slider - - - https://github.com/fluidicon.png; title="GitHub"> - - - -https://avatars1.githubusercontent.com/u/26100939?s=400v=4; />https://github.com/jekylltools/jekyll-ideal-image-slider; /> - - https://assets-cdn.github.com/;> - - - - - - - - - - - - - - - -https://collector.githubapp.com/github-external/browser_event; /> - - - - - - - - - - - - - - - - - - - - - - - - - https://github.com/jekylltools/jekyll-ideal-image-slider/commits/master.atom; rel="alternate" title="Recent Commits to jekyll-ideal-image-slider:master" type="application/atom+xml"> - - https://github.com/jekylltools/jekyll-ideal-image-slider.git;> - - - - -https://github.com/jekylltools/jekyll-ideal-image-slider/blob/master/_plugins/ideal_image_slider.rb; data-pjax-transient> - - - https://api.github.com/_private/browser/stats;> - - https://api.github.com/_private/browser/errors;> - - https://assets-cdn.github.com/pinned-octocat.svg; color="#00"> - https://assets-cdn.github.com/favicon.ico;> - - - - - - - - - - - - - -Skip to content - - - - - - - - - - - - - -https://github.com/; data-hotkey="g d" aria-label="Homepage" data-ga-click="Header, go to dashboard, icon:logo"> - - - - - - - - - - - - - - - - -https://assets-cdn.github.com/images/search-shortcut-hint.svg; alt="" class="mr-2 header-search-key-slash"> - - - - - - - - - - - - - -In this repository - - -All GitHub - - ↵ - - - - Jump to - ↵ - - - - - - - - - - No suggested jump to results - - - - - - https://assets-cdn.github.com/images/spinners/octocat-spinner-128.gif; alt="Octocat Spinner Icon" class="m-2" width="28"> - - - - - - - - - - - - -Pull requests - - - -Issues - - - - Marketplace - - - -Explore - - - - - - - - - - - - - - - - - - - - - - - - - - - New repository - - - -Import repository - - -https://gist.github.com/; data-ga-click="Header, create new gist"> - New gist - - - -New organization - - - - - - - - - - - - -https://avatars2.githubusercontent.com/u/7816715?s=40v=4; height="20" width="20"> - - - - - Signed in as mrutkows - - Your profile - Your repositories - Your stars -https://gist.github.com/; data-ga-click="Header, your gists, text:your gists">Your gists - - https://help.github.com; data-ga-click="Header, go to help, text:help">Help - Settings - - - -
[GitHub] mrutkows opened a new pull request #303: Fix slider plugin file
mrutkows opened a new pull request #303: Fix slider plugin file URL: https://github.com/apache/incubator-openwhisk-website/pull/303 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #3963: k8s: implement invoker-node affinity and eliminate usage of kubectl
codecov-io edited a comment on issue #3963: k8s: implement invoker-node affinity and eliminate usage of kubectl URL: https://github.com/apache/incubator-openwhisk/pull/3963#issuecomment-412588479 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3963?src=pr=h1) Report > Merging [#3963](https://codecov.io/gh/apache/incubator-openwhisk/pull/3963?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/7b5d8057ca9dcae9ae170318c39387a3fb684f67?src=pr=desc) will **decrease** coverage by `4.67%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3963?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3963 +/- ## == - Coverage 85.44% 80.77% -4.68% == Files 146 146 Lines7057 7054 -3 Branches 413 412 -1 == - Hits 6030 5698 -332 - Misses 1027 1356 +329 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3963?src=pr=tree) | Coverage Δ | | |---|---|---| | [...re/containerpool/kubernetes/KubernetesClient.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3963/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL0t1YmVybmV0ZXNDbGllbnQuc2NhbGE=) | `27.27% <0%> (-0.14%)` | :arrow_down: | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3963/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3963/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.1%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3963/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3963/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-81.82%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3963/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-58.83%)` | :arrow_down: | | [...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3963/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3963?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3963?src=pr=footer). Last update [7b5d805...5f47194](https://codecov.io/gh/apache/incubator-openwhisk/pull/3963?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #3963: k8s: implement invoker-node affinity and eliminate usage of kubectl
codecov-io edited a comment on issue #3963: k8s: implement invoker-node affinity and eliminate usage of kubectl URL: https://github.com/apache/incubator-openwhisk/pull/3963#issuecomment-412588479 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3963?src=pr=h1) Report > Merging [#3963](https://codecov.io/gh/apache/incubator-openwhisk/pull/3963?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/7b5d8057ca9dcae9ae170318c39387a3fb684f67?src=pr=desc) will **decrease** coverage by `4.67%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3963?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3963 +/- ## == - Coverage 85.44% 80.77% -4.68% == Files 146 146 Lines7057 7054 -3 Branches 413 412 -1 == - Hits 6030 5698 -332 - Misses 1027 1356 +329 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3963?src=pr=tree) | Coverage Δ | | |---|---|---| | [...re/containerpool/kubernetes/KubernetesClient.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3963/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL0t1YmVybmV0ZXNDbGllbnQuc2NhbGE=) | `27.27% <0%> (-0.14%)` | :arrow_down: | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3963/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3963/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.1%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3963/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3963/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-81.82%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3963/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-58.83%)` | :arrow_down: | | [...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3963/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3963?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3963?src=pr=footer). Last update [7b5d805...5f47194](https://codecov.io/gh/apache/incubator-openwhisk/pull/3963?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #40: Allow /run endpoint to accept more environment variables
csantanapr opened a new pull request #40: Allow /run endpoint to accept more environment variables URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss closed pull request #3772: Update kubectl version in invoker Dockerfile
dgrove-oss closed pull request #3772: Update kubectl version in invoker Dockerfile URL: https://github.com/apache/incubator-openwhisk/pull/3772 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/core/invoker/Dockerfile b/core/invoker/Dockerfile index d1c5d8cc51..726bbd3022 100644 --- a/core/invoker/Dockerfile +++ b/core/invoker/Dockerfile @@ -4,7 +4,7 @@ FROM scala ENV DOCKER_VERSION 1.12.0 -ENV KUBERNETES_VERSION 1.6.4 +ENV KUBERNETES_VERSION 1.8.13 RUN apk add --update openssl This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #3772: Update kubectl version in invoker Dockerfile
dgrove-oss commented on issue #3772: Update kubectl version in invoker Dockerfile URL: https://github.com/apache/incubator-openwhisk/pull/3772#issuecomment-412960884 It turned out to be pretty easy to implement the last couple of operations using the rest client, so we don't even need the kubectl exectuable in the invoker image anymore. Closing this in favor of #3963 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #3963: k8s: implement invoker-node affinity and eliminate usage of kubectl
dgrove-oss commented on issue #3963: k8s: implement invoker-node affinity and eliminate usage of kubectl URL: https://github.com/apache/incubator-openwhisk/pull/3963#issuecomment-412960444 pushed a second commit to remove the kubectl executable from the Dockerfile. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tysonnorris commented on issue #2795: enable concurrent activation processing
tysonnorris commented on issue #2795: enable concurrent activation processing URL: https://github.com/apache/incubator-openwhisk/pull/2795#issuecomment-412958409 I'm seeing test failures related to akka client (enabled on system tests) + `actionproxy.py` + `Connection: close` headers; results in: ``` [DockerContainer] running result: ConnectionError(akka.http.impl.engine.client.OutgoingConnectionBlueprint$UnexpectedConnectionClosureException: The http server closed the connection unexpectedly before delivering responses for 1 outstanding requests) ``` I reproduced this locally (and via travis) with swift and python runtimes; investigating what we might need to change in actionproxy.py (ideas appreciated) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #3798: Allow for activation store to accept user and request information
dubee commented on issue #3798: Allow for activation store to accept user and request information URL: https://github.com/apache/incubator-openwhisk/pull/3798#issuecomment-412955342 @markusthoemmes, any other comments on this one? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed pull request #299: Adding GitHub repo structure
mrutkows closed pull request #299: Adding GitHub repo structure URL: https://github.com/apache/incubator-openwhisk-website/pull/299 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/_layouts/documentation.html b/_layouts/documentation.html index 596e12e..1d49922 100644 --- a/_layouts/documentation.html +++ b/_layouts/documentation.html @@ -11,6 +11,7 @@ Documentation +Project Structure Operators @@ -112,6 +113,356 @@ Documentation + + + +Project Structure +OpenWhisk is comprised of multiple repositories that can be found in Apache GitHub (using a name query by repository): +https://github.com/apache?q=openwhisk;>https://github.com/apache?q=openwhisk +For convenience, here is a listing of current Apache OpenWhisk project repositories (by category). +Note: OpenWhisk repositories follow a naming convention where all repo starts with incubator, for example, openwhisk-cli GitHub repository is named incubator-openwhisk-cli. + + +Platform +Primary source code repositories including platform code, run books, tests and more. + +https://github.com/apache/incubator-openwhisk; +title="Core OpenWhisk repository including controller, invoker, run books, and more."> +openwhisk + + + +https://github.com/apache/incubator-openwhisk-cli; +title="Pluggable Command Line Interface (CLI) for wsk command using the Cobra framework."> +openwhisk-cli + + + +https://github.com/apache/incubator-openwhisk-apigateway; +title="A performant API Gateway based on Openresty and NGINX."> +openwhisk-apigateway + + + +https://github.com/apache/incubator-openwhisk-catalog; +title="Catalog of built-in system, utility, test and sample Actions, Feeds and provider integration services and catalog packaging tooling."> +openwhisk-catalog + + + + +Runtimes +OpenWhisk supports several languages and runtimes. + +https://github.com/apache/incubator-openwhisk-runtime-nodejs; +title="Apache openwhisk nodejs runtime"> +openwhisk-runtime-nodejs + + + +https://github.com/apache/incubator-openwhisk-runtime-docker; +title="Apache openwhisk docker runtime"> +openwhisk-runtime-docker + + + +https://github.com/apache/incubator-openwhisk-runtime-python; +title="Apache openwhisk python runtime"> +openwhisk-runtime-python + + + +https://github.com/apache/incubator-openwhisk-runtime-go; +title="Apache openwhisk go runtime"> +openwhisk-runtime-go + + + +https://github.com/apache/incubator-openwhisk-runtime-swift; +title="Apache openwhisk swift runtime"> +openwhisk-runtime-swift + + + +https://github.com/apache/incubator-openwhisk-runtime-php; +title="Apache openwhisk php runtime"> +openwhisk-runtime-php + + + +https://github.com/apache/incubator-openwhisk-runtime-java; +title="Apache openwhisk java runtime"> +openwhisk-runtime-java + + + + +Deployments +
[GitHub] dubee closed pull request #964: Run the properties.yml playbook in order to create whisk.properties
dubee closed pull request #964: Run the properties.yml playbook in order to
create whisk.properties
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/964
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tools/travis/script.sh b/tools/travis/script.sh
index 1aec7f35..43121bdf 100755
--- a/tools/travis/script.sh
+++ b/tools/travis/script.sh
@@ -53,6 +53,7 @@ $ANSIBLE_CMD couchdb.yml
$ANSIBLE_CMD initdb.yml
$ANSIBLE_CMD wipe.yml
$ANSIBLE_CMD openwhisk.yml -e
'{"openwhisk_cli":{"installation_mode":"remote","remote":{"name":"OpenWhisk_CLI","dest_name":"OpenWhisk_CLI","location":"https://github.com/apache/incubator-openwhisk-cli/releases/download/latest"}}}'
+$ANSIBLE_CMD properties.yml
$ANSIBLE_CMD apigateway.yml
$ANSIBLE_CMD routemgmt.yml
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr closed pull request #129: Iam enablement
csantanapr closed pull request #129: Iam enablement
URL: https://github.com/apache/incubator-openwhisk-client-js/pull/129
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/README.md b/README.md
index 74df04e..c790392 100644
--- a/README.md
+++ b/README.md
@@ -64,6 +64,41 @@ var ow = openwhisk(options);
ow.actions.invoke('sample').then(result => console.log(result))
```
+### Using 3rd party Authentication Handler
+You can specify an authentication handler in `options.authHandler` this is a
an object that provides a function `getAuthHeader` that returns a Promise or
String to be used in the `Authorization` header for every http request.
+```javascript
+const authHandler = {
+ getAuthHeader: ()=>{
+return Promise.resolve('Basic user:password')
+ }
+}
+var openwhisk = require('openwhisk');
+var options = {
+ apihost: 'openwhisk.ng.bluemix.net',
+ authHandler: authHandler
+ }
+var ow = openwhisk(options)
+ow.actions.invoke('sample').then(result => console.log(result))
+```
+
+### Example Using a Authentication Handler with IBM IAM
+For example IBM Functions namespaces that required IAM authentcation use the
following:
+```javascript
+const IAM_API_KEY = 'secretkey' //required if environment variable
__OW_IAM_NAMESPACE_API_KEY not set
+const IAM_API_URL = 'https://iam.bluemix.net/identity/token' //optional or set
environment variable __OW_IAM_API_HOST
+var openwhisk = require('openwhisk')
+var authHandler = require('@ibm-functions/iam-token-manager')
+var options = {
+ apihost: 'openwhisk.ng.bluemix.net',
+ authHandler: new authHandler({
+ iamApiKey: IAM_API_KEY,
+ iamUrl: IAM_API_URL
+ })
+ }
+var ow = openwhisk(options)
+ow.actions.invoke('sample').then(result => console.log(result))
+```
+
### constructor options
_Client constructor supports the following mandatory parameters:_
diff --git a/lib/client.js b/lib/client.js
index 48723e3..834226f 100644
--- a/lib/client.js
+++ b/lib/client.js
@@ -66,6 +66,7 @@ class Client {
* @param {boolean} [options.ignore_certs]
* @param {string} [options.apigw_token]
* @param {string} [options.apigw_space_guid]
+ * @param {Function} [options.authHandler]
*/
constructor (options) {
this.options = this.parseOptions(options || {})
@@ -91,13 +92,13 @@ class Client {
apigwSpaceGuid = apiKey.split(':')[0]
}
-if (!apiKey) {
- throw new Error(`${messages.INVALID_OPTIONS_ERROR} Missing api_key
parameter.`)
+if (!apiKey && !options.authHandler) {
+ throw new Error(`${messages.INVALID_OPTIONS_ERROR} Missing api_key
parameter or token plugin.`)
} else if (!api) {
throw new Error(`${messages.INVALID_OPTIONS_ERROR} Missing either api or
apihost parameters.`)
}
-return {apiKey: apiKey, api, ignoreCerts: ignoreCerts, namespace:
options.namespace, apigwToken: apigwToken, apigwSpaceGuid: apigwSpaceGuid}
+return {apiKey: apiKey, api, ignoreCerts: ignoreCerts, namespace:
options.namespace, apigwToken: apigwToken, apigwSpaceGuid: apigwSpaceGuid,
authHandler: options.authHandler}
}
urlFromApihost (apihost) {
@@ -113,21 +114,23 @@ class Client {
}
request (method, path, options) {
-const req = this.params(method, path, options)
-return rp(req).catch(err => this.handleErrors(err))
+const params = this.params(method, path, options)
+return params.then(req => rp(req)).catch(err => this.handleErrors(err))
}
params (method, path, options) {
-return Object.assign({
- json: true,
- method: method,
- url: this.pathUrl(path),
- rejectUnauthorized: !this.options.ignoreCerts,
- headers: {
-'User-Agent': (options && options['User-Agent']) ||
'openwhisk-client-js',
-Authorization: this.authHeader()
- }
-}, options)
+return this.authHeader().then(header => {
+ return Object.assign({
+json: true,
+method: method,
+url: this.pathUrl(path),
+rejectUnauthorized: !this.options.ignoreCerts,
+headers: {
+ 'User-Agent': (options && options['User-Agent']) ||
'openwhisk-client-js',
+ Authorization: header
+}
+ }, options)
+})
}
pathUrl (urlPath) {
@@ -143,10 +146,13 @@ class Client {
}
authHeader () {
-const apiKeyBase64 = Buffer.from(this.options.apiKey).toString('base64')
-return `Basic ${apiKeyBase64}`
+if (this.options.authHandler) {
+ return this.options.authHandler.getAuthHeader()
+} else {
+ const apiKeyBase64 = Buffer.from(this.options.apiKey).toString('base64')
+ return Promise.resolve(`Basic
[GitHub] csantanapr commented on issue #129: Iam enablement
csantanapr commented on issue #129: Iam enablement URL: https://github.com/apache/incubator-openwhisk-client-js/pull/129#issuecomment-412937448 I think there was a mixup with this PR, I will open a new PR with issue later Closing for now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #357: Run the properties.yml playbook in order to create whisk.properties
houshengbo closed pull request #357: Run the properties.yml playbook in order to create whisk.properties URL: https://github.com/apache/incubator-openwhisk-cli/pull/357 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.travis.yml b/.travis.yml index a2e3f7ba..b3458d99 100644 --- a/.travis.yml +++ b/.travis.yml @@ -57,7 +57,8 @@ before_script: - cd $TRAVIS_BUILD_DIR/.. - git clone https://github.com/apache/incubator-openwhisk-utilities.git - git clone https://github.com/apache/incubator-openwhisk.git - - ./incubator-openwhisk/tools/travis/setup.sh + - cd incubator-openwhisk + - ./tools/travis/setup.sh script: - cd $TRAVIS_BUILD_DIR/../incubator-openwhisk diff --git a/tools/travis/test_openwhisk.sh b/tools/travis/test_openwhisk.sh index 94f27253..4af8b03f 100755 --- a/tools/travis/test_openwhisk.sh +++ b/tools/travis/test_openwhisk.sh @@ -94,6 +94,8 @@ $ANSIBLE_CMD initdb.yml $ANSIBLE_CMD apigateway.yml $ANSIBLE_CMD wipe.yml $ANSIBLE_CMD openwhisk.yml -e cli_installation_mode=local -e openwhisk_cli_home=$TRAVIS_BUILD_DIR -e controllerProtocolForSetup=http +$ANSIBLE_CMD properties.yml +$ANSIBLE_CMD routemgmt.yml # Run the test cases under openwhisk to ensure the quality of the runnint API. cd $TRAVIS_BUILD_DIR This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vvraskin closed pull request #78: remove hardcoded env variables for run handler
vvraskin closed pull request #78: remove hardcoded env variables for run handler
URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/78
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/core/nodejsActionBase/src/service.js
b/core/nodejsActionBase/src/service.js
index daf365f..eb99b6e 100644
--- a/core/nodejsActionBase/src/service.js
+++ b/core/nodejsActionBase/src/service.js
@@ -156,12 +156,14 @@ function NodeActionService(config) {
}
function doRun(req) {
-var msg = req.body || {};
-
-var props = [ 'api_key', 'namespace', 'action_name', 'activation_id',
'deadline' ];
-props.map(function (p) {
-process.env['__OW_' + p.toUpperCase()] = msg[p];
-});
+var msg = req && req.body || {};
+Object.keys(msg).forEach(
+function (k) {
+if(typeof msg[k] === 'string' && k !== 'value'){
+process.env['__OW_' + k.toUpperCase()] = msg[k];
+}
+}
+);
return userCodeRunner.run(msg.value).then(function(result) {
if (typeof result !== "object") {
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubee closed pull request #356: Fix deployment
dubee closed pull request #356: Fix deployment URL: https://github.com/apache/incubator-openwhisk-cli/pull/356 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/tools/travis/test_openwhisk.sh b/tools/travis/test_openwhisk.sh index 94f27253..731167cf 100755 --- a/tools/travis/test_openwhisk.sh +++ b/tools/travis/test_openwhisk.sh @@ -91,6 +91,7 @@ $ANSIBLE_CMD setup.yml $ANSIBLE_CMD prereq.yml $ANSIBLE_CMD couchdb.yml $ANSIBLE_CMD initdb.yml +$ANSIBLE_CMD properties.yml $ANSIBLE_CMD apigateway.yml $ANSIBLE_CMD wipe.yml $ANSIBLE_CMD openwhisk.yml -e cli_installation_mode=local -e openwhisk_cli_home=$TRAVIS_BUILD_DIR -e controllerProtocolForSetup=http This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #127: add explicit call to ansible playbook routemgmt.yml
csantanapr closed pull request #127: add explicit call to ansible playbook
routemgmt.yml
URL: https://github.com/apache/incubator-openwhisk-client-js/pull/127
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tools/travis/build.sh b/tools/travis/build.sh
index 5abd836..fab87a4 100755
--- a/tools/travis/build.sh
+++ b/tools/travis/build.sh
@@ -16,7 +16,7 @@ $ANSIBLE_CMD setup.yml
$ANSIBLE_CMD prereq.yml
$ANSIBLE_CMD couchdb.yml
$ANSIBLE_CMD initdb.yml
-$ANSIBLE_CMD apigateway.yml
+
cd $WHISKDIR
./gradlew -PdockerImagePrefix=openwhisk
@@ -24,6 +24,9 @@ cd $WHISKDIR/ansible
$ANSIBLE_CMD wipe.yml
$ANSIBLE_CMD openwhisk.yml -e
'{"openwhisk_cli":{"installation_mode":"remote","remote":{"name":"OpenWhisk_CLI","dest_name":"OpenWhisk_CLI","location":"https://github.com/apache/incubator-openwhisk-cli/releases/download/latest"}}}'
+$ANSIBLE_CMD apigateway.yml
+$ANSIBLE_CMD properties.yml # required for to run before routemgmt.yml
+$ANSIBLE_CMD routemgmt.yml
$ANSIBLE_CMD postdeploy.yml
cd $WHISKDIR
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubee closed pull request #3964: Run properties.yml in openwhisk.yml
dubee closed pull request #3964: Run properties.yml in openwhisk.yml URL: https://github.com/apache/incubator-openwhisk/pull/3964 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/ansible/openwhisk.yml b/ansible/openwhisk.yml index 1e1891..d74e680f3e 100644 --- a/ansible/openwhisk.yml +++ b/ansible/openwhisk.yml @@ -14,4 +14,6 @@ - import_playbook: edge.yml +- import_playbook: properties.yml + - import_playbook: downloadcli.yml This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #283: Run the properties.yml playbook in order to create whisk.properties
houshengbo closed pull request #283: Run the properties.yml playbook in order to create whisk.properties URL: https://github.com/apache/incubator-openwhisk-catalog/pull/283 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/tools/travis/build.sh b/tools/travis/build.sh index 49a68dd..2c43514 100755 --- a/tools/travis/build.sh +++ b/tools/travis/build.sh @@ -51,6 +51,7 @@ cd $WHISKDIR/ansible $ANSIBLE_CMD wipe.yml $ANSIBLE_CMD openwhisk.yml +$ANSIBLE_CMD properties.yml # Set Environment export OPENWHISK_HOME=$WHISKDIR This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jasonpet closed pull request #282: Fix deployment
jasonpet closed pull request #282: Fix deployment URL: https://github.com/apache/incubator-openwhisk-catalog/pull/282 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/tools/travis/build.sh b/tools/travis/build.sh index 49a68dd..cf7be63 100755 --- a/tools/travis/build.sh +++ b/tools/travis/build.sh @@ -42,6 +42,7 @@ $ANSIBLE_CMD setup.yml $ANSIBLE_CMD prereq.yml $ANSIBLE_CMD couchdb.yml $ANSIBLE_CMD initdb.yml +$ANSIBLE_CMD properties.yml cd $WHISKDIR This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jasonpet closed pull request #90: Fix deployment
jasonpet closed pull request #90: Fix deployment URL: https://github.com/apache/incubator-openwhisk-package-pushnotifications/pull/90 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/tools/travis/build.sh b/tools/travis/build.sh index a191428..2d74122 100755 --- a/tools/travis/build.sh +++ b/tools/travis/build.sh @@ -20,6 +20,7 @@ $ANSIBLE_CMD setup.yml $ANSIBLE_CMD prereq.yml $ANSIBLE_CMD couchdb.yml $ANSIBLE_CMD initdb.yml +$ANSIBLE_CMD properties.yml cd $WHISKDIR This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #357: Run the properties.yml playbook in order to create whisk.properties
houshengbo opened a new pull request #357: Run the properties.yml playbook in order to create whisk.properties URL: https://github.com/apache/incubator-openwhisk-cli/pull/357 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #283: Remove the dependency on whisk.properties
houshengbo opened a new pull request #283: Remove the dependency on whisk.properties URL: https://github.com/apache/incubator-openwhisk-catalog/pull/283 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vvraskin closed pull request #67: remove hardcoded env variables for run handler
vvraskin closed pull request #67: remove hardcoded env variables for run handler
URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/67
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/core/java8/proxy/src/main/java/openwhisk/java/action/Proxy.java
b/core/java8/proxy/src/main/java/openwhisk/java/action/Proxy.java
index dc6c861..209f436 100644
--- a/core/java8/proxy/src/main/java/openwhisk/java/action/Proxy.java
+++ b/core/java8/proxy/src/main/java/openwhisk/java/action/Proxy.java
@@ -28,6 +28,8 @@
import java.nio.charset.StandardCharsets;
import java.nio.file.Path;
import java.util.HashMap;
+import java.util.Map;
+import java.util.Set;
import com.google.gson.JsonElement;
import com.google.gson.JsonObject;
@@ -136,14 +138,15 @@ public void handle(HttpExchange t) throws IOException {
try {
InputStream is = t.getRequestBody();
JsonParser parser = new JsonParser();
-JsonElement ie = parser.parse(new BufferedReader(new
InputStreamReader(is, StandardCharsets.UTF_8)));
-JsonObject inputObject =
ie.getAsJsonObject().getAsJsonObject("value");
+JsonObject body = parser.parse(new BufferedReader(new
InputStreamReader(is, StandardCharsets.UTF_8))).getAsJsonObject();
+JsonObject inputObject = body.getAsJsonObject("value");
HashMap env = new HashMap();
-for (String p : new String[] { "api_key", "namespace",
"action_name", "activation_id", "deadline" }) {
+Set> entrySet = body.entrySet();
+for(Map.Entry entry : entrySet){
try {
-String val =
ie.getAsJsonObject().getAsJsonPrimitive(p).getAsString();
-env.put(String.format("__OW_%s", p.toUpperCase()),
val);
+if(!entry.getKey().equalsIgnoreCase("value"))
+env.put(String.format("__OW_%s",
entry.getKey().toUpperCase()), entry.getValue().getAsString());
} catch (Exception e) {}
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] vvraskin closed pull request #55: remove hardcoded env variables for run handler
vvraskin closed pull request #55: remove hardcoded env variables for run handler URL: https://github.com/apache/incubator-openwhisk-runtime-docker/pull/55 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/core/actionProxy/actionproxy.py b/core/actionProxy/actionproxy.py index 9d34776..9d723a5 100644 --- a/core/actionProxy/actionproxy.py +++ b/core/actionProxy/actionproxy.py @@ -109,9 +109,9 @@ def verify(self): def env(self, message): # make sure to include all the env vars passed in by the invoker env = os.environ -for p in ['api_key', 'namespace', 'action_name', 'activation_id', 'deadline']: -if p in message: -env['__OW_%s' % p.upper()] = message[p] +for k, v in message.items(): +if k != 'value': +env['__OW_%s' % k.upper()] = v return env # runs the action, called iff self.verify() is True. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vvraskin closed pull request #7: remove hardcoded env variables for run handler
vvraskin closed pull request #7: remove hardcoded env variables for run handler
URL: https://github.com/apache/incubator-openwhisk-runtime-ballerina/pull/7
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/ballerina/proxy/src/main/java/org/ballerinalang/openwhisk/runtime/BallerinaProxy.java
b/ballerina/proxy/src/main/java/org/ballerinalang/openwhisk/runtime/BallerinaProxy.java
index f03366e..1734ad0 100644
---
a/ballerina/proxy/src/main/java/org/ballerinalang/openwhisk/runtime/BallerinaProxy.java
+++
b/ballerina/proxy/src/main/java/org/ballerinalang/openwhisk/runtime/BallerinaProxy.java
@@ -17,6 +17,7 @@
package org.ballerinalang.openwhisk.runtime;
+import com.google.gson.JsonElement;
import com.google.gson.JsonObject;
import org.ballerinalang.BLangProgramLoader;
import org.ballerinalang.logging.BLogManager;
@@ -38,6 +39,7 @@
import java.util.Map;
import java.util.Optional;
import java.util.logging.LogManager;
+import java.util.Set;
import javax.ws.rs.POST;
import javax.ws.rs.Path;
import javax.ws.rs.core.Context;
@@ -168,11 +170,12 @@ public Response run(@Context Request request) {
*/
@SuppressWarnings({ "unchecked", "rawtypes" })
private static void augmentEnv(JsonObject requestElements) {
-HashMap env = new HashMap<>();
-for (String p : new String[] { "api_key", "namespace", "action_name",
"activation_id", "deadline" }) {
+HashMap env = new HashMap();
+Set> entrySet =
requestElements.entrySet();
+for(Map.Entry entry : entrySet){
try {
-String val =
requestElements.getAsJsonPrimitive(p).getAsString();
-env.put(String.format("__OW_%s", p.toUpperCase()), val);
+if(!entry.getKey().equalsIgnoreCase("value"))
+env.put(String.format("__OW_%s",
entry.getKey().toUpperCase()), entry.getValue().getAsString());
} catch (Exception ignored) {
}
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] chetanmeh commented on a change in pull request #3886: Proposing Lean OpenWhisk
chetanmeh commented on a change in pull request #3886: Proposing Lean OpenWhisk
URL:
https://github.com/apache/incubator-openwhisk/pull/3886#discussion_r209957227
##
File path: common/scala/src/main/scala/whisk/connector/lean/LeanConsumer.scala
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.connector.lean
+
+import scala.concurrent.duration._
+import whisk.common.Logging
+import whisk.core.connector.MessageConsumer
+import java.util.concurrent.BlockingQueue
+import java.util.concurrent.TimeUnit
+
+class LeanConsumer(queue: BlockingQueue[Array[Byte]], override val maxPeek:
Int)(implicit logging: Logging)
+extends MessageConsumer {
+
+ /**
+ */
+ override def peek(duration: FiniteDuration, retry: Int): Iterable[(String,
Int, Long, Array[Byte])] = {
Review comment:
@kpavel That helps. I missed on fact that `peek` is designed for long poll.
In such a case your previous poll based approach would then be better. Looks
like default java support does not have [drainTo with wait][1]. Guava seems to
provide [one][2]
[1]:
https://stackoverflow.com/questions/831834/blockingqueue-blocked-drainto-methods
[2]:
https://google.github.io/guava/releases/snapshot-jre/api/docs/com/google/common/collect/Queues.html#drain-java.util.concurrent.BlockingQueue-java.util.Collection-int-long-java.util.concurrent.TimeUnit-
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] vvraskin closed pull request #10: remove hardcoded env variables for run handler
vvraskin closed pull request #10: remove hardcoded env variables for run handler
URL: https://github.com/apache/incubator-openwhisk-runtime-ruby/pull/10
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/core/ruby2.5Action/rackapp/run.rb
b/core/ruby2.5Action/rackapp/run.rb
index c4699d2..6fdb68d 100644
--- a/core/ruby2.5Action/rackapp/run.rb
+++ b/core/ruby2.5Action/rackapp/run.rb
@@ -14,9 +14,11 @@ def call(env)
body = Rack::Request.new(env).body.read
data = JSON.parse(body) || {}
env = {'BUNDLE_GEMFILE' => PROGRAM_DIR + 'Gemfile'}
-['api_key', 'namespace', 'action_name', 'activation_id',
'deadline'].each{|e|
- env["__OW_#{e.upcase}"] = data[e] if data[e] && data[e].is_a?(String)
-}
+data.each do |key, value|
+ if key != 'value'
+env["__OW_#{key.upcase}"] = value if value && value.is_a?(String)
+ end
+end
# Save parameter values to file in order to let runner.rb read this later
File.write PARAM, data['value'].to_json
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] chetanmeh commented on a change in pull request #3886: Proposing Lean OpenWhisk
chetanmeh commented on a change in pull request #3886: Proposing Lean OpenWhisk
URL:
https://github.com/apache/incubator-openwhisk/pull/3886#discussion_r209957227
##
File path: common/scala/src/main/scala/whisk/connector/lean/LeanConsumer.scala
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.connector.lean
+
+import scala.concurrent.duration._
+import whisk.common.Logging
+import whisk.core.connector.MessageConsumer
+import java.util.concurrent.BlockingQueue
+import java.util.concurrent.TimeUnit
+
+class LeanConsumer(queue: BlockingQueue[Array[Byte]], override val maxPeek:
Int)(implicit logging: Logging)
+extends MessageConsumer {
+
+ /**
+ */
+ override def peek(duration: FiniteDuration, retry: Int): Iterable[(String,
Int, Long, Array[Byte])] = {
Review comment:
@kpavel That helps. I missed on fact that `peek` is designed for long poll.
In such a case you previous poll based approach would then be better. Looks
like default java support does not have [drainTo with wait][1]. Guava seems to
provide [one][2]
[1]:
https://stackoverflow.com/questions/831834/blockingqueue-blocked-drainto-methods
[2]:
https://google.github.io/guava/releases/snapshot-jre/api/docs/com/google/common/collect/Queues.html#drain-java.util.concurrent.BlockingQueue-java.util.Collection-int-long-java.util.concurrent.TimeUnit-
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dgrove-oss commented on issue #3966: Conductor action returns "application error" when continuation function throws an uncaught exception
dgrove-oss commented on issue #3966: Conductor action returns "application error" when continuation function throws an uncaught exception URL: https://github.com/apache/incubator-openwhisk/issues/3966#issuecomment-412876391 @tardieu is the expert, but is on vacation. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3945: Treat action code as attachments
rabbah commented on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-412873725 What are you hoping to show? The real factor is the size of the Inlined code. If you have to do a fetch for the attachment it’s self evident the cost is additive. Having the size of the average code size and perhaps one std dev would be more informative imo. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #3945: Treat action code as attachments
dubee commented on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-412872766 @chetanmeh, I'll run some performances tests on this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk
kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk
URL:
https://github.com/apache/incubator-openwhisk/pull/3886#discussion_r209951038
##
File path: common/scala/src/main/scala/whisk/connector/lean/LeanConsumer.scala
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.connector.lean
+
+import scala.concurrent.duration._
+import whisk.common.Logging
+import whisk.core.connector.MessageConsumer
+import java.util.concurrent.BlockingQueue
+import java.util.concurrent.TimeUnit
+
+class LeanConsumer(queue: BlockingQueue[Array[Byte]], override val maxPeek:
Int)(implicit logging: Logging)
+extends MessageConsumer {
+
+ /**
+ */
+ override def peek(duration: FiniteDuration, retry: Int): Iterable[(String,
Int, Long, Array[Byte])] = {
Review comment:
@chetanmeh Without sleep it becomes a busy wait, presenting heavy impact on
cpu usage. While testing locally, idle controller container shows about
200-300% cpu usage in case of using drainTo() without sleep. It shows about 1%
cpu usage when using poll().
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dgrove-oss commented on issue #3963: k8s: implement invoker-node affinity and eliminate usage of kubectl
dgrove-oss commented on issue #3963: k8s: implement invoker-node affinity and eliminate usage of kubectl URL: https://github.com/apache/incubator-openwhisk/pull/3963#issuecomment-412871871 I was going to stage it in a separate PR to make it easier to find and revert just that piece in case we wanted the binary back later (or it was being used in openshift in some way I wasn't aware of). I could remove the binary from the Dockerfile in this PR if you'd prefer a single PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee edited a comment on issue #33: Fix deployment failure
dubee edited a comment on issue #33: Fix deployment failure URL: https://github.com/apache/incubator-openwhisk-package-deploy/pull/33#issuecomment-412869798 Closing this one for https://github.com/apache/incubator-openwhisk-package-deploy/pull/31 as that has another fix for Travis as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee closed pull request #31: WIP: remove base64 encoding
dubee closed pull request #31: WIP: remove base64 encoding
URL: https://github.com/apache/incubator-openwhisk-package-deploy/pull/31
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/packages/actions/deployWeb.js b/packages/actions/deployWeb.js
index 282a9ae..a631477 100644
--- a/packages/actions/deployWeb.js
+++ b/packages/actions/deployWeb.js
@@ -75,7 +75,7 @@ function main(params) {
resolve({
statusCode: 200,
headers: { 'Content-Type': 'application/json' },
-body: Buffer.from(JSON.stringify({ status: success, activationId
})).toString('base64'),
+body: { status: success, activationId },
});
}))
.catch(err => (sendError(400, err)));
@@ -120,7 +120,7 @@ function sendError(statusCode, err, message) {
return {
statusCode,
headers: { 'Content-Type': 'application/json' },
-body: Buffer.from(JSON.stringify(params)).toString('base64'),
+body: params,
};
}
diff --git a/tests/src/test/scala/packages/deployWebTests.scala
b/tests/src/test/scala/packages/deployWebTests.scala
index 054aa06..0ffbed2 100644
--- a/tests/src/test/scala/packages/deployWebTests.scala
+++ b/tests/src/test/scala/packages/deployWebTests.scala
@@ -52,9 +52,10 @@ class DeployWebTests extends TestHelpers
val helloWorldActionPackage = "myPackage/helloworld"
// statuses from deployWeb
-val successStatus = status":"success
+val successStatus = status": "success
val activationId = activationId:
-val githubNonExistentStatus = error":"There was a problem cloning from
github. Does that github repo exist? Does it begin with http?
+val githubNonExistentStatus = error": "There was a problem cloning
from github. Does that github repo exist? Does it begin with http?
+val errorLoadingManifestStatus = error": "Error loading manifest file.
Does a manifest file exist?
def makePostCallWithExpectedResult(params: JsObject, expectedResult:
String, expectedCode: Int) = {
val response = RestAssured.given()
@@ -107,7 +108,7 @@ class DeployWebTests extends TestHelpers
"manifestPath" -> JsString(helloWorldPath),
"wskApiHost" -> JsString(wskprops.apihost),
"wskAuth" -> JsString(wskprops.authKey)
- ), error":"Please enter the GitHub repo url in params, 400)
+ ), error": "Please enter the GitHub repo url in params, 400)
}
// test to create a template with a nonexistant github repo provided
@@ -141,7 +142,7 @@ class DeployWebTests extends TestHelpers
"manifestPath" -> JsString(incorrectManifestPath),
"wskApiHost" -> JsString(wskprops.apihost),
"wskAuth" -> JsString(wskprops.authKey)
- ), error":"Error loading manifest file. Does a manifest file
exist?, 400)
+ ), errorLoadingManifestStatus, 400)
}
// test to create a template with manifestPath provided, but no
manifestFile existing
@@ -151,6 +152,6 @@ class DeployWebTests extends TestHelpers
"manifestPath" -> JsString(helloWorldWithNoManifest),
"wskApiHost" -> JsString(wskprops.apihost),
"wskAuth" -> JsString(wskprops.authKey)
- ), error":"Error loading manifest file. Does a manifest file
exist?, 400)
+ ), errorLoadingManifestStatus, 400)
}
}
diff --git a/tools/travis/build.sh b/tools/travis/build.sh
index 65977f8..3b2430f 100755
--- a/tools/travis/build.sh
+++ b/tools/travis/build.sh
@@ -40,6 +40,7 @@ cd $WHISKDIR/ansible
$ANSIBLE_CMD wipe.yml
$ANSIBLE_CMD openwhisk.yml
+$ANSIBLE_CMD properties.yml
# Set Environment
export OPENWHISK_HOME=$WHISKDIR
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubee closed pull request #33: Fix deployment failure
dubee closed pull request #33: Fix deployment failure URL: https://github.com/apache/incubator-openwhisk-package-deploy/pull/33 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/tools/travis/build.sh b/tools/travis/build.sh index 65977f8..3b2430f 100755 --- a/tools/travis/build.sh +++ b/tools/travis/build.sh @@ -40,6 +40,7 @@ cd $WHISKDIR/ansible $ANSIBLE_CMD wipe.yml $ANSIBLE_CMD openwhisk.yml +$ANSIBLE_CMD properties.yml # Set Environment export OPENWHISK_HOME=$WHISKDIR This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #33: Fix deployment failure
dubee commented on issue #33: Fix deployment failure URL: https://github.com/apache/incubator-openwhisk-package-deploy/pull/33#issuecomment-412869798 Closing this one for https://github.com/apache/incubator-openwhisk-package-deploy/pull/33 as that has another fix for Travis as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #3945: Treat action code as attachments
codecov-io edited a comment on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-410980593 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=h1) Report > Merging [#3945](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/7b5d8057ca9dcae9ae170318c39387a3fb684f67?src=pr=desc) will **decrease** coverage by `4.91%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3945 +/- ## == - Coverage 85.44% 80.52% -4.92% == Files 146 146 Lines7057 7056 -1 Branches 413 422 +9 == - Hits 6030 5682 -348 - Misses 1027 1374 +347 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../scala/src/main/scala/whisk/core/entity/Exec.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWMuc2NhbGE=) | `84.96% <100%> (+0.55%)` | :arrow_up: | | [...src/main/scala/whisk/core/entity/WhiskAction.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1doaXNrQWN0aW9uLnNjYWxh) | `86.09% <100%> (ø)` | :arrow_up: | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.1%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-81.82%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-58.83%)` | :arrow_down: | | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `58.82% <0%> (-15.13%)` | :arrow_down: | | [...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | | ... and [1 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=footer). Last update [7b5d805...ac5baab](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact
[GitHub] chetanmeh commented on issue #3945: Treat action code as attachments
chetanmeh commented on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-412835996 > you may want to alert the dev-list about this change as it is rather significant. I have sent a mail [on dev][1] sometime back about this change ... would that be ok?. I can also highlight this on wednesday call > have you run performance tests against this to detect any cold start regressions that may arise from the double database fetch? @dubee I modified the `ColdBlockingInvokeSimulation` to support tweaking the code size. So one can run this like below which would result in using a 100kb code size and thus use of attachmentMode. Note that default `max-inline-size` is 16kb so we need a value higher than that default size ``` OPENWHISK_HOST="server" USERS="1" REQUESTS_PER_SEC="1" SECONDS="30" CODE_SIZE="10" ./gradlew gatlingRun-ColdBlockingInvokeSimulation ``` I tried to run the tests but the numbers are not stable | Pre Change | Post Change | |---|---| ||| Numbers for * 1MB code * 30 sec run Below is aggregated stats https://user-images.githubusercontent.com/664531/44088129-a16e683c-9fdf-11e8-9d5f-0c70cdc8c510.png;> As these are run on a local setup with all OpenWhisk component running on same host (client on another) they would not convey any real value. To get true sense of impact we would need to run same test on a more prod like setup where CouchDB is remote and also bit populated otherwise it would be streaming stuff from memory! Unfortunately I do not have access to such a setup so would not be able to get such numbers. [1]: https://lists.apache.org/thread.html/290fbc7cfa54071754afdb62b383018a52586a0953bddebcde500072@%3Cdev.openwhisk.apache.org%3E This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on a change in pull request #3945: Treat action code as attachments
chetanmeh commented on a change in pull request #3945: Treat action code as
attachments
URL:
https://github.com/apache/incubator-openwhisk/pull/3945#discussion_r209908932
##
File path: ansible/files/runtimes.json
##
@@ -115,8 +155,8 @@
},
"deprecated": false,
"attached": {
-"attachmentName": "jarfile",
-"attachmentType": "application/java-archive"
+"attachmentName": "codefile",
+"attachmentType": "text/plain"
Review comment:
Yes `attachmentName` and `attachmentType` are not used in actual flow.
ContentType is just stored but not interpreted so far for any purpose
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] codecov-io edited a comment on issue #3950: Extend system testsuite
codecov-io edited a comment on issue #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#issuecomment-411691678 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950?src=pr=h1) Report > Merging [#3950](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/f365d1c84ce5d8595fb686ecd4a8ef9220b23c6b?src=pr=desc) will **decrease** coverage by `4.61%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3950 +/- ## == - Coverage85.2% 80.58% -4.62% == Files 146 146 Lines7057 7057 Branches 413 413 == - Hits 6013 5687 -326 - Misses 1044 1370 +326 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950?src=pr=tree) | Coverage Δ | | |---|---|---| | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.1%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-81.82%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-58.83%)` | :arrow_down: | | [...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | | [...rc/main/scala/whisk/common/ForcibleSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjaWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `88.46% <0%> (-3.85%)` | :arrow_down: | | [...whisk/connector/kafka/KafkaProducerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYVByb2R1Y2VyQ29ubmVjdG9yLnNjYWxh) | `91.89% <0%> (+16.21%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950?src=pr=footer). Last update [f365d1c...1b432c5](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3950: Extend system testsuite
rabbah commented on a change in pull request #3950: Extend system testsuite
URL:
https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r209907128
##
File path: tests/src/test/scala/system/basic/WskActionTests.scala
##
@@ -210,6 +253,32 @@ class WskActionTests extends TestHelpers with
WskTestHelpers with JsHelpers with
}
}
+ it should "update an action with different language and check preserving
params" in withAssetCleaner(wskprops) {
+(wp, assetHelper) =>
+ val name = "updatedAction"
+
+ assetHelper.withCleaner(wsk.action, name, false) { (action, _) =>
+wsk.action.create(
+ name,
+ Some(TestUtils.getTestActionFilename("hello.js")),
+ parameters = Map("name" -> testString.toJson)) //unused in the first
function
+ }
+
+ val run1 = wsk.action.invoke(name, Map("payload" -> testString.toJson))
+ withActivation(wsk.activation, run1) { activation =>
+activation.response.status shouldBe "success"
+activation.logs.get.mkString(" ") should include(s"hello, $testString")
+ }
+
+ wsk.action.create(name,
Some(TestUtils.getTestActionFilename("hello.py")), update = true)
+
+ val run2 = wsk.action.invoke(name)
+ withActivation(wsk.activation, run2) { activation =>
+activation.response.status shouldBe "success"
+activation.logs.get.mkString(" ") should include(s"Hello $testString")
+ }
Review comment:
fair - I think the api test iirc (didn’t verify again) checks with the
parameters with a get instead of invoke.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah edited a comment on issue #3945: Treat action code as attachments
rabbah edited a comment on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-412829747 lgtm. As for the performance impact, sure two fetches will be slower than one. The size of the inline chunk could be controlled to tune the performance hit (ie based on expected size of code for example). Also whatever comparison in performance will likely not match a production environment and hence skewed. Lastly this is the direction we need to go toward for streaming in any case. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3945: Treat action code as attachments
rabbah commented on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-412829747 lgtm. As for the performance impact, sure two fetches will be slower than one. The size of the inline chunk could be controlled to tune the performance hit (ie based on expected size of code for example). Also whatever compression in performance will likely not match a production environment and hence skewed. Lastly this is the direction we need to go toward for streaming in any case. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3965: Provide command to update namespace key in wskadmin-next
rabbah commented on issue #3965: Provide command to update namespace key in wskadmin-next URL: https://github.com/apache/incubator-openwhisk/issues/3965#issuecomment-412826458 Do you mean to set the uuid and key or just the key? Can we add a revoke flag to change just the key? This is handy. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3671: Activation id in header
rabbah commented on a change in pull request #3671: Activation id in header URL: https://github.com/apache/incubator-openwhisk/pull/3671#discussion_r209901222 ## File path: tests/src/test/scala/whisk/core/controller/test/ControllerTestCommon.scala ## @@ -89,6 +89,8 @@ protected trait ControllerTestCommon val logStore = SpiLoader.get[LogStoreProvider].instance(actorSystem) val activationStore = SpiLoader.get[ActivationStoreProvider].instance(actorSystem, materializer, logging) + val ActivationIdHeaderInLowercase = ActivationIdHeader.toLowerCase + Review comment: Is this used? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3671: Activation id in header
rabbah commented on a change in pull request #3671: Activation id in header
URL:
https://github.com/apache/incubator-openwhisk/pull/3671#discussion_r209900948
##
File path:
tests/src/test/scala/whisk/core/controller/test/ActionsApiTests.scala
##
@@ -1285,13 +1291,17 @@ class ActionsApiTests extends ControllerTestCommon
with WhiskActionsApi {
// will not wait long enough should get accepted status
Post(s"$collectionPath/${action.name}?blocking=true=100") ~>
Route.seal(routes(creds)) ~> check {
status shouldBe Accepted
+headers should contain(RawHeader(ActivationIdHeader,
response.fields("activationId").convertTo[String]))
+
}
// repeat this time wait longer than active ack delay
Post(s"$collectionPath/${action.name}?blocking=true=500") ~>
Route.seal(routes(creds)) ~> check {
status shouldBe OK
val response = responseAs[JsObject]
response shouldBe activation.withoutLogs.toExtendedJson
+headers should contain(RawHeader(ActivationIdHeader,
response.fields("activationId").convertTo[String]))
+
Review comment:
Extra line.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3950: Extend system testsuite
rabbah commented on a change in pull request #3950: Extend system testsuite
URL:
https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r209900210
##
File path: tests/src/test/scala/whisk/core/cli/test/WskEntitlementTests.scala
##
@@ -160,6 +160,46 @@ abstract class WskEntitlementTests extends TestHelpers
with WskTestHelpers with
}
}
+ it should "list shared packages when package is turned into public" in
withAssetCleaner(guestWskProps) {
+(wp, assetHelper) =>
+ assetHelper.withCleaner(wsk.pkg, samplePackage) { (pkg, _) =>
+pkg.create(samplePackage)(wp)
+ }
+
+ retry {
+val packageList =
wsk.pkg.list(Some(s"/$guestNamespace"))(defaultWskProps)
+verifyPackageNotSharedList(packageList, guestNamespace, samplePackage)
+ }
+
+ wsk.pkg.create(samplePackage, update = true, shared = Some(true))(wp)
+
+ retry {
+val packageList =
wsk.pkg.list(Some(s"/$guestNamespace"))(defaultWskProps)
+verifyPackageSharedList(packageList, guestNamespace, samplePackage)
+ }
+ }
+
+ it should "not list any packages from invalid namespace" in
withAssetCleaner(guestWskProps) { (wp, assetHelper) =>
+val invalidNamespace = "whisk.systsdf"
+retry {
+ val packageList = wsk.pkg.list(Some(s"/$invalidNamespace"))(wp)
+ packageList.stdout should be("[]") //empty list
+}
+ }
+
+ it should "reject getting package from invalid namespace" in
withAssetCleaner(guestWskProps) { (wp, assetHelper) =>
+val invalidNamespace = "whisk.systsdf"
+wsk.pkg.get(s"/${invalidNamespace}/utils", expectedExitCode =
forbiddenCode)(wp).stderr should include(
+ "not authorized")
+ }
+
+ it should "reject getting invalid package from valid namespace" in
withAssetCleaner(guestWskProps) {
+(wp, assetHelper) =>
+ val invalidPackage = "util"
+ wsk.pkg.get(s"/whisk.system/${invalidPackage}", expectedExitCode =
forbiddenCode)(wp).stderr should include(
+"not authorized")
+ }
Review comment:
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3950: Extend system testsuite
rabbah commented on a change in pull request #3950: Extend system testsuite
URL:
https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r20980
##
File path: tests/src/test/scala/common/rest/WskRestOperations.scala
##
@@ -733,13 +738,23 @@ class RestActivationOperations(implicit val actorSystem:
ActorSystem)
fieldFilter: Option[String] = None,
last: Option[Boolean] = None,
summary: Option[Boolean] = None)(implicit wp: WskProps):
RestResult = {
-val rr = activationId match {
+val actId = activationId match {
+ case Some(id) => activationId
+ case None =>
+last match {
Review comment:
The value of the “last” activation might be the last id indexed not
necessarily the last id stored. This is fine for your test related changes from
what I scanned but felt it necessary to mention it as this behavior of last
isn’t generally obvious.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3950: Extend system testsuite
rabbah commented on a change in pull request #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r209899618 ## File path: tests/src/test/scala/system/basic/WskActionTests.scala ## @@ -71,6 +71,21 @@ class WskActionTests extends TestHelpers with WskTestHelpers with JsHelpers with } } + it should "invoke an action that throws an uncaught exception and returns correct status code" in withAssetCleaner( Review comment: That’s fine. There are “basic” action tests in core that do the same. Historically the system package implied tests might be used to check the health of a deployment. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3950: Extend system testsuite
markusthoemmes commented on a change in pull request #3950: Extend system
testsuite
URL:
https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r209898213
##
File path: tests/src/test/scala/whisk/core/cli/test/WskEntitlementTests.scala
##
@@ -160,6 +160,46 @@ abstract class WskEntitlementTests extends TestHelpers
with WskTestHelpers with
}
}
+ it should "list shared packages when package is turned into public" in
withAssetCleaner(guestWskProps) {
+(wp, assetHelper) =>
+ assetHelper.withCleaner(wsk.pkg, samplePackage) { (pkg, _) =>
+pkg.create(samplePackage)(wp)
+ }
+
+ retry {
+val packageList =
wsk.pkg.list(Some(s"/$guestNamespace"))(defaultWskProps)
+verifyPackageNotSharedList(packageList, guestNamespace, samplePackage)
+ }
+
+ wsk.pkg.create(samplePackage, update = true, shared = Some(true))(wp)
+
+ retry {
+val packageList =
wsk.pkg.list(Some(s"/$guestNamespace"))(defaultWskProps)
+verifyPackageSharedList(packageList, guestNamespace, samplePackage)
+ }
+ }
+
+ it should "not list any packages from invalid namespace" in
withAssetCleaner(guestWskProps) { (wp, assetHelper) =>
+val invalidNamespace = "whisk.systsdf"
+retry {
+ val packageList = wsk.pkg.list(Some(s"/$invalidNamespace"))(wp)
+ packageList.stdout should be("[]") //empty list
+}
+ }
+
+ it should "reject getting package from invalid namespace" in
withAssetCleaner(guestWskProps) { (wp, assetHelper) =>
+val invalidNamespace = "whisk.systsdf"
+wsk.pkg.get(s"/${invalidNamespace}/utils", expectedExitCode =
forbiddenCode)(wp).stderr should include(
+ "not authorized")
+ }
+
+ it should "reject getting invalid package from valid namespace" in
withAssetCleaner(guestWskProps) {
+(wp, assetHelper) =>
+ val invalidPackage = "util"
+ wsk.pkg.get(s"/whisk.system/${invalidPackage}", expectedExitCode =
forbiddenCode)(wp).stderr should include(
+"not authorized")
+ }
Review comment:
I looked briefly into this. Ben's interface essentially needs an HttpRequest
and its corresponding HttpResponse, both of which are available in the unit
tests as well. @mgencur already opened an issue (#3959) to track that work. We
agreed to defer that to a followup PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mgencur commented on issue #3950: Extend system testsuite
mgencur commented on issue #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#issuecomment-412822267 Added a few minor fixes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3950: Extend system testsuite
markusthoemmes commented on a change in pull request #3950: Extend system
testsuite
URL:
https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r209897675
##
File path: tests/src/test/scala/common/rest/WskRestOperations.scala
##
@@ -733,13 +738,23 @@ class RestActivationOperations(implicit val actorSystem:
ActorSystem)
fieldFilter: Option[String] = None,
last: Option[Boolean] = None,
summary: Option[Boolean] = None)(implicit wp: WskProps):
RestResult = {
-val rr = activationId match {
+val actId = activationId match {
+ case Some(id) => activationId
+ case None =>
+last match {
+ case Some(true) => {
+val activations = pollFor(N = 1, entity = None, limit = Some(1))
+require(activations.size <= 1)
+if (activations.isEmpty) None else Some(activations.head)
+ }
+ case _ => None
Review comment:
Right, this can be rewritten to:
```scala
val actId = activationId.orElse(last.filter(_ == true).flatMap { _ =>
val activations = pollFor(N = 1, entity = None, limit = Some(1))
require(activations.size <= 1)
activations.headOption
})
```
`orElse` returns the value of the first option (activationId in your case)
or falls back to a second option.
`filter` on an option returns a None if the filter is not fullfilled.
`headOption` returns the head of a list, if its non-empty, otherwise None.
Optional to implement, just mentioning how combinators could be used here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3945: Treat action code as attachments
rabbah commented on a change in pull request #3945: Treat action code as
attachments
URL:
https://github.com/apache/incubator-openwhisk/pull/3945#discussion_r209894353
##
File path: ansible/files/runtimes.json
##
@@ -115,8 +155,8 @@
},
"deprecated": false,
"attached": {
-"attachmentName": "jarfile",
-"attachmentType": "application/java-archive"
+"attachmentName": "codefile",
+"attachmentType": "text/plain"
Review comment:
This won’t break pre-existing java actions I presume.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3945: Treat action code as attachments
rabbah commented on a change in pull request #3945: Treat action code as
attachments
URL:
https://github.com/apache/incubator-openwhisk/pull/3945#discussion_r209896365
##
File path:
tests/src/test/scala/whisk/core/controller/test/ActionsApiTests.scala
##
@@ -1063,6 +1073,73 @@ class ActionsApiTests extends ControllerTestCommon with
WhiskActionsApi {
stream.reset()
}
+ it should "ensure old and new action schemas are supported" in {
+implicit val tid = transid()
Review comment:
Great! Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3945: Treat action code as attachments
rabbah commented on a change in pull request #3945: Treat action code as
attachments
URL:
https://github.com/apache/incubator-openwhisk/pull/3945#discussion_r209894602
##
File path: common/scala/src/main/scala/whisk/core/entity/Exec.scala
##
@@ -301,22 +301,24 @@ protected[core] object Exec extends ArgNormalizer[Exec]
with DefaultJsonProtocol
}
manifest.attached
-.map { a =>
- val jar: Attachment[String] = {
-// java actions once stored the attachment in "jar" instead of
"code"
-obj.fields.get("code").orElse(obj.fields.get("jar"))
- } map {
-attFmt[String].read(_)
- } getOrElse {
+.map { _ =>
+ // java actions once stored the attachment in "jar" instead of
"code"
+ val code =
obj.fields.get("code").orElse(obj.fields.get("jar")).getOrElse {
Review comment:
Maybe we can remove this code or jar (separately). It’s been a long time
since I made this schema change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3945: Treat action code as attachments
rabbah commented on a change in pull request #3945: Treat action code as
attachments
URL:
https://github.com/apache/incubator-openwhisk/pull/3945#discussion_r209897231
##
File path: tests/src/test/scala/whisk/core/entity/test/ExecTests.scala
##
@@ -0,0 +1,175 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.entity.test
+
+import common.StreamLogging
+import spray.json._
+import org.junit.runner.RunWith
+import org.scalatest.junit.JUnitRunner
+import org.scalatest.{BeforeAndAfterAll, FlatSpec, Matchers}
+import whisk.core.WhiskConfig
+import whisk.core.entity.Attachments.{Attached, Inline}
+import whisk.core.entity.{CodeExecAsAttachment, CodeExecAsString, Exec,
ExecManifest, WhiskAction}
+
+import scala.collection.mutable
+
+@RunWith(classOf[JUnitRunner])
+class ExecTests extends FlatSpec with Matchers with StreamLogging with
BeforeAndAfterAll {
+ behavior of "exec deserialization"
+
+ val config = new WhiskConfig(ExecManifest.requiredProperties)
+ ExecManifest.initialize(config)
+
+ override protected def afterAll(): Unit = {
+ExecManifest.initialize(config)
+super.afterAll()
+ }
+
+ it should "read existing code string as attachment" in {
+val json = """{
+ | "name": "action_tests_name2",
+ | "_id":
"anon-Yzycx8QnIYDp3Tby0Fnj23KcMtH/action_tests_name2",
+ | "publish": false,
+ | "annotations": [],
+ | "version": "0.0.1",
+ | "updated": 1533623651650,
+ | "entityType": "action",
+ | "exec": {
+ |"kind": "nodejs:6",
+ |"code": "foo",
+ |"binary": false
+ | },
+ | "parameters": [
+ |{
+ | "key": "x",
+ | "value": "b"
+ |}
+ | ],
+ | "limits": {
+ |"timeout": 6,
+ |"memory": 256,
+ |"logs": 10
+ | },
+ | "namespace": "anon-Yzycx8QnIYDp3Tby0Fnj23KcMtH"
+ |}""".stripMargin.parseJson.asJsObject
+val action = WhiskAction.serdes.read(json)
+action.exec should matchPattern { case CodeExecAsAttachment(_,
Inline("foo"), None, false) => }
+ }
+
+ it should "properly determine binary property" in {
+val j1 = """{
+ | "kind": "nodejs:6",
+ | "code": "SGVsbG8gT3BlbldoaXNr",
+ | "binary": false
+ |}""".stripMargin.parseJson.asJsObject
+Exec.serdes.read(j1) should matchPattern {
+ case CodeExecAsAttachment(_, Inline("SGVsbG8gT3BlbldoaXNr"), None, true)
=>
+}
+
+val j2 = """{
+ | "kind": "nodejs:6",
+ | "code": "while (true)",
+ | "binary": false
+ |}""".stripMargin.parseJson.asJsObject
+Exec.serdes.read(j2) should matchPattern {
+ case CodeExecAsAttachment(_, Inline("while (true)"), None, false) =>
+}
+
+//Defaults to binary
+val j3 = """{
+ | "kind": "nodejs:6",
+ | "code": "while (true)"
+ |}""".stripMargin.parseJson.asJsObject
+Exec.serdes.read(j3) should matchPattern {
+ case CodeExecAsAttachment(_, Inline("while (true)"), None, false) =>
+}
+ }
+
+ it should "read code stored as attachment" in {
+val json = """{
+ | "kind": "java",
+ | "code": {
+ |"attachmentName": "foo:bar",
+ |"attachmentType": "application/java-archive",
+ |"length": 32768,
Review comment:
Thanks for adding this test.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3945: Treat action code as attachments
rabbah commented on a change in pull request #3945: Treat action code as
attachments
URL:
https://github.com/apache/incubator-openwhisk/pull/3945#discussion_r209895656
##
File path:
tests/src/test/scala/whisk/core/controller/test/ActionsApiTests.scala
##
@@ -790,82 +790,91 @@ class ActionsApiTests extends ControllerTestCommon with
WhiskActionsApi {
}
it should "put and then get an action with attachment from cache" in {
-val action =
+val javaAction =
WhiskAction(
namespace,
aname(),
javaDefault(nonInlinedCode(entityStore), Some("hello")),
annotations = Parameters("exec", "java"))
-val content = WhiskActionPut(
- Some(action.exec),
- Some(action.parameters),
- Some(ActionLimitsOption(Some(action.limits.timeout),
Some(action.limits.memory), Some(action.limits.logs
-val name = action.name
-val cacheKey = s"${CacheKey(action)}".replace("(", "\\(").replace(")",
"\\)")
-val expectedPutLog =
- Seq(s"uploading attachment '[\\w-]+' of document 'id:
${action.namespace}/${action.name}", s"caching $cacheKey")
-.mkString("(?s).*")
-val notExpectedGetLog = Seq(
- s"finding document: 'id: ${action.namespace}/${action.name}",
- s"finding attachment '[\\w-/:]+' of document 'id:
${action.namespace}/${action.name}").mkString("(?s).*")
+val nodeAction = WhiskAction(namespace, aname(),
jsDefault(nonInlinedCode(entityStore)), Parameters("x", "b"))
+val swiftAction = WhiskAction(namespace, aname(),
swift3(nonInlinedCode(entityStore)), Parameters("x", "b"))
+val actions = Seq((javaAction, JAVA_DEFAULT), (nodeAction, NODEJS6),
(swiftAction, SWIFT3))
Review comment:
Are there defaults for the other runtimes to use as well? Node 6 and Swift 3
might have short shelf life. Not that imprtant can fix later if there isn’t a
default.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mgencur commented on a change in pull request #3950: Extend system testsuite
mgencur commented on a change in pull request #3950: Extend system testsuite
URL:
https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r209897176
##
File path: tests/src/test/scala/common/rest/WskRestOperations.scala
##
@@ -733,13 +738,23 @@ class RestActivationOperations(implicit val actorSystem:
ActorSystem)
fieldFilter: Option[String] = None,
last: Option[Boolean] = None,
summary: Option[Boolean] = None)(implicit wp: WskProps):
RestResult = {
-val rr = activationId match {
+val actId = activationId match {
+ case Some(id) => activationId
+ case None =>
+last match {
Review comment:
Sorry?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mgencur commented on a change in pull request #3950: Extend system testsuite
mgencur commented on a change in pull request #3950: Extend system testsuite
URL:
https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r209894194
##
File path: tests/src/test/scala/system/basic/WskActionTests.scala
##
@@ -210,6 +253,32 @@ class WskActionTests extends TestHelpers with
WskTestHelpers with JsHelpers with
}
}
+ it should "update an action with different language and check preserving
params" in withAssetCleaner(wskprops) {
+(wp, assetHelper) =>
+ val name = "updatedAction"
+
+ assetHelper.withCleaner(wsk.action, name, false) { (action, _) =>
+wsk.action.create(
+ name,
+ Some(TestUtils.getTestActionFilename("hello.js")),
+ parameters = Map("name" -> testString.toJson)) //unused in the first
function
+ }
+
+ val run1 = wsk.action.invoke(name, Map("payload" -> testString.toJson))
+ withActivation(wsk.activation, run1) { activation =>
+activation.response.status shouldBe "success"
+activation.logs.get.mkString(" ") should include(s"hello, $testString")
+ }
+
+ wsk.action.create(name,
Some(TestUtils.getTestActionFilename("hello.py")), update = true)
+
+ val run2 = wsk.action.invoke(name)
+ withActivation(wsk.activation, run2) { activation =>
+activation.response.status shouldBe "success"
+activation.logs.get.mkString(" ") should include(s"Hello $testString")
+ }
Review comment:
Yeah, check that the bound parameter can be consumed by a different function
with different runtime. Perhaps I'm missing something but I'd loose the
opportunity to check passing the param between different runtimes by moving
this test to the action api.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
