KeonHee opened a new issue #3637: Recognize code as binary
URL: https://github.com/apache/incubator-openwhisk/issues/3637
 
 
   <!--
   Do NOT share passwords, credentials or other confidential information.
   
   Before creating a new issue, please check if there is one already open that
   fits the defect you are reporting.
   If you open an issue and realize later it is a duplicate of a pre-existing
   open issue, please close yours and add a comment to the other.
   
   Issues can be created for either defects or enhancement requests. If you are 
a committer than please add the labels "bug" or "feature". If you are not a 
committer please make clear in the comments which one it is, so that committers 
can add these labels later.
   
   If you are reporting a defect, please edit the issue description to include 
the
   information shown below.
   
   If you are reporting an enhancement request, please include information on 
what you are trying to achieve and why that enhancement would help you.
   
   For more information about reporting issues, see
   
https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md#raising-issues
   
   Use the commands below to provide key information from your environment:
   You do not have to include this information if this is a feature request.
   -->
   
   ## Environment details:
   
   * CentOS distributed environment
   * Mac OS cli
   
   ## Steps to reproduce the issue:
   
   1.   Create a `test.js` file below. 
   ```
   functionmain
   ```
   
   2. And create action using this file.
   ```
   $ wsk action create test test.js
   ```
   
   3. Get `test` action.
   ```
   $ wsk action get test
   ```    
   
   ## Provide the expected results and outputs:
   ```
   {
       "namespace": "geonhui",
       "name": "test",
       "version": "0.0.1",
       "exec": {
           "kind": "nodejs:6",
           "binary": false
       },
       "annotations": [
           {
               "key": "exec",
               "value": "nodejs:6"
           }
       ],
       "limits": {
           "timeout": 60000,
           "memory": 256,
           "logs": 10
       },
       "publish": false
   }
   ```
   
   
   ## Provide the actual results and outputs:
   
   The binary attribute is true.
   ```
   {
       "namespace": "geonhui",
       "name": "test",
       "version": "0.0.1",
       "exec": {
           "kind": "nodejs:6",
           "binary": true
       },
       "annotations": [
           {
               "key": "exec",
               "value": "nodejs:6"
           }
       ],
       "limits": {
           "timeout": 60000,
           "memory": 256,
           "logs": 10
       },
       "publish": false
   }
   ```
   
   
   ## Additional information you deem important:
   * The regular expression below seems to recognize the string as binary.
   * 
https://github.com/apache/incubator-openwhisk/blob/a2dcace3d4cbef737cb5875c758f7e5d2b6d9f3c/common/scala/src/main/scala/whisk/core/entity/Exec.scala#L335
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to